On Tue, Nov 11, 2014 at 08:47:26AM -0800, Pravin Shelar wrote: > On Tue, Nov 11, 2014 at 7:51 AM, Ben Pfaff <b...@nicira.com> wrote: > > On Mon, Nov 10, 2014 at 12:46:11PM -0800, Pravin B Shelar wrote: > >> This is similar to ovs_scan but takes int pointer as extra > >> parameter, this pointer point to starting index of the string. > >> On successful scan this API stores number of characters > >> scanned. This API is useful for parsing complex odp actions > >> e.g. tun_push action. > >> > >> Signed-off-by: Pravin B Shelar <pshe...@nicira.com> > > > > Isn't this the same as the %n format specifier? > > Nope, %n gives me string length for current call. I need to track > string offset across many call to ovs_scan, this function keeps > current offset in new parameter.
OK, could you correct the function comment then? It currently makes it sound the same as %n, but it's actually doing +=. Also it would be better to put a function comment on each of the wrapper functions instead of the inner function. With that change then: Acked-by: Ben Pfaff <b...@nicira.com> Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
