Ben, Let me know what you want me to change, if you want me to do it. I'm still paying attention :) -Scott
On Tue, Nov 11, 2014 at 6:04 PM, Gurucharan Shetty <shet...@nicira.com> wrote: > On Tue, Nov 11, 2014 at 3:07 PM, Ben Pfaff <b...@nicira.com> wrote: > > On Fri, Nov 07, 2014 at 07:02:09PM -0800, Scott Mann wrote: > >> From: Scott Mann <sm...@noironetworks.com> > >> > >> These changes allow for the building of shared libraries by providing > >> the --enable-shared option to configure. In particular, > lib/libopenvwitch.so, > >> lib/libsflow.so, ofproto/libofproto.so, and ovsdb/libovsdb.so will be > built. > >> Original behavior of building static remains the same. > >> > >> Additionally, versioning is introduced to each of the libraries objects > >> paving the way for APIs to be built around them. A detailed comment > >> outlining the rules for changing a version number is provided in > >> configure.ac. Note that at this time, the version number is set to > >> 1.0.0, no API is specified yet, and there are no requirements to > >> maintain any sort of compatibility in any of the libraries. > >> > >> Signed-off-by: Scott Mann <sm...@noironetworks.com> > >> --- > >> Changes for v3: > >> Use version 3 of the patch so that it is easy to determine > >> the correct patch to use (attribute to Ben Pfaff) > >> --- > >> Changes for v2 include: > >> make static build default (attribute to Ben Pfaff) > >> remove changes to vlog.h and await a better fix > >> (attribute to Ben Pfaff and Thomas Graf) > >> fix C-style issues (attribute to Ben Pfaff) > >> fix --with-dpdk build issues (attribute to Thomas Graf) > > > > This seems reasonable; I see only a few minor things that I might > > change. > > > > But I want to make sure that it builds on Windows. Guru, can you try > > out a build there? Thanks. > Windows builds fine with this (We currently don't support --enable-shared > there) > -- -Scott _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
