On Wed, Nov 12, 2014 at 01:48:57PM +0900, Simon Horman wrote: > On Tue, Nov 11, 2014 at 09:24:10AM -0800, Ben Pfaff wrote: > > On Tue, Nov 11, 2014 at 12:39:26PM +0900, Simon Horman wrote: > > > This is in preparation for supporting the bucket commands of > > > (draft) Open Flow 1.5 group mod messages. > > > > > > ONF-JIRA: EXT-350 > > > Signed-off-by: Simon Horman <simon.hor...@netronome.com> > > > > > > --- > > > v2 > > > * As suggested by Ben Pfaff > > > - Use ONF-JIRA: EXT-350 annotation in changelog > > > > I'd add a few function-level comments. In particular it looks like > > ofputil_bucket_clone_list() relies on the caller to have already > > initialized 'dest', which is worth calling out (or maybe changing). > > Thanks, will do. > > I will include documentation of the 'dest' requirement for > ofputil_bucket_clone_list(). I prefer not to change it as callers > (in a subsequent patch) rely on it appending to an existing list > rather than (re)initialising the list.
That's fine, thank you. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
