On Tue, Nov 11, 2014 at 12:39:27PM +0900, Simon Horman wrote: > Handle (draft) OpenFlow 1.5 insert and remove group commands > of group mod messages. > > ONF-JIRA: EXT-350 > Signed-off-by: Simon Horman <simon.hor...@netronome.com> > > --- > v2 > * As suggested by Ben Pfaff > - Use ONF-JIRA: EXT-350 annotation in changelog
It looks like copy_buckets_for_insert_bucket() and copy_buckets_for_remove_bucket() are generic enough that they could be done in ofp-util.c. If so, then I'd prefer that because I don't like ofproto.c to grow more than necessary. I think that the extra error check for OFPGC15_REMOVE_BUCKET could happen at message decoding time in ofp-util.c, and if so then I'd prefer that too. Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
