On Tue, Nov 11, 2014 at 09:21:36AM -0800, Ben Pfaff wrote: > On Tue, Nov 11, 2014 at 12:39:25PM +0900, Simon Horman wrote: > > In preparation for supporting (draft) OpenFlow 1.5 > > group mod commands enhance the error logging of them. > > > > ONF-JIRA: EXT-350 > > Signed-off-by: Simon Horman <simon.hor...@netronome.com> > > > > --- > > v2 > > * As suggested by Ben Pfaff > > - Use ONF-JIRA: EXT-350 annotation in changelog > > Using a blind array dereference into cmd_str[] in bad_group_cmd() seems > like it could easily be overlooked if new commands get added later. I > would use a switch statement or otherwise make this more easily > maintainable.
Sure, will do. I have a feeling that I used this approach here and elsewhere in the series to match the style of other open-vswtich code. I'd be happy to do a pass on cleaning-up other instances of this approach if you are interested. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
