On Tue, Nov 11, 2014 at 12:00:59PM -0800, Jarno Rajahalme wrote: > This patch integrates insert_rule() to the sole caller > classifier_replace(). This makes classifer_replace() more symmetric > with classifier_remove(), and makes it easier to change the following: > > - Rules invisible to the lookups are no longer inserted to any of the > index cmaps or tries. > - subtable's 'n_rules' member is eliminated. > > Signed-off-by: Jarno Rajahalme <jrajaha...@nicira.com>
I don't understand from the commit message above whether this just moves code around or actually changes what it does. It's usually easy to review a patch that moves code around, it's usually easy to review a patch that just changes code, but a patch that does both at once is harder, and I'm not sure which I'm looking at here. Let me know? Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
