On Tue, Nov 11, 2014 at 12:39:26PM +0900, Simon Horman wrote: > This is in preparation for supporting the bucket commands of > (draft) Open Flow 1.5 group mod messages. > > ONF-JIRA: EXT-350 > Signed-off-by: Simon Horman <simon.hor...@netronome.com> > > --- > v2 > * As suggested by Ben Pfaff > - Use ONF-JIRA: EXT-350 annotation in changelog
I'd add a few function-level comments. In particular it looks like ofputil_bucket_clone_list() relies on the caller to have already initialized 'dest', which is worth calling out (or maybe changing). Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev