> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
>
> The relevant /proc/self/mountinfo line is
>
>
> 2207 21
On Mon, 11 Nov 2024 09:51:35 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Wed, 11 Dec 2024 08:06:19 GMT, Adam Sotona wrote:
> Class-File API lost debug printing capability with removal of the
> j.l.classfile.components.ClassPrinter in JDK-8345343.
>
> This is a backport of
> https://github.com/openjdk/jdk/commit/f88c1c6ff86b8f29a71647e46136b6432bb67619,
> review
On Tue, 10 Dec 2024 23:44:37 GMT, Mandy Chung wrote:
> Is the `isLinkFromRuntime` parameter needed in the `newModuleFinder` method?
> The java.base version check does not have any issue for linking from run-time
> image, right?
It's not needed other than for skipping the check (as it'll trivia
On Tue, 10 Dec 2024 23:50:28 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Handle non-existent module-path with ALL-MODULE-PATH
>> - Move test, more test fixes for JEP 493 enabled builds
>
On Tue, 10 Dec 2024 12:06:19 GMT, Severin Gehwolf wrote:
>> Please review this extension to #22609 which now disallows `ALL-MODULE-PATH`
>> without explicit `--module-path` option or a non-existent module path. In
>> addition, this fixes a bug mentioned in #22609 when `ALL-MODULE-PATH` and
>>
On Fri, 6 Dec 2024 09:51:52 GMT, Severin Gehwolf wrote:
>> Sergey Chernyshev has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 13 commits:
>>
>> - diverged after integration of JDK-8344177
>>
>># Conflicts:
>># src/java
On Wed, 11 Dec 2024 15:19:06 GMT, Sergey Chernyshev
wrote:
>> src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp line 322:
>>
>>> 320: } else {
>>> 321: log_warning(os, container)("Cgroup cpu/memory controller path
>>> includes '../', detected limits won't be accurate");
>>> 322: }
> @AlanBateman @mahendrachhipa @bwhuang-us @serhiysachkov @mcimadamore
> @JornVernee
>
> adding as manual tests
Ivan Šipka has updated the pull request incrementally with two additional
commits since the last revision:
- reverting manual group
- jdk_foreign_stress to tier4, revert previous
On Wed, 11 Dec 2024 15:55:00 GMT, Ivan Šipka wrote:
>> @AlanBateman @mahendrachhipa @bwhuang-us @serhiysachkov @mcimadamore
>> @JornVernee
>>
>> adding as manual tests
>
> Ivan Šipka has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - reve
> Please review this fix for JEP 493 enabled JDKs related to the
> `--limit-modules` option. The existing jlink `bindservices` tests cover this
> issue. Previously they didn't run on a JEP 493 enabled JDK, since `jmods`
> folder is missing for them.
>
> The gist of the issue is that multiple `M
On Tue, 10 Dec 2024 20:51:33 GMT, Chen Liang wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [0f035545](https://github.com/openjdk/jdk/commit/0f035545e5c0cd02d11ab8edd5786c1f1f6043a7)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> This is a noreg-
On Tue, 10 Dec 2024 20:51:33 GMT, Chen Liang wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [0f035545](https://github.com/openjdk/jdk/commit/0f035545e5c0cd02d11ab8edd5786c1f1f6043a7)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> This is a noreg-
On Wed, 11 Dec 2024 15:55:00 GMT, Ivan Šipka wrote:
>> @AlanBateman @mahendrachhipa @bwhuang-us @serhiysachkov @mcimadamore
>> @JornVernee
>>
>> adding as manual tests
>
> Ivan Šipka has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - reve
On Wed, 11 Dec 2024 15:55:00 GMT, Ivan Šipka wrote:
>> @AlanBateman @mahendrachhipa @bwhuang-us @serhiysachkov @mcimadamore
>> @JornVernee
>>
>> adding as manual tests
>
> Ivan Šipka has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - reve
On Thu, 5 Dec 2024 16:23:17 GMT, Ivan Šipka wrote:
> @AlanBateman @mahendrachhipa @bwhuang-us @serhiysachkov @mcimadamore
> @JornVernee
>
> adding as manual tests
This pull request has now been integrated.
Changeset: cf0e1aa0
Author:Ivan Šipka
Committer: Jorn Vernee
URL:
https:/
On Wed, 11 Dec 2024 16:02:29 GMT, Severin Gehwolf wrote:
>> Please review this fix for JEP 493 enabled JDKs related to the
>> `--limit-modules` option. The existing jlink `bindservices` tests cover this
>> issue. Previously they didn't run on a JEP 493 enabled JDK, since `jmods`
>> folder is m
On Mon, 9 Dec 2024 12:48:07 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/foreign/SegmentFactories.java line
>> 213:
>>
>>> 211:
>>> 212: @DontInline
>>> 213: private static long allocateNativeOveraligned(long byteSize, long
>>> byteAlignment, MemorySess
> Hi,
>
> This patch improves the performance of a typical `Arena::allocate` in several
> ways:
>
> - Delay the creation of the NativeMemorySegmentImpl. This avoids the merge of
> the instance with the one obtained from the call in the uncommon path,
> increasing the chance the object being sc
On Fri, 6 Dec 2024 16:30:47 GMT, Quan Anh Mai wrote:
> Hi,
>
> This patch improves the performance of a typical `Arena::allocate` in several
> ways:
>
> - Delay the creation of the NativeMemorySegmentImpl. This avoids the merge of
> the instance with the one obtained from the call in the unco
On Fri, 6 Dec 2024 18:29:46 GMT, Jorn Vernee wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address review
>
> src/java.base/share/classes/jdk/internal/foreign/ArenaImpl.java line 53:
>
>> 51: Utils.check
On Wed, 11 Dec 2024 18:40:41 GMT, Brian Burkhalter wrote:
> The native `GetXSpace` method needs to be defined on all platforms
This change fixes that problem:
--- a/test/jdk/java/io/File/libGetXSpace.c
+++ b/test/jdk/java/io/File/libGetXSpace.c
@@ -160,11 +160,11 @@ Java_GetXSpace_getSpace0
On Wed, 11 Dec 2024 18:37:06 GMT, Quan Anh Mai wrote:
>> src/java.base/share/classes/jdk/internal/foreign/ArenaImpl.java line 53:
>>
>>> 51: Utils.checkAllocationSizeAndAlign(byteSize, byteAlignment);
>>> 52: long address = SegmentFactories.allocateNative(byteSize,
>>> byteAlign
On Wed, 11 Dec 2024 16:02:29 GMT, Severin Gehwolf wrote:
>> Please review this fix for JEP 493 enabled JDKs related to the
>> `--limit-modules` option. The existing jlink `bindservices` tests cover this
>> issue. Previously they didn't run on a JEP 493 enabled JDK, since `jmods`
>> folder is m
> Please review this fix for JEP 493 enabled JDKs related to the
> `--limit-modules` option. The existing jlink `bindservices` tests cover this
> issue. Previously they didn't run on a JEP 493 enabled JDK, since `jmods`
> folder is missing for them.
>
> The gist of the issue is that multiple `M
On Wed, 11 Dec 2024 06:20:07 GMT, Julian Waters wrote:
>> Then you'll have to create a macro for disabling the unused warnings
>> (however, I'm not sure how well that would be received). Or fix the bug if
>> it is actually unused. Or wait until we go to 17.
>
> @magicus Sorry for the ping, but
On Fri, 6 Dec 2024 18:03:40 GMT, Weijun Wang wrote:
>> Martin Balao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Algorithms renamed for alignment with SunJCE.
>>
>> Co-authored-by: Martin Balao Alonso
>> Co-authored-by: Franci
Davide,
Can you run the launcher with JPACKAGE_DEBUG env variable set to "true"
on flatpak or anywhere else where it works? It should make the launcher
print log messages to stdout.
On Linux launcher's behavior depends on "LD_LIBRARY_PATH",
"_JPACKAGE_LAUNCHER" env variables, see [1].
Laun
On Tue, 10 Dec 2024 09:31:21 GMT, Prasanta Sadhukhan
wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert changes to binary files
>
> not sure why client label is added, no java.desktop/accessibility files
On Fri, 6 Dec 2024 18:34:00 GMT, Weijun Wang wrote:
>> Martin Balao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Algorithms renamed for alignment with SunJCE.
>>
>> Co-authored-by: Martin Balao Alonso
>> Co-authored-by: Franci
On Mon, 9 Dec 2024 12:30:19 GMT, Magnus Ihse Bursie wrote:
> Some files have been modified in 2024, but the copyright year has not been
> properly updated. This should be fixed.
>
> I have located these modified files using:
>
> git log --since="Jan 1" --name-only --pretty=format: | sort -u >
> We would like to propose an implementation of the HKDF algorithms for
> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
> Derivation Function API
> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
>
> This implementation will be under the _Preview_ umbrella
On Fri, 6 Dec 2024 18:40:04 GMT, Weijun Wang wrote:
> I set CKA_EXTRACTABLE = false and generate an AES key and its `getEncoded` is
> null. Then I use it as an IKM for HKDF and the `deriveKey` output is still
> unextractable. So far so good, but if I call `deriveData` on the same input
> spec,
On Wed, 11 Dec 2024 20:50:15 GMT, Severin Gehwolf wrote:
>> Please review this fix for JEP 493 enabled JDKs related to the
>> `--limit-modules` option. The existing jlink `bindservices` tests cover this
>> issue. Previously they didn't run on a JEP 493 enabled JDK, since `jmods`
>> folder is m
The team isn't unanimous about this yet, but I think it's worth considering
fully. I've filed https://bugs.openjdk.org/browse/JDK-8346033 and gave my
analysis of the situation there. I'll try to nudge it to some resolution -
thanks for raising it!
> On Mon Dec 2 23:17:12 UTC 2024, Éamonn McMan
> On Dec 10, 2024, at 4:54 PM, Vladimir Ivanov
> wrote:
>
>
>
> On 12/9/24 07:55, Paul Sandoz wrote:
>> Some further observations.
>> - This arguably makes it harder for the auto-vectorize to access the
>> SVML/SLEEF functionality. However, in comes cases, we cannot guarantee the
>> same g
On Wed, 11 Dec 2024 16:02:29 GMT, Severin Gehwolf wrote:
>> Please review this fix for JEP 493 enabled JDKs related to the
>> `--limit-modules` option. The existing jlink `bindservices` tests cover this
>> issue. Previously they didn't run on a JEP 493 enabled JDK, since `jmods`
>> folder is m
On Mon, 9 Dec 2024 10:55:13 GMT, Taizo Kurashige wrote:
>> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
>> Cygwin’s `df` to get the size for comparison if the test target drive is a
>> CD-ROM drive.
>>
>> As described in JDK-8343342, GetDiskSpaceInformationW can
> Hi,
>
> This patch improves the performance of a typical `Arena::allocate` in several
> ways:
>
> - Delay the creation of the NativeMemorySegmentImpl. This avoids the merge of
> the instance with the one obtained from the call in the uncommon path,
> increasing the chance the object being sc
On Wed, 11 Dec 2024 18:50:18 GMT, Maurizio Cimadamore
wrote:
>> I want to put it here so that even if `SegmentFactories::allocateNative` is
>> not inlined, this small method will be more likely to be inlined and the
>> segment can be non-escape, then. I have added a comment regarding class
>>
Hi,
thanks for the answer, I really appreciate it.
I tried adding the JPACKAGE_DEBUG env variable but didn't changed the
output.
When I run the binary generated by jpackage in the snap sandbox I get
the "java" command output as output.
This does not happen on flatpak.
Do you know if jpackage
On Wed, 11 Dec 2024 18:17:48 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Mandy's feedback
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 498:
>
>> 496:
As subject.
Current wix v3 is deprecated.
Will jpackage support WixTools v4 or v5 with Java 24?
Thanks
Yes, jpackage will support either v4 or v5 as of JDK 24:
https://bugs.openjdk.org/browse/JDK-8319457
You can also see this in the early access release notes:
https://jdk.java.net/24/release-notes
(bottom of the page)
-- Kevin
On 12/11/2024 12:28 PM, Davide Perini wrote:
As subject.
Curren
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Tue, 10 Dec 2024 16:10:09 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly
>> just the revert of the backout.
>>
>> Regarding the related issues:
>>
>> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and
>> [JDK-83
On Wed, 11 Dec 2024 17:42:29 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Mandy's feedback
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 396:
>
>> 394:
> This PR is a resubmission after PR #21593 was rolled back, and the unsafe
> offset overflow issue has been fixed.
>
> 1) Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to
> reduce duplication.
>
> 2) HexDigits and OctalDigits also include getCharsLatin1 and getCharsUTF
- There is an open bug to adjust the simd sort behavior on AMD zen 4 cores due
to poor performance of an AVX 512 instruction. The simplest solution is to fall
back to AVX2. That may be simpler to manage in Java? (I was looking at the
HotSpot code).
For now, the patch guards AVX512 entries
> We would like to propose an implementation of the HKDF algorithms for
> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
> Derivation Function API
> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
>
> This implementation will be under the _Preview_ umbrella
8345773: Class-File API debug printing capability
-
Commit messages:
- Backport f88c1c6ff86b8f29a71647e46136b6432bb67619
Changes: https://git.openjdk.org/jdk/pull/22675/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22675&range=00
Issue: https://bugs.openjdk.org/browse/J
On Mon, 9 Dec 2024 13:02:15 GMT, Magnus Ihse Bursie wrote:
> Some files have been modified in 2024, but the copyright year has not been
> properly updated. This should be fixed.
>
> I have located these modified files using:
>
> git log --since="Jan 1" --name-only --pretty=format: | sort -u >
On Mon, 9 Dec 2024 21:02:03 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Tue, 10 Dec 2024 20:51:33 GMT, Chen Liang wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [0f035545](https://github.com/openjdk/jdk/commit/0f035545e5c0cd02d11ab8edd5786c1f1f6043a7)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> This is a noreg-
On Mon, 9 Dec 2024 18:09:21 GMT, Adam Sotona wrote:
>> Class-File API lost debug printing capability with removal of the
>> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
>> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to
>> restore the capability.
>>
>> Please r
On Mon, 9 Dec 2024 10:25:01 GMT, Adam Sotona wrote:
> Class-File API lost debug printing capability with removal of the
> `j.l.classfile.components.ClassPrinter` in JDK-8345343.
> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to restore
> the capability.
>
> Please review.
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Tue, 10 Dec 2024 09:07:32 GMT, liyazzi wrote:
>> For two cases:
>>
>> 1. When the ImageReaderFactory was loaded by local jdk,that means the
>> ImageReaderFactory was loaded by boot class loader,then init the `Path
>> BOOT_MODULES_JIMAGE` by using `sun.nio.fs.DefaultFileSystemProvider` which
> Improve documentation for constant pool entries. This include some models
> for those entries, symbolic descriptors, and some general guidance in package
> summary.
>
> APIDiff: https://cr.openjdk.org/~liach/apidiff/cf-consts/
> Javadoc: https://cr.openjdk.org/~liach/javadoc/cf-consts/
>
> P
On Wed, 11 Dec 2024 22:59:29 GMT, Martin Balao wrote:
>> We would like to propose an implementation of the HKDF algorithms for
>> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
>> Derivation Function API
>> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
>
> Cgroup V1 subsustem fails to initialize mounted controllers properly in
> certain cases, that may lead to controllers left undetected/inactive. We
> observed the behavior in CloudFoundry deployments, it affects also host
> systems.
>
> The relevant /proc/self/mountinfo line is
>
>
> 2207 21
On Wed, 11 Dec 2024 15:24:12 GMT, Severin Gehwolf wrote:
>> Would you recommand also to include the paths in that warning? Something like
>> ```cgroup controller path at '/sys/fs/cgroup' seems to have moved to
>> '../../test', detected limits won't be accurate```
>> This way it will have all the
On Thu, 12 Dec 2024 01:10:04 GMT, Weijun Wang wrote:
>> Martin Balao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Make EMPTY_KEY static.
>>
>> Co-authored-by: Martin Balao Alonso
>> Co-authored-by: Francisco Ferrari Bihurriet
This test makes assertions about the number of gc manager beans and the number
of memory pools. The generational mode for Shenandoah adds another memory pool.
-
Commit messages:
- Fix summary, remove debugging
- Separate test for Shenandoah's generational mode
Changes: https://git
On Wed, 4 Dec 2024 12:26:20 GMT, Alan Bateman wrote:
>> We could have two views with only one event. The query for the view could
>> filter for exceptionMessage != null or a failure property. The advantage of
>> having two events is that the failure event could have a threshold of 0 ms.
>>
>>
Please review this change ensuring all targeted classes in a MR-JAR file should
target the same or a lower classfile version.
For example, having compiled source files with `javac` 25 without using the
`--release` option (or with `--release 25`) and trying to archive them via a
`jar --create --
On Wed, 11 Dec 2024 20:55:41 GMT, Magnus Ihse Bursie wrote:
>> @magicus Sorry for the ping, but I'm a bit confused. Do you know what bug
>> report site Phil is referring to when he says to submit a bug to AWT
>> instead? Is it just the JBS? (There's a little bit of a problem if it is, it
>> is
On Tue, 17 Sep 2024 16:13:55 GMT, Quan Anh Mai wrote:
> Hi,
>
> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly just
> the revert of the backout.
>
> Regarding the related issues:
>
> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and
> [JDK-8309531](ht
> Please review this change for the `jar` tool to gracefully handle the case
> where `--release` is not specified as the last arguments.
>
> Prior to this commit, operation modes `-d --describe-module` and `--validate`
> expected to read the optional `--release` option as a file argument: `jar -
On Thu, 12 Dec 2024 02:13:41 GMT, Martin Balao wrote:
>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KDF.java line
>> 154:
>>
>>> 152: long saltType = CKF_HKDF_SALT_NULL;
>>> 153: byte[] saltBytes = null;
>>> 154: P11Key p11SaltKey = null;
>>
>> For `Ex
> We would like to propose an implementation of the HKDF algorithms for
> SunPKCS11, aligned with the KDF API proposed for JDK 24 (see [JEP 478: Key
> Derivation Function API
> (Preview)](https://bugs.openjdk.org/browse/JDK-8189808)).
>
> This implementation will be under the _Preview_ umbrella
On Thu, 12 Dec 2024 03:08:30 GMT, Weijun Wang wrote:
>> For Expand, `salt` should be `null`. Do you mean adding or hitting an
>> assertion?
>
> Assertion on line 162 will throw an NPE.
Ah, you're right, the assertion throws an NPE. Fixed.
-
PR Review Comment: https://git.openjdk.o
java/lang/Thread/virtual/Starvation.java is failing on s390x with Timeout error
as continuations support is not there for s390x.
-
Commit messages:
- mandate continuations
Changes: https://git.openjdk.org/jdk/pull/22702/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22702
73 matches
Mail list logo
