On Wed, 4 Dec 2024 12:26:20 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> We could have two views with only one event. The query for the view could >> filter for exceptionMessage != null or a failure property. The advantage of >> having two events is that the failure event could have a threshold of 0 ms. >> >> We are planning to add a throttling mechanism for exception events, perhaps >> per call site. The same mechanism could be used for a failed event. If you >> receive 500 events per second for a call site, there is little value in >> having additional events. > > We need to help Tim on the question of whether there is one or two events. > > An application that makes outbound network connections may run slowly for > several reasons. A duration event may help to diagnose this, irrespective of > whether the connection is established successfully or it fails, so one event > is okay. Separately, another big source of latency is the name service / DNS > lookup which happens before getting to the Socket connect. Maybe further work > could add events to InetAddress for this. > > When hunting misbehaving behavior then focusing on the cases where a > connection cannot be established may be more interesting. So it's possible > someone might want to run with threshold=0 to see all failed events. If there > is throttling support, and since we control call site for both the successful > and failed cases, could we live with one event? I'm not sure if one or two events are most suitable. If possible, I would like to discuss it with Markus to get some more input. He will back in January. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21528#discussion_r1881347326
