On Fri, 6 Dec 2024 18:03:40 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Martin Balao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Algorithms renamed for alignment with SunJCE.
>>
>> Co-authored-by: Martin Balao Alonso <mba...@redhat.com>
>> Co-authored-by: Francisco Ferrari Bihurriet <fferr...@redhat.com>
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KDF.java line
> 268:
>
>> 266:
>> 267: SecretKey getKeyMaterial() {
>> 268: return null;
>
> If the ikms list is empty, this would return a null key and `convertKey` does
> not like it. You might say this should not happen, but it seems the RFC has
> not forbidden this and the one in SunJCE does support it.
You're right, good catch!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22215#discussion_r1880975831
