On Fri, 6 Dec 2024 18:34:00 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Martin Balao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Algorithms renamed for alignment with SunJCE.
>>
>> Co-authored-by: Martin Balao Alonso <mba...@redhat.com>
>> Co-authored-by: Francisco Ferrari Bihurriet <fferr...@redhat.com>
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KDF.java line
> 188:
>
>> 186: }
>> 187: } else {
>> 188: ret = P11Key.secretKey(session, derivedObjectID, alg,
>> outLen,
>
> Is the key length in bytes or bits here?
Good question. Should be converted to bits. The same issue repeats one more
time.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22215#discussion_r1881000882
