On Wed, 11 Dec 2024 18:17:48 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Mandy's feedback > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java line 498: > >> 496: Set<String> limitMods, >> 497: Set<String> roots, >> 498: boolean isRuntimeLink) > > `isRuntimeLink` is strictly for performance but this method has no > relationship with linking from packaged modules or run-time image. Suggest > to drop this new parameter and refactor the version check as a separate > method and call it before creating `JlinkConfiguration` Thanks. I've moved the version check outside this method. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22609#discussion_r1880888770
