On Wed, 11 Dec 2024 06:20:07 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> Then you'll have to create a macro for disabling the unused warnings >> (however, I'm not sure how well that would be received). Or fix the bug if >> it is actually unused. Or wait until we go to 17. > > @magicus Sorry for the ping, but I'm a bit confused. Do you know what bug > report site Phil is referring to when he says to submit a bug to AWT instead? > Is it just the JBS? (There's a little bit of a problem if it is, it is > extremely inconvenient to review what to do with the problem areas in the JBS > as opposed to a Pull Request, that and no one actually checks the JBS for new > issues, so a bug submitted there is doomed to be ignored until the end of > time) You need to split this up into multiple parts. One part is about removing dead code. Do not comment it out, just remove it. Open a new JBS issue on client-libs for removal of dead code. This should be trivial to get pushed. Then, you have some other changes. Looks like you moved something from a header file to a cpp file. Make that a separate PR, also on client-libs. Then you are making some annotation stuff. I have not seen these before. Are they established? This might need some more discussion to get a consensus on how to proceed with. And finally you are bumping the C++ language level. You have already opened a separate JBS issue for that, and we've said that we do that when we do that. So just drop that part. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21655#discussion_r1880973110
