On Tue, 10 Dec 2024 23:50:28 GMT, Mandy Chung <mch...@openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Handle non-existent module-path with ALL-MODULE-PATH >> - Move test, more test fixes for JEP 493 enabled builds > > test/jdk/tools/jlink/basic/AllModulePathTest.java line 54: > >> 52: * @run main/othervm -Xmx1g AllModulePathTest >> 53: */ >> 54: public class AllModulePathTest { > > Any reason why these test cases can't be added to `AllModulePath`? > `AllModulePathTest` and `AllModulePath` test names are very alike. I'll merge the tests into `AllModulePath`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22494#discussion_r1880397567