On Thu, 12 Dec 2024 02:13:41 GMT, Martin Balao <mba...@openjdk.org> wrote:
>> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KDF.java line >> 154: >> >>> 152: long saltType = CKF_HKDF_SALT_NULL; >>> 153: byte[] saltBytes = null; >>> 154: P11Key p11SaltKey = null; >> >> For `Expand`, `salt` is null. >> >> Did you test with assertion on? > > For Expand, `salt` should be `null`. Do you mean adding or hitting an > assertion? Assertion on line 162 will throw an NPE. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22215#discussion_r1881318777
