Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v6]

[Brian Burkhalter]

On Wed, 11 Dec 2024 18:40:41 GMT, Brian Burkhalter <b...@openjdk.org> wrote:

> The native `GetXSpace` method needs to be defined on all platforms

This change fixes that problem:

--- a/test/jdk/java/io/File/libGetXSpace.c
+++ b/test/jdk/java/io/File/libGetXSpace.c
@@ -160,11 +160,11 @@ Java_GetXSpace_getSpace0
     return totalSpaceIsEstimated;
 }
 
-#ifdef WINDOWS
 JNIEXPORT jboolean JNICALL
 Java_GetXSpace_isCDDrive
     (JNIEnv *env, jclass cls, jstring root)
 {
+#ifdef WINDOWS
     const jchar* strchars = (*env)->GetStringChars(env, root, NULL);
     if (strchars == NULL) {
         JNU_ThrowByNameWithLastError(env, "java/lang/RuntimeException",
@@ -182,8 +182,10 @@ Java_GetXSpace_isCDDrive
     }
 
     return JNI_TRUE;
-}
+#else
+    return JNI_FALSE;
 #endif
+}

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21799#discussion_r1880733430