Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074827254 ## drivers/misc/optee.c: ## @@ -476,62 +956,83 @@ static int optee_ioctl_invoke(FAR struct optee_priv_data *priv, arg->ret = TEE_ERROR_COMMUNICATION; arg->ret_o

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074827254 ## drivers/misc/optee.c: ## @@ -476,62 +956,83 @@ static int optee_ioctl_invoke(FAR struct optee_priv_data *priv, arg->ret = TEE_ERROR_COMMUNICATION; arg->ret_o

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074827254 ## drivers/misc/optee.c: ## @@ -476,62 +956,83 @@ static int optee_ioctl_invoke(FAR struct optee_priv_data *priv, arg->ret = TEE_ERROR_COMMUNICATION; arg->ret_o

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-05 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2074827578 ## sched/semaphore/sem_waitirq.c: ## @@ -72,31 +72,55 @@ void nxsem_wait_irq(FAR struct tcb_s *wtcb, int errcode) { FAR struct tcb_s *rtcb = this_task(); FAR se

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074827254 ## drivers/misc/optee.c: ## @@ -476,62 +956,83 @@ static int optee_ioctl_invoke(FAR struct optee_priv_data *priv, arg->ret = TEE_ERROR_COMMUNICATION; arg->ret_o

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-05 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2074821911 ## sched/semaphore/sem_trywait.c: ## @@ -63,8 +63,11 @@ int nxsem_trywait_slow(FAR sem_t *sem) { irqstate_t flags; - int32_t semcount; - int ret; + int ret = -

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074817879 ## drivers/misc/optee.c: ## @@ -348,8 +419,8 @@ static int optee_ioctl_open_session(FAR struct optee_priv_data *priv, msg->params + 2);

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074805787 ## include/nuttx/tee.h: ## @@ -198,6 +198,10 @@ struct tee_ioctl_shm_register_fd_data #define TEE_IOCTL_LOGIN_REE_KERNEL 0x8000 +/* Macro to help

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074805787 ## include/nuttx/tee.h: ## @@ -198,6 +198,10 @@ struct tee_ioctl_shm_register_fd_data #define TEE_IOCTL_LOGIN_REE_KERNEL 0x8000 +/* Macro to help

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-05 Thread via GitHub
jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2074810210 ## sched/semaphore/sem_destroy.c: ## @@ -61,6 +61,9 @@ int nxsem_destroy(FAR sem_t *sem) { int32_t old; + bool mutex = NXSEM_IS_MUTEX(sem); + FAR atomic_t *cons

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074805787 ## include/nuttx/tee.h: ## @@ -198,6 +198,10 @@ struct tee_ioctl_shm_register_fd_data #define TEE_IOCTL_LOGIN_REE_KERNEL 0x8000 +/* Macro to help

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074809921 ## drivers/misc/optee.c: ## @@ -145,10 +207,398 @@ static bool optee_safe_va_range(FAR void *va, size_t size) return false; } -#else +#else /* !CONFIG_ARCH_ADDR

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074805787 ## include/nuttx/tee.h: ## @@ -198,6 +198,10 @@ struct tee_ioctl_shm_register_fd_data #define TEE_IOCTL_LOGIN_REE_KERNEL 0x8000 +/* Macro to help

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074805206 ## drivers/misc/optee.h: ## @@ -0,0 +1,77 @@ +/ + * drivers/misc/optee.h + * + * SPD

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074804683 ## drivers/misc/optee.c: ## @@ -145,10 +207,398 @@ static bool optee_safe_va_range(FAR void *va, size_t size) return false; } -#else +#else /* !CONFIG_AR

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-05 Thread via GitHub
jlaitine commented on PR #16194: URL: https://github.com/apache/nuttx/pull/16194#issuecomment-2853411481 > It doesn't make sense to boost the thread which pass nxsem_wait on a counting semaphore, since the priority boost is meaningful only for a mutex(binary semaphore). That's why I sug

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074773932 ## drivers/misc/optee.c: ## @@ -145,10 +207,398 @@ static bool optee_safe_va_range(FAR void *va, size_t size) return false; } -#else +#else /* !CONFIG_ARCH_ADDR

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074799936 ## include/nuttx/tee.h: ## @@ -198,6 +198,10 @@ struct tee_ioctl_shm_register_fd_data #define TEE_IOCTL_LOGIN_REE_KERNEL 0x8000 +/* Macro

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074799133 ## drivers/misc/optee.h: ## @@ -0,0 +1,77 @@ +/ + * drivers/misc/optee.h + * + * SPD

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074762646 ## libs/libc/wqueue/work_queue.c: ## @@ -87,17 +87,17 @@ static int work_qqueue(FAR struct usr_wqueue_s *wqueue, /* Initialize the work structure */ - w

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-05 Thread via GitHub
xiaoxiang781216 commented on PR #16194: URL: https://github.com/apache/nuttx/pull/16194#issuecomment-2853378798 > > @jlaitine after this patchset get merged, we can simplify the holder logic for priority inheritance since: > > > > 1. Don't track the multiple holders since mutex always

Re: [PR] arch/arm/rp23xx: add dsp/fpu extensions support [nuttx]

2025-05-05 Thread via GitHub
shtirlic commented on PR #16306: URL: https://github.com/apache/nuttx/pull/16306#issuecomment-2853375204 @avgoor ``` static void core1_boot(void) { #if CONFIG_ARCH_INTERRUPTSTACK > 3 /* Initializes the stack pointer */ arm_initialize_stack(); #endif arm_

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074781958 ## drivers/misc/optee.h: ## @@ -0,0 +1,77 @@ +/ + * drivers/misc/optee.h + * + * SPDX-Licen

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074781958 ## drivers/misc/optee.h: ## @@ -0,0 +1,77 @@ +/ + * drivers/misc/optee.h + * + * SPDX-Licen

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074777223 ## drivers/misc/optee.c: ## @@ -145,10 +207,398 @@ static bool optee_safe_va_range(FAR void *va, size_t size) return false; } -#else +#else /* !CONFIG_ARCH_ADDR

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074773932 ## drivers/misc/optee.c: ## @@ -145,10 +207,398 @@ static bool optee_safe_va_range(FAR void *va, size_t size) return false; } -#else +#else /* !CONFIG_ARCH_ADDR

Re: [PR] wqueue: improve the robustness of the work [nuttx]

2025-05-05 Thread via GitHub
xiaoxiang781216 closed pull request #16283: wqueue: improve the robustness of the work URL: https://github.com/apache/nuttx/pull/16283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Enable mutex functionality in nxsem [nuttx]

2025-05-05 Thread via GitHub
jlaitine commented on PR #16194: URL: https://github.com/apache/nuttx/pull/16194#issuecomment-2853322370 > @jlaitine after this patchset get merged, we can simplify the holder logic for priority inheritance since: > > 1. Don't track the multiple holders since mutex always can have one

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074746657 ## drivers/misc/optee.c: ## @@ -125,52 +115,24 @@ static const struct file_operations g_optee_ops = static int optee_open(FAR struct file *filep) { - FAR struct s

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074743563 ## include/nuttx/tee.h: ## @@ -198,6 +198,10 @@ struct tee_ioctl_shm_register_fd_data #define TEE_IOCTL_LOGIN_REE_KERNEL 0x8000 +/* Macro to help

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074681300 ## libs/libc/wqueue/work_cancel.c: ## @@ -89,7 +89,7 @@ static int work_qcancel(FAR struct usr_wqueue_s *wqueue, */ curr = wqueue->q.head; -

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074680567 ## sched/wqueue/kwork_thread.c: ## @@ -110,6 +116,53 @@ struct lp_wqueue_s g_lpwork = * Private Functions **

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074680361 ## sched/wqueue/wqueue.h: ## @@ -159,6 +148,65 @@ static inline_function FAR struct kwork_wqueue_s *work_qid2wq(int qid) } } +/

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-05 Thread via GitHub
Fix-Point commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074674647 ## sched/wqueue/kwork_cancel.c: ## @@ -59,17 +59,37 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue, bool sync, */ flags = spin_lock_irqsave(&w

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-05 Thread via GitHub
Fix-Point commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074673094 ## sched/wqueue/kwork_thread.c: ## @@ -148,33 +193,54 @@ static int work_thread(int argc, FAR char *argv[]) kworker = (FAR struct kworker_s *) ((uintp

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-05 Thread via GitHub
Fix-Point commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074669532 ## sched/wqueue/wqueue.h: ## @@ -159,6 +148,65 @@ static inline_function FAR struct kwork_wqueue_s *work_qid2wq(int qid) } } +/**

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #16323: URL: https://github.com/apache/nuttx/pull/16323#discussion_r2074659948 ## arch/avr/src/avr/Kconfig: ## @@ -57,6 +57,26 @@ config AVR_BUILDROOT_TOOLCHAIN endchoice # Toolchain +config AVR_LINUXGCC_TOOLCHAIN_IS_GCC + bool

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074663527 ## sched/wqueue/kwork_cancel.c: ## @@ -59,17 +59,37 @@ static int work_qcancel(FAR struct kwork_wqueue_s *wqueue, bool sync, */ flags = spin_lock_irqs

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-05 Thread via GitHub
xiaoxiang781216 commented on PR #16323: URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2853129084 > @sumpfralle please add RCALL to codespell exception, it is failing: > > /home/runner/work/nuttx/nuttx/nuttx/arch/avr/src/avr/excptmacros.h:336: RCALL ==> RECALL > >

Re: [PR] drivers/misc/optee.c: Add an SMC driver for arm [nuttx]

2025-05-05 Thread via GitHub
xiaoxiang781216 commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2073947475 ## include/nuttx/tee.h: ## @@ -198,6 +198,10 @@ struct tee_ioctl_shm_register_fd_data #define TEE_IOCTL_LOGIN_REE_KERNEL 0x8000 +/* Macro

Re: [PR] DOCS: Chip tagging [nuttx]

2025-05-05 Thread via GitHub
linguini1 commented on code in PR #16321: URL: https://github.com/apache/nuttx/pull/16321#discussion_r2074649541 ## Documentation/platforms/arm64/zynq-mpsoc/boards/zcu111/index.rst: ## @@ -2,6 +2,8 @@ Zynq UltraScale+ RFSoC ZCU111 = +.. tags:: chi

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-05 Thread via GitHub
Fix-Point commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074646362 ## sched/wqueue/kwork_thread.c: ## @@ -148,33 +193,54 @@ static int work_thread(int argc, FAR char *argv[]) kworker = (FAR struct kworker_s *) ((uintp

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-05 Thread via GitHub
Fix-Point commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074646468 ## sched/wqueue/kwork_queue.c: ## @@ -141,65 +80,72 @@ int work_queue_period_wq(FAR struct kwork_wqueue_s *wqueue, FAR void *arg, clock_t de

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-05 Thread via GitHub
Fix-Point commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074631788 ## sched/wqueue/kwork_thread.c: ## @@ -148,33 +193,54 @@ static int work_thread(int argc, FAR char *argv[]) kworker = (FAR struct kworker_s *) ((uintp

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-05 Thread via GitHub
Fix-Point commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074631337 ## sched/wqueue/wqueue.h: ## @@ -159,6 +148,65 @@ static inline_function FAR struct kwork_wqueue_s *work_qid2wq(int qid) } } +/**

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-05 Thread via GitHub
Fix-Point commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074628950 ## include/nuttx/wqueue.h: ## @@ -249,19 +249,11 @@ typedef CODE void (*worker_t)(FAR void *arg); struct work_s { - union - { -struct -{ - struct l

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-05 Thread via GitHub
Fix-Point commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074630963 ## sched/wqueue/kwork_queue.c: ## @@ -141,65 +80,72 @@ int work_queue_period_wq(FAR struct kwork_wqueue_s *wqueue, FAR void *arg, clock_t de

Re: [PR] sched/wqueue: Refactor delayed and periodic workqueue. [nuttx]

2025-05-05 Thread via GitHub
Fix-Point commented on code in PR #16231: URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074628825 ## sched/wqueue/kwork_cancel.c: ## @@ -31,7 +31,7 @@ #include #include -#include +#include Review Comment: Done. ## sched/wqueue/wqueue.h:

Re: [PR] RP2040: Allow simultaneous selection of multiple interrupt modes [nuttx]

2025-05-05 Thread via GitHub
linguini1 commented on PR #16281: URL: https://github.com/apache/nuttx/pull/16281#issuecomment-2852895106 > Thank you @linguini1 :-) I have ordered this Xiao RP2040 board so I can help testing too :-) You could probably re-use this example on another RP2040 board just using a differe

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-05 Thread via GitHub
acassis commented on PR #16323: URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2852893321 @sumpfralle please add RCALL to codespell exception -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-05 Thread via GitHub
nuttxpr commented on PR #16323: URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2852887823 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements.

[PR] Patches to support AVRDA/DB created by KR [nuttx]

2025-05-05 Thread via GitHub
acassis opened a new pull request, #16323: URL: https://github.com/apache/nuttx/pull/16323 ## Summary These patches were created by KR to enable support to AVRDA and AVRDB. This is early stage with only hello board profile example. ## Impact Users will be able to test Nu

Re: [PR] DOCS: Chip tagging [nuttx]

2025-05-05 Thread via GitHub
cederom commented on code in PR #16321: URL: https://github.com/apache/nuttx/pull/16321#discussion_r2074478831 ## Documentation/platforms/arm/nrf91/boards/thingy91/index.rst: ## @@ -2,6 +2,8 @@ Nordic Thingy:91 = +.. tags:: chip:nrf91, chip:nrf9160, chip:nrf5

Re: [PR] RP2040: Allow simultaneous selection of multiple interrupt modes [nuttx]

2025-05-05 Thread via GitHub
cederom commented on PR #16281: URL: https://github.com/apache/nuttx/pull/16281#issuecomment-2852851358 Thank you @linguini1 :-) I have ordered this Xiao RP2040 board so I can help testing too :-) -- This is an automated message from the Apache Git Service. To respond to the message, plea

(nuttx-website) branch asf-site updated: Publishing web: 16e1777b863bd27e3a00b7b779baf0131af07df6 docs: e086ef2d029fbceb2a3d9bea070f3d286535aa29

2025-05-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 047d79353 Publishing web: 16e1777

Re: [PR] arch/avr: fixes rfc2. [nuttx]

2025-05-05 Thread via GitHub
acassis commented on PR #16322: URL: https://github.com/apache/nuttx/pull/16322#issuecomment-2852840229 These are the right commits: ![image](https://github.com/user-attachments/assets/f7527369-67cd-46bc-a0e8-e8fab6db5f92) -- This is an automated message from the Apache Git Ser

Re: [PR] arch/avr: fixes rfc2. [nuttx]

2025-05-05 Thread via GitHub
cederom commented on PR #16322: URL: https://github.com/apache/nuttx/pull/16322#issuecomment-2852840089 Ah allright, thank you @acassis !! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] arch/avr: fixes rfc2. [nuttx]

2025-05-05 Thread via GitHub
cederom commented on PR #16322: URL: https://github.com/apache/nuttx/pull/16322#issuecomment-2852839271 Yeah, lets reopen this one and mark "draft" until resolved so I have somewhere to work on :-) -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] arch/avr: fixes rfc2. [nuttx]

2025-05-05 Thread via GitHub
acassis commented on PR #16322: URL: https://github.com/apache/nuttx/pull/16322#issuecomment-2852839261 I'm reviewing and testing the code that he submitted, you should have aligned with me before submitting it! :-D -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] arch/avr: fixes rfc2. [nuttx]

2025-05-05 Thread via GitHub
acassis commented on PR #16322: URL: https://github.com/apache/nuttx/pull/16322#issuecomment-2852832650 @cederom there are something wrong, the commit you sent are not related -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] arch/avr: fixes rfc2. [nuttx]

2025-05-05 Thread via GitHub
cederom closed pull request #16322: arch/avr: fixes rfc2. URL: https://github.com/apache/nuttx/pull/16322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [PR] arch/avr: fixes rfc2. [nuttx]

2025-05-05 Thread via GitHub
nuttxpr commented on PR #16322: URL: https://github.com/apache/nuttx/pull/16322#issuecomment-2852831163 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with

[PR] arch/avr: fixes rfc2. [nuttx]

2025-05-05 Thread via GitHub
cederom opened a new pull request, #16322: URL: https://github.com/apache/nuttx/pull/16322 ## Summary Note: This is a proxy PR from kr@kerogit.eu, continues https://github.com/apache/nuttx/pull/16268. Here are the changes from previous version: 1. some formatting and

Re: [PR] fix misspelled names in locally scoped code [nuttx]

2025-05-05 Thread via GitHub
anchao commented on code in PR #16319: URL: https://github.com/apache/nuttx/pull/16319#discussion_r2074367178 ## libs/libc/stream/lib_blkoutstream.c: ## @@ -153,15 +153,15 @@ static ssize_t blkoutstream_puts(FAR struct lib_sostream_s *self, if (offset > 0) { -

Re: [PR] espressif: Add variable to override MCUboot version and URL [nuttx]

2025-05-05 Thread via GitHub
anchao commented on code in PR #16320: URL: https://github.com/apache/nuttx/pull/16320#discussion_r2074362653 ## arch/risc-v/src/common/espressif/Bootloader.mk: ## @@ -35,8 +35,14 @@ BOOTLOADER_CONFIG= $(BOOTLOADER_SRCDIR)/bootloader.conf MCUBOOT_SRCDIR = $(BOOTLOADER

Re: [PR] Added a small usability improve for Unix.mk savedefconfig [nuttx]

2025-05-05 Thread via GitHub
anchao commented on code in PR #16312: URL: https://github.com/apache/nuttx/pull/16312#discussion_r2074361455 ## tools/Unix.mk: ## @@ -768,6 +768,7 @@ savedefconfig: apps_preconfig $(Q) rm -f warning.tmp $(Q) rm -f defconfig.tmp $(Q) rm -f sortedconfig.tm

(nuttx) branch master updated: boards/arm/stm32f7/nucleo-f767zi: enhance button support

2025-05-05 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git The following commit(s) were added to refs/heads/master by this push: new e086ef2d02 boards/arm/stm32f7/nucleo-f767zi: enh

Re: [PR] boards/arm/stm32f7/nucleo-f767zi: enhance button support [nuttx]

2025-05-05 Thread via GitHub
acassis merged PR #16307: URL: https://github.com/apache/nuttx/pull/16307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac

Re: [I] [FEATURE] Need "Contributing" documentation for Python scripts [nuttx]

2025-05-05 Thread via GitHub
TimJTi commented on issue #16264: URL: https://github.com/apache/nuttx/issues/16264#issuecomment-2852427171 > You are right, we are missing documentation regarding Python linting. We do however have instructions on using `pre-commit`, it should automatically run the Python linting tools: [

Re: [I] [FEATURE] raspberrypi pico w/2/2w firmware flashing automation with make flash [nuttx]

2025-05-05 Thread via GitHub
cederom commented on issue #16271: URL: https://github.com/apache/nuttx/issues/16271#issuecomment-2852399425 > @keever50: I can confirm platformio (https://github.com/earlephilhower/arduino-pico) is including a bootloader. Might be a nice addition for NuttX to add it as well. Hmm thi

Re: [I] [FEATURE] raspberrypi pico w/2/2w firmware flashing automation with make flash [nuttx]

2025-05-05 Thread via GitHub
keever50 commented on issue #16271: URL: https://github.com/apache/nuttx/issues/16271#issuecomment-2852289928 I can confirm platformio (https://github.com/earlephilhower/arduino-pico) is including a bootloader. Might be a nice addition for NuttX to add it as well. -- This is an automat

Re: [PR] examples/posix_stdio: Adding posix stdio example for new joiners. [nuttx-apps]

2025-05-05 Thread via GitHub
cederom commented on code in PR #3065: URL: https://github.com/apache/nuttx-apps/pull/3065#discussion_r2074031679 ## examples/posix_stdio/posix_stdio.c: ## @@ -0,0 +1,100 @@ +/ + * apps/examples/posix_st

Re: [I] [FEATURE] raspberrypi pico w/2/2w firmware flashing automation with make flash [nuttx]

2025-05-05 Thread via GitHub
linguini1 commented on issue #16271: URL: https://github.com/apache/nuttx/issues/16271#issuecomment-2852209273 After doing more research on this topic I haven't been able to find any mention of automatic flashing of RP2040 chips. All sources I've found said that the chip requires the "boots

Re: [PR] DOCS: Chip tagging [nuttx]

2025-05-05 Thread via GitHub
nuttxpr commented on PR #16321: URL: https://github.com/apache/nuttx/pull/16321#issuecomment-2852199679 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements. T

Re: [PR] boards/arm/stm32f7/nucleo-f767zi: enhance button support [nuttx]

2025-05-05 Thread via GitHub
vrmay23 commented on PR #16307: URL: https://github.com/apache/nuttx/pull/16307#issuecomment-2852193055 @acassis it is done! Thanks! BR, Vinicius -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] DOCS: Chip tagging [nuttx]

2025-05-05 Thread via GitHub
linguini1 opened a new pull request, #16321: URL: https://github.com/apache/nuttx/pull/16321 ## Summary This PR introduces more chip tags to various different boards in the documentation, as part of the initiative to add the tagging system to the NuttX docs. This PR adds tags

Re: [PR] boards/stm32f0l0g0: Add Nucleo G0B1RE support. [nuttx]

2025-05-05 Thread via GitHub
stbenn commented on PR #16293: URL: https://github.com/apache/nuttx/pull/16293#issuecomment-2852151807 @lupyuen Any idea why Linux arm-13 might be failing on this build? I don't see any error or warnings (outside of CMake warning) in the logs. The only strange part of the logs is that after

Re: [I] [HELP] Please explain the esp32 wlan driver working which cause the following issue on cpu0 [nuttx]

2025-05-05 Thread via GitHub
abisop commented on issue #16269: URL: https://github.com/apache/nuttx/issues/16269#issuecomment-2852100158 > Ok so it is not the wifi defconfig by itself, right? Please send here your current defconfig so I can replicate with the actual features >that are enabled (`make savedefconfig`).

Re: [PR] Documentation: fix spelling [nuttx]

2025-05-05 Thread via GitHub
sumpfralle commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2852038376 hint: updated PR with one more spelling fix (`MingGW`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [HELP] Please explain the esp32 wlan driver working which cause the following issue on cpu0 [nuttx]

2025-05-05 Thread via GitHub
fdcavalcanti commented on issue #16269: URL: https://github.com/apache/nuttx/issues/16269#issuecomment-2852032528 Ok so it is not the wifi defconfig by itself, right? Please send here your current defconfig so I can replicate with the actual features that are enabled (`make savedefconfig`

Re: [PR] espressif: Add variable to override MCUboot version and URL [nuttx]

2025-05-05 Thread via GitHub
nuttxpr commented on PR #16320: URL: https://github.com/apache/nuttx/pull/16320#issuecomment-2852025746 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR meets the NuttX requirements. The summary

Re: [PR] Documentation: fix spelling [nuttx]

2025-05-05 Thread via GitHub
acassis commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2852015092 Thank you @sumpfralle now I saw the point, the -c parameter already existed in checkpatch.sh. The issue is: in the past it was optional, since there is no codespell check in the CI.

[PR] espressif: Add variable to override MCUboot version and URL [nuttx]

2025-05-05 Thread via GitHub
tmedicci opened a new pull request, #16320: URL: https://github.com/apache/nuttx/pull/16320 ## Summary * espressif: Add variable to override MCUboot version and URL The version and the git repository of Espressif's MCUboot port can be changed by setting the `MCUBOOT_VERSION` an

Re: [PR] Documentation: fix spelling [nuttx]

2025-05-05 Thread via GitHub
sumpfralle commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2852005777 > @sumpfralle I looked again and didn't see it included inside checkpatch.sh script. > > More info about the script: https://nuttx.apache.org/docs/latest/components/tools/index.

Re: [PR] Documentation: fix spelling [nuttx]

2025-05-05 Thread via GitHub
acassis commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2851981753 > > I think now the checkpatch should include the code spelling test, [..] > > I think, this was done in #16302? Or do you mean something else? @sumpfralle I looked again and

Re: [PR] RP2040: Allow simultaneous selection of multiple interrupt modes [nuttx]

2025-05-05 Thread via GitHub
linguini1 commented on PR #16281: URL: https://github.com/apache/nuttx/pull/16281#issuecomment-2851975135 @keever50 @cederom I see that this change has already been merged, however I did take the time to write a test case that I tested on the XIAO RP2040 board I have on hand:

Re: [PR] Documentation: fix spelling [nuttx]

2025-05-05 Thread via GitHub
sumpfralle commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2851955035 > I think now the checkpatch should include the code spelling test, [..] I think, this was done in #16302? Or do you mean something else? -- This is an automated message from t

Re: [PR] Documentation: fix spelling [nuttx]

2025-05-05 Thread via GitHub
acassis commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2851946384 @sumpfralle @xiaoxiang781216 I think now the checkpatch should include the code spelling test, otherwise devs only will discover about the fault too late (then it is using the CI) and we

Re: [PR] boards/arm/stm32f7/nucleo-f767zi: enhance button support [nuttx]

2025-05-05 Thread via GitHub
acassis commented on PR #16307: URL: https://github.com/apache/nuttx/pull/16307#issuecomment-2851940203 @vrmay23 now there is a code spell support and it detected an issue here: /home/runner/work/nuttx/nuttx/nuttx/boards/arm/stm32f7/nucleo-f767zi/src/nucleo-f767zi.h:307: inialization

Re: [PR] boards/arm/stm32f7/nucleo-f767zi: enhance button support [nuttx]

2025-05-05 Thread via GitHub
acassis commented on PR #16307: URL: https://github.com/apache/nuttx/pull/16307#issuecomment-2851935487 @vrmay23 the CI is not able to detect that none file was modified, to it will redo everything -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] examples/posix_stdio: Adding posix stdio example for new joiners. [nuttx-apps]

2025-05-05 Thread via GitHub
vrmay23 commented on PR #3065: URL: https://github.com/apache/nuttx-apps/pull/3065#issuecomment-2851705165 @cederom it's done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] boards/arm/stm32f7/nucleo-f767zi: enhance button support [nuttx]

2025-05-05 Thread via GitHub
vrmay23 commented on PR #16307: URL: https://github.com/apache/nuttx/pull/16307#issuecomment-2851572910 @jerpelea it's done. But it seems now it have to be checked again, everything. Is this? BR, Vinicius -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] [BUG] esp32-devkitc:smp fails on ostest after #16030 [nuttx]

2025-05-05 Thread via GitHub
tmedicci commented on issue #16193: URL: https://github.com/apache/nuttx/issues/16193#issuecomment-2851571164 > Hi, trying to get around the race conditions between signal dispatching and delivery in smp in [#16301](https://github.com/apache/nuttx/pull/16301) > > Could you check, if t

Re: [I] [HELP] Please explain the esp32 wlan driver working which cause the following issue on cpu0 [nuttx]

2025-05-05 Thread via GitHub
abisop commented on issue #16269: URL: https://github.com/apache/nuttx/issues/16269#issuecomment-2851542947 Thanks @fdcavalcanti sir for responding I don't think its a power issue As far as i got to know, its some kind of memory and timing (maybe race condition) issue... Please

Re: [PR] boot/nxboot: Enhancements to add progress messages and copy-to-RAM [nuttx-apps]

2025-05-05 Thread via GitHub
TimJTi commented on code in PR #3068: URL: https://github.com/apache/nuttx-apps/pull/3068#discussion_r2073755822 ## boot/nxboot/loader/boot.c: ## @@ -403,6 +440,42 @@ static int perform_update(struct nxboot_state *state, bool check_only) return OK; } +#ifdef CONFIG_NXBOOT

Re: [PR] boot/nxboot: Enhancements to add progress messages and copy-to-RAM [nuttx-apps]

2025-05-05 Thread via GitHub
TimJTi commented on code in PR #3068: URL: https://github.com/apache/nuttx-apps/pull/3068#discussion_r2073755151 ## boot/nxboot/loader/boot.c: ## @@ -403,6 +440,42 @@ static int perform_update(struct nxboot_state *state, bool check_only) return OK; } +#ifdef CONFIG_NXBOOT

Re: [PR] fix misspelled names in locally scoped code [nuttx]

2025-05-05 Thread via GitHub
nuttxpr commented on PR #16319: URL: https://github.com/apache/nuttx/pull/16319#issuecomment-2851507216 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. This PR does not fully meet the NuttX requirements.

Re: [PR] Documentation: fix spelling [nuttx]

2025-05-05 Thread via GitHub
sumpfralle commented on code in PR #16318: URL: https://github.com/apache/nuttx/pull/16318#discussion_r2073738401 ## .codespell-ignore-lines: ## @@ -12,3 +12,10 @@ Linix 45ZWN24-40 2 0.5 Ohm0.400 mH 2.34A 24V THN, # define AES_ISR_URAT_WORRDACC (5 <<

Re: [PR] arch/arm/rp23xx: add dsp/fpu extensions support [nuttx]

2025-05-05 Thread via GitHub
avgoor commented on PR #16306: URL: https://github.com/apache/nuttx/pull/16306#issuecomment-2851495441 Hi @shtirlic, after enabling the FPU on RP2350 it now locks up during a startup in SMP configurations. Here are the only culprits I have at the moment: ``` [rp2350.dap.core1] c

[PR] fix misspelled names in locally scoped code [nuttx]

2025-05-05 Thread via GitHub
sumpfralle opened a new pull request, #16319: URL: https://github.com/apache/nuttx/pull/16319 ## Summary [Codespell](https://github.com/codespell-project/codespell/) discovered a few typos in variable or function names. These misspelled words are used in strictly local scopes.

  1   2   >