anchao commented on code in PR #16320: URL: https://github.com/apache/nuttx/pull/16320#discussion_r2074362653
########## arch/risc-v/src/common/espressif/Bootloader.mk: ########## @@ -35,8 +35,14 @@ BOOTLOADER_CONFIG = $(BOOTLOADER_SRCDIR)/bootloader.conf MCUBOOT_SRCDIR = $(BOOTLOADER_SRCDIR)/mcuboot MCUBOOT_ESPDIR = $(MCUBOOT_SRCDIR)/boot/espressif -MCUBOOT_URL = https://github.com/mcu-tools/mcuboot MCUBOOT_TOOLCHAIN = $(TOOLSDIR)/mcuboot_toolchain_espressif.cmake +ifndef MCUBOOT_VERSION + MCUBOOT_VERSION = $(CONFIG_ESPRESSIF_MCUBOOT_VERSION) +endif + +ifndef MCUBOOT_URL + MCUBOOT_URL = https://github.com/mcu-tools/mcuboot Review Comment: ```suggestion MCUBOOT_URL ?= https://github.com/mcu-tools/mcuboot ``` ########## arch/risc-v/src/common/espressif/Bootloader.mk: ########## @@ -35,8 +35,14 @@ BOOTLOADER_CONFIG = $(BOOTLOADER_SRCDIR)/bootloader.conf MCUBOOT_SRCDIR = $(BOOTLOADER_SRCDIR)/mcuboot MCUBOOT_ESPDIR = $(MCUBOOT_SRCDIR)/boot/espressif -MCUBOOT_URL = https://github.com/mcu-tools/mcuboot MCUBOOT_TOOLCHAIN = $(TOOLSDIR)/mcuboot_toolchain_espressif.cmake +ifndef MCUBOOT_VERSION + MCUBOOT_VERSION = $(CONFIG_ESPRESSIF_MCUBOOT_VERSION) Review Comment: ```suggestion MCUBOOT_VERSION ?= $(CONFIG_ESPRESSIF_MCUBOOT_VERSION) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
