gpoulios commented on code in PR #16309:
URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074746657
##########
drivers/misc/optee.c:
##########
@@ -125,52 +115,24 @@ static const struct file_operations g_optee_ops =
static int optee_open(FAR struct file *filep)
{
- FAR struct socket *psock;
-#ifdef CONFIG_DEV_OPTEE_LOCAL
- struct sockaddr_un addr;
-#else
- struct sockaddr_rpmsg addr;
-#endif
+ FAR struct optee_priv_data *priv;
int ret;
- psock = (FAR struct socket *)kmm_zalloc(sizeof(struct socket));
- if (psock == NULL)
+ priv = (FAR struct optee_priv_data *)
+ kmm_zalloc(sizeof(struct optee_priv_data));
+ if (priv == NULL)
{
return -ENOMEM;
}
-#ifdef CONFIG_DEV_OPTEE_LOCAL
- ret = psock_socket(AF_UNIX, SOCK_STREAM, 0, psock);
-#else
- ret = psock_socket(AF_RPMSG, SOCK_STREAM, 0, psock);
-#endif
+ ret = optee_transport_open(priv);
if (ret < 0)
{
- kmm_free(psock);
Review Comment:
I did not. See
[optee_socket.c#131](https://github.com/apache/nuttx/pull/16309/commits/2c5e54e253d4b1d175a7240a1c37d5945c1a717d#diff-9378743f90d8f42d4ddd8948d29bca9086689127b4c9bdc3ed026878a4bd5d41R131).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
