sumpfralle commented on PR #16318: URL: https://github.com/apache/nuttx/pull/16318#issuecomment-2852005777
> @sumpfralle I looked again and didn't see it included inside checkpatch.sh script. > > More info about the script: https://nuttx.apache.org/docs/latest/components/tools/index.html#checkpatch-sh > > Basically before the user open a PR they should run checkpatch.sh to find issues, so normally users don't need to run the CI locally, but just checkpatch.sh to spot issues I have the feeling, we are confusing each other :) My understanding is the following: * `checkpatch.sh` can be called with the parameter `-c` in order to run codespell * the pre-commit hook calls `checkpatch.sh` with the `-c` parameter (since #16302) * the CI workflow `check` calls `checkpatch.sh` with the `-c` parameter I am not sure, what I am missing here. Maybe you want to enable the codespell check in `checkpatch.sh` by default? (i.e. without requiring `-c`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
