nuttxpr commented on PR #16323: URL: https://github.com/apache/nuttx/pull/16323#issuecomment-2852887823
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary and mentions impact, it lacks crucial details. Here's a breakdown of missing information: * **Summary:** Lacks specifics. *What* functional part of the code changed? *How* does enabling AVRDA/DB support work (e.g., new drivers, board configuration files, modifications to existing code)? Are there related NuttX issues? * **Impact:** While user impact is mentioned, it needs to address *all* other impact categories (build process, hardware, documentation, security, compatibility). Simply stating "NO" is insufficient; justify why there's no impact or provide details if there is. * **Testing:** "Breadboard" is not adequate testing information. The requirements ask for specific host and target details (OS, CPU, compiler, architecture, board, configuration) and, crucially, *testing logs*. Without logs demonstrating the functionality before and after the change, there's no verifiable proof that the changes work as intended. Therefore, the PR needs substantial revision before it can be considered complete. The author needs to provide the missing details to ensure the changes are properly documented, reviewed, and integrated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
