nuttxpr commented on PR #16319: URL: https://github.com/apache/nuttx/pull/16319#issuecomment-2851507216
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. This PR does not fully meet the NuttX requirements. While the summary is acceptable, the impact and testing sections are insufficient. **Impact:** While the author *claims* there is no impact, they need to explicitly answer NO/YES for each question. For example: * Is new feature added? NO * Is existing feature changed? NO * Impact on user (will user need to adapt to change)? NO * ...and so on for all impact questions. **Testing:** "No testing was conducted" is unacceptable. Even for trivial changes like typos, a basic build test should be performed and the output logged. The author needs to demonstrate that the code still compiles and ideally run some basic functionality tests related to the changed code. Even if the change seems trivial, unexpected issues can arise. The PR description should include: * Build Host(s) information as required * Target(s) information as required * Build logs (even if they are identical before and after) In short, while the changes themselves might be minor, the PR needs to follow the required template completely to ensure consistent review and prevent regressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
