xiaoxiang781216 commented on code in PR #16231:
URL: https://github.com/apache/nuttx/pull/16231#discussion_r2074762646


##########
libs/libc/wqueue/work_queue.c:
##########
@@ -87,17 +87,17 @@ static int work_qqueue(FAR struct usr_wqueue_s *wqueue,
 
   /* Initialize the work structure */
 
-  work->worker = worker;             /* Work callback. non-NULL means queued */
-  work->arg    = arg;                /* Callback argument */
-  work->u.s.qtime = clock() + delay; /* Delay until work performed */
+  work->worker = worker;          /* Work callback. non-NULL means queued */
+  work->arg    = arg;             /* Callback argument */
+  work->qtime  = clock() + delay; /* Delay until work performed */
 
   /* Do the easy case first -- when the work queue is empty. */
 
   if (wqueue->q.head == NULL)

Review Comment:
   need change from dq_entry_s to list_node in usr_wqueue_s at:
   https://github.com/apache/nuttx/blob/master/libs/libc/wqueue/wqueue.h#L52



##########
libs/libc/wqueue/work_usrthread.c:
##########
@@ -136,7 +136,7 @@ static void work_process(FAR struct usr_wqueue_s *wqueue)
           dq_remfirst(&wqueue->q);

Review Comment:
   need change all dq_xxx to list_xxx in this file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to