cederom opened a new pull request, #16322:
URL: https://github.com/apache/nuttx/pull/16322

   ## Summary
   
   Note: This is a proxy PR from kr....@kerogit.eu, continues 
https://github.com/apache/nuttx/pull/16268.
   
   Here are the changes from previous version:
   
   1. some formatting and typo fixes in various documents
   
   2. as discussed above, some mixed-case constants were preserved (_bm and
   _bp suffix) and some removed. Patch for the nxstyle tool that
   facilitates this exception is added to the series. Non-permitted
   constants with mixed-case letters are no longer used in their form from
   library io.h file, instead there are new files within NuttX source tree
   that provide all-uppercase constant names.
   
   3. nxstyle cannot deal with the exceptions properly and come constants
   with _bm suffix in their name were still flagged as incorrect. That is
   worked around by various code shuffling, assigning into temporary
   variables etc. Most places where this was needed to be done are marked
   with comment along the lines of "this will make nxstyle happpy." The
   code seems less readable this way but after trying to make heads or
   tails of the nxstyle source code, this is the only solution I can
   provide on my own.
   
   4. after dealing with this, I found that there were some mixed-case
   warnings still left - I missed them because of the quantity of others.
   Specifically, it was the type USART_t, a data type which facilitates
   access to a peripheral I/O registers for USART. (Other peripherals have
   their types named in the same way.) I changed this one into
   avrdx_usart_t and redefined it in the NuttX source as well.
   
   Any comments and reviews are appreciated.
   
   ## Impact
   
   *arch/avr.
   
   ## Testing
   
   * There should be no checkpatch errors left.
   * From what I tested, the code compiles to a binary identical to previous 
version of the patch series.
   * TODO: What hardware was it tested on?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to