nuttxpr commented on PR #16322: URL: https://github.com/apache/nuttx/pull/16322#issuecomment-2852831163
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. No, this PR does not fully meet the NuttX requirements. Here's why: * **Insufficient Summary:** While the summary explains the *changes from a previous PR*, it doesn't adequately explain the original purpose of the changes. What problem does the original PR (16268) solve? What functionality is affected? The summary focuses too much on the process and not enough on the "what" and "why." * **Vague Impact:** Stating "*arch/avr*" is not enough detail. Which specific AVR chips are affected? Are there specific boards? Drivers? The impact section needs to be much more specific. * **Incomplete Testing:** "TODO: What hardware was it tested on?" is unacceptable. Testing must be performed and documented *before* submitting a PR. The provided testing information is also inadequate. Simply stating that the binary is identical to a previous version isn't sufficient proof that the changes work as intended. Specific tests performed and their results should be documented, along with the expected behavior. The "no checkpatch errors" statement is good, but the output of checkpatch should ideally be included (or at least a statement confirming it ran cleanly). The lack of "before" and "after" logs, as requested in the template, is also a problem. **Specific recommendations for improvement:** * **Rewrite the Summary:** Focus on the original goal of the change, not just the revisions. Clearly state what problem is being solved and what functionality is affected. Reference the original issue that prompted this PR. * **Detail the Impact:** Be explicit about which AVR architectures, boards, and drivers are affected. Explain how the change might impact users of those specific targets. Address all other impact points (build, documentation, security, compatibility) thoroughly. Don't just say "NO" – explain why there's no impact. * **Complete Testing:** Test on real hardware and document the specific hardware used. Provide clear, detailed test cases and results, including "before" and "after" logs. Remove the "TODO" and provide the requested information. Show the *output* of checkpatch, not just a statement about it. By addressing these points, the PR will better meet the NuttX requirements and have a higher chance of being accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
