gpoulios commented on code in PR #16309: URL: https://github.com/apache/nuttx/pull/16309#discussion_r2074781958
########## drivers/misc/optee.h: ########## @@ -0,0 +1,77 @@ +/**************************************************************************** + * drivers/misc/optee.h + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __DRIVERS_MISC_OPTEE_H +#define __DRIVERS_MISC_OPTEE_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> +#include <nuttx/compiler.h> +#include <nuttx/tee.h> + +#include "optee_msg.h" + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#define OPTEE_SERVER_PATH "optee" +#define OPTEE_MAX_PARAM_NUM 6 + +/**************************************************************************** + * Public Types + ****************************************************************************/ + +struct optee_priv_data; + +struct optee_priv_data Review Comment: I put it there because of its common part (the shm list). If `optee_priv_data` is transport-specific then we can't have common alloc/free'ing of shared memory implemented in optee.c (e.g. see optee.c#`optee_close()`). Are you sure? If so, do you mean perhaps to move all shared memory specifics into optee_smc.c instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
