[PATCH v2 2/8] vpci/header: Emulate legacy capability list for host

2025-04-09 Thread Jiqian Chen
Current logic of init_header() only emulates legacy capability list for guest, expand it to emulate for host too. So that it will be easy to hide a capability whose initialization fails and no need to distinguish host or guest. Signed-off-by: Jiqian Chen --- cc: "Roger Pau Monné" --- v1->v2 chan

Re: [RFC PATCH v1 01/15] x86/msr: Replace __wrmsr() with native_wrmsrl()

2025-04-09 Thread Ingo Molnar
* H. Peter Anvin wrote: > On April 2, 2025 8:41:07 AM PDT, Dave Hansen wrote: > >On 3/31/25 22:53, Xin Li wrote: > >> Per "struct msr" defined in arch/x86/include/asm/shared/msr.h: > >> > >> struct msr { > >>     union { > >>     struct { > >>     u32 l; >

Re: [RFC PATCH v1 01/15] x86/msr: Replace __wrmsr() with native_wrmsrl()

2025-04-09 Thread Dave Hansen
On 4/9/25 12:53, Ingo Molnar wrote: >>> What would folks think about "wrmsr64()"? It's writing a 64-bit >>> value to an MSR and there are a lot of functions in the kernel that >>> are named with the argument width in bits. >> Personally, I hate the extra verbosity, mostly visual, since numerals

Re: [RFC PATCH v1 01/15] x86/msr: Replace __wrmsr() with native_wrmsrl()

2025-04-09 Thread Ingo Molnar
* Dave Hansen wrote: > On 4/9/25 12:53, Ingo Molnar wrote: > >>> What would folks think about "wrmsr64()"? It's writing a 64-bit > >>> value to an MSR and there are a lot of functions in the kernel that > >>> are named with the argument width in bits. > >> Personally, I hate the extra verbosi

Re: [PATCH v3 13/16] x86/hyperlaunch: specify dom0 mode with device tree

2025-04-09 Thread Denis Mukhin
On Tuesday, April 8th, 2025 at 9:07 AM, Alejandro Vallejo wrote: > > > From: "Daniel P. Smith" dpsm...@apertussolutions.com > > > Enable selecting the mode in which the domain will be built and ran. This > includes: > > - whether it will be either a 32/64 bit domain > - if it will be run as

Re: [PATCH v3 11/16] x86/hyperlaunch: locate dom0 initrd with hyperlaunch

2025-04-09 Thread Denis Mukhin
On Tuesday, April 8th, 2025 at 9:07 AM, Alejandro Vallejo wrote: > > > From: "Daniel P. Smith" dpsm...@apertussolutions.com > > > Look for a subnode of type `multiboot,ramdisk` within a domain node and > parse via the fdt_read_multiboot_module() helper. After a successful > helper call, the

[PATCH v2 8/8] vpci/msix: Add function to clean MSIX resources

2025-04-09 Thread Jiqian Chen
When init_msix() fails, it needs to clean all MSIX resources. So, add a new function fini_msix() to do that. And to unregister the mmio handler of vpci_msix_table_ops, add a new function. Signed-off-by: Jiqian Chen --- cc: Jan Beulich cc: Andrew Cooper cc: "Roger Pau Monné" --- v1->v2 changes

Re: [PATCH v3 16/16] x86/hyperlaunch: add capabilities to boot domain

2025-04-09 Thread Denis Mukhin
On Tuesday, April 8th, 2025 at 9:07 AM, Alejandro Vallejo wrote: > > > From: "Daniel P. Smith" dpsm...@apertussolutions.com > > > Introduce the ability to assign capabilities to a domain via its definition in > device tree. The first capability enabled to select is the control domain > capab

Re: [PATCH 6/8] Factor our x86-isms in the linux build script

2025-04-09 Thread Marek Marczykowski-Górecki
On Wed, Apr 09, 2025 at 07:05:21PM +0200, Marek Marczykowski-Górecki wrote: > On Wed, Apr 09, 2025 at 05:37:00PM +0100, Andrew Cooper wrote: > > ... in preparation to use it for arm64 too. Rename the script. > > > > Signed-off-by: Andrew Cooper > > Reviewed-by: Marek Marczykowski-Górecki Repl

[PATCH TEST-ARTEFACTS 0/8] Cleanup and Linux ARM64 support

2025-04-09 Thread Andrew Cooper
Various bits of cleanup, and support for arm64 Linux builds. Run using the new Linux 6.6.86 on (most) x86, and ARM64: https://gitlab.com/xen-project/hardware/xen-staging/-/pipelines/1760667411 Still to go: - Merge argo into the linux build (as it builds a module), strip devel artefacts - Roo

Re: [PATCH v2 1/3] kasan: Avoid sleepable page allocation from atomic context

2025-04-09 Thread Alexander Gordeev
On Wed, Apr 09, 2025 at 04:10:58PM +0200, Andrey Ryabinin wrote: Hi Andrey, > > @@ -301,7 +301,7 @@ static int kasan_populate_vmalloc_pte(pte_t *ptep, > > unsigned long addr, > > if (likely(!pte_none(ptep_get(ptep > > return 0; > > > > - page = __get_free_page(GFP_KERNEL)

Re: [PATCH] CI: Update x86 tests from Linux 6.1.19 to 6.6.56

2025-04-09 Thread Marek Marczykowski-Górecki
On Wed, Apr 09, 2025 at 02:05:05PM +0100, Andrew Cooper wrote: > Linux 6.6.56 was already added to test-artifacts for the argo testing, and > this removes one moving part while cleaning things up. > > Drop the associated export job, and dockerfile. My hw12 runner series adds CONFIG_USB_RTL8152, t

[PATCH v3 2/4] xen/arm: make pci_host_common_probe return the bridge

2025-04-09 Thread Mykyta Poturai
From: Oleksandr Andrushchenko Some of the PCI host bridges require additional processing during the probe phase. For that they need to access struct bridge of the probed host, so return pointer to the new bridge from pci_host_common_probe. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: M

[PATCH v3 1/4] xen/arm: allow PCI host bridge to have private data

2025-04-09 Thread Mykyta Poturai
From: Oleksandr Andrushchenko Some of the PCI host bridges require private data. Add priv field to struct pci_host_bridge, so such bridges may populate it with their private data. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Mykyta Poturai --- v2->v3: * removed priv allocation from co

[PATCH v3 4/4] xen/arm: add support for R-Car Gen4 PCI host controller

2025-04-09 Thread Mykyta Poturai
From: Oleksandr Andrushchenko Add support for Renesas R-Car Gen4 PCI host controller, specifically targeting the S4 and V4H SoCs. The implementation includes configuration read/write operations for both root and child buses. For accessing the child bus, iATU is used for address translation. Code

[PATCH] x86/HVM: improve local variable use in hvm_hap_nested_page_fault()

2025-04-09 Thread Jan Beulich
First gfn can be set just once, rather than (conditionally) twice. And then gfn can be used in two function calls, rather than re- calculating the value there. Signed-off-by: Jan Beulich --- I wasn't quite sure about continuing to use an open-coded shift. PFN_DOWN() could be used, or paddr_to_pf

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Roger Pau Monné
On Wed, Apr 09, 2025 at 02:59:45PM +0200, Jan Beulich wrote: > On 09.04.2025 12:39, Roger Pau Monné wrote: > > On Wed, Apr 09, 2025 at 12:00:16PM +0200, Jan Beulich wrote: > >> On 09.04.2025 11:07, Roger Pau Monné wrote: > >>> On Tue, Apr 08, 2025 at 03:57:17PM +0200, Jan Beulich wrote: > On 0

Re: [PATCH v3 03/16] x86/boot: add cmdline to struct boot_domain

2025-04-09 Thread Jan Beulich
On 09.04.2025 13:11, Alejandro Vallejo wrote: > On Wed Apr 9, 2025 at 7:48 AM BST, Jan Beulich wrote: >> On 08.04.2025 18:07, Alejandro Vallejo wrote: >>> --- a/xen/arch/x86/hvm/dom0_build.c >>> +++ b/xen/arch/x86/hvm/dom0_build.c >>> @@ -653,7 +653,6 @@ static int __init pvh_load_kernel( >>>

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Roger Pau Monné
On Wed, Apr 09, 2025 at 03:50:13PM +0200, Jan Beulich wrote: > On 09.04.2025 15:33, Roger Pau Monné wrote: > > On Wed, Apr 09, 2025 at 02:59:45PM +0200, Jan Beulich wrote: > >> On 09.04.2025 12:39, Roger Pau Monné wrote: > >>> On Wed, Apr 09, 2025 at 12:00:16PM +0200, Jan Beulich wrote: > On 0

Re: [PATCH 5/8] Adjust Linux build script to work with other major versions

2025-04-09 Thread Marek Marczykowski-Górecki
On Wed, Apr 09, 2025 at 05:36:59PM +0100, Andrew Cooper wrote: > Also use 'tar o' to decompress based on file name. Do you mean 'tar a'? -o is --no-same-owner. Anyway, just 'tar xf' works too, even in alpine. > Signed-off-by: Andrew Cooper > --- > CC: Roger Pau Monné > CC: Stefano Stabellini >

[PATCH] include: sort $(wildcard ...) results

2025-04-09 Thread Jan Beulich
The order of items is stored in .*.chk.cmd, and hence variations between how items are ordered would result in re-invocation of the checking rule during "make install-xen" despite that already having successfully run earlier on. The difference can become noticable when building (as non- root) and i

[PATCH v3 3/4] xen/arm: add support for PCI child bus

2025-04-09 Thread Mykyta Poturai
From: Oleksandr Andrushchenko PCI host bridges often have different ways to access the root and child bus configuration spaces. One of the examples is Designware's host bridge and its multiple clones [1]. Linux kernel implements this by instantiating a child bus when device drivers provide not o

Re: [PATCH v3 04/16] kconfig: introduce option to independently enable libfdt

2025-04-09 Thread Denis Mukhin
On Tuesday, April 8th, 2025 at 9:07 AM, Alejandro Vallejo wrote: > > > From: "Daniel P. Smith" dpsm...@apertussolutions.com > > > Currently, the inclusion of libfdt is controlled by the CONFIG_HAS_DEVICE_TREE > kconfig flag. This flag also changes behavior in a few places, such as boot > mod

[PATCH v3] xen/riscv: Increase XEN_VIRT_SIZE

2025-04-09 Thread Oleksii Kurochko
A randconfig job failed with the following issue: riscv64-linux-gnu-ld: Xen too large for early-boot assumptions The reason is that enabling the UBSAN config increased the size of the Xen binary. Increase XEN_VIRT_SIZE to reserve enough space, allowing both UBSAN and GCOV to be enabled together

Re: [PATCH v3 14/16] x86/hyperlaunch: add memory parsing to domain config

2025-04-09 Thread Denis Mukhin
On Tuesday, April 8th, 2025 at 9:07 AM, Alejandro Vallejo wrote: > > > From: "Daniel P. Smith" dpsm...@apertussolutions.com > > > Add three properties, memory, mem-min, and mem-max, to the domain node device > tree parsing to define the memory allocation for a domain. All three fields > are

Re: [PATCH v3 15/16] x86/hyperlaunch: add max vcpu parsing of hyperlaunch device tree

2025-04-09 Thread Denis Mukhin
On Tuesday, April 8th, 2025 at 9:07 AM, Alejandro Vallejo wrote: > > > From: "Daniel P. Smith" dpsm...@apertussolutions.com > > > Introduce the `cpus` property, named as such for dom0less compatibility, that > represents the maximum number of vpcus to allocate for a domain. In the device > t

Re: [PATCH v3 12/16] x86/hyperlaunch: add domain id parsing to domain config

2025-04-09 Thread Denis Mukhin
On Tuesday, April 8th, 2025 at 9:07 AM, Alejandro Vallejo wrote: > > > From: "Daniel P. Smith" dpsm...@apertussolutions.com > > > Introduce the ability to specify the desired domain id for the domain > definition. The domain id will be populated in the domid property of the > domain > node i

Re: [PATCH v3 10/16] x86/hyperlaunch: obtain cmdline from device tree

2025-04-09 Thread Denis Mukhin
On Tuesday, April 8th, 2025 at 9:07 AM, Alejandro Vallejo wrote: > > > From: "Daniel P. Smith" dpsm...@apertussolutions.com > > > Add support to read the command line from the hyperlauunch device tree. > The device tree command line is located in the "bootargs" property of the > "multiboot,k

[PATCH 8/8] Linux 6.6.86 for x86 and arm64

2025-04-09 Thread Andrew Cooper
It's the latest 6.6 at the time of writing. Signed-off-by: Andrew Cooper --- CC: Roger Pau Monné CC: Stefano Stabellini CC: Michal Orzel CC: Marek Marczykowski-Górecki CC: Anthony PERARD --- .gitlab-ci.yml | 12 1 file changed, 12 insertions(+) diff --git a/.gitlab-ci.yml b/.g

Re: [PATCH v2 01/15] x86/boot: introduce boot domain

2025-04-09 Thread Daniel P. Smith
On 4/7/25 03:10, Jan Beulich wrote: On 05.04.2025 02:04, Daniel P. Smith wrote: On 1/30/25 08:45, Jan Beulich wrote: On 26.12.2024 17:57, Daniel P. Smith wrote: @@ -596,9 +597,10 @@ int __init dom0_setup_permissions(struct domain *d) return rc; } -int __init construct_dom0(struct

Re: [PATCH TEST-ARTEFACTS 0/8] Cleanup and Linux ARM64 support

2025-04-09 Thread Jason Andryuk
On 2025-04-09 13:01, Andrew Cooper wrote: On 09/04/2025 5:36 pm, Andrew Cooper wrote: Various bits of cleanup, and support for arm64 Linux builds. Run using the new Linux 6.6.86 on (most) x86, and ARM64: https://gitlab.com/xen-project/hardware/xen-staging/-/pipelines/1760667411 Lovely, Lin

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Jan Beulich
On 09.04.2025 12:39, Roger Pau Monné wrote: > On Wed, Apr 09, 2025 at 12:00:16PM +0200, Jan Beulich wrote: >> On 09.04.2025 11:07, Roger Pau Monné wrote: >>> On Tue, Apr 08, 2025 at 03:57:17PM +0200, Jan Beulich wrote: On 08.04.2025 11:31, Roger Pau Monne wrote: > When running on AMD hardw

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Jan Beulich
On 09.04.2025 16:01, Roger Pau Monné wrote: > On Wed, Apr 09, 2025 at 03:50:13PM +0200, Jan Beulich wrote: >> On 09.04.2025 15:33, Roger Pau Monné wrote: >>> On Wed, Apr 09, 2025 at 02:59:45PM +0200, Jan Beulich wrote: On 09.04.2025 12:39, Roger Pau Monné wrote: > On Wed, Apr 09, 2025 at 1

Re: [PATCH v3 03/16] x86/boot: add cmdline to struct boot_domain

2025-04-09 Thread Jan Beulich
On 09.04.2025 13:28, Alejandro Vallejo wrote: > On Wed Apr 9, 2025 at 12:11 PM BST, Alejandro Vallejo wrote: >> On Wed Apr 9, 2025 at 7:48 AM BST, Jan Beulich wrote: >>> On 08.04.2025 18:07, Alejandro Vallejo wrote: --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -978,10 +97

Re: [PATCH v2 1/3] kasan: Avoid sleepable page allocation from atomic context

2025-04-09 Thread Andrey Ryabinin
On 4/8/25 6:07 PM, Alexander Gordeev wrote: > apply_to_page_range() enters lazy MMU mode and then invokes > kasan_populate_vmalloc_pte() callback on each page table walk > iteration. The lazy MMU mode may only be entered only under > protection of the page table lock. However, the callback can >

Re: [PATCH v3 06/16] x86/hyperlaunch: introduce the domain builder

2025-04-09 Thread Denis Mukhin
On Tuesday, April 8th, 2025 at 9:07 AM, Alejandro Vallejo wrote: > > > From: "Daniel P. Smith" dpsm...@apertussolutions.com > > > Introduce the domain builder which is capable of consuming a device tree as > the > first boot module. If it finds a device tree as the first boot module, it wil

[PATCH 1/8] Consistently use DOCKER_CMD in makefiles

2025-04-09 Thread Andrew Cooper
From: Marek Marczykowski-Górecki This allows rebuilding containers using podman too. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Stefano Stabellini [Ported from Xen] Signed-off-by: Andrew Cooper --- images/Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff -

[PATCH 6/8] Factor our x86-isms in the linux build script

2025-04-09 Thread Andrew Cooper
... in preparation to use it for arm64 too. Rename the script. Signed-off-by: Andrew Cooper --- CC: Roger Pau Monné CC: Stefano Stabellini CC: Michal Orzel CC: Marek Marczykowski-Górecki CC: Anthony PERARD --- .gitlab-ci.yml| 3 +- ...{x86_64-kernel-linux.s

[PATCH 4/8] Clean up Gitlab yaml

2025-04-09 Thread Andrew Cooper
Factor out the registry into a common location. Fix the worflow name. List all the stages. Set a default expiry of 1 month. Note all the current jobs as legacy. Their naming scheme needs changing, and we'll use this opportunity to switch formats too. However, the artefacts need to stay using

[PATCH 2/8] Port containerise

2025-04-09 Thread Andrew Cooper
While it pains me to keep the wrong spelling, do so for consistency. Signed-off-by: Andrew Cooper --- CC: Roger Pau Monné CC: Stefano Stabellini CC: Michal Orzel CC: Marek Marczykowski-Górecki CC: Anthony PERARD --- containerize | 94 1 f

[PATCH 7/8] Infrastructure for arm64 linux builds

2025-04-09 Thread Andrew Cooper
Signed-off-by: Andrew Cooper --- CC: Roger Pau Monné CC: Stefano Stabellini CC: Michal Orzel CC: Marek Marczykowski-Górecki CC: Anthony PERARD --- .gitlab-ci.yml| 7 ++ containerize | 1 + images/alpine/3.18-arm64-build.dockerfil

[PATCH 5/8] Adjust Linux build script to work with other major versions

2025-04-09 Thread Andrew Cooper
Also use 'tar o' to decompress based on file name. Signed-off-by: Andrew Cooper --- CC: Roger Pau Monné CC: Stefano Stabellini CC: Michal Orzel CC: Marek Marczykowski-Górecki CC: Anthony PERARD --- scripts/x86_64-kernel-linux.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) di

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Marek Marczykowski
On Tue, Apr 08, 2025 at 03:57:17PM +0200, Jan Beulich wrote: > On 08.04.2025 11:31, Roger Pau Monne wrote: > > When running on AMD hardware in HVM mode the guest linear address (GLA) > > will not be provided to hvm_emulate_one_mmio(), and instead is > > unconditionally set of ~0. As a consequence

Re: [PATCH v2 1/3] kasan: Avoid sleepable page allocation from atomic context

2025-04-09 Thread Andrey Ryabinin
On 4/9/25 4:25 PM, Alexander Gordeev wrote: > On Wed, Apr 09, 2025 at 04:10:58PM +0200, Andrey Ryabinin wrote: > > Hi Andrey, > >>> @@ -301,7 +301,7 @@ static int kasan_populate_vmalloc_pte(pte_t *ptep, >>> unsigned long addr, >>> if (likely(!pte_none(ptep_get(ptep >>> ret

Re: [PATCH 6/8] Factor our x86-isms in the linux build script

2025-04-09 Thread Andrew Cooper
On 09/04/2025 11:59 pm, Marek Marczykowski-Górecki wrote: > On Wed, Apr 09, 2025 at 07:05:21PM +0200, Marek Marczykowski-Górecki wrote: >> On Wed, Apr 09, 2025 at 05:37:00PM +0100, Andrew Cooper wrote: >>> ... in preparation to use it for arm64 too. Rename the script. >>> >>> Signed-off-by: Andrew

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Jan Beulich
On 09.04.2025 17:33, Roger Pau Monné wrote: > On Wed, Apr 09, 2025 at 04:08:47PM +0200, Jan Beulich wrote: >> On 09.04.2025 16:01, Roger Pau Monné wrote: >>> As I understand the checks done in >>> mmio_ro_emulated_write() are to ensure correctness, but carrying the >>> access even when the %cr2 ch

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Roger Pau Monné
On Wed, Apr 09, 2025 at 04:08:47PM +0200, Jan Beulich wrote: > On 09.04.2025 16:01, Roger Pau Monné wrote: > > On Wed, Apr 09, 2025 at 03:50:13PM +0200, Jan Beulich wrote: > >> On 09.04.2025 15:33, Roger Pau Monné wrote: > >>> On Wed, Apr 09, 2025 at 02:59:45PM +0200, Jan Beulich wrote: > On 0

[PATCH v2 1/8] driver/pci: Get next capability without passing caps

2025-04-09 Thread Jiqian Chen
Modify function pci_find_next_cap_ttl to support returning position of next capability when array "caps" is empty or size "n" is zero. That can help caller to get next capability offset if caller just has a information of current capability offset. That will be used in a follow-on change. Signed

Re: [PATCH] libxl+hvmloader: extend IGD check part 2

2025-04-09 Thread Marek Marczykowski-Górecki
On Tue, Apr 08, 2025 at 04:11:36PM +0200, Jan Beulich wrote: > On 08.04.2025 15:23, Marek Marczykowski-Górecki wrote: > > --- a/tools/firmware/hvmloader/pci.c > > +++ b/tools/firmware/hvmloader/pci.c > > @@ -173,6 +173,7 @@ void pci_setup(void) > > switch ( class ) > > { > >

[PATCH] CI: Update x86 tests from Linux 6.1.19 to 6.6.56

2025-04-09 Thread Andrew Cooper
Linux 6.6.56 was already added to test-artifacts for the argo testing, and this removes one moving part while cleaning things up. Drop the associated export job, and dockerfile. Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Stefano Stabellini CC: Michal Orzel CC: Doug Goldstein CC:

Re: [PATCH v3 01/16] x86/boot: introduce boot domain

2025-04-09 Thread Jan Beulich
On 08.04.2025 18:07, Alejandro Vallejo wrote: > From: "Daniel P. Smith" > > To begin moving toward allowing the hypervisor to construct more than one > domain at boot, a container is needed for a domain's build information. > Introduce a new header, , that contains the initial > struct boot_domai

Re: [PATCH] include: sort $(wildcard ...) results

2025-04-09 Thread Andrew Cooper
On 09/04/2025 2:15 pm, Jan Beulich wrote: > The order of items is stored in .*.chk.cmd, and hence variations between > how items are ordered would result in re-invocation of the checking rule > during "make install-xen" despite that already having successfully run > earlier on. The difference can b

Re: [PATCH] CI: Update x86 tests from Linux 6.1.19 to 6.6.56

2025-04-09 Thread Andrew Cooper
On 09/04/2025 2:28 pm, Marek Marczykowski-Górecki wrote: > On Wed, Apr 09, 2025 at 02:05:05PM +0100, Andrew Cooper wrote: >> Linux 6.6.56 was already added to test-artifacts for the argo testing, and >> this removes one moving part while cleaning things up. >> >> Drop the associated export job, and

Re: [PATCH TEST-ARTEFACTS 0/8] Cleanup and Linux ARM64 support

2025-04-09 Thread Andrew Cooper
On 09/04/2025 5:36 pm, Andrew Cooper wrote: > Various bits of cleanup, and support for arm64 Linux builds. > > Run using the new Linux 6.6.86 on (most) x86, and ARM64: > https://gitlab.com/xen-project/hardware/xen-staging/-/pipelines/1760667411 Lovely, Linux 6.6.86 is broken for x86 PVH.  It tri

Re: [PATCH 6/8] Factor our x86-isms in the linux build script

2025-04-09 Thread Marek Marczykowski-Górecki
On Wed, Apr 09, 2025 at 05:37:00PM +0100, Andrew Cooper wrote: > ... in preparation to use it for arm64 too. Rename the script. > > Signed-off-by: Andrew Cooper Reviewed-by: Marek Marczykowski-Górecki > --- > CC: Roger Pau Monné > CC: Stefano Stabellini > CC: Michal Orzel > CC: Marek Marczy

Re: [PATCH v5 1/3] xen/arm: Move some of the functions to common file

2025-04-09 Thread Ayan Kumar Halder
Hi, On 08/04/2025 08:33, Orzel, Michal wrote: On 07/04/2025 20:44, Ayan Kumar Halder wrote: Added a new file common.inc to hold the common earlyboot MPU regions NIT: Describe your changes in imperative mood Also, my understanding was that this file will contain common constructs not only reg

Re: [PATCH 7/8] Infrastructure for arm64 linux builds

2025-04-09 Thread Marek Marczykowski-Górecki
On Wed, Apr 09, 2025 at 05:37:01PM +0100, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper > --- > CC: Roger Pau Monné > CC: Stefano Stabellini > CC: Michal Orzel > CC: Marek Marczykowski-Górecki > CC: Anthony PERARD > --- > .gitlab-ci.yml| 7 ++ > contain

Re: [PATCH 7/8] Infrastructure for arm64 linux builds

2025-04-09 Thread Andrew Cooper
On 09/04/2025 6:11 pm, Marek Marczykowski-Górecki wrote: > On Wed, Apr 09, 2025 at 05:37:01PM +0100, Andrew Cooper wrote: >> Signed-off-by: Andrew Cooper >> --- >> CC: Roger Pau Monné >> CC: Stefano Stabellini >> CC: Michal Orzel >> CC: Marek Marczykowski-Górecki >> CC: Anthony PERARD >> ---

Re: [PATCH 4/8] Clean up Gitlab yaml

2025-04-09 Thread Marek Marczykowski-Górecki
On Wed, Apr 09, 2025 at 05:36:58PM +0100, Andrew Cooper wrote: > Factor out the registry into a common location. Fix the worflow name. List > all the stages. Set a default expiry of 1 month. This is okay, since last artifacts for a branch are preserved even if expired. > Note all the current j

Re: [PATCH 5/8] Adjust Linux build script to work with other major versions

2025-04-09 Thread Andrew Cooper
On 09/04/2025 5:57 pm, Marek Marczykowski-Górecki wrote: > On Wed, Apr 09, 2025 at 05:36:59PM +0100, Andrew Cooper wrote: >> Also use 'tar o' to decompress based on file name. > Do you mean 'tar a'? -o is --no-same-owner. Anyway, just 'tar xf' > works too, even in alpine. Hmm...  Muscle memory fro

Re: [PATCH v3 00/16] Hyperlaunch device tree for dom0

2025-04-09 Thread Alejandro Vallejo
On Wed Apr 9, 2025 at 7:29 AM BST, Jan Beulich wrote: > On 08.04.2025 18:07, Alejandro Vallejo wrote: >> I've purposefully not added my S-by on anything I haven't touched >> (besides rebasing) as most of the feedback had already been addressed by >> Jason by the time I looked at it and it would be

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Jan Beulich
On 09.04.2025 15:33, Roger Pau Monné wrote: > On Wed, Apr 09, 2025 at 02:59:45PM +0200, Jan Beulich wrote: >> On 09.04.2025 12:39, Roger Pau Monné wrote: >>> On Wed, Apr 09, 2025 at 12:00:16PM +0200, Jan Beulich wrote: On 09.04.2025 11:07, Roger Pau Monné wrote: > On Tue, Apr 08, 2025 at 0

Re: [PATCH v3 03/16] x86/boot: add cmdline to struct boot_domain

2025-04-09 Thread Denis Mukhin
On Tuesday, April 8th, 2025 at 9:07 AM, Alejandro Vallejo wrote: > > > From: "Daniel P. Smith" dpsm...@apertussolutions.com > > > Add a container for the "cooked" command line for a domain. This > provides for the backing memory to be directly associated with the > domain being constructed.

Re: [PATCH v3 09/16] x86/hyperlaunch: locate dom0 kernel with hyperlaunch

2025-04-09 Thread Denis Mukhin
On Tuesday, April 8th, 2025 at 9:07 AM, Alejandro Vallejo wrote: > > > From: "Daniel P. Smith" dpsm...@apertussolutions.com > > > Look for a subnode of type `multiboot,kernel` within a domain node. If > found, locate it using the multiboot module helper to generically ensure > it lives in th

Re: [PATCH v3.1 1/2] x86/amd: Add guest support for AMD TCE

2025-04-09 Thread Jan Beulich
On 07.04.2025 11:10, Teddy Astie wrote: > AMD Translation Cache Extension is a flag that can be enabled in the EFER MSR > to optimize > some TLB flushes. Expose this flag to guest if supported by hardware. This > flag can be > used by Linux since version 6.14. > > Only expose this feature to HAP

Re: [PATCH v3.1 2/2] x86/amd: Enable TCE in Xen

2025-04-09 Thread Jan Beulich
On 07.04.2025 11:10, Teddy Astie wrote: > Aside exposing this flag to guests, Xen can also make use of it to reduce the > cost of > some TLB flushes. Enable this flag if supported by hardware. As said before: This needs to come with (perhaps a lot of) justification as to it being safe for Xen to

Re: [PATCH v3 02/16] x86/boot: introduce domid field to struct boot_domain

2025-04-09 Thread Jan Beulich
On 08.04.2025 18:07, Alejandro Vallejo wrote: > @@ -1010,15 +1010,15 @@ static struct domain *__init create_dom0(struct > boot_info *bi) > dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; > > /* Create initial domain. Not d0 for pvshim. */ > -domid = get_initial_domain_id(); > -d =

Re: [PATCH v3.1 2/2] x86/amd: Enable TCE in Xen

2025-04-09 Thread Jan Beulich
On 09.04.2025 09:11, Jan Beulich wrote: > On 07.04.2025 11:10, Teddy Astie wrote: >> Aside exposing this flag to guests, Xen can also make use of it to reduce >> the cost of >> some TLB flushes. Enable this flag if supported by hardware. > > As said before: This needs to come with (perhaps a lot

Re: [PATCH v3.1 1/2] x86/amd: Add guest support for AMD TCE

2025-04-09 Thread Jan Beulich
On 07.04.2025 11:10, Teddy Astie wrote: > --- a/xen/include/public/arch-x86/cpufeatureset.h > +++ b/xen/include/public/arch-x86/cpufeatureset.h > @@ -170,6 +170,7 @@ XEN_CPUFEATURE(SKINIT,3*32+12) /* SKINIT/STGI > instructions */ > XEN_CPUFEATURE(WDT, 3*32+13) /* Watchdog ti

Re: [PATCH v2 2/7] arm/mpu: Provide access to the MPU region from the C code

2025-04-09 Thread Luca Fancellu
Hi Ayan, >>> The point of the code was to don’t issue an isb() every time we change the >>> selector, >>> of course the code would be easier otherwise, but do we want to do that? >> >> Not sure if it is beneficial as you would need to use isb() from region16 >> onwards. > > The isb() is issued

Re: [PATCH v3.1 1/2] x86/amd: Add guest support for AMD TCE

2025-04-09 Thread Jan Beulich
On 09.04.2025 10:53, Jan Beulich wrote: > On 07.04.2025 11:10, Teddy Astie wrote: >> --- a/xen/include/public/arch-x86/cpufeatureset.h >> +++ b/xen/include/public/arch-x86/cpufeatureset.h >> @@ -170,6 +170,7 @@ XEN_CPUFEATURE(SKINIT,3*32+12) /* SKINIT/STGI >> instructions */ >> XEN_CPUF

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Jan Beulich
On 09.04.2025 11:07, Roger Pau Monné wrote: > On Tue, Apr 08, 2025 at 03:57:17PM +0200, Jan Beulich wrote: >> On 08.04.2025 11:31, Roger Pau Monne wrote: >>> When running on AMD hardware in HVM mode the guest linear address (GLA) >>> will not be provided to hvm_emulate_one_mmio(), and instead is >>

Re: [PATCH v2 2/7] arm/mpu: Provide access to the MPU region from the C code

2025-04-09 Thread Ayan Kumar Halder
On 09/04/2025 09:26, Luca Fancellu wrote: Hi Ayan, Hi Luca, The point of the code was to don’t issue an isb() every time we change the selector, of course the code would be easier otherwise, but do we want to do that? Not sure if it is beneficial as you would need to use isb() from region

[PATCH v5] xen: debug: gcov: add condition coverage support

2025-04-09 Thread Volodymyr Babchuk
Condition coverage, also known as MC/DC (modified condition/decision coverage) is a coverage metric that tracks separate outcomes in boolean expressions. This patch adds CONFIG_CONDITION_COVERAGE option to enable MC/DC for GCC. Clang is not supported right now because Xen can't emit version 10 of

Re: [PATCH v2] xen/riscv: Increase XEN_VIRT_SIZE

2025-04-09 Thread Oleksii Kurochko
On 4/8/25 4:04 PM, Jan Beulich wrote: On 08.04.2025 15:46, Oleksii Kurochko wrote: On 4/8/25 2:02 PM, Jan Beulich wrote: On 08.04.2025 13:51, Oleksii Kurochko wrote: On 4/7/25 12:09 PM, Jan Beulich wrote: On 04.04.2025 18:04, Oleksii Kurochko wrote: --- a/xen/arch/riscv/include/asm/mm.h +++

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Roger Pau Monné
On Tue, Apr 08, 2025 at 03:57:17PM +0200, Jan Beulich wrote: > On 08.04.2025 11:31, Roger Pau Monne wrote: > > When running on AMD hardware in HVM mode the guest linear address (GLA) > > will not be provided to hvm_emulate_one_mmio(), and instead is > > unconditionally set of ~0. As a consequence

Re: [PATCH v2 2/7] arm/mpu: Provide access to the MPU region from the C code

2025-04-09 Thread Luca Fancellu
Hi Ayan, > On 9 Apr 2025, at 11:07, Ayan Kumar Halder wrote: > > > On 09/04/2025 09:26, Luca Fancellu wrote: >> Hi Ayan, > Hi Luca, >> > The point of the code was to don’t issue an isb() every time we change > the selector, > of course the code would be easier otherwise, but do we

Re: [PATCH 2/2] x86/hvm: fix write emulation of RO ranges

2025-04-09 Thread Roger Pau Monné
On Wed, Apr 09, 2025 at 12:00:16PM +0200, Jan Beulich wrote: > On 09.04.2025 11:07, Roger Pau Monné wrote: > > On Tue, Apr 08, 2025 at 03:57:17PM +0200, Jan Beulich wrote: > >> On 08.04.2025 11:31, Roger Pau Monne wrote: > >>> When running on AMD hardware in HVM mode the guest linear address (GLA)

[PATCH] x86/ucode: Extend warning about disabling digest check too

2025-04-09 Thread Andrew Cooper
This was missed by accident. Fixes: b63951467e96 ("x86/ucode: Extend AMD digest checks to cover Zen5 CPUs") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné --- xen/arch/x86/cpu/microcode/amd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/x

Re: [PATCH v3 00/16] Hyperlaunch device tree for dom0

2025-04-09 Thread Alejandro Vallejo
On Wed Apr 9, 2025 at 11:19 AM BST, Alejandro Vallejo wrote: > On Wed Apr 9, 2025 at 7:29 AM BST, Jan Beulich wrote: >> On 08.04.2025 18:07, Alejandro Vallejo wrote: >>> I've purposefully not added my S-by on anything I haven't touched >>> (besides rebasing) as most of the feedback had already been

Re: [PATCH v3 01/16] x86/boot: introduce boot domain

2025-04-09 Thread Alejandro Vallejo
On Wed Apr 9, 2025 at 7:24 AM BST, Jan Beulich wrote: > On 08.04.2025 18:07, Alejandro Vallejo wrote: >> From: "Daniel P. Smith" >> >> To begin moving toward allowing the hypervisor to construct more than one >> domain at boot, a container is needed for a domain's build information. >> Introduce

Re: [PATCH] x86/ucode: Extend warning about disabling digest check too

2025-04-09 Thread Roger Pau Monné
On Wed, Apr 09, 2025 at 11:38:36AM +0100, Andrew Cooper wrote: > This was missed by accident. > > Fixes: b63951467e96 ("x86/ucode: Extend AMD digest checks to cover Zen5 CPUs") > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Thanks, Roger.

Re: [PATCH v2 2/7] arm/mpu: Provide access to the MPU region from the C code

2025-04-09 Thread Luca Fancellu
Hi Ayan, > On 9 Apr 2025, at 11:46, Ayan Kumar Halder wrote: > > > On 09/04/2025 11:21, Luca Fancellu wrote: >> Hi Ayan, > Hi, >> >>> On 9 Apr 2025, at 11:07, Ayan Kumar Halder wrote: >>> >>> >>> On 09/04/2025 09:26, Luca Fancellu wrote: Hi Ayan, >>> Hi Luca, >>> The point of the c

Re: [PATCH v3 02/16] x86/boot: introduce domid field to struct boot_domain

2025-04-09 Thread Alejandro Vallejo
On Wed Apr 9, 2025 at 7:34 AM BST, Jan Beulich wrote: > On 08.04.2025 18:07, Alejandro Vallejo wrote: >> @@ -1010,15 +1010,15 @@ static struct domain *__init create_dom0(struct >> boot_info *bi) >> dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; >> >> /* Create initial domain. Not d0 for

Re: [PATCH v2 2/7] arm/mpu: Provide access to the MPU region from the C code

2025-04-09 Thread Luca Fancellu
Hi Ayan, > On 8 Apr 2025, at 18:02, Ayan Kumar Halder wrote: > > Hi, > > On 08/04/2025 17:48, Luca Fancellu wrote: >> >>> On 8 Apr 2025, at 17:33, Ayan Kumar Halder wrote: >>> >>> >>> On 08/04/2025 15:29, Luca Fancellu wrote: Hi Ayan, >>> Hi Luca, > On 8 Apr 2025, at 15:02, Ayan Ku

Re: [PATCH v4 1/6] x86: suppress ERMS for internal use when MISC_ENABLE.FAST_STRING is clear

2025-04-09 Thread Jan Beulich
On 08.01.2025 11:11, Jan Beulich wrote: > --- a/xen/arch/x86/cpu-policy.c > +++ b/xen/arch/x86/cpu-policy.c > @@ -487,6 +487,12 @@ static void __init guest_common_max_feat > */ > if ( test_bit(X86_FEATURE_RTM, fs) ) > __set_bit(X86_FEATURE_RTM_ALWAYS_ABORT, fs); > + > +/* >

Re: [PATCH v3 03/16] x86/boot: add cmdline to struct boot_domain

2025-04-09 Thread Alejandro Vallejo
On Wed Apr 9, 2025 at 12:11 PM BST, Alejandro Vallejo wrote: > On Wed Apr 9, 2025 at 7:48 AM BST, Jan Beulich wrote: >> On 08.04.2025 18:07, Alejandro Vallejo wrote: >>> --- a/xen/arch/x86/setup.c >>> +++ b/xen/arch/x86/setup.c >>> @@ -978,10 +978,30 @@ static unsigned int __init copy_bios_e820(str

Re: [PATCH v7] Avoid crash calling PrintErrMesg from efi_multiboot2

2025-04-09 Thread Frediano Ziglio
ping On Fri, Mar 21, 2025 at 10:33 AM Frediano Ziglio wrote: > > Although code is compiled with -fpic option data is not position > independent. This causes data pointer to become invalid if > code is not relocated properly which is what happens for > efi_multiboot2 which is called by multiboot e