On Wed, 13 Nov 2024 22:38:27 GMT, Andy Goryachev wrote:
> too late to the party, but
>
> ```
> Description ResourceTypePathLocation
> The method load(int, double, double, boolean, boolean, float, float) of type
> GIFImageLoader2 should be tagged with @Override since it actuall
On Wed, 13 Nov 2024 18:33:27 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) S
On Wed, 13 Nov 2024 18:33:27 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) S
s how the feature can
> be used to load SVG images in a JavaFX application:
> https://github.com/mstr2/jfx-imageio-sample
This pull request has now been integrated.
Changeset: 72af9e23
Author:Michael Strauß
URL:
https://git.openjdk.org/jfx/commit/72af9e2366727a83ca1eace73e1c337cc4
On Wed, 13 Nov 2024 18:33:27 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) S
On Wed, 13 Nov 2024 18:33:27 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) S
On Wed, 13 Nov 2024 12:15:20 GMT, John Hendrikx wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 33 commits:
>>
>> - Merge branch 'master' into feature/ximageloader
>> - move automatically added imports
>
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Sat, 9 Nov 2024 07:43:43 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) SV
On Sat, 9 Nov 2024 07:43:43 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) SV
On Wed, 13 Nov 2024 06:17:18 GMT, Michael Strauß wrote:
>>> 2. This patch causes a failure in one of our closed white-box tests,
>>> which depends on internal API that has changed. It will be easy for us to
>>> fix it, but it will mean that down the road, when this is ready to go in,
>>> w
On Sat, 9 Nov 2024 07:43:43 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) SV
On Wed, 13 Nov 2024 04:38:51 GMT, Jayathirth D V wrote:
>> I'm just starting to look at this. The tests I ran look good so far, with
>> two things to note:
>>
>> 1. If `XImageLoaderFactory` fails to load, it with throw an `Error` that
>> terminates the app. I left a comment and suggestion inli
On Fri, 1 Nov 2024 16:59:50 GMT, Kevin Rushforth wrote:
> 2. This patch causes a failure in one of our closed white-box tests,
> which depends on internal API that has changed. It will be easy for us to fix
> it, but it will mean that down the road, when this is ready to go in, we will
> n
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Fri, 8 Nov 2024 18:44:22 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - move automatically added imports
>> - rename test...javax -> test...java2d
>
> modules/javafx.graphics/src/main/
On Thu, 7 Nov 2024 19:04:07 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) SV
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Wed, 6 Nov 2024 21:26:30 GMT, Kevin Rushforth wrote:
>> I'm not so sure about this, since there's already "iio" in in the name.
>
> How about one of the following as an alternative?
>
> * com.sun.javafx.iio.java2d
> * com.sun.javafx.iio.j2d
> * com.sun.javafx.iio.desktop
>
> That's roughly i
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Wed, 6 Nov 2024 18:46:38 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/test/addExports line 22:
>>
>>> 20: --add-exports javafx.graphics/com.sun.javafx.iio=ALL-UNNAMED
>>> 21: --add-exports javafx.graphics/com.sun.javafx.iio.png=ALL-UNNAMED
>>> 22: --add-exports javafx.graphics/co
On Sat, 2 Nov 2024 05:02:20 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) SV
On Wed, 6 Nov 2024 10:32:52 GMT, Jayathirth D V wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> revert doc change
>
> modules/javafx.graphics/src/test/addExports line 22:
>
>> 20: --add-exports javafx.graphics/c
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Fri, 1 Nov 2024 17:03:16 GMT, Kevin Rushforth wrote:
>> `ImageTools.computeDimensions()` will not allow the dimensions to be less
>> than 0.
>
> An integer overflow doesn't necessarily cause the result to be negative. I
> echo Jay's comment, and suggest an explicit check. I note that the cod
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Wed, 30 Oct 2024 18:32:55 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/bmp/BMPImageLoaderFactory.java
>> line 496:
>>
>>> 494:
>>> 495: int[] outWH = ImageTools.computeDimensions(
>>> 496: bih.biWidth, hght, (int)(w * imagePixelS
On Thu, 31 Oct 2024 15:42:56 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) S
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Wed, 30 Oct 2024 18:35:26 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/javax/XImageLoader.java
>> line 126:
>>
>>> 124: int imageHeight = reader.getHeight(imageIndex);
>>> 125: int[] widthHeight = ImageTools.computeDimensions(
On Tue, 29 Oct 2024 10:26:26 GMT, Jayathirth D V wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 21 additional
>> commi
On Wed, 30 Oct 2024 08:02:19 GMT, Jayathirth D V wrote:
>> Michael Strauß has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 21 additional
>> commi
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Mon, 28 Oct 2024 17:36:56 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) S
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Tue, 22 Oct 2024 15:13:05 GMT, Andy Goryachev wrote:
>> `scanlineStride` is useful for all the `ImageFrame` constructors, or do you
>> think recomputing it (with the risk of it being different) is still the best
>> course of action given that AWT supplies it and might be using some other
>>
On Tue, 22 Oct 2024 15:55:20 GMT, Michael Strauß wrote:
>>> `var` helps the writer of the code, but almost never helps the reader of
>>> the code
>>
>> I fully agree with John on this.
>
>> `scanlineStride` is useful for all the `ImageFrame` constructors, or do you
>> think recomputing it (wit
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Tue, 22 Oct 2024 05:54:28 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/javax/XImageLoader.java
>> line 209:
>>
>>> 207: : ImageStorage.ImageType.PALETTE;
>>> 208:
>>> 209: var scanlineStride = switch(image.getSampl
On Tue, 22 Oct 2024 05:51:04 GMT, John Hendrikx wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> scanline stride always measured in bytes
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/javax/XImageLo
On Mon, 21 Oct 2024 13:27:08 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) S
On Mon, 21 Oct 2024 13:27:08 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) S
On Sat, 19 Oct 2024 16:24:42 GMT, John Hendrikx wrote:
>> Michael Strauß has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - remove unused code
>> - fix line endings
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/javax/XImag
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Thu, 17 Oct 2024 19:25:30 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) S
On Thu, Oct 17, 2024 at 9:49 PM Phil Race wrote:
>
> In general dependencies on the the desktop module are an obstacle to
> making FX
> an independent toolkit. We already have that situation of course, but
> making it
> more common is the wrong direction, unless you think it an unrealistic goal
>
On Tue, 15 Oct 2024 17:29:30 GMT, Nir Lisker wrote:
> It is at all possible to split the image loaders from the desktop module into
> its own? I would think it will be useful for more than just JavaFX.
That would still be dependent on the desktop module, so I don't see how that
would help any
On Tue, 15 Oct 2024 20:08:31 GMT, John Hendrikx wrote:
> Any idea why FX has custom image loaders at all, and doesn't simply always
> delegate to `ImageIO` for this? If the dependency burden is high, it could be
> further reduced by removing built-in decoders? In other words, what's the
> adva
On Thu, 17 Oct 2024 19:19:02 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) S
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Wed, 16 Oct 2024 14:30:12 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/javax/XImageLoader.java
>> line 203:
>>
>>> 201: case TYPE_BYTE_INDEXED -> "TYPE_BYTE_INDEXED";
>>> 202: default -> Integer.toString(image.
On Tue, 15 Oct 2024 22:04:42 GMT, John Hendrikx wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review changes
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/javax/XImageLoader.java
> line 203:
>
On Wed, 16 Oct 2024 14:15:42 GMT, Michael Strauß wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) S
On Tue, 15 Oct 2024 20:26:29 GMT, John Hendrikx wrote:
> With the restructuring to make the dependency optional at runtime, this seems
> like a reasonable approach to consider. I also want to make sure that we
> don't initialize the AWT toolkit unless an application tries to load an image
> fi
On Tue, 15 Oct 2024 22:47:38 GMT, John Hendrikx wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review changes
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/image/impl/IntBgr.java
> line 68:
>
>> 66:
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Tue, 15 Oct 2024 22:55:45 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/image/impl/BaseByteToByteConverter.java
>> line 296:
>>
>>> 294: {
>>> 295: srcscanbytes -= w * 3;
>>> 296: srcscanbytes -= w * 4;
>>
>> This really do
On Tue, 15 Oct 2024 21:35:14 GMT, John Hendrikx wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review changes
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/iio/ImageStorage.java
> line 201:
>
>> 199
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. However, adding more built-in image
> loaders is a signifi
On Tue, 15 Oct 2024 22:29:52 GMT, John Hendrikx wrote:
>> This PR is an improved version of #1093.
>>
>> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
>> loaders. It has been a long-standing request to support more image formats,
>> most notably (but not limited to) SV
On Mon, 7 Oct 2024 15:13:17 GMT, Michael Strauß wrote:
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. Ho
On Mon, 7 Oct 2024 15:13:17 GMT, Michael Strauß wrote:
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. Ho
On Tue, 15 Oct 2024 17:23:11 GMT, Kevin Rushforth wrote:
> With the restructuring to make the dependency optional at runtime, this seems
> like a reasonable approach to consider. I also want to make sure that we
> don't initialize the AWT toolkit unless an application tries to load an image
>
On Mon, 7 Oct 2024 15:13:17 GMT, Michael Strauß wrote:
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. Ho
On Mon, 7 Oct 2024 15:13:17 GMT, Michael Strauß wrote:
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. Ho
On Mon, 7 Oct 2024 15:13:17 GMT, Michael Strauß wrote:
> This PR is an improved version of #1093.
>
> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image
> loaders. It has been a long-standing request to support more image formats,
> most notably (but not limited to) SVG. Ho
This PR is an improved version of #1093.
JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image loaders.
It has been a long-standing request to support more image formats, most notably
(but not limited to) SVG. However, adding more built-in image loaders is a
significant effort
Hi Michael,
yes you are right. It could live in parallel.
> On 18. Apr 2023, at 20:23, Michael Strauß wrote:
>
> Hi Clemens,
>
> when you talk about doing it faster, are you concerned about performance?
>
> Creating an API for the JavaFX image loaders is also a possibility,
> but that's muc
Hi Clemens,
when you talk about doing it faster, are you concerned about performance?
Creating an API for the JavaFX image loaders is also a possibility,
but that's much more difficult to get done.
We can always do that in the future though, the proposed support for
Java Image I/O doesn't close a
You can do it via non public API much faster. You can have a look into LibrawFX
or LibHeifFX.
What would help is to make the existing API public.
Clemens
> On 18. Apr 2023, at 17:51, John Neffenger wrote:
>
> On 4/17/23 2:10 PM, Michael Strauß wrote:
>> I've been working on a proposal that
On 4/17/23 2:10 PM, Michael Strauß wrote:
I've been working on a proposal that doesn't add any new API to
JavaFX, but instead plugs into the existing `javax.imageio` API,
allowing applications to use third-party libraries like TwelveMonkeys
[0] to load a wide variety of image formats.
Looks int
Extending the image loading capabilities of JavaFX to support
additional image formats is a recurring question that still has no
good answer.
I've been working on a proposal that doesn't add any new API to
JavaFX, but instead plugs into the existing `javax.imageio` API,
allowing applications to us
77 matches
Mail list logo
