On Sat, 2 Nov 2024 05:02:20 GMT, Michael Strauß <mstra...@openjdk.org> wrote:
>> This PR is an improved version of #1093. >> >> JavaFX can load BMP, GIF, PNG, and JPEG images with its built-in image >> loaders. It has been a long-standing request to support more image formats, >> most notably (but not limited to) SVG. However, adding more built-in image >> loaders is a significant effort not only in creating the functionality, but >> also in maintaining the additional dependencies. >> >> This will probably not happen any time soon, so we are left with three >> alternatives: >> 1. Accept the fact that JavaFX will never be able to load additional image >> formats. >> 2. Create a public image loader API, and hope that developers in the JavaFX >> ecosystem will create image loader plugins. >> 3. Leverage the existing Java Image I/O API. >> >> From these options, I think we should simply support existing Java APIs; >> both because it is the shortest and most realistic path forward, but also >> because I don't think it is sensible to bifurcate pluggable image loading in >> the Java ecosystem. >> >> Of course, Java Image I/O is a part of the `java.desktop` module, which as >> of now, all JavaFX applications require. However, it has been noted in the >> previous PR that we shouldn't lock JavaFX into the `java.desktop` dependency >> even further. >> >> I've improved this PR to not permanently require the `java.desktop` >> dependency: if the module is present, then JavaFX will use Image I/O for >> image formats that it can't load with the built-in loaders; if the module is >> not present, only the built-in loaders are available. >> >> I have prepared a small sample application that showcases how the feature >> can be used to load SVG images in a JavaFX application: >> https://github.com/mstr2/jfx-imageio-sample > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > revert doc change Went through the files again and latest change LGTM apart from the suggestion about package name for JDK ImageIO usage. Tested loading svg images also using sample app. modules/javafx.graphics/src/test/addExports line 22: > 20: --add-exports javafx.graphics/com.sun.javafx.iio=ALL-UNNAMED > 21: --add-exports javafx.graphics/com.sun.javafx.iio.png=ALL-UNNAMED > 22: --add-exports javafx.graphics/com.sun.javafx.iio.javax=ALL-UNNAMED I am little bit hesitant about this package name. Using "javax" doesn't give clear idea what we are trying to do here. May be com.sun.javafx.iio.imageio is a better option. ------------- Marked as reviewed by jdv (Author). PR Review: https://git.openjdk.org/jfx/pull/1593#pullrequestreview-2417866140 PR Review Comment: https://git.openjdk.org/jfx/pull/1593#discussion_r1830768433
