On Tue, 15 Oct 2024 22:55:45 GMT, John Hendrikx <[email protected]> wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/image/impl/BaseByteToByteConverter.java
>> line 296:
>>
>>> 294: {
>>> 295: srcscanbytes -= w * 3;
>>> 296: srcscanbytes -= w * 4;
>>
>> This really doesn't look right. Should it not be `dstscanbytes` on the 2nd
>> line, and also multiplied by `3` instead of `4`?
>>
>> It looks like this was incorrect in the original?
>
> Also nitpicking: I think it's bad form to modify parameter values.
Yes, this was incorrect in the original. Fixed it.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1593#discussion_r1803190270
