On Wed, 13 Nov 2024 12:15:20 GMT, John Hendrikx <jhendr...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 33 commits: >> >> - Merge branch 'master' into feature/ximageloader >> - move automatically added imports >> - rename test...javax -> test...java2d >> - Merge branch 'master' into feature/ximageloader >> - Merge branch 'master' into feature/ximageloader >> - rename iio.javax -> iio.java2d >> - revert doc change >> - Merge branch 'master' into feature/ximageloader >> - validate max image width/height >> - catch NoClassDefFoundError >> >> Co-authored-by: Kevin Rushforth <kevin.rushfo...@oracle.com> >> - ... and 23 more: https://git.openjdk.org/jfx/compare/d0011b21...d8d2a9c1 > > modules/javafx.graphics/src/main/java/com/sun/javafx/iio/common/ImageTools.java > line 216: > >> 214: public static void validateMaxDimensions(double width, double >> height, double scaleFactor) { >> 215: if (width * scaleFactor > Integer.MAX_VALUE) { >> 216: throw new IllegalArgumentException("Image width exceeds >> maximum value"); > > You may want to include the values used to reach this conclusion here and > with the other 2 exceptions; if these exceptions ever come up, that's the > first thing a developer will likely want to know (which may be you if this is > posted in an issue). Changed as suggested. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1593#discussion_r1840981078
