On Wed, 6 Nov 2024 10:32:52 GMT, Jayathirth D V <j...@openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   revert doc change
>
> modules/javafx.graphics/src/test/addExports line 22:
> 
>> 20: --add-exports javafx.graphics/com.sun.javafx.iio=ALL-UNNAMED
>> 21: --add-exports javafx.graphics/com.sun.javafx.iio.png=ALL-UNNAMED
>> 22: --add-exports javafx.graphics/com.sun.javafx.iio.javax=ALL-UNNAMED
> 
> I am little bit hesitant about this package name. Using "javax" doesn't give 
> clear idea what we are trying to do here.
> 
> May be com.sun.javafx.iio.imageio is a better option.

I'm not so sure about this, since there's already "iio" in in the name.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1593#discussion_r1831545973

Reply via email to