On Mon, 16 Sep 2024 09:10:08 GMT, Lukasz Kostyra wrote:
> This PR migrates RenderPerf performance test application from jfx-sandbox
> metal branch:
> https://github.com/openjdk/jfx-sandbox/tree/metal/tests/performance/animation/RenderPerfTest/src/renderperf
>
> RenderPerf is a performance test
On Thu, 19 Sep 2024 14:15:23 GMT, Kevin Rushforth wrote:
> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not
> have an explicit `@Timeout` on either the methods or the class, and a default
> timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`,
> `@BeforeA
On Thu, 19 Sep 2024 14:03:45 GMT, Kevin Rushforth wrote:
> This PR fixes a hang on exit which can happen if QuantumToolkit.dispose hangs
> when called from the QuantumToolkit shutdown hook. A shutdown hook should
> never run indefinitely, so the fix is to call dispose from a background
> threa
On Thu, 19 Sep 2024 23:17:31 GMT, Andy Goryachev wrote:
>> This PR fixes a hang on exit which can happen if QuantumToolkit.dispose
>> hangs when called from the QuantumToolkit shutdown hook. A shutdown hook
>> should never run indefinitely, so the fix is to call dispose from a
>> background th
On Thu, 19 Sep 2024 14:03:45 GMT, Kevin Rushforth wrote:
> This PR fixes a hang on exit which can happen if QuantumToolkit.dispose hangs
> when called from the QuantumToolkit shutdown hook. A shutdown hook should
> never run indefinitely, so the fix is to call dispose from a background
> threa
> Successfully converted Non-parametrized base tests to JUnit 5
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
one missing , formating
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1576/files
- new: https://git.
On Thu, 19 Sep 2024 21:04:06 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Modification as per review
>
> modules/javafx.base/src/test/java/test/com/sun/javafx/binding/ContentBindingMapTest.ja
> Successfully converted Non-parametrized base tests to JUnit 5
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Modification as per review
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1576/files
- new: https://g
On Thu, 19 Sep 2024 14:03:45 GMT, Kevin Rushforth wrote:
> This PR fixes a hang on exit which can happen if QuantumToolkit.dispose hangs
> when called from the QuantumToolkit shutdown hook. A shutdown hook should
> never run indefinitely, so the fix is to call dispose from a background
> threa
On Thu, 19 Sep 2024 14:15:23 GMT, Kevin Rushforth wrote:
> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not
> have an explicit `@Timeout` on either the methods or the class, and a default
> timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`,
> `@BeforeA
On Thu, 19 Sep 2024 16:27:26 GMT, Jay Bhaskar wrote:
>> Successfully converted Non-parametrized base tests to JUnit 5
>
> Jay Bhaskar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert "8339515: [TestBug] Convert web tests to JUnit 5"
>
On Mon, 9 Sep 2024 19:36:29 GMT, Andy Goryachev wrote:
> Further additions to the MonkeyTester application:
>
> - tree/table view column property sheets ✔
> - new pages: button, checkbox, hyperlink, menu bar, radio button, toggle
> button, canvas, split menu button, dnd ✔
> - properties... cont
> Converting system tests to junit5.
>
> Please see migration notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> ### Notes:
>
> I see shutdown timeout on linux, this will be addressed by
> [JDK-8340403](https://bugs.openjdk.org/browse/JDK-8340403)
> Converting system tests to junit5.
>
> Please see migration notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> ### Notes:
>
> I see shutdown timeout on linux, this will be addressed by
> [JDK-8340403](https://bugs.openjdk.org/browse/JDK-8340403)
On Thu, 19 Sep 2024 09:01:13 GMT, Ambarish Rapte wrote:
> Here is a patch to remove unused imports.
there were more. I don't have this warning enabled in Eclipse because, if
enabled, I see 410+ such warnings.
but thank you for noticing - I did forget to optimize imports in a few places.
On Wed, 18 Sep 2024 23:17:01 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> unused imports
>
> tests/system/src/test/java/test/robot/javafx/scene/SRGBTest.java line 249:
>
>> 247: // Ti
On Wed, 18 Sep 2024 23:05:31 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> unused imports
>
> tests/system/src/test/java/test/robot/javafx/embed/swing/NonFocusableJFXPanelTest.java
> line
On Wed, 18 Sep 2024 21:51:33 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> unused imports
>
> tests/system/src/test/java/test/javafx/scene/UIRenderSnapToPixelTest.java
> line 76:
>
>> 74:
On Wed, 18 Sep 2024 21:42:08 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> unused imports
>
> tests/system/src/test/java/test/javafx/scene/Snapshot1Test.java line 139:
>
>> 137:
> Converting system tests to junit5.
>
> Please see migration notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> ### Notes:
>
> I see shutdown timeout on linux, this will be addressed by
> [JDK-8340403](https://bugs.openjdk.org/browse/JDK-8340403)
On Thu, 19 Sep 2024 13:16:21 GMT, Lukasz Kostyra wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 18 additional
>> commi
On Fri, 13 Sep 2024 15:14:39 GMT, Lukasz Kostyra wrote:
> This PR converts all tests in `modules/javafx.graphics` to use JUnit5.
>
> ## Details
>
> Trivial changes resolved by first four commits:
> - Import changes to use `org.junit.jupiter` package instead of `org.junit` or
> `junit.framework
On Fri, 13 Sep 2024 15:14:39 GMT, Lukasz Kostyra wrote:
> This PR converts all tests in `modules/javafx.graphics` to use JUnit5.
>
> ## Details
>
> Trivial changes resolved by first four commits:
> - Import changes to use `org.junit.jupiter` package instead of `org.junit` or
> `junit.framework
That is exactly what FX needs per your examples.
On Thu, Sep 19, 2024 at 11:48 AM John Hendrikx
wrote:
> oneOfMyNodes.getScene().focusNext();
>
> or:
>
> oneOfMyNodes.getScene().focus(Direction.NEXT);
>
And why should every developer have to do their own utilities to accomplish
some
On Fri, 13 Sep 2024 15:14:39 GMT, Lukasz Kostyra wrote:
> This PR converts all tests in `modules/javafx.graphics` to use JUnit5.
>
> ## Details
>
> Trivial changes resolved by first four commits:
> - Import changes to use `org.junit.jupiter` package instead of `org.junit` or
> `junit.framework
On Fri, 13 Sep 2024 15:14:39 GMT, Lukasz Kostyra wrote:
> This PR converts all tests in `modules/javafx.graphics` to use JUnit5.
>
> ## Details
>
> Trivial changes resolved by first four commits:
> - Import changes to use `org.junit.jupiter` package instead of `org.junit` or
> `junit.framework
On Fri, 13 Sep 2024 15:14:39 GMT, Lukasz Kostyra wrote:
> This PR converts all tests in `modules/javafx.graphics` to use JUnit5.
>
> ## Details
>
> Trivial changes resolved by first four commits:
> - Import changes to use `org.junit.jupiter` package instead of `org.junit` or
> `junit.framework
On Fri, 13 Sep 2024 15:14:39 GMT, Lukasz Kostyra wrote:
> This PR converts all tests in `modules/javafx.graphics` to use JUnit5.
>
> ## Details
>
> Trivial changes resolved by first four commits:
> - Import changes to use `org.junit.jupiter` package instead of `org.junit` or
> `junit.framework
This should certainly also become possible at some point. There already
is internal API to find the next/previous or left/right Node, it is more
a question how to expose this as an API at this point.
For this specific case, you'd probably want to change focus in an
ActionEvent, or possibly a
This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not
have an explicit `@Timeout` on either the methods or the class, and a default
timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`, `@BeforeAll`,
`@AfterEach`, `@AfterAll`).
JUnit 5 effects its timeout by in
On Thu, 19 Sep 2024 14:15:23 GMT, Kevin Rushforth wrote:
> This PR adds a default timeout of 120 seconds for JUnit 5 tests that do not
> have an explicit `@Timeout` on either the methods or the class, and a default
> timeout of 20 seconds for lifecycle methods (e.g., `@BeforeEach`,
> `@BeforeA
Focus traversal in JavaFX is one of the two things I miss most about
Swing. With Swing we could access the policy and move to the next or
previous object programmatically -- a feature that is sadly lacking in FX.
For those of us old enough to remember the good old days of character
interfaces, hit
On Thu, 19 Sep 2024 14:03:45 GMT, Kevin Rushforth wrote:
> This PR fixes a hang on exit which can happen if QuantumToolkit.dispose hangs
> when called from the QuantumToolkit shutdown hook. A shutdown hook should
> never run indefinitely, so the fix is to call dispose from a background
> threa
This PR fixes a hang on exit which can happen if QuantumToolkit.dispose hangs
when called from the QuantumToolkit shutdown hook. A shutdown hook should never
run indefinitely, so the fix is to call dispose from a background thread and
wait for up to 5 seconds for it to finish normally, and then
On Fri, 13 Sep 2024 15:14:39 GMT, Lukasz Kostyra wrote:
> This PR converts all tests in `modules/javafx.graphics` to use JUnit5.
>
> ## Details
>
> Trivial changes resolved by first four commits:
> - Import changes to use `org.junit.jupiter` package instead of `org.junit` or
> `junit.framework
On Wed, 18 Sep 2024 12:22:08 GMT, Kevin Rushforth wrote:
>> Hima Bindu Meda has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright
>
> modules/javafx.web/src/main/native/Source/WebKitLegacy/java/WebCoreSupport/HistoryItemClient
> Updated additional webkit-619.1 fixes from webkitgtk-2.44.4. Build is
> successful on all platforms.No issues seen
Hima Bindu Meda has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright
-
Changes:
- all: https://git.op
> Successfully converted Non-parametrized base tests to JUnit 5
Jay Bhaskar has updated the pull request incrementally with one additional
commit since the last revision:
Revert "8339515: [TestBug] Convert web tests to JUnit 5"
This reverts commit 86f73271142049a2c0162d987aee6bd0fcb2f82a.
Successfully converted Non-parametrized base tests to JUnit 5
-
Commit messages:
- 8339511: [TestBug] Convert Non parametrized base tests to JUnit 5
- 8339515: [TestBug] Convert web tests to JUnit 5
Changes: https://git.openjdk.org/jfx/pull/1576/files
Webrev: https://webrevs.open
On Thu, 19 Sep 2024 15:06:07 GMT, Andy Goryachev wrote:
>> This PR converts all tests in `modules/javafx.graphics` to use JUnit5.
>>
>> ## Details
>>
>> Trivial changes resolved by first four commits:
>> - Import changes to use `org.junit.jupiter` package instead of `org.junit`
>> or `junit.fr
On Fri, 13 Sep 2024 15:14:39 GMT, Lukasz Kostyra wrote:
> This PR converts all tests in `modules/javafx.graphics` to use JUnit5.
>
> ## Details
>
> Trivial changes resolved by first four commits:
> - Import changes to use `org.junit.jupiter` package instead of `org.junit` or
> `junit.framework
I've been looking into how exactly navigation keys are being used in FX,
and who is responsible for handling them:
- Controls can choose to install navigational keys directly in their
input map (using FocusTraversalInputMap::getFocusTraversalMappings)
- Controls can choose to do nothing and lea
My apologies then, I was a bit impatient. Good luck with the test
sprint then!
--John
On 18/09/2024 17:13, Andy Goryachev wrote:
Oh, sorry, I did not mean to ignore your comments. I should have
mentioned we are having a bi-annual "test sprint" and work exclusively
on the test suite. You
On Wed, 18 Sep 2024 15:36:53 GMT, Andy Goryachev wrote:
>> Converting control module tests to junit5.
>>
>> The following notes might help reviewers and people migrating other parts of
>> https://bugs.openjdk.org/browse/JDK-8339170. The direct link to the notes:
>> https://github.com/andy-gory
On Thu, 19 Sep 2024 09:34:20 GMT, Lukasz Kostyra wrote:
>> modules/javafx.graphics/src/test/java/test/com/sun/javafx/sg/prism/DirtyRegionTestBase.java
>> line 76:
>>
>>> 74: return Stream.concat(stream, Stream.of(arg));
>>> 75: }
>>> 76:
>>
>> same comment: `List` might also work
On Mon, 16 Sep 2024 17:57:07 GMT, Andy Goryachev wrote:
> Converting system tests to junit5.
>
> Please see migration notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> ### Notes:
>
> I see shutdown timeout on linux, this will be addressed by
> [
On Wed, 18 Sep 2024 23:10:40 GMT, Kevin Rushforth wrote:
>> Converting system tests to junit5.
>>
>> Please see migration notes:
>> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>>
>> ### Notes:
>>
>> I see shutdown timeout on linux, this will be addresse
On Wed, 18 Sep 2024 15:25:47 GMT, Lukasz Kostyra wrote:
>> This PR migrates RenderPerf performance test application from jfx-sandbox
>> metal branch:
>> https://github.com/openjdk/jfx-sandbox/tree/metal/tests/performance/animation/RenderPerfTest/src/renderperf
>>
>> RenderPerf is a performance
On Wed, 18 Sep 2024 22:40:20 GMT, Andy Goryachev wrote:
>> This PR converts all tests in `modules/javafx.graphics` to use JUnit5.
>>
>> ## Details
>>
>> Trivial changes resolved by first four commits:
>> - Import changes to use `org.junit.jupiter` package instead of `org.junit`
>> or `junit.fr
On Mon, 16 Sep 2024 15:18:33 GMT, Andy Goryachev wrote:
>> Further additions to the MonkeyTester application:
>>
>> - tree/table view column property sheets ✔
>> - new pages: button, checkbox, hyperlink, menu bar, radio button, toggle
>> button, canvas, split menu button, dnd ✔
>> - properties.
On Mon, 16 Sep 2024 17:57:07 GMT, Andy Goryachev wrote:
> Converting system tests to junit5.
>
> Please see migration notes:
> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md
>
> ### Notes:
>
> I see shutdown timeout on linux, this will be addressed by
> [
51 matches
Mail list logo
