On Wed, 18 Sep 2024 15:25:47 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:

>> This PR migrates RenderPerf performance test application from jfx-sandbox 
>> metal branch: 
>> https://github.com/openjdk/jfx-sandbox/tree/metal/tests/performance/animation/RenderPerfTest/src/renderperf
>> 
>> RenderPerf is a performance test application which draws provided number of 
>> "particles" (JFX nodes) on the screen and animates them. After some time 
>> (default 10 seconds of testing + warmup) the test automatically closes and 
>> reports FPS values. Test was developed as part of Metal backend for 
>> performance testing and we decided to integrate it with mainline for any 
>> potential further development and fixes.
>> 
>> Command line options for the test:
>> - `-n` - number of particles to draw, defaults to 1000
>> - `-t` - name of test to run, defaults to running all tests in random order. 
>> Can provide multiple tests, ex. `-t Rectangle Image`
>> - `-d` - test duration in seconds, defaults to 10. Can be set to 0, which 
>> means the test will run infinitely long and end only when user manually 
>> closes the stage, mostly useful for stability testing.
>> 
>> Some tests use `duke.png` image provided with this PR. This is an openly 
>> available Duke Wave image taken from 
>> https://wiki.openjdk.org/display/duke/Gallery and rescaled for test purposes.
>> 
>> PR consists of two commits:
>> - Base version of RenderPerfTest developed by @karthikpandelu 
>> - My commit adding `-d` flag and implementing plenty of other fixes as part 
>> of [JDK-8331570](https://bugs.openjdk.org/browse/JDK-8331570)
>
> Lukasz Kostyra has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update copyright year to 2024

I did basic testing with different options and everything works fine.
Its good that we are open-sourcing this rendering performance test.
LGTM.

-------------

Marked as reviewed by jdv (Author).

PR Review: https://git.openjdk.org/jfx/pull/1568#pullrequestreview-2315194679

Reply via email to