On Wed, 18 Sep 2024 12:22:08 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Hima Bindu Meda has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update copyright > > modules/javafx.web/src/main/native/Source/WebKitLegacy/java/WebCoreSupport/HistoryItemClientJava.cpp > line 1: > >> 1: #include "HistoryItemClientJava.h" > > Where did this file come from? I don't see any changes related to > HistoryItemClient in the 2.44.4 release of WebKitGTK? > > Presuming we need this file, it will need a proper copyright header. This file has been added in order to adapt to the changes to the interface added as part of webkit commit def02cb5c4c24ed8a05e4e5075eb6ec95216ef80 in HistoryItem.h. Added the copyright header. > modules/javafx.web/src/main/native/Source/WebKitLegacy/java/WebCoreSupport/HistoryItemClientJava.h > line 1: > >> 1: #pragma once > > Presuming we need this file, it will need a proper copyright header. Updated the copyright ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1570#discussion_r1767328674 PR Review Comment: https://git.openjdk.org/jfx/pull/1570#discussion_r1767329292
