On Thu, 19 Sep 2024 13:16:21 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 18 additional >> commits since the last revision: >> >> - review comments >> - Merge remote-tracking branch 'origin/master' into 8338468.junit5.controls >> - review comments >> - Merge remote-tracking branch 'origin/master' into 8338468.junit5.controls >> - part 12, 9274 - 185 = 9089 >> - Merge remote-tracking branch 'origin/master' into 8338468.junit5.controls >> - part 11, 9242 tests, 185 ignored >> - part 10 >> - part 9 cell >> - part 8 >> - ... and 8 more: https://git.openjdk.org/jfx/compare/0594f014...55b33b2c > > modules/javafx.controls/src/test/java/test/javafx/scene/control/TextInputControlTest.java > line 517: > >> 515: } >> 516: >> 517: // @Test public void selectedTextWorksWhenSelectionIsBound() { > > This test was removed. Shouldn't we keep even commented tests around? out of scope, for this PR ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1561#discussion_r1767597282
