On Wed, 18 Sep 2024 21:51:33 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> unused imports > > tests/system/src/test/java/test/javafx/scene/UIRenderSnapToPixelTest.java > line 76: > >> 74: Assertions.assertEquals(0, ((sp.snappedBottomInset() * >> scale) + epsilon) % 1, 0.0001, "Bottom inset not snapped to pixel"); >> 75: Assertions.assertEquals(0, ((sp.snappedLeftInset() * >> scale) + epsilon) % 1, 0.0001, "Left inset not snapped to pixel"); >> 76: Assertions.assertEquals(0, ((sp.snappedRightInset() * >> scale) + epsilon) % 1, 0.0001, "Right inset not snapped to pixel"); > > Minor: these lines are geting a bit long. Maybe use static imports? still too long, but I do prefer having the class qualifier over static import (though static imports make more sense in the tests). I think tests is one area where we can relax the maximum line length rule (we already violate it in many places anyway) ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1569#discussion_r1767622092
