On Thu, 19 Sep 2024 09:34:20 GMT, Lukasz Kostyra <lkost...@openjdk.org> wrote:
>> modules/javafx.graphics/src/test/java/test/com/sun/javafx/sg/prism/DirtyRegionTestBase.java >> line 76: >> >>> 74: return Stream.concat(stream, Stream.of(arg)); >>> 75: } >>> 76: >> >> same comment: `List<Arguments>` might also work >> (here and possibly elsewhere, I don't want to add duplicate comments) > > There will be plenty of uses of that all throughout this change, I wasn't > 100% sure what JUnit5 expects or allows so I used the same > `Stream<Arguments>` return type for parameter methods across all tests. This is fine and I think Stream<Argument> is what you will in most documentations as well, so good IMO. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1566#discussion_r1766687081
