On Wed, 18 Sep 2024 23:05:31 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> unused imports > > tests/system/src/test/java/test/robot/javafx/embed/swing/NonFocusableJFXPanelTest.java > line 51: > >> 49: import static org.junit.jupiter.api.Assertions.assertNotNull; >> 50: import static org.junit.jupiter.api.Assertions.assertNull; >> 51: import static org.junit.jupiter.api.Assertions.assertSame; > > I promised myself I wasn't going to look at the imports, but... Does Eclipse > really mix static and non-static imports? And are any of the static imports > actually used? I suspect not in both cases, so you might just need to have > Eclipse fix up your imports. comment refers to an earlier version which has been fixed since then. to answer Eclipse question, the imports are sorted like this: static come first, then I think it's in alphabetical order. and yes, don't look at the imports :-) ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1569#discussion_r1767627777
