On Wed, 18 Sep 2024 23:10:40 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Converting system tests to junit5. >> >> Please see migration notes: >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Tests/JUnit5Migration.md >> >> ### Notes: >> >> I see shutdown timeout on linux, this will be addressed by >> [JDK-8340403](https://bugs.openjdk.org/browse/JDK-8340403) >> >> QPathTest > executionError FAILED >> org.opentest4j.AssertionFailedError: Exceeded timeout limit of 10000 msec >> at >> app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:39) >> at app//org.junit.jupiter.api.Assertions.fail(Assertions.java:134) >> at app//test.util.Util.runAndWait(Util.java:156) >> at app//test.util.Util.runAndWait(Util.java:127) >> at app//test.util.Util.shutdown(Util.java:365) >> at >> app//test.com.sun.marlin.QPathTest.teardownOnce(QPathTest.java:146) >> >> >> This test might fail intermittently (?) on linux only: >> >> SetSceneScalingTest > testShowAndSetScene() FAILED >> org.opentest4j.AssertionFailedError: expected: <true> but was: <false> >> at >> app//org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55) >> at >> app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:40) >> at >> app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:35) >> at >> app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:179) >> at >> app//test.robot.javafx.stage.SetSceneScalingTest$TestShowSetSceneApp.test(SetSceneScalingTest.java:129) >> at >> app//test.robot.javafx.stage.SetSceneScalingTest$TestApp.runTest(SetSceneScalingTest.java:89) >> at >> app//test.robot.javafx.stage.SetSceneScalingTest.testShowAndSetScene(SetSceneScalingTest.java:193) > > tests/system/src/test/java/test/robot/javafx/embed/swing/SwingNodePlatformExitCrashTest.java > line 39: > >> 37: >> 38: @Test >> 39: @Disabled("JDK-8190329") > > Unrelated to your PR...well this is embarrassing! I just fixed the FX clone > of JDK-8190329 a couple weeks ago, and forgot to look to see if there was an > existing test. I'll file a follow-up bug for this. I filed [JDK-8340442](https://bugs.openjdk.org/browse/JDK-8340442). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1569#discussion_r1766638928
