On 02/17/2015 08:23 PM, Matt Turner wrote:
On Tue, Feb 17, 2015 at 3:27 AM, Tapani Pälli wrote:
Here is a skeleton for the GL_ARB_program_interface_query API functions.
Adding the enum values makes it possible to start introducing changes in
the current shader query functions using these
On 10/26/2013 07:42 AM, Matt Turner wrote:
On Thu, Oct 24, 2013 at 1:28 AM, Tapani Pälli wrote:
Hello;
These patches introduce GL_OES_get_program_binary extension support for Mesa.
There are already stub functions for this extension, patches add the missing
functionality part. This is based
f possible. I
can't tell from this paragraph if you have a better idea for the
architecture or not.
Thanks for the feedback;
// Tapani
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 11/01/2013 06:41 PM, Eric Anholt wrote:
Tapani Pälli writes:
On 10/29/2013 03:48 PM, Paul Berry wrote:
On 29 October 2013 00:53, Tapani mailto:tapani.pa...@intel.com>> wrote:
+}
+
+
+/* data required to serialize ir_variable */
+
On 11/06/2013 10:55 PM, Paul Berry wrote:
On 5 November 2013 23:45, Tapani Pälli <mailto:tapani.pa...@intel.com>> wrote:
On 11/05/2013 07:36 PM, Paul Berry wrote:
On 1 November 2013 02:16, Tapani Pälli mailto:tapani.pa...@intel.com>> wrote:
+
+/**
Hi;
On 11/06/2013 07:35 PM, Erik Faye-Lund wrote:
Sorry for the late reply.
On Fri, Nov 1, 2013 at 4:14 PM, Tapani wrote:
On 11/01/2013 03:31 PM, Erik Faye-Lund wrote:
That won't help for programs that maintain their own (explicit)
shader-cache, which was the intention of introd
On 06/02/2014 09:22 PM, Kenneth Graunke wrote:
On Monday, June 02, 2014 07:44:15 PM Benjamin Bellec wrote:
[snip]
The "canary error" on Google points to a previously closed bug from
glsl-compiler :
https://bugs.freedesktop.org/show_bug.cgi?id=58039
It's probably unrelated - failing the canary c
Reviewed-by: Tapani Pälli
On 06/11/2014 05:14 AM, Ian Romanick wrote:
From: Ian Romanick
And delete the incorrect comment.
Signed-off-by: Ian Romanick
---
src/glsl/ir_uniform.h| 7 ++-
src/mesa/main/uniforms.c | 2 +-
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git
Reviewed-by: Tapani Pälli
On 06/21/2014 03:44 AM, Ian Romanick wrote:
From: Ian Romanick
In file included from ../../src/glsl/builtin_functions.cpp:61:0:
../../src/glsl/glsl_parser_extras.h:154:9: warning: unused parameter 'var'
[-Wunused-parameter]
Signed-off-by: Ian Romanick
On 07/17/2014 04:31 AM, Matt Turner wrote:
On Mon, Jul 14, 2014 at 9:38 PM, Tapani Pälli wrote:
This makes some of the UE4 engine demos (Stylized, Mobile Temple)
render correctly, tested on Intel Haswell machine.
Signed-off-by: Tapani Pälli
This should have a Bugzilla: tag.
Yep, I did not
Reviewed-by: Tapani Pälli
On 06/19/2014 03:49 AM, Anuj Phogat wrote:
Fixes gles3 Khronos CTS test:
egl_create_context.egl_create_context
Cc:
Signed-off-by: Anuj Phogat
---
src/egl/main/eglcontext.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/egl
On 12/05/2013 07:22 PM, Ian Romanick wrote:
On 12/01/2013 01:53 AM, Tapani Pälli wrote:
Commit a594cec broke EGL X11 backend by adding dependency between
X11 and DRM backends requiring HAVE_EGL_PLATFORM_DRM defined for X11.
This patch fixes the issue by adding additional define for libdrm
On 01/14/2014 07:53 PM, Paul Berry wrote:
On 2 January 2014 03:58, Tapani Pälli <mailto:tapani.pa...@intel.com>> wrote:
diff --git a/src/glsl/shader_cache.cpp b/src/glsl/shader_cache.cpp
new file mode 100644
+/**
+ * It is currently unknown if we need these to be
On 05/19/2014 07:51 PM, Ian Romanick wrote:
On 04/09/2014 02:56 AM, Tapani Pälli wrote:
Patch initializes the UniformRemapTable for explicit locations. This
needs to happen before optimizations to make sure all inactive uniforms
get their explicit locations correctly.
Signed-off-by: Tapani
On 05/19/2014 08:07 PM, Ian Romanick wrote:
On 04/09/2014 02:56 AM, Tapani Pälli wrote:
Patch refactors the existing uniform processing so explicit locations
are taken in to account during variable processing. These locations
are temporarily stored in gl_uniform_storage before actual locations
On 05/19/2014 08:09 PM, Ian Romanick wrote:
On 04/09/2014 02:56 AM, Tapani Pälli wrote:
Support inactive uniforms that have explicit location set in
glUniform* functions.
Signed-off-by: Tapani Pälli
---
src/mesa/main/uniform_query.cpp | 15 +++
1 file changed, 15 insertions
On 05/19/2014 08:18 PM, Ian Romanick wrote:
On 04/09/2014 02:56 AM, Tapani Pälli wrote:
Patch adds a preprocessor define for the extension and stores explicit
location data for uniforms during AST->HIR conversion. It also sets
layout token to be available when having the extension in pl
OK, I was following the way how GL_ARB_explicit_attrib_location was
enabled. That one is still only for "all drivers that support GLSL" and
you really need GLSL to be able to use attributes or uniforms. I can
enable it everywhere via dummy_true.
On 04/09/2014 02:56 AM, Tapani Pälli w
On 05/19/2014 08:26 PM, Ian Romanick wrote:
On 04/09/2014 02:56 AM, Tapani Pälli wrote:
Patch adds new implementation dependent value required by the
GL_ARB_explicit_uniform_location extension. Default value for user
assignable locations is calculated as sum of MaxUniformComponents
for each
On 05/21/2014 01:27 AM, Ian Romanick wrote:
On 05/19/2014 10:08 PM, Tapani wrote:
On 05/19/2014 08:18 PM, Ian Romanick wrote:
On 04/09/2014 02:56 AM, Tapani Pälli wrote:
Patch adds a preprocessor define for the extension and stores explicit
location data for uniforms during AST->
On 05/21/2014 05:43 PM, Tapani wrote:
On 05/21/2014 01:27 AM, Ian Romanick wrote:
On 05/19/2014 10:08 PM, Tapani wrote:
On 05/19/2014 08:18 PM, Ian Romanick wrote:
On 04/09/2014 02:56 AM, Tapani Pälli wrote:
Patch adds a preprocessor define for the extension and stores
explicit
location
these
particular changes and internal api introduced for state slots works fine;
Reviewed-by: Tapani Pälli
---
src/glsl/builtin_variables.cpp | 5 +--
src/glsl/ir.h | 56 ++
src/glsl/ir_clone.cpp
e things as small as possible and base_type here is one of
those things I found that I can safely use just uint8_t. But you are
right, with the small amount of these it does not really matter from
memory usage perspective.
On 05/27/2014 10:09 PM, Tapani Pälli wrote:
Signed-off-by: Tapani P
izeof(int).
I see, should've checked with 'pahole' tool first. As with
glsl_type::base_type, 'swizzle' here was something that I was hoping to
get smaller only from serialization perspective (shader cache work).
On 05/27/2014 10:09 PM, Tapani Pälli wrote:
Signed-off-by
On 05/28/2014 10:20 PM, Ian Romanick wrote:
On 05/28/2014 07:22 AM, Tapani wrote:
On 05/28/2014 05:49 AM, Ian Romanick wrote:
From: Ian Romanick
Also move num_state_slots inside ir_variable_data for better packing.
The payoff for this will come in a few more patches.
Signed-off-by: Ian
On 01/06/2015 07:39 PM, Chad Versace wrote:
On 11/25/2014 11:09 PM, Tapani Pälli wrote:
Patch enables ES2 extension that utilizes existing ES3 functionality.
Changes make all the subtests to run and pass in WebGL conformance
test 'webgl-draw-buffers' when running Chrome on Open
On 01/14/2015 03:16 PM, Iago Toral Quiroga wrote:
Hi Tapani,
thanks for looking into this one, I certainly missed that extension...
On mié, 2015-01-14 at 14:04 +0200, Tapani Pälli wrote:
Commit 8ec6534 changed texture upload path and the way how texture
format is being checked, this commit
On 01/14/2015 05:59 PM, Samuel Iglesias Gonsálvez wrote:
Hello,
Mesa fails the following dEQP GLES 3 test:
dEQP-GLES3.functional.fbo.api.attachment_query_default_fbo
This test calls glGetFramebufferAttachmentParameteriv() to get
FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE information from COLOR_ATTACHM
On 01/20/2015 08:29 PM, Ian Romanick wrote:
On 01/19/2015 10:55 PM, Tapani Pälli wrote:
Fixes currently failing Piglit case
interface-blocks-name-reused-globally.vert
Signed-off-by: Tapani Pälli
---
src/glsl/ast_to_hir.cpp | 17 -
1 file changed, 16 insertions(+), 1
go further to get rid of ir_variable usage
completely and have only the required bits of it, this is still WIP though.
Reviewed-by: Tapani Pälli
On 04/28/2015 11:56 PM, Jose Fonseca wrote:
It's returning random values, because RESOURCE_VAR() is casting
different objects into ir_var
On 05/06/2015 07:54 PM, Ilia Mirkin wrote:
On Wed, May 6, 2015 at 2:36 AM, Tapani Pälli wrote:
Increases pass rate of ES31-CTS.*program_interface_query* tests
when run with MESA_EXTENSION_OVERRIDE='GL_ARB_compute_shader'. Many
of the negative tests that happen to use compute stage
On 05/07/2015 08:02 AM, Ilia Mirkin wrote:
On Thu, May 7, 2015 at 12:55 AM, Tapani Pälli wrote:
This was really the original purpose, for enabling the path for
ES3.1 tests without the extension being set. Set also fallthrough
comment for Coverity (caught by Matt).
Signed-off-by: Tapani Pälli
On 05/13/2015 09:52 PM, Ian Romanick wrote:
On 05/06/2015 03:19 AM, Tapani Pälli wrote:
I've just noticed that this is wrong, sorry :/ We should to make a new
section for some of the enums that are only in GL core and ES31,
DRAW_INDIRECT_BUFFER_BINDING is one of these cases .. so this pat
On 05/26/2015 03:08 PM, Marek Olšák wrote:
It's mainly for distributions. You can turn it off, but it won't make
the build faster, because all code is shared.
Right, then seems good move to me.
Marek
On Tue, May 26, 2015 at 1:26 PM, Tapani Pälli wrote:
On 05/26/2015 01:57 PM, M
On 05/26/2015 10:37 PM, Ian Romanick wrote:
From: Ian Romanick
This is a bit of a hack for now. Several of the extensions required for
OpenGL ES 3.1 have no support, at all, in Mesa. However, with this
patch and a patch to allow MESA_GL_VERSION_OVERRIDE to work with ES
contexts, people can be
;m reading
more recent one.
Series is
Reviewed-by: Tapani Pälli
On 05/26/2015 10:37 PM, Ian Romanick wrote:
The first two patches are just re-re-sends of the same patches.
Based on feedback from Emil and others, I changed the later patches to
use a new environment variable, MESA_GLES_VERSIO
On 05/27/2015 02:30 AM, Francisco Jerez wrote:
Ian Romanick writes:
On 05/26/2015 02:04 PM, Francisco Jerez wrote:
Ian Romanick writes:
On 05/26/2015 02:53 AM, Tapani Pälli wrote:
Hello;
I'd like to ping if this approach would be ok. We've had some
discussions with Curro ab
esource' in the
resource list instead of adding to the storage, but eventually one needs
almost all the fields of gl_uniform_storage so this makes things much
simpler.
Reviewed-by: Tapani Pälli
On 05/19/2015 04:18 PM, Martin Peres wrote:
It seems like there were restrictions on b
I've read this a couple of times now and cannot spot any users of
storage that would be making a wrong assumption, you've fixed these and
I trust Jenkins was OK for i915?
Everything is ok if you remove 'I think' and 'Hopefully' from commit
message :)
Review
On 05/31/2015 10:07 AM, Tapani wrote:
Hi Martin;
This patch together with 'reference built-in uniforms into
gl_uniform_storage' fixes the "builtins missing" issue and also
exposes some bugs with program_interface_query which I'm about to
address soon. I played around
y required, however
this pattern is followed by other xml files. Then there's one typo in
enums "ACTIVE_SUBROUTINE_UNIFORM_MAX_LENGT".
With these fixed;
Reviewed-by: Tapani Pälli
On 06/01/2015 04:34 AM, Dave Airlie wrote:
From: Chris Forbes
Signed-off-by: Chris Forbes
Reviewed-by: Tapani Pälli
On 06/04/2015 02:19 PM, Martin Peres wrote:
The comment was accurate but the condition was reversed...
Signed-off-by: Martin Peres
---
src/mesa/program/ir_to_mesa.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/program
On 09/30/2014 06:13 PM, Ian Romanick wrote:
On 09/30/2014 12:28 AM, Tapani Pälli wrote:
Patch fixes failing test in WebGL conformance test
'point-no-attributes' when running Chrome on OpenGL ES.
(Shader program may draw points using constant data in shader.)
No Piglit regressions.
T
On 10/14/2014 03:35 PM, Francisco Jerez wrote:
Tapani Pälli writes:
Patch fixes 'glsl-2types-of-textures-on-same-unit' in WebGL conformance
test suite, no Piglit regressions.
To avoid adding potentially heavy check during draw (valid_to_render),
check is done during uniform
Reviewed-by: Tapani Pälli
On 10/16/2014 07:28 PM, Kenneth Graunke wrote:
A while back, Matt made the uniform upload functions simply upload
ctx->Const.UniformBooleanTrue for boolean values instead of 0/1, which
removed the need to convert it later. We also set UniformBooleanTrue to
1.0f
Reviewed-by: Tapani Pälli
(This is a fix for https://bugs.freedesktop.org/show_bug.cgi?id=83445)
On 10/14/2014 12:48 PM, Lionel Landwerlin wrote:
Signed-off-by: Lionel Landwerlin
---
src/egl/drivers/dri2/platform_drm.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/egl
Reviewed-by: Tapani Pälli
On 11/04/2014 02:22 AM, Ian Romanick wrote:
This is the first, and more minor, batch of micro-optimizations for the
glUniform* paths. Other than patch 8, these probably aren't going to
make a lot of difference, even on CPU limited applications.
The next batch,
On 11/25/2014 03:56 PM, Ilia Mirkin wrote:
On Tue, Nov 25, 2014 at 6:23 AM, Tapani Pälli wrote:
Patch enables ES2 extension that utilizes existing ES3 functionality.
Changes make all the subtests to run and pass in WebGL conformance
test 'webgl-draw-buffers' when running Chrome on
I sent this too when submitting the test :)
http://patchwork.freedesktop.org/patch/36194/
On 11/29/2014 10:54 PM, Chris Forbes wrote:
Fixes the piglit test: spec/glsl-es-3.00/compiler/invariant_all.frag
Signed-off-by: Chris Forbes
---
src/glsl/glsl_parser.yy | 4
1 file changed, 4 ins
Reviewed-by: Tapani Pälli
On 03/11/2015 10:44 PM, Ian Romanick wrote:
From: Ian Romanick
On platforms that do not natively generate 0u and ~0u for Boolean
results, b2f expressions that look like
f = b2f(expr cmp 0)
will generate better code by pretending the expression is
f
. This rename change is fine with me,
Even `programInterface` was the chosen name in the extension, I admit
is a tad long. I just want to fix the build asap, but if you prefer
to rename to something smaller (e.g, `iface`) I'm happy to do it too.
Jose
On 01/04/15 13:14, Tapani Pälli
On 04/21/2015 04:49 AM, Matt Turner wrote:
On Wed, Apr 1, 2015 at 5:14 AM, Tapani Pälli wrote:
Patch adds ProgramResourceList to gl_shader_program structure.
List contains references to active program resources and is
constructed during linking phase.
This list will be used by follow-up
On 04/21/2015 04:01 PM, Emil Velikov wrote:
On 16/04/15 21:52, Brian Paul wrote:
---
src/mesa/main/shader_query.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp
index b5f1d08..ad936e5 100644
--- a/src/mesa/main/shader_quer
On 04/21/2015 06:19 PM, Matt Turner wrote:
On Mon, Apr 20, 2015 at 10:37 PM, Matt Turner wrote:
On Mon, Apr 20, 2015 at 10:27 PM, Tapani Pälli wrote:
Signed-off-by: Tapani Pälli
---
src/glsl/linker.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/glsl/linker.cpp b/src/glsl
On 08/25/2014 07:19 PM, Eric Anholt wrote:
Tapani Pälli writes:
commit 4e64cfbb4 changed how gl_constant_value bool gets interpreted
with drivers, for swrast driver true should be 1.
Signed-off-by: Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82978
Everywhere else in
On 08/26/2014 02:29 PM, Emil Velikov wrote:
On 26/08/14 08:41, Tapani wrote:
On 08/25/2014 07:19 PM, Eric Anholt wrote:
Tapani Pälli writes:
commit 4e64cfbb4 changed how gl_constant_value bool gets interpreted
with drivers, for swrast driver true should be 1.
Signed-off-by: Tapani Pälli
On 09/10/2014 09:32 AM, Francisco Jerez wrote:
Tapani Pälli writes:
Patch modifies is_loop_constant() to take advantage of 'read_only' bit
in ir_variable to detect a loop constant. Variables marked read-only
are loop constant like mentioned by a comment in the function.
Signed-off-
On 09/11/2014 03:12 PM, Erik Faye-Lund wrote:
On Thu, Aug 28, 2014 at 9:58 AM, Tapani Pälli wrote:
Remap table for uniforms may contain empty entries when using explicit
uniform locations. If no active/inactive variable exists with given
location, remap table contains NULL.
Signed-off-by
On 09/16/2014 05:48 PM, Ian Romanick wrote:
On 09/16/2014 04:21 AM, Tapani Pälli wrote:
Patch fixes following test case from 'shaders-with-varyings' WebGL
conformance suite: "vertex shader with unused varying and fragment
shader with used varying must succeed"
Oh bot
Reviewed-by: Tapani Pälli
On 06/11/2015 02:46 AM, Anuj Phogat wrote:
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/dri/i965/intel_blit.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_blit.c
b/src/mesa/drivers/dri/i965/intel_blit.c
index 987b5f5
Reviewed-by: Tapani Pälli
On 06/11/2015 02:50 AM, Anuj Phogat wrote:
Signed-off-by: Anuj Phogat
---
src/mesa/drivers/common/meta_blit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/mesa/drivers/common/meta_blit.c
b/src/mesa/drivers/common/meta_blit.c
index
Alignment restriction is for _mm_stream_load_si128 used by
_mesa_streaming_load_memcpy
("The 128-bit (V)MOVNTDQA addresses must be 16-byte aligned or the
instruction will cause a #GP.")
Reviewed-by: Tapani Pälli
On 06/11/2015 02:50 AM, Anuj Phogat wrote:
I don't know where
This increases memory pressure during linking but makes it easier
for backend to free IR after it is not needed anymore.
v2: use resource list as ralloc context in case of relink (Kenneth)
Signed-off-by: Tapani Pälli
---
src/glsl/linker.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion
This is based on Kenneth's patch to delete 'most of the IR'. Due to
linker changes to clone variables, we can now free all of IR.
Saves 58MB of memory when replaying a Dota 2 trace on Broadwell.
Signed-off-by: Tapani Pälli
---
src/mesa/drivers/dri/i965/brw_shader.cpp | 5 -
On 06/09/2015 03:52 PM, Francisco Jerez wrote:
Tapani Pälli writes:
Signed-off-by: Tapani Pälli
---
src/mesa/drivers/dri/i965/brw_context.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_context.c
b/src/mesa/drivers/dri/i965/brw_context.c
index
taking into
* account the inter-image padding specified with the image height packing
* property.
// Tapani
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 06/11/2015 02:54 AM, Anuj Phogat wrote:
Signed-off-by: Anuj Phogat
---
src/mesa/main/readpix.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c
index 9166a50..cba9db8 100644
--- a/src/mesa/main/readpix.c
+++
Reviewed-by: Tapani Pälli
On 06/11/2015 02:54 AM, Anuj Phogat wrote:
This will be used by _mesa_meta_pbo_GetTexSubImage() in a later patch.
Signed-off-by: Anuj Phogat
---
src/mesa/main/readpix.c | 11 ++-
src/mesa/main/readpix.h | 3 +++
2 files changed, 9 insertions(+), 5
Patches 1,2,4,5
Reviewed-by: Tapani Pälli
For 3 and 6 (multisample + explicit_uniform_locaion) you need to move
the enums in to the following array:
{ "apis": ["GL", "GL_CORE", "GLES3"], "params": [
On 05/07/2015 10:57 AM, Marta Lofstedt
On 06/11/2015 03:01 PM, Tapani Pälli wrote:
Patches 1,2,4,5
Reviewed-by: Tapani Pälli
Just to add the r-b is for v3 that you sent separately for:
"mesa/es3.1: enable ARB_shader_atomic_counters for GLES 3.1"
(not the one in this particular series)
For 3 and 6 (m
Reviewed-by: Tapani Pälli
On 06/11/2015 07:58 PM, Anuj Phogat wrote:
Signed-off-by: Anuj Phogat
---
src/mesa/main/readpix.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/readpix.c b/src/mesa/main/readpix.c
index df46f83..9166a50 100644
--- a/src/mesa
On 06/11/2015 08:00 PM, Anuj Phogat wrote:
On Thu, Jun 11, 2015 at 2:44 AM, Tapani Pälli wrote:
On 06/11/2015 02:54 AM, Anuj Phogat wrote:
Signed-off-by: Anuj Phogat
---
src/mesa/main/readpix.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/src/mesa
On 06/11/2015 09:05 PM, Jordan Justen wrote:
On 2015-06-10 13:03:20, Jordan Justen wrote:
Whoops. I re-wrote this last night:
http://cgit.freedesktop.org/~jljusten/mesa/commit/?h=cs-33&id=3ebe7b79
On 2015-06-04 21:41:15, Tapani Pälli wrote:
Before 9b5e92f get_gl_override was called
Reviewed-by: Tapani Pälli
On 06/11/2015 08:36 PM, Anuj Phogat wrote:
After recent addition of pbo testing in piglit test getteximage-luminance,
it fails on i965. This patch makes a sub test pass.
Signed-off-by: Anuj Phogat
Cc:
Cc: Tapani Palli
---
src/mesa/drivers/common
On 06/11/2015 03:08 PM, Tapani Pälli wrote:
On 06/11/2015 03:01 PM, Tapani Pälli wrote:
Patches 1,2,4,5
Reviewed-by: Tapani Pälli
Just to add the r-b is for v3 that you sent separately for:
"mesa/es3.1: enable ARB_shader_atomic_counters for GLES 3.1"
(not the one in this
sent some small comments to patches 1 and 2, with commit messages
and those small things fixed this series is
Reviewed-by: Tapani Pälli
(I also run Piglit with these, no regressions.)
On 06/15/2015 02:19 PM, Marta Lofstedt wrote:
This is the V3 versions of my previous patch-set.
Also, pleas
small style nits below ..
On 06/15/2015 02:19 PM, Marta Lofstedt wrote:
From: Marta Lofstedt
v3: only expose enums from GL_ARB_shader_image_load_store
for gles 3.1 and GL core
Signed-off-by: Marta Lofstedt
---
src/mesa/main/get.c | 6 ++
src/mesa/main/get_hash_params.py
On 06/15/2015 02:19 PM, Marta Lofstedt wrote:
From: Marta Lofstedt
v3 : only expose ARB_shader_atomic_counters enums
for gles 3.1 and GL core.
Signed-off-by: Marta Lofstedt
---
src/mesa/main/get.c | 6 ++
src/mesa/main/get_hash_params.py | 22 +-
2
Reviewed-by: Tapani Pälli
(no v4 really needed for the little nitpicks but I forgot to say this)
On 06/25/2015 12:08 PM, Marta Lofstedt wrote:
This are for the V4s.
Marta Lofstedt (6):
mesa/es3.1: enable GL_ARB_shader_image_load_store for gles3.1
mesa/es3.1: enable
1, 2015 at 12:41 AM, Tapani Pälli wrote:
This is based on Kenneth's patch to delete 'most of the IR'. Due to
linker changes to clone variables, we can now free all of IR.
Saves 58MB of memory when replaying a Dota 2 trace on Broadwell.
I think we've saved ~50 MB 3 times now
On 06/25/2015 05:24 PM, Emil Velikov wrote:
Hi gents,
On 9 June 2015 at 14:09, Francisco Jerez wrote:
Francisco Jerez writes:
Tapani Pälli writes:
Desktop GLSL < 130 and GLSL ES < 300 allow sampler array indexing where
index can contain a loop induction variable. This extra chec
n check against version 3.1.
-ilia
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
// Tapani
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 06/26/2015 05:38 PM, Ilia Mirkin wrote:
On Fri, Jun 26, 2015 at 4:18 AM, Tapani Pälli wrote:
On 06/26/2015 01:06 AM, Ilia Mirkin wrote:
On Thu, Jun 25, 2015 at 4:22 PM, Ilia Mirkin wrote:
On Thu, Jun 25, 2015 at 5:08 AM, Marta Lofstedt
wrote:
From: Marta Lofstedt
v4 : only
Reviewed-by: Tapani Pälli
On 06/26/2015 07:54 PM, Neil Roberts wrote:
Since commit 104c8fc2c2aa5621261f8 the GLSL IR will be freed if NIR is
being used. This was causing it to segfault if INTEL_DEBUG=wm is set.
This patch just makes it avoid dumping the GLSL IR in that case.
---
src/mesa
st in the first place, making it non-NULL.
But before it can do that, we use it as a memory context for cloning.
Tapani, any thoughts on that? You know this code much better than I do :)
Right, this was not so simple after all. I think we might even need a
separate context here to handle this gr
Signed-off-by: Tapani Pälli
---
src/mesa/drivers/dri/i915/i915_context.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/mesa/drivers/dri/i915/i915_context.c
b/src/mesa/drivers/dri/i915/i915_context.c
index 42ea54e..57b033c 100644
--- a/src/mesa/drivers/dri/i915/i915_context.c
+++ b
Signed-off-by: Tapani Pälli
---
src/mesa/drivers/dri/i965/brw_shader.cpp | 4
1 file changed, 4 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp
b/src/mesa/drivers/dri/i965/brw_shader.cpp
index 32c4013..3e3d78b 100644
--- a/src/mesa/drivers/dri/i965/brw_shader.cpp
+++ b
ster:
http://cgit.freedesktop.org/~tpalli/mesa/log/?h=unroll_loops
Thanks;
Tapani Pälli (3):
i965: use EmitNoIndirectSampler for gen < 7
i915: use EmitNoIndirectSampler
mesa/st: use EmitNoIndirectSampler if !ARB_gpu_shader5
src/mesa/drivers/dri/i915/i915_context.c | 3 +++
src/mesa/dri
Signed-off-by: Tapani Pälli
---
src/mesa/state_tracker/st_context.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/mesa/state_tracker/st_context.c
b/src/mesa/state_tracker/st_context.c
index ed9ed0f..62a0fbe 100644
--- a/src/mesa/state_tracker/st_context.c
+++ b/src/mesa
Instead of using symbol table, build mask by inspecting IR. This
change is required by further patches to move resource list creation
to happen later when symbol table does not exist anymore.
Signed-off-by: Tapani Pälli
---
src/glsl/linker.cpp | 11 ---
1 file changed, 8 insertions
.
Tapani Pälli (3):
glsl: build stageref mask using IR, not symbol table
glsl: expose build_program_resource_list function
glsl: create program resource list after LinkShader
src/glsl/linker.cpp | 17 +
src/glsl/program.h | 4
src/mesa/program
Resource list can be created properly only after LinkShader hook
has been called to make sure all dead variables have been removed.
Signed-off-by: Tapani Pälli
https://bugs.freedesktop.org/show_bug.cgi?id=90925
---
src/glsl/linker.cpp | 4
src/mesa/program/ir_to_mesa.cpp | 2
This is required so that we can move resource list creation
to happen later.
Signed-off-by: Tapani Pälli
---
src/glsl/linker.cpp | 2 +-
src/glsl/program.h | 4
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index 9be48f0..abf7391
the change should happen in a different file) or do we try to
pull in other patches to make this work?
Thanks;
// Tapani
On 06/25/2015 05:24 PM, Emil Velikov wrote:
Hi gents,
On 9 June 2015 at 14:09, Francisco Jerez wrote:
Francisco Jerez writes:
Tapani Pälli writes:
Desktop GLSL < 1
Same check is made for glBindFragDataLocationIndexed but it was missing
when using layout qualifiers.
Fixes following Piglit test:
arb_blend_func_extended-output-location
Signed-off-by: Tapani Pälli
---
src/glsl/linker.cpp | 19 +++
1 file changed, 19 insertions
Change function to get all gl_constants for inspection, this is used
by follow-up patch.
Signed-off-by: Tapani Pälli
---
src/glsl/linker.cpp | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index 71a45e8..aae0c0d
:57 AM, Tapani Pälli wrote:
Patch changes linker to allocate gl_shader_variable instead of using
ir_variable. This makes it possible to get rid of ir_variables and ir
as a whole.
Signed-off-by: Tapani Pälli
---
src/glsl/linker.cpp| 42 ++-
src/mesa/main
nGL ES 3.1 Mesa 11.1.0-devel (git-78042ff)"
Signed-off-by: Tapani Pälli
---
src/mesa/main/version.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c
index 498b2f8..a1b1db5 100644
--- a/src/mesa/main/version.c
+++ b/src
On 10/13/2015 09:35 AM, Boyan Ding wrote:
2015-10-13 13:49 GMT+08:00 Tapani Pälli :
Otherwise there are problems when user overrides version and application
such as Piglit wants to detect used api with glGetString(GL_VERSION).
Below is example when using MESA_GLES_VERSION_OVERRIDE=3.1
igned-off-by: Tapani Pälli
---
src/glsl/ir_uniform.h | 32 ++--
1 file changed, 22 insertions(+), 10 deletions(-)
diff --git a/src/glsl/ir_uniform.h b/src/glsl/ir_uniform.h
index 50fe76b..1854279 100644
--- a/src/glsl/ir_uniform.h
+++ b/src/glsl/ir_uniform.h
@@ -
1 - 100 of 2200 matches
Mail list logo
