Re: [Mesa-dev] [PATCH v2 00/23] Multi-stream support for geometry shaders

Hi, this is a summary of the review process for the multi-stream support series. Most of the patches got a reviewed-by by either Chris or Ian and if I am not mistaken only 4 patches still need a reviewed-by so I hopefully we get these 4 reviewed soon :). Here is the situation of each of these

Re: [Mesa-dev] [PATCH v2 18/23] i965: Implement GL_PRIMITIVES_GENERATED with non-zero streams.

It looks like you can have the SOL stage increment that counter even when not doing any actual streamout, which should give you the correct semantics. See the definition of 3DSTATE_STREAMOUT in the Haswell PRM, Volume 2b. You want: - dw1.31 SO Function Enable = 1 - dw1.25 SO Statistics Enable = 1

Re: [Mesa-dev] [PATCH v2 00/23] Multi-stream support for geometry shaders

I sent comments on patch 18 - I think it can be made to work correctly when not doing real SO. It seems everyone allows EmitStreamVertex(0), so I think you should follow suit. It would be nice to get the spec clarified to explicitly allow this. Patches 11, 12 and 21 are: Reviewed-by: Chris Forbe

Re: [Mesa-dev] [PATCH v2 18/23] i965: Implement GL_PRIMITIVES_GENERATED with non-zero streams.

Continuing from this, I think you need a test to ensure that the points emitted in nonzero streams are not accidentally rendered when SO isn't active. According to that same section of the Haswell PRM, if SO Function Enable is 0, it appears the StreamID bits are ignored entirely, rather than filte

Re: [Mesa-dev] [PATCH 11/14] glsl: Implement saturate as ir_binop_saturate

On 06/24/2014 08:27 AM, Abdiel Janulgue wrote: Now that we have the ir_binop_saturate implemented as a single instruction, generate the correct simplified expression. s/binop_saturate/unop_saturate/ in subject and commit text. -- Petri Latvala __

Re: [Mesa-dev] [PATCH 2/5] clover: Fix not setting build log if the build succeeds.

Tom Stellard writes: >[...] Hi Tom, > Even with your patch, I'm still having trouble getting this to work. What problem are you having? > What is the correct pattern here? I know I need to use compat::string > in the function signature, but what type should I pass to the > compile_program_llv

Re: [Mesa-dev] [PATCH 1/1] r600: Fix use after free in compute_memory_promote_item.

On Mon, 2014-06-23 at 17:15 +0200, Bruno Jimenez wrote: > On Mon, 2014-06-23 at 10:39 -0400, Jan Vesely wrote: > > The dst pointer needs to be initialized after any calls to > > compute_memory_grow_pool, as the function might change the pool->vbo > > pointer. > > You are completely right. Good c

Re: [Mesa-dev] [PATCH 2/3] glsl: Optimize clamp(x, 0.0, b), where b < 1.0 as saturate(min(x, b))

On Tue, Jun 24, 2014 at 1:32 AM, Abdiel Janulgue wrote: > Signed-off-by: Abdiel Janulgue > --- > src/glsl/opt_algebraic.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp > index 8d7609d..0d694b6 100644 > --- a/src/glsl/opt_al

Re: [Mesa-dev] [PATCH v2 18/23] i965: Implement GL_PRIMITIVES_GENERATED with non-zero streams.

On Tuesday, June 24, 2014 09:53:02 PM Chris Forbes wrote: > It looks like you can have the SOL stage increment that counter even > when not doing any actual streamout, which should give you the correct > semantics. > > See the definition of 3DSTATE_STREAMOUT in the Haswell PRM, Volume 2b. You wan

Re: [Mesa-dev] [PATCH v2 12/23] glsl: Validate vertex emission in geometry shaders.

On Friday, June 20, 2014 08:51:14 AM Iago Toral wrote: > On Wed, 2014-06-18 at 13:38 -0700, Ian Romanick wrote: > > On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: > (...) > > > + /* From the ARB_gpu_shader5 spec: > > > + * > > > + * "Multiple vertex streams are supported only

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

Send patches with git-send-email and no other method. Save this message and apply it to origin/master using git-am to see why. Hopefully Matt or Ken can review this... On 06/12/2014 12:35 PM, Cody Northrop wrote: > Commit 17c7ead7 exposed a bug in how uniform loading happens in the > presence of

Re: [Mesa-dev] [PATCH 1/1] r600: Fix use after free in compute_memory_promote_item.

On Tue, Jun 24, 2014 at 08:39:28AM -0400, Jan Vesely wrote: > On Mon, 2014-06-23 at 17:15 +0200, Bruno Jimenez wrote: > > On Mon, 2014-06-23 at 10:39 -0400, Jan Vesely wrote: > > > The dst pointer needs to be initialized after any calls to > > > compute_memory_grow_pool, as the function might chan

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

On Tuesday, June 24, 2014 08:17:23 AM Ian Romanick wrote: > Send patches with git-send-email and no other method. Save this message > and apply it to origin/master using git-am to see why. > > Hopefully Matt or Ken can review this... > > On 06/12/2014 12:35 PM, Cody Northrop wrote: > > Commit 17

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

On Tuesday, June 24, 2014 08:17:23 AM Ian Romanick wrote: > Send patches with git-send-email and no other method. Save this message > and apply it to origin/master using git-am to see why. > > Hopefully Matt or Ken can review this... > > On 06/12/2014 12:35 PM, Cody Northrop wrote: > > Commit 17

Re: [Mesa-dev] [PATCH v2 3/3] mesa/st: enable ARB_fragment_layer_viewport

Hi, this does not seem to work on r600g (or I'm too stupid ;-)). I updated to latest mesa master, patched piglit and this is the result: $ glxinfo [...] OpenGL vendor string: X.Org OpenGL renderer string: Gallium 0.4 on AMD JUNIPER OpenGL core profile version string: 3.3 (Core Profile) Mesa 10.3.

Re: [Mesa-dev] [PATCH v2 3/3] mesa/st: enable ARB_fragment_layer_viewport

On Tue, Jun 24, 2014 at 12:44 PM, Tobias Droste wrote: > Hi, > > this does not seem to work on r600g (or I'm too stupid ;-)). > I updated to latest mesa master, patched piglit and this is the result: > > $ glxinfo > [...] > OpenGL vendor string: X.Org > OpenGL renderer string: Gallium 0.4 on AMD J

Re: [Mesa-dev] [PATCH v2 3/3] mesa/st: enable ARB_fragment_layer_viewport

Am Di, 24. Juni 2014, 12:46:39 schrieb Ilia Mirkin: > On Tue, Jun 24, 2014 at 12:44 PM, Tobias Droste wrote: > > Hi, > > > > this does not seem to work on r600g (or I'm too stupid ;-)). > > I updated to latest mesa master, patched piglit and this is the result: > > > > $ glxinfo > > [...] > > Op

Re: [Mesa-dev] [PATCH v2 3/3] mesa/st: enable ARB_fragment_layer_viewport

On Tue, Jun 24, 2014 at 12:58 PM, Tobias Droste wrote: > Am Di, 24. Juni 2014, 12:46:39 schrieb Ilia Mirkin: >> On Tue, Jun 24, 2014 at 12:44 PM, Tobias Droste wrote: >> > Hi, >> > >> > this does not seem to work on r600g (or I'm too stupid ;-)). >> > I updated to latest mesa master, patched pigl

Re: [Mesa-dev] [PATCH 02/14] glsl: Add constant evaluation of ir_unop_saturate

On 06/23/2014 10:27 PM, Abdiel Janulgue wrote: > Signed-off-by: Abdiel Janulgue > --- > src/glsl/ir_constant_expression.cpp | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/glsl/ir_constant_expression.cpp > b/src/glsl/ir_constant_expression.cpp > index 8afe8f7..b885a2f 100644

Re: [Mesa-dev] Add support for GLSL IR saturate()

On Mon, Jun 23, 2014 at 10:27 PM, Abdiel Janulgue wrote: > This patch series add the plumbing to support the GLSL IR instruction > saturate(). > Previously, saturate is implemented as min/max instructions. Most GPUs, > however, > can probably perform saturate for free. With these changes, we can

Re: [Mesa-dev] [PATCH 06/14] ir_to_mesa, glsl_to_tgsi: Remove try_emit_saturate

Unless it causes other probmes, patches 6, 9, and 10 should go after the patches that optimize min(max()) and max(min()) to saturate. Otherwise there may be odd performance regressions in bisects. Generally we don't want to remove code until after it's no longer used... unless that causes other p

Re: [Mesa-dev] [PATCH 1/3] glsl: Optimize clamp(x, 0, 1) as saturate(x)

I think this also needs to check that the base type is float. We don't want to generate ir_unop_saturate for int x; ... int y = min(max(x, 0), 1); As stupid as that code is. :) That would also make a good test case... On 06/23/2014 10:32 PM, Abdiel Janulgue wrote: > Signed-off-b

Re: [Mesa-dev] [PATCH 2/3] glsl: Optimize clamp(x, 0.0, b), where b < 1.0 as saturate(min(x, b))

On 06/23/2014 10:32 PM, Abdiel Janulgue wrote: > Signed-off-by: Abdiel Janulgue > --- > src/glsl/opt_algebraic.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp > index 8d7609d..0d694b6 100644 > --- a/src/glsl/opt_algebraic.c

[Mesa-dev] [PATCH] glxext: Send the Drawable's ID in the GLX_BufferSwapComplete event

While the official INTEL_swap_event specification says that the drawable field should contain the GLXDrawable, not the Drawable, the existing DRI2 code in dri2.c that translates from DRI2_BufferSwapComplete sends out GLX_BufferSwapComplete with the Drawable's ID, so existing codebases like Clutter/

Re: [Mesa-dev] [PATCH] meta: Use AMD_vertex_shader_layer instead of a GS for layered clears.

On Monday, June 23, 2014 09:11:09 PM Chris Forbes wrote: > Reviewed-by: Chris Forbes > > Have you got a case where this makes a noticeable difference to performance? No, not particularly - I was just looking at INTEL_DEBUG=state when running Shadowrun and noticed a bunch of GS and URB churn in

Re: [Mesa-dev] [PATCH 11/14] glsl: Implement saturate as ir_binop_saturate

Good catch! Yep, should be unop_saturate On 24.06.2014 03:13, Petri Latvala wrote: > On 06/24/2014 08:27 AM, Abdiel Janulgue wrote: >> Now that we have the ir_binop_saturate implemented as a single >> instruction, generate the correct simplified expression. >> > > s/binop_saturate/unop_saturate/

Re: [Mesa-dev] Add support for GLSL IR saturate()

On 24.06.2014 10:34, Matt Turner wrote: > On Mon, Jun 23, 2014 at 10:27 PM, Abdiel Janulgue > wrote: >> This patch series add the plumbing to support the GLSL IR instruction >> saturate(). >> Previously, saturate is implemented as min/max instructions. Most GPUs, >> however, >> can probably per

Re: [Mesa-dev] [PATCH 2/3] i965/vec4: Don't fix_math_operand() on Gen >= 8.

On Mon, Jun 23, 2014 at 7:36 PM, Ben Widawsky wrote: > On Mon, Jun 23, 2014 at 01:30:14PM -0700, Matt Turner wrote: >> The emit_math?_gen? functions serve to implement workarounds for the >> math instruction, none of which exist on Gen8+. > > There are still several restrictions with the math inst

Re: [Mesa-dev] [PATCH 09/14] i965/fs: Remove try_emit_saturate

On Mon, Jun 23, 2014 at 10:27 PM, Abdiel Janulgue wrote: > Now that sature is implemented natively as instruction, > we can cut down on uneeded functionality. Just a couple of typos (also exist in the other try_emit_sat patches): sature & uneeded. ___ m

Re: [Mesa-dev] Add support for GLSL IR saturate()

On Mon, Jun 23, 2014 at 10:27 PM, Abdiel Janulgue wrote: > This patch series add the plumbing to support the GLSL IR instruction > saturate(). > Previously, saturate is implemented as min/max instructions. Most GPUs, > however, > can probably perform saturate for free. With these changes, we can

Re: [Mesa-dev] [PATCH 2/3] glsl: Optimize clamp(x, 0.0, b), where b < 1.0 as saturate(min(x, b))

On Tue, Jun 24, 2014 at 6:27 AM, Ilia Mirkin wrote: > On Tue, Jun 24, 2014 at 1:32 AM, Abdiel Janulgue > wrote: >> Signed-off-by: Abdiel Janulgue >> --- >> src/glsl/opt_algebraic.cpp | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebr

[Mesa-dev] [PATCH 2/7] i965/fs: Make try_constant_propagate() static.

--- src/mesa/drivers/dri/i965/brw_fs.h| 1 - src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.h b/src/mesa/drivers/dri/i965/brw_fs.h index 0da79ba..af8b0b9 100644 ---

[Mesa-dev] [PATCH 3/7] i965/fs: Constant propagate into 2-src math instructions on Gen8.

total instructions in shared programs: 1878133 -> 1876986 (-0.06%) instructions in affected programs: 153007 -> 151860 (-0.75%) --- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/br

[Mesa-dev] [PATCH 4/7] i965/vec4: Constant propagate into 2-src math instructions on Gen8.

--- src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp b/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp index 11571ad..278ec7b 100644 --- a/src/mes

[Mesa-dev] [PATCH 5/7] i965/vec4: Rename try_copy/constant_propagat{ion, e} to match the fs.

--- src/mesa/drivers/dri/i965/brw_vec4.h| 4 ++-- src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 12 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.h b/src/mesa/drivers/dri/i965/brw_vec4.h index 366ef0

[Mesa-dev] [PATCH 7/7] i965/vec4: Try constant propagate after copy propagate made progress.

--- src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp b/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp index 2019d15..db6063c 100644 --- a/src/mesa/driv

[Mesa-dev] [PATCH 1/7] i965: Make can_do_source_mods() a member of the instruction classes.

Pretty nonsensical to have it as a method of the visitor just for access to brw. --- src/mesa/drivers/dri/i965/brw_fs.cpp| 8 src/mesa/drivers/dri/i965/brw_fs.h | 3 +-- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 2 +- src/mesa/drive

[Mesa-dev] [PATCH 6/7] i965/vec4: Make try_copy_propagate() static.

Now that can_do_source_mods() isn't part of the visitor, this doesn't need to be either. --- src/mesa/drivers/dri/i965/brw_vec4.h| 3 --- src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 8 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/mes

Re: [Mesa-dev] [PATCH v3 1/4] nvc0/ir: clear subop when folding constant expressions

Ilia Mirkin writes: > Here's a backported patch for 10.1... Thanks, Ilia! Comparing that patch to the original, I'm fairly embarrassed that I didn't come up with that myself. It's one of those cases where a tiny bit of altered context made the git conflict display look quite excessive. -Carl

Re: [Mesa-dev] [PATCH 6/8] android, egl: typo dri2_fallback_pixmap_surface -> dri2_fallback_create_pixmap_surface

Emil Velikov writes: > Indeed the Chad's eglGetPlatformDisplay work went in with mesa 10.2 so I > believe that this patch can be dropped. Pardon for that :) No worries at all, Emil. Thanks for confirming that. -Carl -- carl.d.wo...@intel.com pgpNJeNDAdv6E.pgp Description: PGP signature

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

On Tue, Jun 24, 2014 at 9:17 AM, Ian Romanick wrote: > Send patches with git-send-email and no other method. Save this message > and apply it to origin/master using git-am to see why. > > Hopefully Matt or Ken can review this... > > On 06/12/2014 12:35 PM, Cody Northrop wrote: > > Commit 17c7ead

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

On Tue, Jun 24, 2014 at 10:23 AM, Kenneth Graunke wrote: > On Tuesday, June 24, 2014 08:17:23 AM Ian Romanick wrote: > > Send patches with git-send-email and no other method. Save this message > > and apply it to origin/master using git-am to see why. > > > > Hopefully Matt or Ken can review thi

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

On Tue, Jun 24, 2014 at 10:29 AM, Kenneth Graunke wrote: > On Tuesday, June 24, 2014 08:17:23 AM Ian Romanick wrote: > > Send patches with git-send-email and no other method. Save this message > > and apply it to origin/master using git-am to see why. > > > > Hopefully Matt or Ken can review thi

Re: [Mesa-dev] [PATCH 08/11] GLX/DRI3: Add GPU offloading support.

On 23/06/2014 04:48, Michel Dänzer wrote : If X doesn't know anything about the secondary card, the secondary card must use the server side GLX information from the driver of the primary card, right? That seems rather hackish to me, and like it can only work as long as the cards / drivers are 'si

Re: [Mesa-dev] [PATCH] Remove unneeded stall calls from batches on Baytrail.

On Wednesday, June 18, 2014 11:21:00 AM Gregory Hunt wrote: > From: Greg Hunt > > These cause a small slowdown when we are sending a large number of small batches to the GPU. Hello! Do you have any more specific data? For example, "improves performance by X% in application Y" would be great.

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

On Tuesday, June 24, 2014 02:11:42 PM Cody Northrop wrote: [snip] > > Hi Cody, > > > > I noticed that the Piglit test is a hack to an existing SSO test - would > > it be > > possible to create a new Piglit test for this, and submit it to > > pig...@lists.freedesktop.org for inclusion upstream? It'

Re: [Mesa-dev] i965: Uniform loading via samplers with discard

On 06/24/2014 01:09 PM, Cody Northrop wrote: > > > > On Tue, Jun 24, 2014 at 10:23 AM, Kenneth Graunke > wrote: > > On Tuesday, June 24, 2014 08:17:23 AM Ian Romanick wrote: > > Send patches with git-send-email and no other method. Save this > message

Re: [Mesa-dev] [PATCH 03/11] Loader: Add gpu selection code via DRI_PRIME.

On 19/06/14 04:27, Axel Davy wrote: > v2: Fix the leak of device_name > v3: Rebased > > It enables to use the DRI_PRIME env var to specify > which gpu to use. > Two syntax are supported: > If DRI_PRIME is 1 it means: take any other gpu than the default one. > If DRI_PRIME is the ID_PATH_TAG of a d

Re: [Mesa-dev] [Mesa-stable] [PATCH] Fix zero-division in llvmpipe_texture_layout()

Am 24.06.2014 00:59, schrieb Carl Worth: > Roland Scheidegger writes: >> Am 07.06.2014 20:38, schrieb Johannes Obermayr: >>> From: Takashi Iwai >>> >>> Fix the crash of "gnome-control-center info" invocation on QEMU where >>> zero height is passed at init. > ... >>> Cc: "10.2" > ... >> Reviewed-

Re: [Mesa-dev] [PATCH 07/11] Gallium/dri2: implement blitImage

Reviewed-by: Marek Olšák Marek On Thu, Jun 19, 2014 at 5:27 AM, Axel Davy wrote: > V3: call flush_resource before flush > V4: Add new flags > > Signed-off-by: Axel Davy > --- > src/gallium/state_trackers/dri/drm/dri2.c | 55 > +-- > 1 file changed, 52 insertions(+

[Mesa-dev] [PATCH] r600g: allow viewport index/layer to be sent to fs

In order to support ARB_fragment_layer_viewport, we need to explicitly send these along to the fragment shader, since it has no other way to retrieve them. Signed-off-by: Ilia Mirkin Tested-by: Tobias Droste --- Note: I have no knowledge of how r600 works, this is all written based on advice gi

Re: [Mesa-dev] [PATCH 06/11] DRIimage: add blitImage to the specification

Reviewed-by: Marek Olšák Marek On Thu, Jun 19, 2014 at 5:27 AM, Axel Davy wrote: > It allows to blit two __DRIimages. > > Signed-off-by: Axel Davy > --- > include/GL/internal/dri_interface.h | 24 +++- > 1 file changed, 23 insertions(+), 1 deletion(-) > > diff --git a/incl

[Mesa-dev] [PATCH] i965: Include marketing names for Broadwell GPUs.

Intel would like us to include the marketing names. Developers additionally want "Broadwell GT1/2/3" because it makes it easier to identify what hardware users have when they request assistance or report issues. Including both makes it easy for everyone to map between the names. Signed-off-by: K

[Mesa-dev] [PATCH] radeon/llvm: Use the llvm.rsq.clamped intrinsic for RSQ

https://bugs.freedesktop.org/show_bug.cgi?id=80015 CC: "10.1 10.2" --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.

Re: [Mesa-dev] [PATCH] i965: Include marketing names for Broadwell GPUs.

Reviewed-by: Jordan Justen On Tue, Jun 24, 2014 at 4:26 PM, Kenneth Graunke wrote: > Intel would like us to include the marketing names. Developers > additionally want "Broadwell GT1/2/3" because it makes it easier > to identify what hardware users have when they request assistance > or report

[Mesa-dev] [PATCH 6/6] i965: Enable compressed multisample support (CMS) on Broadwell.

Everything is in place and appears to be working. Signed-off-by: Kenneth Graunke Reviewed-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 8 1 file changed, 8 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/int

[Mesa-dev] [PATCH 3/6] i965: Drop SINT workaround for CMS layout on Broadwell.

According to the documentation, we don't need this SINT workaround on Broadwell. (Or at least, it doesn't mention that we need it.) Signed-off-by: Kenneth Graunke Reviewed-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(

[Mesa-dev] [PATCH 5/6] i965: Add 2x MSAA support to the MCS allocation function.

2x MSAA also uses 8 bits, just like 4x. More bits are unused. Signed-off-by: Kenneth Graunke Reviewed-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i9

[Mesa-dev] [PATCH 1/6] i965: Add auxiliary surface field #defines for Broadwell.

From: Jordan Justen Signed-off-by: Jordan Justen Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_defines.h | 10 ++ 1 file changed, 10 insertions(+) Sending these out mostly as a formality - Jordan and I already reviewed each other's work. But, in case anyone spots a

[Mesa-dev] [PATCH 2/6] i965: Add plumbing for Broadwell's auxiliary surface support.

Broadwell generalizes the MCS fields to allow for multiple kinds of auxiliary surfaces. This patch adds the plumbing to set those values, but doesn't yet hook any up. v2: (by Jordan Justen) Use mt for qpitch; pitch is tiles - 1. v3: Don't forget to subtract 1 from aux_mt->pitch. v4: Drop unnecess

[Mesa-dev] [PATCH 4/6] i965: Hook up the MCS buffers in SURFACE_STATE on Broadwell.

MCS buffers are never allocated on Broadwell, so this does nothing for now, but puts the infrastructure in place for when they do exist. Signed-off-by: Kenneth Graunke Reviewed-by: Jordan Justen --- src/mesa/drivers/dri/i965/gen8_surface_state.c | 10 ++ 1 file changed, 10 insertions(+)

[Mesa-dev] [PATCH v2] r600g: allow viewport index/layer to be sent to fs

In order to support ARB_fragment_layer_viewport, we need to explicitly send these along to the fragment shader, since it has no other way to retrieve them. Signed-off-by: Ilia Mirkin Tested-by: Tobias Droste --- v1 -> v2: - Add forgotten copy to initialize new output with the settings of the

Re: [Mesa-dev] [PATCH 1/7] i965: Make can_do_source_mods() a member of the instruction classes.

On Tuesday, June 24, 2014 12:16:49 PM Matt Turner wrote: > Pretty nonsensical to have it as a method of the visitor just for access > to brw. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp| 8 > src/mesa/drivers/dri/i965/brw_fs.h | 3 +-- > src/mesa/

[Mesa-dev] [PATCH] glsl: Don't convert reductions of ivec to a dot-product

From: Ian Romanick Mesa has an optimization that converts expressions like "v.x + v.y + v.z + v.w" into dot(v, 1.0). And therein lies the rub: the other operand to the dot-product is always a float... even if the vector is an ivec or uvec. This results in an assertion failure in ir_builder. If

Re: [Mesa-dev] [PATCH] glsl: Don't convert reductions of ivec to a dot-product

On Tuesday, June 24, 2014 07:15:00 PM Ian Romanick wrote: > From: Ian Romanick > > Mesa has an optimization that converts expressions like "v.x + v.y + v.z > + v.w" into dot(v, 1.0). And therein lies the rub: the other operand to > the dot-product is always a float... even if the vector is an iv

Re: [Mesa-dev] [PATCH] glsl: Don't convert reductions of ivec to a dot-product

Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] radeon/llvm: Use the llvm.rsq.clamped intrinsic for RSQ

On 25.06.2014 09:15, Tom Stellard wrote: > https://bugs.freedesktop.org/show_bug.cgi?id=80015 > > CC: "10.1 10.2" > --- > src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llv

[Mesa-dev] Mesa 10.1.5

Mesa 10.1.6 has been released. Mesa 10.1.6 is a bug fix release which fixes bugs fixed since the 10.1.5 release, (see below for a list of changes). The tag in the git repository for Mesa 10.1.6 is 'mesa-10.1.6'. Mesa 10.1.6 is available for download at ftp://freedesktop.org/pub/mesa/10.1.6/ SHA-

[Mesa-dev] Mesa 10.2.2

Mesa 10.2.2 has been released. Mesa 10.2.2 is a bug fix release which fixes bugs fixed since the 10.2.1 release, (see below for a list of changes). The tag in the git repository for Mesa 10.2.2 is 'mesa-10.2.2'. Mesa 10.2.2 is available for download at ftp://freedesktop.org/pub/mesa/10.2.2/ SHA-

Re: [Mesa-dev] [Mesa-stable] [PATCH] Remove unneeded stall calls from batches on Baytrail.

Kenneth Graunke writes: > Please send a V2 of the patch with the "improves performance by 5% in " > note in the commit message and the extra hunks dropped. Then, I believe we > can commit this. Also, with the updated version, you can drop the CC of mesa-stable@. This looks like a performance o

[Mesa-dev] Questions about EVoC: GL/GLSL tests for GL 4.0 and newer

Hi, I am a master student from State Key Lab of CAD&CG, Zhejiang University in China. I'm interesting in contributing to mesa by EVoC. I am familiar with C/C++ and OpenGL. So I choose "GL/GLSL tests for GL 4.0 and newer". My destop is Lenovo Y460, GPU: ATI Mobility Radeon HD 5650, which support