https://bugs.freedesktop.org/show_bug.cgi?id=100854
Gary Wang changed:
What|Removed |Added
CC||gary.c.w...@intel.com
--
You are receiving
On Thu, May 11, 2017 at 04:32:06PM -0700, Kenneth Graunke wrote:
> See commit ece0e535a44c228dd994861592deb155c14740d8. This makes
> Gen4-5 follow the behavior we use on Gen6+. It seems to have
> worked out there.
Nice work, I couldn't spot anything amiss in the entire series. I was a little
hes
This will allow us to share code between the dsa, non-dsa and
no_error variants.
---
src/mesa/main/bufferobj.c | 41 -
1 file changed, 24 insertions(+), 17 deletions(-)
diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
index 97e4df9..e53adb
---
src/mesa/main/compute.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/mesa/main/compute.c b/src/mesa/main/compute.c
index 5c84516..e881d4f 100644
--- a/src/mesa/main/compute.c
+++ b/src/mesa/main/compute.c
@@ -47,27 +47,26 @@ check_valid_to_compute(struct gl_con
This will be used to add KHR_no_error support.
---
src/mesa/main/blend.c | 45 -
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c
index 955fda1..ed519bc 100644
--- a/src/mesa/main/blend.c
+++ b
---
src/mapi/glapi/gen/ARB_draw_buffers_blend.xml | 2 +-
src/mesa/main/blend.c | 9 +
src/mesa/main/blend.h | 3 +++
3 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/src/mapi/glapi/gen/ARB_draw_buffers_blend.xml
b/src/mapi/gla
This is the only place it is used so there is no reason for it to be
in api_validate.c
---
src/mesa/main/api_validate.c | 234 ---
src/mesa/main/api_validate.h | 13 ---
src/mesa/main/compute.c | 234 ++-
3 files
---
src/mapi/glapi/gen/gl_API.xml | 3 ++-
src/mesa/main/bufferobj.c | 20 +---
src/mesa/main/bufferobj.h | 3 +++
3 files changed, 22 insertions(+), 4 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml
index 8afd5ec..762fb5a 100644
-
These will be used to add KHR_no_error support.
---
src/mesa/main/compute.c | 51 -
1 file changed, 38 insertions(+), 13 deletions(-)
diff --git a/src/mesa/main/compute.c b/src/mesa/main/compute.c
index f3cc6af..16bb11f 100644
--- a/src/mesa/main/co
Will be used to add KHR_no_error support.
---
src/mesa/main/blend.c | 26 +-
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c
index 8811ef9..e91c14a 100644
--- a/src/mesa/main/blend.c
+++ b/src/mesa/main/blend.c
@@
This is required to add KHR_no_error support.
---
src/mesa/main/compute.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/mesa/main/compute.c b/src/mesa/main/compute.c
index e881d4f..f3cc6af 100644
--- a/src/mesa/main/compute.c
+++ b/src/mesa/main/compute.c
@@
---
src/mapi/glapi/gen/ARB_compute_shader.xml | 4 ++--
.../glapi/gen/ARB_compute_variable_group_size.xml | 2 +-
src/mesa/main/compute.c| 26 ++
src/mesa/main/compute.h| 12 ++
4 files changed, 41 inse
This will allow use to add KHR_no_error support.
---
src/mesa/main/bufferobj.c | 42 +++---
1 file changed, 27 insertions(+), 15 deletions(-)
diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
index 2ab7fe9..0f93b0f 100644
--- a/src/mesa/main/bu
---
src/mapi/glapi/gen/ARB_draw_buffers_blend.xml | 4 ++--
src/mesa/main/blend.c | 18 ++
src/mesa/main/blend.h | 6 ++
3 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/src/mapi/glapi/gen/ARB_draw_buffers_blend.x
There is now a no error profile/support for piglit which should
cover most of the KHR_no_error support in mesa so far.
So far I've been adding support for the various calls I've
seen in some Feral games.
Previous series still awaiting review:
https://patchwork.freedesktop.org/series/24291/
https
---
src/mapi/glapi/gen/gl_API.xml | 2 +-
src/mesa/main/bufferobj.c | 20 +---
src/mesa/main/bufferobj.h | 3 +++
3 files changed, 21 insertions(+), 4 deletions(-)
diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml
index 1a3b306..8afd5ec 100644
--
---
src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +-
src/mesa/main/bufferobj.c | 27 +++---
src/mesa/main/bufferobj.h | 3 +++
3 files changed, 24 insertions(+), 8 deletions(-)
diff --git a/src/mapi/glapi/gen/ARB_direct_state_a
---
src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +-
src/mesa/main/bufferobj.c | 31 --
src/mesa/main/bufferobj.h | 3 +++
3 files changed, 28 insertions(+), 8 deletions(-)
diff --git a/src/mapi/glapi/gen/ARB_direct_state_a
This change assumes meta will always pass valid arguments to
_mesa_buffer_sub_data().
---
src/mesa/drivers/common/meta.c | 12 +++
src/mesa/drivers/common/meta_blit.c | 3 +-
src/mesa/main/bufferobj.c | 67 +
src/mesa/main/bufferobj.h
This will allow us to share code between the dsa, non-dsa and
no_error variants.
---
src/mesa/main/bufferobj.c | 47 +++
1 file changed, 27 insertions(+), 20 deletions(-)
diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
index 0f93b0f..
Reviewed-by: Tapani Pälli
On 05/12/2017 02:37 PM, Lionel Landwerlin wrote:
In the unlikely case the parsing of genxml files fails, we were
leaking an xml parser object.
Signed-off-by: Lionel Landwerlin
---
src/intel/common/gen_decoder.c | 13 +++--
1 file changed, 7 insertions(+),
Reviewed-by: Tapani Pälli
On 05/12/2017 06:49 PM, Lionel Landwerlin wrote:
v2: Just use cast to uintptr_t (Chris)
Reported-by: Mauro Rossi
Signed-off-by: Lionel Landwerlin
---
src/mesa/drivers/dri/i965/brw_performance_query.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
I have made the requested changes. I've also added a Reviewed-by with
permission from funfunctor in #radeon (2017-05-14 EDT):
[19:31:37] Frogging101: ping
[19:32:37] Frogging101: with the minor style fix of putting a
space around if or whatever, you have my Rb on your Dying Light patch
This option will allow GLSL builtins to be redeclared verbatim (e.g.
redeclaring "in int gl_VertexID" in a vertex shader). This is not strictly
valid and would normally fail to compile, but some applications (such as
newer Techland ports) do it and need more leniency.
v2 (Samuel Pitoiset):
- R
This fixes the long-standing problem with Dying Light where the game would
produce a black screen when running under Mesa. This happened because the
game's vertex shaders redeclare gl_VertexID, which is a GLSL builtin.
Mesa's GLSL compiler is a little more strict than others, and would not
compile
Conditional on allow_glsl_builtin_variable_redeclaration driconf option.
v2 (Samuel Pitoiset):
- Rename allow_glsl_builtin_redeclaration ->
allow_glsl_builtin_variable_redeclaration
- style: put spaces after 'if'
Signed-off-by: John Brooks
Reviewed-by: Edward O'Callaghan
---
src/
From: Dave Airlie
Note: this is on top of nha's rework.
This just sets the vulkan device type depending on whether
this is an APU or GPU.
---
src/amd/vulkan/radv_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_devic
Ping!
On 09/05/17 13:04, Timothy Arceri wrote:
There is still more that can be removed I just though I'd get comments before
going too far.
This is a follow on from [1][2].
Besides patch 1 we are just replacing it with an unreachable() when the
path doesn't try to work around the problem i.e r
Hi all,
Dying Light really works (Radeon RX460 4GB, Ubuntu 17.04, Mesa git
patches applied plus some minor changes that i have locally to get rid
of compiler warnings).
I did have to jump through some additional hoops to get it working:
Dying Light only launches from within Steam, Launch Opti
On 13 May 2017, at 09:01, Jan Beich wrote:
>
> Jonathan Gray writes:
>
>> On Sat, May 13, 2017 at 02:22:30AM +0200, Jan Beich wrote:
>>
>>> "int" isn't large enough and lack of builtins only manifests at link time.
>>> This was breaking build on FreeBSD 11.0 i386 with Clang 3.8.0.
>>>
>>> gls
On Thu, 11 May 2017 21:02:21 +0200
Nicolai Hähnle wrote:
> Violating the "async" promise on debug callbacks is a problem. This
> breaks the OpenGL API in a place where it wasn't broken before, and
> that's not okay.
As an application developer who has occasionally relied on this
behavior to debu
On 15 May 2017 at 07:46, Nicolai Hähnle wrote:
> Hi all,
>
> It has bugged me for quite some time that this code is duplicated between
> radeonsi and radv. Also, I wanted to play around with addrlib, and for that
> it was helpful to have the code extracted from the various winsys
> structures. So
From: Dave Airlie
S8 surfaces have no non-stencil levels, so compute level
can fail for them, but we should continue to compute the levels
for the stencil later.
This is what we did in radv previous to fix this, but maybe
we can do something cleaner?
---
src/amd/common/ac_surface.c | 2 +-
1 fi
From: Dave Airlie
The old code copied over all the surface info from the image
surface, we only want some bits of it, and to modify the flags.
This fixes a regression caused by nha's rework of surface,
and should probably be squashed in somewhere.
Signed-off-by: Dave Airlie
---
src/amd/vulkan
When we add the reloc, we write the value of the relocation target using
non-canonical form. If we later patch up the address prior to command
submission, we will rewrite it using canonical form. We should always
write the address in canonical form in case we skip the relocation (as
the target did
Now that all callers request and use the relocation target address, we
can unconditionally pass it back and so enforce that the caller does
supply it (and we hope uses it!).
Signed-off-by: Chris Wilson
---
src/intel/vulkan/anv_batch_chain.c | 7 +++
1 file changed, 3 insertions(+), 4 deletio
It is a requirement, not just of using the NO_RELOC mode, that all
relocation values in the execobjects match their reloc.presumed_offset,
as the kernel will skip performing *any* relocation if the presumed_offset
matches the target object. In many places the relocation entry is record
with the rig
Track seen bo for a reloc list separately from the bo used by the
relocs. This is a step towards not using the relocation entries
themselves, but we still need to track the used bo and provide those to
the kernel.
In the short term, since the array of unique is likely small, we can try
to keep it
A very simple allocator that increments from the last globally allocated
offset and assigns that for the lifetime of this bo for every context.
Once we run out of space, we delegate finding holes to the kernel. In
the future, we can opt to handle this ourselves as well, but a 48b
address space mean
A requirement for NORELOC is that the relocation entry exactly matches
the content of the buffer, and so we must set the value in the buffer on
adding the relocation.
Signed-off-by: Chris Wilson
---
src/intel/vulkan/anv_batch_chain.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
dif
Signed-off-by: Chris Wilson
---
src/intel/vulkan/anv_allocator.c | 10 ++
src/intel/vulkan/anv_device.c| 7 +--
src/intel/vulkan/anv_intel.c | 3 +--
src/intel/vulkan/anv_private.h | 20
4 files changed, 24 insertions(+), 16 deletions(-)
diff --git a/
Signed-off-by: Chris Wilson
---
src/intel/vulkan/anv_allocator.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/intel/vulkan/anv_allocator.c b/src/intel/vulkan/anv_allocator.c
index dc9b55b4a6..e316b421f4 100644
--- a/src/intel/vulkan/anv_allocator.c
+++ b/src/intel/
Compute the target address address whilst adding the relocation so that
we guarantee the value matches the relocation entry we pass to the
kernel. Pass it back from the relocation function for it to be written
into the command stream.
Signed-off-by: Chris Wilson
---
src/intel/vulkan/anv_batch_ch
Signed-off-by: Chris Wilson
---
src/intel/vulkan/anv_allocator.c | 8 +---
src/intel/vulkan/anv_device.c| 8 +---
src/intel/vulkan/anv_private.h | 3 ++-
src/intel/vulkan/genX_query.c| 2 +-
4 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/src/intel/vulkan/anv_all
A requirement for NORELOC is that the relocation entry exactly matches
the content of the buffer, and so we must set the value in the buffer on
adding the relocation.
Signed-off-by: Chris Wilson
---
src/intel/blorp/blorp_genX_exec.h | 11 ---
src/intel/vulkan/genX_blorp_exec.c
A requirement for NORELOC is that the relocation entry exactly matches
the content of the buffer, and so we must set the value in the buffer on
adding the relocation.
Signed-off-by: Chris Wilson
---
src/intel/vulkan/genX_cmd_buffer.c | 19 +--
1 file changed, 17 insertions(+), 2
From: Nicolai Hähnle
We're not using thick tiling modes, so we can just derive the value
ourselves.
---
src/amd/vulkan/radv_image.c| 2 +-
src/amd/vulkan/radv_radeon_winsys.h| 1 -
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 4
3 files change
From: Nicolai Hähnle
---
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 391 +
1 file changed, 6 insertions(+), 385 deletions(-)
diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c
b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c
index 508a6d1..eaa978e
From: Nicolai Hähnle
Like radeonsi. This saves memory, and the information can easily be
recomputed on the fly where necessary.
---
src/amd/vulkan/radv_image.c| 11 ++-
src/amd/vulkan/radv_private.h | 1 -
src/amd/vulkan/radv_radeon_winsys.h
From: Nicolai Hähnle
---
src/amd/vulkan/radv_device.c | 28 ++-
src/amd/vulkan/radv_radeon_winsys.h | 1 -
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 28 ---
3 files changed, 27 insertions(+), 30 deletions(-)
d
From: Nicolai Hähnle
Like radeonsi; replace with radeon_surf::num_dcc_levels.
---
src/amd/vulkan/radv_device.c | 2 +-
src/amd/vulkan/radv_image.c| 2 +-
src/amd/vulkan/radv_meta_resolve.c | 2 +-
src/amd/vulkan/radv_radeon_winsys.h
From: Nicolai Hähnle
---
src/amd/vulkan/radv_device.c | 10 +-
src/amd/vulkan/radv_private.h | 1 +
src/amd/vulkan/radv_radeon_winsys.h | 55 +--
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 175 +-
src/amd
From: Nicolai Hähnle
---
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 69 -
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.h | 1 -
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 90 ++
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h | 3 -
From: Nicolai Hähnle
Vulkan needs them.
---
src/amd/common/ac_gpu_info.c | 15 +--
src/amd/common/ac_gpu_info.h | 3 ++-
src/gallium/drivers/radeon/r600_pipe_common.c | 4 ++--
src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 4 ++--
From: Nicolai Hähnle
---
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 2 +-
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs
From: Nicolai Hähnle
---
src/amd/vulkan/radv_image.c | 3 +--
src/amd/vulkan/radv_radeon_winsys.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
index f663e29..6225240 100644
--- a/src/amd/vulkan/radv_image.c
From: Nicolai Hähnle
This is mostly mechanical changes of renaming types and introducing
"legacy" everywhere.
It doesn't use the ac_surface computation functions yet.
---
src/amd/common/ac_surface.h| 1 +
src/amd/vulkan/radv_device.c | 22 +++---
s
From: Nicolai Hähnle
---
src/amd/vulkan/radv_image.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
index e1e9d9c..c0fc896 100644
--- a/src/amd/vulkan/radv_image.c
+++ b/src/amd/vulkan/radv_image.c
@@ -8
From: Nicolai Hähnle
---
src/amd/common/ac_gpu_info.h | 8
src/amd/common/ac_surface.h | 8
2 files changed, 16 insertions(+)
diff --git a/src/amd/common/ac_gpu_info.h b/src/amd/common/ac_gpu_info.h
index 9bf2b84..d8029ef 100644
--- a/src/amd/common/ac_gpu_info.h
+++ b/src/am
From: Nicolai Hähnle
Vulkan needs it.
---
src/amd/common/ac_surface.c | 4
src/amd/common/ac_surface.h | 2 ++
2 files changed, 6 insertions(+)
diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c
index 486d3f8..376eb47 100644
--- a/src/amd/common/ac_surface.c
+++ b/src/a
From: Nicolai Hähnle
---
src/amd/common/ac_gpu_info.h | 93 ++
src/gallium/drivers/radeon/radeon_winsys.h | 62 +---
2 files changed, 94 insertions(+), 61 deletions(-)
create mode 100644 src/amd/common/ac_gpu_info.h
diff --git a/src/amd
From: Nicolai Hähnle
To match radeonsi / ac_surface.
---
src/amd/vulkan/radv_image.c| 12 ++--
src/amd/vulkan/radv_radeon_winsys.h| 5 +++--
src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 8
3 files changed, 13 insertions(+), 12 de
From: Nicolai Hähnle
---
src/amd/Makefile.common.am| 2 +-
src/amd/Makefile.sources | 4 +-
src/amd/common/ac_gpu_info.c | 280 ++
src/amd/common/ac_gpu_info.h | 4 +
src/gallium/winsys/amdgp
From: Nicolai Hähnle
---
src/amd/common/ac_surface.c| 33 ++
src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 16 -
2 files changed, 33 insertions(+), 16 deletions(-)
diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c
i
From: Nicolai Hähnle
---
src/amd/common/ac_surface.c| 430 +
src/amd/common/ac_surface.h| 24 ++
src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 427 +---
3 files changed, 470 insertions(+), 411 deletions(-)
d
From: Nicolai Hähnle
---
src/amd/common/ac_surface.c| 47 ++
src/amd/common/ac_surface.h| 11 +++---
src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 6 +---
src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 2 +-
4 files changed,
From: Nicolai Hähnle
---
src/amd/common/ac_surface.c| 27 ++
src/amd/common/ac_surface.h| 12
src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 5 +
3 files changed, 24 insertions(+), 20 deletions(-)
diff --git a/s
From: Nicolai Hähnle
---
src/amd/Makefile.common.am | 2 +
src/amd/Makefile.sources | 4 +
src/amd/common/ac_surface.c| 198 +
src/amd/common/ac_surface.h| 10 ++
src/gallium/winsys/amd
From: Nicolai Hähnle
We can now merge the two *_surface_init functions.
---
src/amd/common/ac_surface.c| 380 ++
src/amd/common/ac_surface.h| 4 +
src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 425 +
3 files
Hi all,
It has bugged me for quite some time that this code is duplicated between
radeonsi and radv. Also, I wanted to play around with addrlib, and for that
it was helpful to have the code extracted from the various winsys
structures. So this series moves the surface code into amd/common and
chan
From: Nicolai Hähnle
---
src/amd/common/ac_surface.h| 178 +
src/gallium/drivers/radeon/radeon_winsys.h | 148 +---
2 files changed, 179 insertions(+), 147 deletions(-)
create mode 100644 src/amd/common/ac_surface.h
diff --git a/s
From: Benedikt Schemmer
This patch sets the allow_glsl_builtin_redeclaration for Dead Island
Riptide Definitive Edition.
This requires the patch series:
[Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying
Light and Dead Island Definitive Edition
by John Brooks sent Fri M
On Sat, May 13, 2017 at 1:55 AM, John Brooks wrote:
> On Sat, May 13, 2017 at 09:04:05AM +1000, Timothy Arceri wrote:
>> On 13/05/17 00:11, John Brooks wrote:
>> >On Fri, May 12, 2017 at 03:56:26PM +0200, Samuel Pitoiset wrote:
>> >>
>> >>
>> >>On 05/12/2017 03:39 PM, John Brooks wrote:
>> >>>Sinc
Gražvydas
On Sat, May 13, 2017 at 12:20 PM, Jan Beich wrote:
> glsl/.libs/libstandalone.a(libmesautil_la-disk_cache.o): In function
> `disk_cache_remove':
> disk_cache.c:(.text+0x763): undefined reference to `__atomic_fetch_add_8'
> glsl/.libs/libstandalone.a(libmesautil_la-disk_cache.o): In fu
On Wed, May 10, 2017 at 6:45 PM, Marek Olšák wrote:
> Hi,
>
> This series adds an optional module into gallium/util that wraps
> around pipe_context and moves execution of all pipe_context calls into
> a separate thread.
>
> It puts a lot of new requirements on the driver, especially on thread-
>
2017-05-13 19:19 GMT+02:00 Jason Ekstrand :
> Jonas,
>
> Welcome to mesa-dev!
>
> On May 11, 2017 12:08:01 PM Jonas Kulla wrote:
>
> > Hello everyone,
> >
> > I'm a student who's looking to create a small Vulkan demo for my computer
> > graphics class; my laptop (CPU: Intel N3540) has an integrat
On 14/05/17 01:39, Samuel Pitoiset wrote:
Mmh, this can still crash if location is < -1 or greater than the number
of uniforms. How about:
Sorry my commit message went missing it should have something like:
"-1 is allowed by the spec so that inactive uniforms don't cause the app
to throw an e
77 matches
Mail list logo