[Mesa-dev] [Bug 100854] YUV to RGB Color Space Conversion result is not precise

2017-05-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100854 Gary Wang changed: What|Removed |Added CC||gary.c.w...@intel.com -- You are receiving

Re: [Mesa-dev] [PATCH 9/9] i965: Always scissor on Gen4-5 instead of disabling guardband.

2017-05-14 Thread Pohjolainen, Topi
On Thu, May 11, 2017 at 04:32:06PM -0700, Kenneth Graunke wrote: > See commit ece0e535a44c228dd994861592deb155c14740d8. This makes > Gen4-5 follow the behavior we use on Gen6+. It seems to have > worked out there. Nice work, I couldn't spot anything amiss in the entire series. I was a little hes

[Mesa-dev] [PATCH 06/17] mesa: add buffer_sub_data() helper

2017-05-14 Thread Timothy Arceri
This will allow us to share code between the dsa, non-dsa and no_error variants. --- src/mesa/main/bufferobj.c | 41 - 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 97e4df9..e53adb

[Mesa-dev] [PATCH 14/17] mesa: compute.c C99 tidy up

2017-05-14 Thread Timothy Arceri
--- src/mesa/main/compute.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/compute.c b/src/mesa/main/compute.c index 5c84516..e881d4f 100644 --- a/src/mesa/main/compute.c +++ b/src/mesa/main/compute.c @@ -47,27 +47,26 @@ check_valid_to_compute(struct gl_con

[Mesa-dev] [PATCH 09/17] mesa: add blend_func_separatei() helper

2017-05-14 Thread Timothy Arceri
This will be used to add KHR_no_error support. --- src/mesa/main/blend.c | 45 - 1 file changed, 28 insertions(+), 17 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 955fda1..ed519bc 100644 --- a/src/mesa/main/blend.c +++ b

[Mesa-dev] [PATCH 12/17] mesa: add KHR_no_error support for glBlendEquationSeparateiARB()

2017-05-14 Thread Timothy Arceri
--- src/mapi/glapi/gen/ARB_draw_buffers_blend.xml | 2 +- src/mesa/main/blend.c | 9 + src/mesa/main/blend.h | 3 +++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/ARB_draw_buffers_blend.xml b/src/mapi/gla

[Mesa-dev] [PATCH 13/17] mesa: move DispatchCompute() validation to compute.c

2017-05-14 Thread Timothy Arceri
This is the only place it is used so there is no reason for it to be in api_validate.c --- src/mesa/main/api_validate.c | 234 --- src/mesa/main/api_validate.h | 13 --- src/mesa/main/compute.c | 234 ++- 3 files

[Mesa-dev] [PATCH 08/17] mesa: add KHR_no_error support for glBufferSubData()

2017-05-14 Thread Timothy Arceri
--- src/mapi/glapi/gen/gl_API.xml | 3 ++- src/mesa/main/bufferobj.c | 20 +--- src/mesa/main/bufferobj.h | 3 +++ 3 files changed, 22 insertions(+), 4 deletions(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 8afd5ec..762fb5a 100644 -

[Mesa-dev] [PATCH 16/17] mesa: add DispatchCompute* helpers

2017-05-14 Thread Timothy Arceri
These will be used to add KHR_no_error support. --- src/mesa/main/compute.c | 51 - 1 file changed, 38 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/compute.c b/src/mesa/main/compute.c index f3cc6af..16bb11f 100644 --- a/src/mesa/main/co

[Mesa-dev] [PATCH 11/17] mesa: add blend_equation_separatei() helper

2017-05-14 Thread Timothy Arceri
Will be used to add KHR_no_error support. --- src/mesa/main/blend.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c index 8811ef9..e91c14a 100644 --- a/src/mesa/main/blend.c +++ b/src/mesa/main/blend.c @@

[Mesa-dev] [PATCH 15/17] mesa: move FLUSH_CURRENT() calls out of DispatchCompute*() validation

2017-05-14 Thread Timothy Arceri
This is required to add KHR_no_error support. --- src/mesa/main/compute.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/mesa/main/compute.c b/src/mesa/main/compute.c index e881d4f..f3cc6af 100644 --- a/src/mesa/main/compute.c +++ b/src/mesa/main/compute.c @@

[Mesa-dev] [PATCH 17/17] mesa: add KHR_no_error support for glDispatchCompute*()

2017-05-14 Thread Timothy Arceri
--- src/mapi/glapi/gen/ARB_compute_shader.xml | 4 ++-- .../glapi/gen/ARB_compute_variable_group_size.xml | 2 +- src/mesa/main/compute.c| 26 ++ src/mesa/main/compute.h| 12 ++ 4 files changed, 41 inse

[Mesa-dev] [PATCH 01/17] mesa: add validate_buffer_storage() helper

2017-05-14 Thread Timothy Arceri
This will allow use to add KHR_no_error support. --- src/mesa/main/bufferobj.c | 42 +++--- 1 file changed, 27 insertions(+), 15 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 2ab7fe9..0f93b0f 100644 --- a/src/mesa/main/bu

[Mesa-dev] [PATCH 10/17] mesa: add KHR_no_error support for glBlendFunc*iARB()

2017-05-14 Thread Timothy Arceri
--- src/mapi/glapi/gen/ARB_draw_buffers_blend.xml | 4 ++-- src/mesa/main/blend.c | 18 ++ src/mesa/main/blend.h | 6 ++ 3 files changed, 26 insertions(+), 2 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_draw_buffers_blend.x

[Mesa-dev] Some more KHR_no_error patches

2017-05-14 Thread Timothy Arceri
There is now a no error profile/support for piglit which should cover most of the KHR_no_error support in mesa so far. So far I've been adding support for the various calls I've seen in some Feral games. Previous series still awaiting review: https://patchwork.freedesktop.org/series/24291/ https

[Mesa-dev] [PATCH 04/17] mesa: add KHR_no_error support for glBufferStorage()

2017-05-14 Thread Timothy Arceri
--- src/mapi/glapi/gen/gl_API.xml | 2 +- src/mesa/main/bufferobj.c | 20 +--- src/mesa/main/bufferobj.h | 3 +++ 3 files changed, 21 insertions(+), 4 deletions(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 1a3b306..8afd5ec 100644 --

[Mesa-dev] [PATCH 07/17] mesa: add KHR_no_error support for glNamedBufferSubData()

2017-05-14 Thread Timothy Arceri
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/bufferobj.c | 27 +++--- src/mesa/main/bufferobj.h | 3 +++ 3 files changed, 24 insertions(+), 8 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_state_a

[Mesa-dev] [PATCH 03/17] mesa: add KHR_no_error support for glNamedBufferStorage()

2017-05-14 Thread Timothy Arceri
--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 2 +- src/mesa/main/bufferobj.c | 31 -- src/mesa/main/bufferobj.h | 3 +++ 3 files changed, 28 insertions(+), 8 deletions(-) diff --git a/src/mapi/glapi/gen/ARB_direct_state_a

[Mesa-dev] [PATCH 05/17] mesa: create validate_buffer_sub_data() helper

2017-05-14 Thread Timothy Arceri
This change assumes meta will always pass valid arguments to _mesa_buffer_sub_data(). --- src/mesa/drivers/common/meta.c | 12 +++ src/mesa/drivers/common/meta_blit.c | 3 +- src/mesa/main/bufferobj.c | 67 + src/mesa/main/bufferobj.h

[Mesa-dev] [PATCH 02/17] mesa: add inlined_buffer_storage() helper

2017-05-14 Thread Timothy Arceri
This will allow us to share code between the dsa, non-dsa and no_error variants. --- src/mesa/main/bufferobj.c | 47 +++ 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 0f93b0f..

Re: [Mesa-dev] [PATCH 1/2] intel: gen-decoder: fix xml parser leak

2017-05-14 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 05/12/2017 02:37 PM, Lionel Landwerlin wrote: In the unlikely case the parsing of genxml files fails, we were leaking an xml parser object. Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 13 +++-- 1 file changed, 7 insertions(+),

Re: [Mesa-dev] [PATCH v2 2/2] i965: perf: fix pointer to integer cast

2017-05-14 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 05/12/2017 06:49 PM, Lionel Landwerlin wrote: v2: Just use cast to uintptr_t (Chris) Reported-by: Mauro Rossi Signed-off-by: Lionel Landwerlin --- src/mesa/drivers/dri/i965/brw_performance_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[Mesa-dev] [PATCH v2 0/3] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-14 Thread John Brooks
I have made the requested changes. I've also added a Reviewed-by with permission from funfunctor in #radeon (2017-05-14 EDT): [19:31:37] Frogging101: ping [19:32:37] Frogging101: with the minor style fix of putting a space around if or whatever, you have my Rb on your Dying Light patch

[Mesa-dev] [PATCH v2 1/3] driconf: Add allow_glsl_builtin_variable_redeclaration option

2017-05-14 Thread John Brooks
This option will allow GLSL builtins to be redeclared verbatim (e.g. redeclaring "in int gl_VertexID" in a vertex shader). This is not strictly valid and would normally fail to compile, but some applications (such as newer Techland ports) do it and need more leniency. v2 (Samuel Pitoiset): - R

[Mesa-dev] [PATCH v2 3/3] drirc: Add allow_glsl_builtin_variable_redeclaration for Dying Light and Dead Island Definitive Edition

2017-05-14 Thread John Brooks
This fixes the long-standing problem with Dying Light where the game would produce a black screen when running under Mesa. This happened because the game's vertex shaders redeclare gl_VertexID, which is a GLSL builtin. Mesa's GLSL compiler is a little more strict than others, and would not compile

[Mesa-dev] [PATCH v2 2/3] glsl: Conditionally allow redeclaration of built-in variables

2017-05-14 Thread John Brooks
Conditional on allow_glsl_builtin_variable_redeclaration driconf option. v2 (Samuel Pitoiset): - Rename allow_glsl_builtin_redeclaration -> allow_glsl_builtin_variable_redeclaration - style: put spaces after 'if' Signed-off-by: John Brooks Reviewed-by: Edward O'Callaghan --- src/

[Mesa-dev] [PATCH] radv: expose integrated device type for APUs.

2017-05-14 Thread Dave Airlie
From: Dave Airlie Note: this is on top of nha's rework. This just sets the vulkan device type depending on whether this is an APU or GPU. --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_devic

Re: [Mesa-dev] RFC Remove _mesa_problem() from paths where execution path is not altered

2017-05-14 Thread Timothy Arceri
Ping! On 09/05/17 13:04, Timothy Arceri wrote: There is still more that can be removed I just though I'd get comments before going too far. This is a follow on from [1][2]. Besides patch 1 we are just replacing it with an unreachable() when the path doesn't try to work around the problem i.e r

[Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-14 Thread Benedikt Schemmer
Hi all, Dying Light really works (Radeon RX460 4GB, Ubuntu 17.04, Mesa git patches applied plus some minor changes that i have locally to get rid of compiler warnings). I did have to jump through some additional hoops to get it working: Dying Light only launches from within Steam, Launch Opti

Re: [Mesa-dev] Fix __atomic* builtins detection for Clang

2017-05-14 Thread Dimitry Andric
On 13 May 2017, at 09:01, Jan Beich wrote: > > Jonathan Gray writes: > >> On Sat, May 13, 2017 at 02:22:30AM +0200, Jan Beich wrote: >> >>> "int" isn't large enough and lack of builtins only manifests at link time. >>> This was breaking build on FreeBSD 11.0 i386 with Clang 3.8.0. >>> >>> gls

Re: [Mesa-dev] [PATCH 00/13] Threaded Gallium for RadeonSI

2017-05-14 Thread Turo Lamminen
On Thu, 11 May 2017 21:02:21 +0200 Nicolai Hähnle wrote: > Violating the "async" promise on debug callbacks is a problem. This > breaks the OpenGL API in a place where it wasn't broken before, and > that's not okay. As an application developer who has occasionally relied on this behavior to debu

Re: [Mesa-dev] [PATCH 00/24] ac, radeonsi, radv: common surface and radeon_info code

2017-05-14 Thread Dave Airlie
On 15 May 2017 at 07:46, Nicolai Hähnle wrote: > Hi all, > > It has bugged me for quite some time that this code is duplicated between > radeonsi and radv. Also, I wanted to play around with addrlib, and for that > it was helpful to have the code extracted from the various winsys > structures. So

[Mesa-dev] [PATCH] ac/surface: fix regression for S8 on radv.

2017-05-14 Thread Dave Airlie
From: Dave Airlie S8 surfaces have no non-stencil levels, so compute level can fail for them, but we should continue to compute the levels for the stencil later. This is what we did in radv previous to fix this, but maybe we can do something cleaner? --- src/amd/common/ac_surface.c | 2 +- 1 fi

[Mesa-dev] [PATCH] radv: fix fmask surface creation (on top of nha rework)

2017-05-14 Thread Dave Airlie
From: Dave Airlie The old code copied over all the surface info from the image surface, we only want some bits of it, and to modify the flags. This fixes a regression caused by nha's rework of surface, and should probably be squashed in somewhere. Signed-off-by: Dave Airlie --- src/amd/vulkan

[Mesa-dev] [PATCH 01/12] anv: Canonicalize known offsets

2017-05-14 Thread Chris Wilson
When we add the reloc, we write the value of the relocation target using non-canonical form. If we later patch up the address prior to command submission, we will rewrite it using canonical form. We should always write the address in canonical form in case we skip the relocation (as the target did

[Mesa-dev] [PATCH 10/12] anv: Force use of reloc address

2017-05-14 Thread Chris Wilson
Now that all callers request and use the relocation target address, we can unconditionally pass it back and so enforce that the caller does supply it (and we hope uses it!). Signed-off-by: Chris Wilson --- src/intel/vulkan/anv_batch_chain.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletio

[Mesa-dev] [PATCH 11/12] anv: Always set the reloc value to match the presumed_offset

2017-05-14 Thread Chris Wilson
It is a requirement, not just of using the NO_RELOC mode, that all relocation values in the execobjects match their reloc.presumed_offset, as the kernel will skip performing *any* relocation if the presumed_offset matches the target object. In many places the relocation entry is record with the rig

[Mesa-dev] [PATCH 05/12] anv: Split tracking of bo and relocation entries

2017-05-14 Thread Chris Wilson
Track seen bo for a reloc list separately from the bo used by the relocs. This is a step towards not using the relocation entries themselves, but we still need to track the used bo and provide those to the kernel. In the short term, since the array of unique is likely small, we can try to keep it

[Mesa-dev] [PATCH 12/12] anv: Allocate buffer offsets from userspace

2017-05-14 Thread Chris Wilson
A very simple allocator that increments from the last globally allocated offset and assigns that for the lifetime of this bo for every context. Once we run out of space, we delegate finding holes to the kernel. In the future, we can opt to handle this ourselves as well, but a 48b address space mean

[Mesa-dev] [PATCH 09/12] anv: Always set batch chain GTT address

2017-05-14 Thread Chris Wilson
A requirement for NORELOC is that the relocation entry exactly matches the content of the buffer, and so we must set the value in the buffer on adding the relocation. Signed-off-by: Chris Wilson --- src/intel/vulkan/anv_batch_chain.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) dif

[Mesa-dev] [PATCH 02/12] anv: Refactor anv_bo flag initialisation

2017-05-14 Thread Chris Wilson
Signed-off-by: Chris Wilson --- src/intel/vulkan/anv_allocator.c | 10 ++ src/intel/vulkan/anv_device.c| 7 +-- src/intel/vulkan/anv_intel.c | 3 +-- src/intel/vulkan/anv_private.h | 20 4 files changed, 24 insertions(+), 16 deletions(-) diff --git a/

[Mesa-dev] [PATCH 04/12] anv: Exclude state objects from being placed above 4G

2017-05-14 Thread Chris Wilson
Signed-off-by: Chris Wilson --- src/intel/vulkan/anv_allocator.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/anv_allocator.c b/src/intel/vulkan/anv_allocator.c index dc9b55b4a6..e316b421f4 100644 --- a/src/intel/vulkan/anv_allocator.c +++ b/src/intel/

[Mesa-dev] [PATCH 06/12] anv: Compute the target address for relocations just once

2017-05-14 Thread Chris Wilson
Compute the target address address whilst adding the relocation so that we guarantee the value matches the relocation entry we pass to the kernel. Pass it back from the relocation function for it to be written into the command stream. Signed-off-by: Chris Wilson --- src/intel/vulkan/anv_batch_ch

[Mesa-dev] [PATCH 03/12] anv: Pass the allocation bo flags through anv_bo_init_new

2017-05-14 Thread Chris Wilson
Signed-off-by: Chris Wilson --- src/intel/vulkan/anv_allocator.c | 8 +--- src/intel/vulkan/anv_device.c| 8 +--- src/intel/vulkan/anv_private.h | 3 ++- src/intel/vulkan/genX_query.c| 2 +- 4 files changed, 13 insertions(+), 8 deletions(-) diff --git a/src/intel/vulkan/anv_all

[Mesa-dev] [PATCH 07/12] anv: Always set blorp GTT address

2017-05-14 Thread Chris Wilson
A requirement for NORELOC is that the relocation entry exactly matches the content of the buffer, and so we must set the value in the buffer on adding the relocation. Signed-off-by: Chris Wilson --- src/intel/blorp/blorp_genX_exec.h | 11 --- src/intel/vulkan/genX_blorp_exec.c

[Mesa-dev] [PATCH 08/12] anv: Always set surface_state GTT address

2017-05-14 Thread Chris Wilson
A requirement for NORELOC is that the relocation entry exactly matches the content of the buffer, and so we must set the value in the buffer on adding the relocation. Signed-off-by: Chris Wilson --- src/intel/vulkan/genX_cmd_buffer.c | 19 +-- 1 file changed, 17 insertions(+), 2

[Mesa-dev] [PATCH 16/24] radv: remove radeon_surf_level::nblk_z

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle We're not using thick tiling modes, so we can just derive the value ourselves. --- src/amd/vulkan/radv_image.c| 2 +- src/amd/vulkan/radv_radeon_winsys.h| 1 - src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 4 3 files change

[Mesa-dev] [PATCH 24/24] radv: use ac_compute_surface

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 391 + 1 file changed, 6 insertions(+), 385 deletions(-) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c index 508a6d1..eaa978e

[Mesa-dev] [PATCH 14/24] radv: remove radeon_surf_level::pitch_bytes

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle Like radeonsi. This saves memory, and the information can easily be recomputed on the fly where necessary. --- src/amd/vulkan/radv_image.c| 11 ++- src/amd/vulkan/radv_private.h | 1 - src/amd/vulkan/radv_radeon_winsys.h

[Mesa-dev] [PATCH 20/24] radv: remove radeon_info::name

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/vulkan/radv_device.c | 28 ++- src/amd/vulkan/radv_radeon_winsys.h | 1 - src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 28 --- 3 files changed, 27 insertions(+), 30 deletions(-) d

[Mesa-dev] [PATCH 15/24] radv: remove radeon_surf_level::dcc_enabled

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle Like radeonsi; replace with radeon_surf::num_dcc_levels. --- src/amd/vulkan/radv_device.c | 2 +- src/amd/vulkan/radv_image.c| 2 +- src/amd/vulkan/radv_meta_resolve.c | 2 +- src/amd/vulkan/radv_radeon_winsys.h

[Mesa-dev] [PATCH 21/24] radv: use ac_gpu_info

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/vulkan/radv_device.c | 10 +- src/amd/vulkan/radv_private.h | 1 + src/amd/vulkan/radv_radeon_winsys.h | 55 +-- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 175 +- src/amd

[Mesa-dev] [PATCH 23/24] radv: use amdgpu_addr_create

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 69 - src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.h | 1 - src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 90 ++ src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h | 3 -

[Mesa-dev] [PATCH 11/24] ac: add radeon_info::num_{sdma, compute}_rings

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle Vulkan needs them. --- src/amd/common/ac_gpu_info.c | 15 +-- src/amd/common/ac_gpu_info.h | 3 ++- src/gallium/drivers/radeon/r600_pipe_common.c | 4 ++-- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 4 ++--

[Mesa-dev] [PATCH 22/24] radv: stop using radv_amdgpu_winsys::family

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 2 +- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs

[Mesa-dev] [PATCH 17/24] radv: remove unused RADEON_SURF_HAS_SBUFFER_MIPTREE

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/vulkan/radv_image.c | 3 +-- src/amd/vulkan/radv_radeon_winsys.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index f663e29..6225240 100644 --- a/src/amd/vulkan/radv_image.c

[Mesa-dev] [PATCH 19/24] radv: use ac_surface data structures

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle This is mostly mechanical changes of renaming types and introducing "legacy" everywhere. It doesn't use the ac_surface computation functions yet. --- src/amd/common/ac_surface.h| 1 + src/amd/vulkan/radv_device.c | 22 +++--- s

[Mesa-dev] [PATCH 13/24] radv: add surface helper variable in radv_GetImageSubresourceLayout

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/vulkan/radv_image.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index e1e9d9c..c0fc896 100644 --- a/src/amd/vulkan/radv_image.c +++ b/src/amd/vulkan/radv_image.c @@ -8

[Mesa-dev] [PATCH 12/24] ac: add missing extern "C" guards

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_gpu_info.h | 8 src/amd/common/ac_surface.h | 8 2 files changed, 16 insertions(+) diff --git a/src/amd/common/ac_gpu_info.h b/src/amd/common/ac_gpu_info.h index 9bf2b84..d8029ef 100644 --- a/src/amd/common/ac_gpu_info.h +++ b/src/am

[Mesa-dev] [PATCH 10/24] ac: add radeon_surf::htile_slice_size

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle Vulkan needs it. --- src/amd/common/ac_surface.c | 4 src/amd/common/ac_surface.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c index 486d3f8..376eb47 100644 --- a/src/amd/common/ac_surface.c +++ b/src/a

[Mesa-dev] [PATCH 07/24] ac/radeonsi: move struct radeon_info to ac_gpu_info.h

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_gpu_info.h | 93 ++ src/gallium/drivers/radeon/radeon_winsys.h | 62 +--- 2 files changed, 94 insertions(+), 61 deletions(-) create mode 100644 src/amd/common/ac_gpu_info.h diff --git a/src/amd

[Mesa-dev] [PATCH 18/24] radv: rename radeon_surf::bo_{size, alignment} to surf_{size, alignment}

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle To match radeonsi / ac_surface. --- src/amd/vulkan/radv_image.c| 12 ++-- src/amd/vulkan/radv_radeon_winsys.h| 5 +++-- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_surface.c | 8 3 files changed, 13 insertions(+), 12 de

[Mesa-dev] [PATCH 08/24] ac/radeonsi: move radeon_info initialization to amd/common

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/Makefile.common.am| 2 +- src/amd/Makefile.sources | 4 +- src/amd/common/ac_gpu_info.c | 280 ++ src/amd/common/ac_gpu_info.h | 4 + src/gallium/winsys/amdgp

[Mesa-dev] [PATCH 06/24] ac/radeonsi: move some aspects of sanity checking to ac_surface

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_surface.c| 33 ++ src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 16 - 2 files changed, 33 insertions(+), 16 deletions(-) diff --git a/src/amd/common/ac_surface.c b/src/amd/common/ac_surface.c i

[Mesa-dev] [PATCH 03/24] ac/radeonsi: move the bulk of gfx6_surface_init to ac_surface

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_surface.c| 430 + src/amd/common/ac_surface.h| 24 ++ src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 427 +--- 3 files changed, 470 insertions(+), 411 deletions(-) d

[Mesa-dev] [PATCH 09/24] ac_surface: use radeon_info from ac_gpu_info

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_surface.c| 47 ++ src/amd/common/ac_surface.h| 11 +++--- src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 6 +--- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 2 +- 4 files changed,

[Mesa-dev] [PATCH 05/24] ac/radeonsi: add ac_compute_surface to automatically switch gfx6 vs. gfx9

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_surface.c| 27 ++ src/amd/common/ac_surface.h| 12 src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 5 + 3 files changed, 24 insertions(+), 20 deletions(-) diff --git a/s

[Mesa-dev] [PATCH 02/24] ac/radeonsi: move amdgpu_addr_create to ac_surface

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/Makefile.common.am | 2 + src/amd/Makefile.sources | 4 + src/amd/common/ac_surface.c| 198 + src/amd/common/ac_surface.h| 10 ++ src/gallium/winsys/amd

[Mesa-dev] [PATCH 04/24] ac/radeonsi: move the bulk of gfx9_surface_init to ac_surface

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle We can now merge the two *_surface_init functions. --- src/amd/common/ac_surface.c| 380 ++ src/amd/common/ac_surface.h| 4 + src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 425 + 3 files

[Mesa-dev] [PATCH 00/24] ac, radeonsi, radv: common surface and radeon_info code

2017-05-14 Thread Nicolai Hähnle
Hi all, It has bugged me for quite some time that this code is duplicated between radeonsi and radv. Also, I wanted to play around with addrlib, and for that it was helpful to have the code extracted from the various winsys structures. So this series moves the surface code into amd/common and chan

[Mesa-dev] [PATCH 01/24] ac/radeonsi: move surface definitions to new header ac_surface.h

2017-05-14 Thread Nicolai Hähnle
From: Nicolai Hähnle --- src/amd/common/ac_surface.h| 178 + src/gallium/drivers/radeon/radeon_winsys.h | 148 +--- 2 files changed, 179 insertions(+), 147 deletions(-) create mode 100644 src/amd/common/ac_surface.h diff --git a/s

[Mesa-dev] [PATCH] drirc: Add allow_glsl_builtin_redeclaration for Dead Island Riptide Definitive Edition

2017-05-14 Thread Benedikt Schemmer
From: Benedikt Schemmer This patch sets the allow_glsl_builtin_redeclaration for Dead Island Riptide Definitive Edition. This requires the patch series: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition by John Brooks sent Fri M

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

2017-05-14 Thread Marek Olšák
On Sat, May 13, 2017 at 1:55 AM, John Brooks wrote: > On Sat, May 13, 2017 at 09:04:05AM +1000, Timothy Arceri wrote: >> On 13/05/17 00:11, John Brooks wrote: >> >On Fri, May 12, 2017 at 03:56:26PM +0200, Samuel Pitoiset wrote: >> >> >> >> >> >>On 05/12/2017 03:39 PM, John Brooks wrote: >> >>>Sinc

Re: [Mesa-dev] [PATCH 1/2] Clang doesn't have 64bit __atomic* builtins on i386

2017-05-14 Thread Grazvydas Ignotas
Gražvydas On Sat, May 13, 2017 at 12:20 PM, Jan Beich wrote: > glsl/.libs/libstandalone.a(libmesautil_la-disk_cache.o): In function > `disk_cache_remove': > disk_cache.c:(.text+0x763): undefined reference to `__atomic_fetch_add_8' > glsl/.libs/libstandalone.a(libmesautil_la-disk_cache.o): In fu

Re: [Mesa-dev] [PATCH 00/13] Threaded Gallium for RadeonSI

2017-05-14 Thread Rob Clark
On Wed, May 10, 2017 at 6:45 PM, Marek Olšák wrote: > Hi, > > This series adds an optional module into gallium/util that wraps > around pipe_context and moves execution of all pipe_context calls into > a separate thread. > > It puts a lot of new requirements on the driver, especially on thread- >

Re: [Mesa-dev] anv: finishing bay trail support

2017-05-14 Thread Jonas Kulla
2017-05-13 19:19 GMT+02:00 Jason Ekstrand : > Jonas, > > Welcome to mesa-dev! > > On May 11, 2017 12:08:01 PM Jonas Kulla wrote: > > > Hello everyone, > > > > I'm a student who's looking to create a small Vulkan demo for my computer > > graphics class; my laptop (CPU: Intel N3540) has an integrat

Re: [Mesa-dev] [PATCH] mesa: don't crash in KHR_no_error uniform variants when location == -1

2017-05-14 Thread Timothy Arceri
On 14/05/17 01:39, Samuel Pitoiset wrote: Mmh, this can still crash if location is < -1 or greater than the number of uniforms. How about: Sorry my commit message went missing it should have something like: "-1 is allowed by the spec so that inactive uniforms don't cause the app to throw an e