Re: [Mesa-dev] [PATCH] mesa: Set api prefix to version string when overriding version

2015-10-12 Thread Tapani Pälli
On 10/13/2015 09:35 AM, Boyan Ding wrote: 2015-10-13 13:49 GMT+08:00 Tapani Pälli : Otherwise there are problems when user overrides version and application such as Piglit wants to detect used api with glGetString(GL_VERSION). Below is example when using MESA_GLES_VERSION_OVERRIDE=3.1. Befor

[Mesa-dev] [PATCH] glsl: fix matrix stride calculation for std430's row_major matrices with two columns

2015-10-12 Thread Samuel Iglesias Gonsalvez
This is the result of applying several rules: From OpenGL 4.3 spec, section 7.6.2.2 "Standard Uniform Block Layout": "2. If the member is a two- or four-component vector with components consuming N basic machine units, the base alignment is 2N or 4N, respectively." [...] "4. If the member is an a

Re: [Mesa-dev] [PATCH] mesa: Set api prefix to version string when overriding version

2015-10-12 Thread Boyan Ding
2015-10-13 13:49 GMT+08:00 Tapani Pälli : > Otherwise there are problems when user overrides version and application > such as Piglit wants to detect used api with glGetString(GL_VERSION). > > Below is example when using MESA_GLES_VERSION_OVERRIDE=3.1. > > Before: > "3.1 Mesa 11.1.0-devel (

Re: [Mesa-dev] [PATCH 3/3] nir: Add helpers for creating variables and adding them to lists

2015-10-12 Thread Iago Toral
On Mon, 2015-10-12 at 07:47 -0700, Jason Ekstrand wrote: > > On Oct 12, 2015 1:26 AM, "Iago Toral" wrote: > > > > On Fri, 2015-10-09 at 07:09 -0700, Jason Ekstrand wrote: > > > --- > > > src/glsl/nir/glsl_to_nir.cpp | 40 - > > > src/glsl/nir/nir.c | 66 > ++

[Mesa-dev] [PATCH] mesa: Set api prefix to version string when overriding version

2015-10-12 Thread Tapani Pälli
Otherwise there are problems when user overrides version and application such as Piglit wants to detect used api with glGetString(GL_VERSION). Below is example when using MESA_GLES_VERSION_OVERRIDE=3.1. Before: "3.1 Mesa 11.1.0-devel (git-24a1a15)" After: "OpenGL ES 3.1 Mesa 11.1

[Mesa-dev] [PATCH 2/4] tgsi: try and handle overflowing shaders.

2015-10-12 Thread Dave Airlie
From: Dave Airlie This is used to detect error in virgl if we overflow the shader dumping buffers. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_dump.c | 10 -- src/gallium/auxiliary/tgsi/tgsi_dump.h | 2 +- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 4/4] virgl/vtest: add vtest driver

2015-10-12 Thread Dave Airlie
virgl/vtest is a swrast driver that allows the virgl acceleration to be tested without having a virtual machine. The backend has a unix socket server that this connects to. This is run by setting LIBGL_ALWAYS_SOFTWARE=y GALLIUM_DRIVER=virpipe In this mode all renderering is sent over a socket to

[Mesa-dev] gallium virgl driver - first posting

2015-10-12 Thread Dave Airlie
Hey all, Things finally seem to be heading upstream in qemu and kernel land, so I'm going to post this now. virgl is a project started by me to create a virtio based GPU using gallium/tgsi as the basis for 3D acceleration. The 3D acceleration portion is contained a qemu plugin library virglrende

[Mesa-dev] [PATCH 1/4] tgsi: add option to dump floats as hex values

2015-10-12 Thread Dave Airlie
This adds support to the parser to accept hex values as floats, and then adds support to the dumper to allow the user to select to dump float as 32-bit hex numbers. This is required to get accurate values for virgl use of TGSI. Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_dump

[Mesa-dev] [PATCH 02/11] vbo: simplify vertex array initializations in vbo_context.c

2015-10-12 Thread Brian Paul
--- src/mesa/vbo/vbo_context.c | 95 +- 1 file changed, 43 insertions(+), 52 deletions(-) diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_context.c index b5dc45c..5e1a760 100644 --- a/src/mesa/vbo/vbo_context.c +++ b/src/mesa/vbo/vbo_context.

[Mesa-dev] [PATCH 10/11] vbo: make void vbo_exec_BeginVertices() static

2015-10-12 Thread Brian Paul
Not called from any other file. Rename and move before use. --- src/mesa/vbo/vbo_exec.h | 4 +--- src/mesa/vbo/vbo_exec_api.c | 37 +++-- 2 files changed, 20 insertions(+), 21 deletions(-) diff --git a/src/mesa/vbo/vbo_exec.h b/src/mesa/vbo/vbo_exec.h index 0

[Mesa-dev] [PATCH 06/11] vbo: add comments, braces in ATTR_UNION() in vbo_exec_api.c

2015-10-12 Thread Brian Paul
--- src/mesa/vbo/vbo_exec_api.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_api.c b/src/mesa/vbo/vbo_exec_api.c index 583a2f9..9de2886 100644 --- a/src/mesa/vbo/vbo_exec_api.c +++ b/src/mesa/vbo/vbo_exec_api.c @@ -413,18 +413,27 @@ vbo_

[Mesa-dev] [PATCH 04/11] vbo: move 'tmp' var initialization

2015-10-12 Thread Brian Paul
Improve readability a bit. --- src/mesa/vbo/vbo_save_api.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c index 02cd03c..fdc677f 100644 --- a/src/mesa/vbo/vbo_save_api.c +++ b/src/mesa/vbo/vbo_save_api.c @@ -648,7 +64

[Mesa-dev] [PATCH 03/11] vbo: improve fprintf() formatting

2015-10-12 Thread Brian Paul
--- src/mesa/vbo/vbo_save_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c index 1a70d16..02cd03c 100644 --- a/src/mesa/vbo/vbo_save_api.c +++ b/src/mesa/vbo/vbo_save_api.c @@ -1543,7 +1543,7 @@ vbo_print_vertex_lis

[Mesa-dev] [PATCH 11/11] mesa: clean up comments for gl_current_attrib struct

2015-10-12 Thread Brian Paul
--- src/mesa/main/mtypes.h | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 0a54b20..62eb592 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -487,26 +487,24 @@ struct gl_colorbuffer_attrib st

[Mesa-dev] [PATCH 09/11] vbo: document vbo_exec_context fields

2015-10-12 Thread Brian Paul
--- src/mesa/vbo/vbo_exec.h | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/src/mesa/vbo/vbo_exec.h b/src/mesa/vbo/vbo_exec.h index 80f3015..0f894aa 100644 --- a/src/mesa/vbo/vbo_exec.h +++ b/src/mesa/vbo/vbo_exec.h @@ -79,7 +79,7 @@ struct vbo_exec_copied_vtx {

[Mesa-dev] [PATCH 05/11] vbo: fix whitespace in vbo_exec_draw.c

2015-10-12 Thread Brian Paul
--- src/mesa/vbo/vbo_exec_draw.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_draw.c b/src/mesa/vbo/vbo_exec_draw.c index 2bfb0c3..174cbc3 100644 --- a/src/mesa/vbo/vbo_exec_draw.c +++ b/src/mesa/vbo/vbo_exec_draw.c @@ -53,10

[Mesa-dev] [PATCH 07/11] vbo: add assertion in ATTR_UNION macro

2015-10-12 Thread Brian Paul
--- src/mesa/vbo/vbo_exec_api.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/vbo/vbo_exec_api.c b/src/mesa/vbo/vbo_exec_api.c index 9de2886..3943523 100644 --- a/src/mesa/vbo/vbo_exec_api.c +++ b/src/mesa/vbo/vbo_exec_api.c @@ -423,6 +423,9 @@ vbo_exec_fixup_vertex(struct gl_con

[Mesa-dev] [PATCH 01/11] vbo: get rid of needless NR_MAT_ATTRIBS constant

2015-10-12 Thread Brian Paul
--- src/mesa/vbo/vbo_context.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/mesa/vbo/vbo_context.c b/src/mesa/vbo/vbo_context.c index 802955d..b5dc45c 100644 --- a/src/mesa/vbo/vbo_context.c +++ b/src/mesa/vbo/vbo_context.c @@ -33,7 +33,6 @@ #include "vbo.h" #

[Mesa-dev] [PATCH 08/11] vbo: minor clean-ups for vbo_exec_fixup_vertex()

2015-10-12 Thread Brian Paul
--- src/mesa/vbo/vbo_exec_api.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/vbo/vbo_exec_api.c b/src/mesa/vbo/vbo_exec_api.c index 3943523..a99887a 100644 --- a/src/mesa/vbo/vbo_exec_api.c +++ b/src/mesa/vbo/vbo_exec_api.c @@ -375,13 +375,16 @@ vbo_exec_wrap

[Mesa-dev] [PATCH] vbo: fix incorrect switch statement in init_mat_currval()

2015-10-12 Thread Brian Paul
The variable 'i' is a value in [0, MAT_ATTRIB_MAX-1] so subtracting VERT_ATTRIB_GENERIC0 gave a bogus value and we executed the default switch clause for all loop iterations. This doesn't fix any known issues but was clearly incorrect. Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/vbo/vbo_c

[Mesa-dev] [PATCH] mesa: pass caller name to create_textures()

2015-10-12 Thread Brian Paul
Simpler than the dsa flag approach. --- src/mesa/main/texobj.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 60c55ae..b571b1b 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -1205,17 +1205

Re: [Mesa-dev] [PATCH 03/17] mesa: Move gl_frag_depth_layout from mtypes.h to shader_enums.h

2015-10-12 Thread Rob Clark
and bonus points for adding a gl_frag_depth_layout_name() ;-) On Fri, Oct 9, 2015 at 5:04 AM, Michael Schellenberger Costa wrote: > Hi, > > as this conflicts directly with Robs patch > http://lists.freedesktop.org/archives/mesa-dev/2015-October/096670.html > you might want to update it > > Michae

Re: [Mesa-dev] [PATCH 03/17] mesa: Move gl_frag_depth_layout from mtypes.h to shader_enums.h

2015-10-12 Thread Michael Schellenberger Costa
Hi, as this conflicts directly with Robs patch http://lists.freedesktop.org/archives/mesa-dev/2015-October/096670.html you might want to update it Michael Am 09.10.2015 um 02:22 schrieb Jason Ekstrand: > --- src/glsl/shader_enums.h | 17 + > src/mesa/main/mtypes.h | 18 -

Re: [Mesa-dev] [PATCH] android: build i965_compile_FILES sources

2015-10-12 Thread Florian Wiedemann
Hi Mauro, is it a patch to compile Android Marshmallow or is it a patch to fix the fonts problem on Intel graphics hardware? Florian ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/5] i965/vec4: adding vec4_cmod_propagation optimization

2015-10-12 Thread Matt Turner
On Mon, Oct 12, 2015 at 4:25 PM, Matt Turner wrote: > On Sat, Oct 10, 2015 at 4:24 AM, Alejandro Piñeiro > wrote: >> vec4 port of fs_cmod_propagation. >> >> Shader-db results: >> total instructions in shared programs: 6241226 -> 6224469 (-0.27%) >> instructions in affected programs: 498213 -

Re: [Mesa-dev] [PATCH v2 6/7] radeonsi: Add DCC decompress.

2015-10-12 Thread Marek Olšák
On Mon, Oct 12, 2015 at 10:27 PM, Axel Davy wrote: > On 12/10/2015 17:05, Bas Nieuwenhuizen wrote: >> >> Hi Marek, >> >> Thanks for the quick review. >> >> I do not think I understand the sharing semantics. We currently have >> fast clear for scanout surfaces with the CMASK and eliminate it on >>

Re: [Mesa-dev] [PATCH v2 6/7] radeonsi: Add DCC decompress.

2015-10-12 Thread Marek Olšák
On Mon, Oct 12, 2015 at 5:05 PM, Bas Nieuwenhuizen wrote: > Hi Marek, > > Thanks for the quick review. > > I do not think I understand the sharing semantics. We currently have > fast clear for scanout surfaces with the CMASK and eliminate it on > flush resource. I would think we could do that simi

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Roland Scheidegger
Am 13.10.2015 um 00:26 schrieb Rob Clark: > On Mon, Oct 12, 2015 at 6:07 PM, Roland Scheidegger > wrote: >> Am 12.10.2015 um 22:37 schrieb Rob Clark: >>> On Mon, Oct 12, 2015 at 3:41 PM, Roland Scheidegger >>> wrote: Am 12.10.2015 um 20:33 schrieb Rob Clark: > On Mon, Oct 12, 2015 at 2

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Roland Scheidegger
Am 13.10.2015 um 01:01 schrieb Matt Turner: > On Mon, Oct 12, 2015 at 3:07 PM, Roland Scheidegger > wrote: >> As far as I can tell (and I could easily be wrong here...) intel hw >> doesn't have explicit conversion instruction, you just say it's a f16 >> destination. As such I believe the conversi

Re: [Mesa-dev] [PATCH 2/5] i965/vec4: adding vec4_cmod_propagation optimization

2015-10-12 Thread Matt Turner
On Sat, Oct 10, 2015 at 4:24 AM, Alejandro Piñeiro wrote: > vec4 port of fs_cmod_propagation. > > Shader-db results: > total instructions in shared programs: 6241226 -> 6224469 (-0.27%) > instructions in affected programs: 498213 -> 481456 (-3.36%) > helped:3082

Re: [Mesa-dev] [PATCH v2 6/7] radeonsi: Add DCC decompress.

2015-10-12 Thread Axel Davy
On 13/10/2015 00:42, Bas Nieuwenhuizen wrote: Hi Axel, Using DCC for scanout surfaces is problematic because as far as I understand the display hardware does not support it. We could solve that partially by decompressing when displaying. However, the X server can also use these surfaces as a fr

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Matt Turner
On Mon, Oct 12, 2015 at 3:07 PM, Roland Scheidegger wrote: > As far as I can tell (and I could easily be wrong here...) intel hw > doesn't have explicit conversion instruction, you just say it's a f16 > destination. As such I believe the conversion used would just use > ordinary rounding mode, whi

Re: [Mesa-dev] [PATCH v2 6/7] radeonsi: Add DCC decompress.

2015-10-12 Thread Bas Nieuwenhuizen
Hi Axel, Using DCC for scanout surfaces is problematic because as far as I understand the display hardware does not support it. We could solve that partially by decompressing when displaying. However, the X server can also use these surfaces as a front buffer and for that case we cannot just use

Re: [Mesa-dev] [PATCH shader-db] check_dependencies: refactor to a python script

2015-10-12 Thread Matt Turner
On Sat, Oct 10, 2015 at 12:45 AM, Rhys Kidd wrote: > Deliver consistency with all other shader-db scripts, which are Python > scripts. I'm not sure why that'd be beneficial... The only additional thing I really want this script (and run.c) to handle is ES shaders. I think we silently accept th

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Rob Clark
On Mon, Oct 12, 2015 at 6:07 PM, Roland Scheidegger wrote: > Am 12.10.2015 um 22:37 schrieb Rob Clark: >> On Mon, Oct 12, 2015 at 3:41 PM, Roland Scheidegger >> wrote: >>> Am 12.10.2015 um 20:33 schrieb Rob Clark: On Mon, Oct 12, 2015 at 2:22 PM, Matt Turner wrote: > On Mon, Oct 12, 20

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Roland Scheidegger
Am 12.10.2015 um 22:37 schrieb Rob Clark: > On Mon, Oct 12, 2015 at 3:41 PM, Roland Scheidegger > wrote: >> Am 12.10.2015 um 20:33 schrieb Rob Clark: >>> On Mon, Oct 12, 2015 at 2:22 PM, Matt Turner wrote: On Mon, Oct 12, 2015 at 11:12 AM, Rob Clark wrote: > On Mon, Oct 12, 2015 at 12:

[Mesa-dev] [PATCH v2 12/11] i965: Add scalar geometry shader support.

2015-10-12 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs.cpp | 174 ++ src/mesa/drivers/dri/i965/brw_fs.h| 16 +- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 378 ++ src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4

Re: [Mesa-dev] [PATCH shader-db v2 1/3] Makefile: avoid undefined reference build errors

2015-10-12 Thread Matt Turner
On Mon, Oct 12, 2015 at 4:25 AM, Rhys Kidd wrote: > Signed-off-by: Rhys Kidd > --- Thanks. Pushed this with review. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH shader-db 3/3] docs: Add symbolic link generation step

2015-10-12 Thread Matt Turner
On Sat, Oct 10, 2015 at 10:30 PM, Rhys Kidd wrote: > Signed-off-by: Rhys Kidd > --- > README | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/README b/README > index 6ed3244..03be4e7 100644 > --- a/README > +++ b/README > @@ -60,6 +60,11 @@ Build with: > make > ``` > > +run.py rel

Re: [Mesa-dev] [PATCH shader-db 2/3] docs: Improve dependencies documentation

2015-10-12 Thread Matt Turner
On Sat, Oct 10, 2015 at 10:30 PM, Rhys Kidd wrote: > Signed-off-by: Rhys Kidd > --- > README | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/README b/README > index e301d0e..6ed3244 100644 > --- a/README > +++ b/README > @@ -47,7 +47,18 @@ ST_DEBUG=precompi

[Mesa-dev] [PATCH v2 03/11] i965: Introduce a brw_vue_prog_data::include_vue_handles flag.

2015-10-12 Thread Kenneth Graunke
Tessellation shaders and SIMD8 geometry shaders may need to resort to the pull model for inputs at times. When set, the state upload code will tell the hardware to provide URB handles for input data. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_context.h | 3 +++ src/mesa/

[Mesa-dev] [PATCH v2 05/11] i965: Make emit_urb_writes() only set EOT for the VS.

2015-10-12 Thread Kenneth Graunke
The GS will emit a bunch of vertices, and we don't want to do an EOT prematurely. We'll emit GS_OPCODE_THREAD_END when we want to terminate the thread. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[Mesa-dev] [PATCH v2 06/11] i965: Make emit_urb_writes() reserve space for GS header information.

2015-10-12 Thread Kenneth Graunke
Geometry shaders have additional header data at the beginning of their output URB entries. Shaders that use EndPrimitive() or multiple streams have a control data header; shaders with a dynamic vertex count have an additional vec4 slot to hold the 32-bit vertex count (and 96 bits of padding). Sig

[Mesa-dev] [PATCH v2 11/11] i965: Add scalar GS input lowering code.

2015-10-12 Thread Kenneth Graunke
We really ought to compute the VUE map at link time and stash it, rather than recomputing it here, but with the mess of program structures I wasn't sure where to put it. We can improve that later. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_nir.c | 44 ++

[Mesa-dev] [PATCH v2 07/11] i965: Add a brw->scalar_gs flag controlled by INTEL_SCALAR_GS=1.

2015-10-12 Thread Kenneth Graunke
This patch introduces a brw->scalar_gs flag, similar to brw->scalar_vs, which controls whether or not to use SIMD8 geometry shaders. For now, we control it via a new environment variable, INTEL_SCALAR_GS. This provides a convenient way to try it out. Signed-off-by: Kenneth Graunke --- src/mesa/

[Mesa-dev] [PATCH v2 08/11] i965: Add a fs_visitor constructor that takes a brw_gs_compile.

2015-10-12 Thread Kenneth Graunke
Unlike the vs/wm structs, brw_gs_compile is actually useful: it contains the input VUE map and information about the control data headers. Passing this in allows us to share that code in brw_gs.c, and calculate them before deciding on vec4 vs. scalar mode, as it's independent of that choice. Signe

[Mesa-dev] [PATCH v2 04/11] i965: Make fs_visitor::emit_urb_writes reusable for scalar GS.

2015-10-12 Thread Kenneth Graunke
GS doesn't have ClampVertexColor, and we don't want to go through VS structures. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/

[Mesa-dev] [PATCH v2 09/11] i965: Implement nir_intrinsic_load_primitive.

2015-10-12 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 51189a2..a67e545 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp

[Mesa-dev] [PATCH v2 10/11] i965: Implement gl_InvocationID.

2015-10-12 Thread Kenneth Graunke
It's stored in bits 31:27 of g1 (along with the URB handles). Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 13 + 1 file changed, 13 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index

[Mesa-dev] [PATCH v2 02/11] i965: Introduce a new SHADER_OPCODE_URB_READ_SIMD8 opcode.

2015-10-12 Thread Kenneth Graunke
In scalar mode, geometry shader inputs can easily take up hundreds of registers. This makes pushing VUE entries impractical; we'll need to resort to the pull model in some cases. To support this, we introduce a new opcode corresponding to the "URB Read SIMD8" message. Signed-off-by: Kenneth Grau

[Mesa-dev] [PATCH v2 01/11] i965: Introduce new SHADER_OPCODE_URB_WRITE_SIMD8_MASKED/PER_SLOT opcodes.

2015-10-12 Thread Kenneth Graunke
In the vec4 backend, we have a vec4_instruction::urb_write_flags field. There are many kinds of flags for SIMD4x2 messages. However, there are really only two (per-slot offset, use channel masks) for SIMD8 messages. Rather than adding a boolean flag for per-slot offsets (polluting all instruction

Re: [Mesa-dev] [PATCH shader-db 2/3] docs: Improve dependencies documentation

2015-10-12 Thread Kenneth Graunke
On Sunday, October 11, 2015 04:30:13 PM Rhys Kidd wrote: > Signed-off-by: Rhys Kidd > --- > README | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/README b/README > index e301d0e..6ed3244 100644 > --- a/README > +++ b/README > @@ -47,7 +47,18 @@ ST_DEBUG=pr

Re: [Mesa-dev] [PATCH shader-db] check_dependencies: refactor to a python script

2015-10-12 Thread Dylan Baker
On Sat, Oct 10, 2015 at 06:45:08PM +1100, Rhys Kidd wrote: > Deliver consistency with all other shader-db scripts, which are Python > scripts. > > No change in features or output strings. > > Passed pep8, except for two comment lines suggesting commands to add > dependencies to the [require] sec

Re: [Mesa-dev] llvmpipe broken on Skylake Pentium (LP_NATIVE_VECTOR_WIDTH=128)

2015-10-12 Thread Roland Scheidegger
Am 12.10.2015 um 22:47 schrieb Adam Jackson: > On Mon, 2015-10-12 at 21:57 +0200, Roland Scheidegger wrote: > >> Note that the vector width doesn't really control if avx is used or not, >> since that's a decision which llvm does on its own (we do set it >> manually if we detect avx on our own, but

Re: [Mesa-dev] llvmpipe broken on Skylake Pentium (LP_NATIVE_VECTOR_WIDTH=128)

2015-10-12 Thread Adam Jackson
On Mon, 2015-10-12 at 21:57 +0200, Roland Scheidegger wrote: > Note that the vector width doesn't really control if avx is used or not, > since that's a decision which llvm does on its own (we do set it > manually if we detect avx on our own, but llvm will use avx anyway even > if we don't if it t

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Roland Scheidegger
Am 12.10.2015 um 21:41 schrieb Roland Scheidegger: > Am 12.10.2015 um 20:33 schrieb Rob Clark: >> On Mon, Oct 12, 2015 at 2:22 PM, Matt Turner wrote: >>> On Mon, Oct 12, 2015 at 11:12 AM, Rob Clark wrote: On Mon, Oct 12, 2015 at 12:47 AM, Jason Ekstrand wrote: >>> +/** >>> + *

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Rob Clark
On Mon, Oct 12, 2015 at 3:41 PM, Roland Scheidegger wrote: > Am 12.10.2015 um 20:33 schrieb Rob Clark: >> On Mon, Oct 12, 2015 at 2:22 PM, Matt Turner wrote: >>> On Mon, Oct 12, 2015 at 11:12 AM, Rob Clark wrote: On Mon, Oct 12, 2015 at 12:47 AM, Jason Ekstrand wrote: >>> +/** >>

Re: [Mesa-dev] [PATCH v2 6/7] radeonsi: Add DCC decompress.

2015-10-12 Thread Axel Davy
On 12/10/2015 17:05, Bas Nieuwenhuizen wrote: Hi Marek, Thanks for the quick review. I do not think I understand the sharing semantics. We currently have fast clear for scanout surfaces with the CMASK and eliminate it on flush resource. I would think we could do that similarly with DCC fast cle

Re: [Mesa-dev] llvmpipe broken on Skylake Pentium (LP_NATIVE_VECTOR_WIDTH=128)

2015-10-12 Thread Roland Scheidegger
Am 12.10.2015 um 21:57 schrieb Roland Scheidegger: > Am 12.10.2015 um 21:27 schrieb Adam Jackson: >> I'm having some difficulty getting llvmpipe working on a Skylake >> Pentium, which has the charming property of not having AVX support at >> all (Skylake Cores have AVX2, and Xeons have AVX512, but

Re: [Mesa-dev] llvmpipe broken on Skylake Pentium (LP_NATIVE_VECTOR_WIDTH=128)

2015-10-12 Thread Roland Scheidegger
Am 12.10.2015 um 21:27 schrieb Adam Jackson: > I'm having some difficulty getting llvmpipe working on a Skylake > Pentium, which has the charming property of not having AVX support at > all (Skylake Cores have AVX2, and Xeons have AVX512, but Pentium seems > to be the new way of spelling Celeron).

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Roland Scheidegger
Am 12.10.2015 um 20:33 schrieb Rob Clark: > On Mon, Oct 12, 2015 at 2:22 PM, Matt Turner wrote: >> On Mon, Oct 12, 2015 at 11:12 AM, Rob Clark wrote: >>> On Mon, Oct 12, 2015 at 12:47 AM, Jason Ekstrand >>> wrote: >> +/** >> + * Convert a 2-byte half float to a 4-byte float. >> + *

Re: [Mesa-dev] llvmpipe broken on Skylake Pentium (LP_NATIVE_VECTOR_WIDTH=128)

2015-10-12 Thread Ilia Mirkin
On Mon, Oct 12, 2015 at 3:27 PM, Adam Jackson wrote: > I'm having some difficulty getting llvmpipe working on a Skylake > Pentium, which has the charming property of not having AVX support at > all (Skylake Cores have AVX2, and Xeons have AVX512, but Pentium seems Sounds an awful lot like what I

[Mesa-dev] llvmpipe broken on Skylake Pentium (LP_NATIVE_VECTOR_WIDTH=128)

2015-10-12 Thread Adam Jackson
I'm having some difficulty getting llvmpipe working on a Skylake Pentium, which has the charming property of not having AVX support at all (Skylake Cores have AVX2, and Xeons have AVX512, but Pentium seems to be the new way of spelling Celeron). Currently I'm trying this with llvm 3.6.2 and Mesa 1

[Mesa-dev] [PATCH] glsl: move half<->float convertion to util

2015-10-12 Thread Rob Clark
From: Rob Clark Needed in NIR too, so move out of mesa/main/imports.c Signed-off-by: Rob Clark --- src/glsl/Makefile.am | 1 + src/glsl/ir_constant_expression.cpp | 1 + src/glsl/nir/nir_constant_expressions.py | 1 + src/mesa/drivers/dri/i965/brw_

Re: [Mesa-dev] [PATCH 2/6] glsl: move builtin types to glsl_types.cpp

2015-10-12 Thread Rob Clark
On Mon, Oct 12, 2015 at 12:50 AM, Jason Ekstrand wrote: > Can we tweak the commit message a bit: > > glsl: move builtin vector types to glsl_types.cpp > > builtin_types.CPP contains a lot more than just vec4_type and friends and > you're not moving all of them. ok, updated the commit msg[1] (but

Re: [Mesa-dev] [PATCH] android: build i965_compile_FILES sources

2015-10-12 Thread Mauro Rossi
The response is in the first line of the of the patch motivations, the build error affects lollipop-x86 build and it would have affected marshmallow-x86 too, if not addressed. There is still no solution for the fonts problems Mauro Il giorno lunedì 12 ottobre 2015 14:15:51 UTC+2, Florian Wiede

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Rob Clark
On Mon, Oct 12, 2015 at 2:22 PM, Matt Turner wrote: > On Mon, Oct 12, 2015 at 11:12 AM, Rob Clark wrote: >> On Mon, Oct 12, 2015 at 12:47 AM, Jason Ekstrand >> wrote: > +/** > + * Convert a 2-byte half float to a 4-byte float. > + * Based on code from: > + * http://www.openg

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Matt Turner
On Mon, Oct 12, 2015 at 11:12 AM, Rob Clark wrote: > On Mon, Oct 12, 2015 at 12:47 AM, Jason Ekstrand wrote: >>> > +/** >>> > + * Convert a 2-byte half float to a 4-byte float. >>> > + * Based on code from: >>> > + * http://www.opengl.org/discussion_boards/ubb/Forum3/HTML/008786.html >>> > + */ >

[Mesa-dev] [Bug 92361] [BSW SKL] Regression: glx@glx-copy-sub-buffer failed

2015-10-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92361 Mark Janes changed: What|Removed |Added Status|NEW |NEEDINFO Assignee|mesa-dev@lists.

Re: [Mesa-dev] [PATCH 3/6] glsl: move half<->float convertion to util

2015-10-12 Thread Rob Clark
On Mon, Oct 12, 2015 at 12:47 AM, Jason Ekstrand wrote: >> > +/** >> > + * Convert a 2-byte half float to a 4-byte float. >> > + * Based on code from: >> > + * http://www.opengl.org/discussion_boards/ubb/Forum3/HTML/008786.html >> > + */ >> > +static inline float >> > +_mesa_half_to_float(GLhalfAR

Re: [Mesa-dev] [PATCH 8/9] glsl: In later GLSL versions, sequence operator is cannot be a constant expression

2015-10-12 Thread Ian Romanick
On 10/09/2015 07:14 PM, Matt Turner wrote: > On Fri, Oct 9, 2015 at 6:53 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Fixes: >> ES3-CTS.shaders.negative.constant_sequence >> >> spec/glsl-es-3.00/compiler/global-initializer/from-sequence.vert >> spec/glsl-es-3.00/compiler/global

Re: [Mesa-dev] [PATCH 2/9] ff_fragment_shader: Use binding to set the sampler unit

2015-10-12 Thread Ian Romanick
On 10/09/2015 07:03 PM, Matt Turner wrote: > On Fri, Oct 9, 2015 at 6:52 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> This is the way layout(binding=xxx) works from GLSL. The old method >> just happened to work (and significantly predated support for >> layout(binding=xxx)), but future ch

Re: [Mesa-dev] [PATCH 1/9] glsl: Allow built-in functions as constant expressions in OpenGL ES 1.00

2015-10-12 Thread Ian Romanick
On 10/09/2015 07:01 PM, Matt Turner wrote: > On Fri, Oct 9, 2015 at 6:52 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> In d4a24745 (August 2012), Paul made functions calls not be constant >> expressions in GLSL ES 1.00. Since this feature was added in desktop >> GLSL 1.20, we believed that

Re: [Mesa-dev] [PATCH] mesa: use gl_shader_variable in program resource list WIP

2015-10-12 Thread Tapani Pälli
On 10/09/2015 07:25 PM, Marek Olšák wrote: Hi, I like the idea. I started working on this too, but stopped because of other things: http://cgit.freedesktop.org/~mareko/mesa/commit/?id=d5266d5c22ba798c105b95c8f227faf8f04718af Cool, then I will pursue this way. Marek On Fri, Oct 9, 2015 at 7:

[Mesa-dev] [PATCH] Fix the incorrect path of sse_minmax.c

2015-10-12 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang --- src/mesa/Android.libmesa_dricore.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/Android.libmesa_dricore.mk b/src/mesa/Android.libmesa_dricore.mk index 2e308b8..fef76c8 100644 --- a/src/mesa/Android.libmesa_dricore.mk +++ b/src/me

Re: [Mesa-dev] [PATCH v2 6/7] radeonsi: Add DCC decompress.

2015-10-12 Thread Bas Nieuwenhuizen
Hi Marek, Thanks for the quick review. I do not think I understand the sharing semantics. We currently have fast clear for scanout surfaces with the CMASK and eliminate it on flush resource. I would think we could do that similarly with DCC fast clear. Both require a flush_resource after modifyin

Re: [Mesa-dev] [PATCH v2 7/7] radeonsi: Add DCC compression tracking machinery.

2015-10-12 Thread Marek Olšák
On Sun, Oct 11, 2015 at 5:38 PM, Bas Nieuwenhuizen wrote: > Add a mask to track if a texture level is still in its decompressed > state or that we would need to decompress again. I think you can drop this patch. I described to plan the support DCC with shared textures at patch 6. For image store

Re: [Mesa-dev] [PATCH 3/3] nir: Add helpers for creating variables and adding them to lists

2015-10-12 Thread Jason Ekstrand
On Oct 12, 2015 1:26 AM, "Iago Toral" wrote: > > On Fri, 2015-10-09 at 07:09 -0700, Jason Ekstrand wrote: > > --- > > src/glsl/nir/glsl_to_nir.cpp | 40 - > > src/glsl/nir/nir.c | 66 ++ > > src/glsl/nir/nir.h

Re: [Mesa-dev] [PATCH 2/2] r600/vce: enable VCE for trinity/richland

2015-10-12 Thread Alex Deucher
On Mon, Oct 12, 2015 at 4:53 AM, Christian König wrote: > From: Christian König > > Signed-off-by: Christian König For the series: Reviewed-by: Alex Deucher > --- > src/gallium/drivers/r600/r600_uvd.c | 22 +- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --g

Re: [Mesa-dev] [PATCH v2 0/7] Add DCC Support.

2015-10-12 Thread Marek Olšák
Patches 5-7 reviewed as well. Marek On Mon, Oct 12, 2015 at 2:46 AM, Marek Olšák wrote: > i've reviewed patches 1-4. I'll try to review the rest tomorrow. > > Marek > > On Sun, Oct 11, 2015 at 5:38 PM, Bas Nieuwenhuizen > wrote: >> These patches enable delta color compression (DCC) for Vulcanic

Re: [Mesa-dev] [PATCH v2 6/7] radeonsi: Add DCC decompress.

2015-10-12 Thread Marek Olšák
On Sun, Oct 11, 2015 at 5:38 PM, Bas Nieuwenhuizen wrote: > This is currently not needed but will be necessary when we have > features that do not work with DCC enabled, such as image stores > and sharing non-scanout surfaces. For shared non-scanout surfaces, the plan is: - allocate DCC as part o

Re: [Mesa-dev] [PATCH] u_vbuf: fix vb slot assignment for translated buffers

2015-10-12 Thread Alex Deucher
On Mon, Oct 12, 2015 at 7:10 AM, Nicolai Hähnle wrote: > On 09.10.2015 23:57, Marek Olšák wrote: >> >> Do you still have commit access and should somebody else push this? > > > I have to figure out how to get somebody to pay attention to > https://bugs.freedesktop.org/show_bug.cgi?id=92281 > > Fee

Re: [Mesa-dev] [mesa-dev, mesa-demos][PATCH] sharedtex_mt: fix rendering thread hang

2015-10-12 Thread Belal, Awais
Hi Brian, Thanks for your reply :) The move of variable definition was just to make the code look a little cleaner. BR, Awais From: Brian Paul [bri...@vmware.com] Sent: Monday, October 12, 2015 6:31 PM To: Belal, Awais; mesa-dev@lists.freedesktop.org Subj

Re: [Mesa-dev] [mesa-dev, mesa-demos][PATCH] sharedtex_mt: fix rendering thread hang

2015-10-12 Thread Brian Paul
On 10/12/2015 05:25 AM, Belal, Awais wrote: Hi, Is there are a reservation against the below patch? Looks OK, but one comment below. BR, Awais From: mesa-dev [mesa-dev-boun...@lists.freedesktop.org] on behalf of Belal, Awais Sent: Thursday, October

Re: [Mesa-dev] [PATCH] llvmpipe: fix fp64 inputs to geom shader.

2015-10-12 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger Am 12.10.2015 um 07:55 schrieb Dave Airlie: > From: Dave Airlie > > This fixes the fetching of fp64 inputs to the geometry shader, > > this fixes the recently posted piglit's > arb_gpu_shader_fp64/execution/gs-fs-vs-double-array.shader_test > arb_vertex_attrib_

Re: [Mesa-dev] Plan to work on opt_peephole_sel optimization for vec4

2015-10-12 Thread Francisco Jerez
Antía Puentes writes: > Hi Matt, > > thanks for your suggestions. > > On dom, 2015-10-11 at 10:35 -0700, Matt Turner wrote: >> I don't believe it's valuable to port the opt_peephole_sel() pass to >> the vec4 backend. With NIR (since NIR essentially performs the same >> optimization), the opt_peep

[Mesa-dev] [Bug 92437] osmesa: Expose GL entry points for Windows build, via .def file

2015-10-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92437 --- Comment #1 from Nigel Stewart --- See also: https://github.com/nigels-com/glew/pull/25 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___

[Mesa-dev] [Bug 92437] osmesa: Expose GL entry points for Windows build, via .def file

2015-10-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92437 Nigel Stewart changed: What|Removed |Added CC||nigels@gmail.com -- You are receivi

[Mesa-dev] [Bug 92437] osmesa: Expose GL entry points for Windows build, via .def file

2015-10-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92437 Bug ID: 92437 Summary: osmesa: Expose GL entry points for Windows build, via .def file Product: Mesa Version: 11.0 Hardware: All OS: All Status:

Re: [Mesa-dev] [RFC] i965: Resolve color for all active shader images in intel_update_state().

2015-10-12 Thread Francisco Jerez
Chris Wilson writes: > On Sat, Oct 03, 2015 at 05:57:05PM +0300, Francisco Jerez wrote: >> Jordan Justen writes: >> >> > From: Francisco Jerez >> > >> > Fixes >> > arb_shader_image_load_store/execution/load-from-cleared-image.shader_test >> > >> > Cc: Chris Wilson >> > Cc: Jason Ekstrand >>

[Mesa-dev] [PATCH shader-db v2 1/3] Makefile: avoid undefined reference build errors

2015-10-12 Thread Rhys Kidd
Signed-off-by: Rhys Kidd --- v2: Adopt alternative approach to replace LDFLAGS with LDLIBS per discussion with Matt Turner Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 1ae0776..9422b32 100644 --- a/Makefile +++ b/Makefile @@ -21,7 +21,7

Re: [Mesa-dev] [mesa-dev, mesa-demos][PATCH] sharedtex_mt: fix rendering thread hang

2015-10-12 Thread Belal, Awais
Hi, Is there are a reservation against the below patch? BR, Awais From: mesa-dev [mesa-dev-boun...@lists.freedesktop.org] on behalf of Belal, Awais Sent: Thursday, October 08, 2015 2:00 PM To: mesa-dev@lists.freedesktop.org Subject: [Mesa-dev] [mesa-dev,

Re: [Mesa-dev] [PATCH] u_vbuf: fix vb slot assignment for translated buffers

2015-10-12 Thread Nicolai Hähnle
On 09.10.2015 23:57, Marek Olšák wrote: Do you still have commit access and should somebody else push this? I have to figure out how to get somebody to pay attention to https://bugs.freedesktop.org/show_bug.cgi?id=92281 Feel free to push this in the meantime; otherwise I'll eventually do it

Re: [Mesa-dev] Plan to work on opt_peephole_sel optimization for vec4

2015-10-12 Thread Antía Puentes
Hi Matt, thanks for your suggestions. On dom, 2015-10-11 at 10:35 -0700, Matt Turner wrote: > I don't believe it's valuable to port the opt_peephole_sel() pass to > the vec4 backend. With NIR (since NIR essentially performs the same > optimization), the opt_peephole_sel() pass only improves code

[Mesa-dev] [PATCH 1/2] r600/uvd: disable UVD tiling by default

2015-10-12 Thread Christian König
From: Christian König It has only minimal advantages for post processing and doesn't work with VCE. Signed-off-by: Christian König --- src/gallium/drivers/r600/r600_uvd.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/r600/r600_uvd.c b/src/gall

[Mesa-dev] [PATCH 2/2] r600/vce: enable VCE for trinity/richland

2015-10-12 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/drivers/r600/r600_uvd.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_uvd.c b/src/gallium/drivers/r600/r600_uvd.c index 3a94a5a..e2e9033 100644 --- a/

Re: [Mesa-dev] [PATCH 2/3] nir/prog: Use nir_foreach_variable

2015-10-12 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Fri, 2015-10-09 at 07:09 -0700, Jason Ekstrand wrote: > --- > src/mesa/program/prog_to_nir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/program/prog_to_nir.c b/src/mesa/program/prog_to_nir.c > index fc00534..d9b1854 10064

Re: [Mesa-dev] [PATCH shader-db 0/3] Makefile and documentation cleanup

2015-10-12 Thread Rhys Kidd
On 12 October 2015 at 12:09, Matt Turner wrote: > On Sun, Oct 11, 2015 at 4:18 PM, Rhys Kidd wrote: > > On Sunday, 11 October 2015, Matt Turner wrote: > >> > >> On Sat, Oct 10, 2015 at 10:30 PM, Rhys Kidd wrote: > >> > Patchset adds Makefile and documentation improvements. > >> > > >> > I aime

Re: [Mesa-dev] [PATCH 3/3] nir: Add helpers for creating variables and adding them to lists

2015-10-12 Thread Iago Toral
On Fri, 2015-10-09 at 07:09 -0700, Jason Ekstrand wrote: > --- > src/glsl/nir/glsl_to_nir.cpp | 40 - > src/glsl/nir/nir.c | 66 > ++ > src/glsl/nir/nir.h | 20 + > src/mesa/program/prog_to_nir.c

  1   2   >