Re: [Mesa-dev] [PATCH 2/2] radeonsi: Add CIK SDMA support

2015-05-26 Thread Michel Dänzer
On 27.05.2015 04:29, Grigori Goronzy wrote: > On 26.05.2015 09:28, Michel Dänzer wrote: >> From: Michel Dänzer >> >> Based on the corresponding SI support. Same as that, this is currently >> only enabled for one-dimensional buffer copies due to issues with >> multi-dimensional SDMA copies. >> > >

[Mesa-dev] [Bug 90669] make check DispatchSanity_test.GLES3 regression

2015-05-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90669 Ian Romanick changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Mesa-dev] [PATCH] gallivm: Do not use NoFramePointerElim with LLVM 3.7

2015-05-26 Thread Vinson Lee
TargetOptions::NoFramePointerElim was removed in llvm-3.7.0svn r238244 "Remove NoFramePointerElim and NoFramePointerElimOverride from TargetOptions and remove ExecutionEngine's dependence on CodeGen. NFC." Signed-off-by: Vinson Lee --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 2 ++ src/g

Re: [Mesa-dev] [PATCH 1/2] configure.ac: enable building GLES1 and GLES2 by default

2015-05-26 Thread Dave Airlie
On 26 May 2015 at 22:08, Marek Olšák wrote: > It's mainly for distributions. You can turn it off, but it won't make > the build faster, because all code is shared. we (fedora/rhel) don't enable GLES1, and hope nobody else wants to either. gles2 is fine, leave gles1 die. Dave. ___

Re: [Mesa-dev] [PATCH 1/2] configure.ac: enable building GLES1 and GLES2 by default

2015-05-26 Thread Tapani
On 05/26/2015 03:08 PM, Marek Olšák wrote: It's mainly for distributions. You can turn it off, but it won't make the build faster, because all code is shared. Right, then seems good move to me. Marek On Tue, May 26, 2015 at 1:26 PM, Tapani Pälli wrote: On 05/26/2015 01:57 PM, Marek Olšák w

Re: [Mesa-dev] [PATCH] softpipe: fix offset wrapping calculations

2015-05-26 Thread Roland Scheidegger
Thanks for addressing this, some minor issues. Am 27.05.2015 um 03:14 schrieb Dave Airlie: > Roland pointed out my previous attempt was lacking, so I enhanced the > texwrap piglit test, and tested them. This fixes the offset calculations > in a number of areas by adding the offset first, it also f

[Mesa-dev] [PATCH] softpipe: fix offset wrapping calculations

2015-05-26 Thread Dave Airlie
Roland pointed out my previous attempt was lacking, so I enhanced the texwrap piglit test, and tested them. This fixes the offset calculations in a number of areas by adding the offset first, it also fixes the fastpaths, which I forgot to address in the previous commit. Signed-off-by: Dave Airlie

Re: [Mesa-dev] [Mesa-stable] [PATCH] glapi: Encapsulate nop table knowledge in new _mesa_new_nop_table function

2015-05-26 Thread Brian Paul
On 05/26/2015 05:56 PM, Ian Romanick wrote: From: Ian Romanick Encapsulate the knowledge about how to build the nop table in a new _mesa_new_nop_table function. This makes it easier for dispatch_sanity to keep working now and in the future. Signed-off-by: Ian Romanick Cc: Brian Paul Cc: Emi

Re: [Mesa-dev] [PATCH] egl: return EGL_BAD_ALLOC if _eglConvertAttribsToInt fails

2015-05-26 Thread Emil Velikov
On 27 May 2015 at 01:40, Marek Olšák wrote: > On Wed, May 27, 2015 at 3:20 AM, Emil Velikov > wrote: >> On 27/05/15 00:12, Marek Olšák wrote: >>> On Wed, May 27, 2015 at 3:07 AM, Emil Velikov >>> wrote: On 26/05/15 21:59, Marek Olšák wrote: > From: Marek Olšák > > This is a f

Re: [Mesa-dev] [PATCH] egl: return EGL_BAD_ALLOC if _eglConvertAttribsToInt fails

2015-05-26 Thread Marek Olšák
On Wed, May 27, 2015 at 3:20 AM, Emil Velikov wrote: > On 27/05/15 00:12, Marek Olšák wrote: >> On Wed, May 27, 2015 at 3:07 AM, Emil Velikov >> wrote: >>> On 26/05/15 21:59, Marek Olšák wrote: From: Marek Olšák This is a fix for the EGL 1.5 patch series. >>> Can you squash this

Re: [Mesa-dev] [PATCH 2/2] configure.ac: enable building the EGL DRM platform by default

2015-05-26 Thread Emil Velikov
Hmm ./autogen.sh --with-gallium-drivers=radeonsi --enable-egl --enable-gbm seems to work fine here. Although... if I drop the --enable-gbm it complains "EGL platform drm needs gbm", which is an entirely different kettle of fish. Fwiw I would opt to just enable gbm on supported platforms (everyth

Re: [Mesa-dev] [PATCH] egl: return EGL_BAD_ALLOC if _eglConvertAttribsToInt fails

2015-05-26 Thread Emil Velikov
On 27/05/15 00:12, Marek Olšák wrote: > On Wed, May 27, 2015 at 3:07 AM, Emil Velikov > wrote: >> On 26/05/15 21:59, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> This is a fix for the EGL 1.5 patch series. >> Can you squash this with the offending patches (12 and 13). Pretty >> please :-) >>

[Mesa-dev] [Bug 90669] make check DispatchSanity_test.GLES3 regression

2015-05-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90669 Ian Romanick changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |i...@freedesktop.org |o

[Mesa-dev] [Bug 90669] make check DispatchSanity_test.GLES3 regression

2015-05-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90669 Ian Romanick changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Ian Romanick

Re: [Mesa-dev] [PATCH] egl: return EGL_BAD_ALLOC if _eglConvertAttribsToInt fails

2015-05-26 Thread Marek Olšák
On Wed, May 27, 2015 at 3:07 AM, Emil Velikov wrote: > On 26/05/15 21:59, Marek Olšák wrote: >> From: Marek Olšák >> >> This is a fix for the EGL 1.5 patch series. > Can you squash this with the offending patches (12 and 13). Pretty > please :-) > >> --- >> src/egl/main/eglapi.c | 25 +++

Re: [Mesa-dev] [PATCH] egl: return EGL_BAD_ALLOC if _eglConvertAttribsToInt fails

2015-05-26 Thread Emil Velikov
On 26/05/15 21:59, Marek Olšák wrote: > From: Marek Olšák > > This is a fix for the EGL 1.5 patch series. Can you squash this with the offending patches (12 and 13). Pretty please :-) > --- > src/egl/main/eglapi.c | 25 +++-- > 1 file changed, 19 insertions(+), 6 deletions(-

Re: [Mesa-dev] [PATCH] glapi: Encapsulate nop table knowledge in new _mesa_new_nop_table function

2015-05-26 Thread Emil Velikov
On 26/05/15 23:56, Ian Romanick wrote: > From: Ian Romanick > > Encapsulate the knowledge about how to build the nop table in a new > _mesa_new_nop_table function. This makes it easier for dispatch_sanity > to keep working now and in the future. > > Signed-off-by: Ian Romanick > Cc: Brian Paul

[Mesa-dev] [PATCH] glapi: Encapsulate nop table knowledge in new _mesa_new_nop_table function

2015-05-26 Thread Ian Romanick
From: Ian Romanick Encapsulate the knowledge about how to build the nop table in a new _mesa_new_nop_table function. This makes it easier for dispatch_sanity to keep working now and in the future. Signed-off-by: Ian Romanick Cc: Brian Paul Cc: Emil Velikov Cc: 10.6 --- I sent this just a fe

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-26 Thread Mark Janes
This patch fixes `make check` for me, but v2 has been pushed, so... Who gets to make a patch to fix master? Tested-by: Mark Janes Ian Romanick writes: > From: Brian Paul > > Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and > _glapi_set_nop_handler() functions in the glapi dispat

[Mesa-dev] [Bug 90669] make check DispatchSanity_test.GLES3 regression

2015-05-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90669 Vinson Lee changed: What|Removed |Added Version|10.6|git -- You are receiving this mail because

[Mesa-dev] [Bug 90669] make check DispatchSanity_test.GLES3 regression

2015-05-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90669 Bug ID: 90669 Summary: make check DispatchSanity_test.GLES3 regression Product: Mesa Version: 10.6 Hardware: All OS: Linux (All) Status: NEW Keywords: bis

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] glsl: validate sampler array indexing for 'constant-index-expression'

2015-05-26 Thread Francisco Jerez
Ian Romanick writes: > On 05/26/2015 02:04 PM, Francisco Jerez wrote: >> Ian Romanick writes: >> >>> On 05/26/2015 02:53 AM, Tapani Pälli wrote: Hello; I'd like to ping if this approach would be ok. We've had some discussions with Curro about it and overall it would seem nic

Re: [Mesa-dev] [PATCH] radeon/llvm: don't use a static array size for radeon_llvm_context::arrays

2015-05-26 Thread Marek Olšák
On Wed, May 27, 2015 at 12:39 AM, Jan Vesely wrote: > On Wed, 2015-05-27 at 00:36 +0200, Marek Olšák wrote: >> On Tue, May 26, 2015 at 10:19 PM, Emil Velikov >> wrote: >> > On 26/05/15 14:04, Marek Olšák wrote: >> >> From: Marek Olšák >> >> >> >> --- >> >> src/gallium/drivers/radeon/radeon_llv

Re: [Mesa-dev] [PATCH 2/3] glsl_to_tgsi: don't use a static array size for st_translate::arrays

2015-05-26 Thread Marek Olšák
On Tue, May 26, 2015 at 10:15 PM, Emil Velikov wrote: > On 26/05/15 14:04, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 17 + >> 1 file changed, 9 insertions(+), 8 deletions(-) >> >> diff --git a/src/mesa/state_tracker/st_glsl_

Re: [Mesa-dev] [PATCH] radeon/llvm: don't use a static array size for radeon_llvm_context::arrays

2015-05-26 Thread Jan Vesely
On Wed, 2015-05-27 at 00:36 +0200, Marek Olšák wrote: > On Tue, May 26, 2015 at 10:19 PM, Emil Velikov > wrote: > > On 26/05/15 14:04, Marek Olšák wrote: > >> From: Marek Olšák > >> > >> --- > >> src/gallium/drivers/radeon/radeon_llvm.h| 5 ++--- > >> src/gallium/drivers/radeon/rad

Re: [Mesa-dev] [PATCH] radeon/llvm: don't use a static array size for radeon_llvm_context::arrays

2015-05-26 Thread Marek Olšák
On Tue, May 26, 2015 at 10:19 PM, Emil Velikov wrote: > On 26/05/15 14:04, Marek Olšák wrote: >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeon/radeon_llvm.h| 5 ++--- >> src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 15 +++ >> 2 files changed, 13 inse

[Mesa-dev] [PATCH 1/2] radeon/llvm: don't use a static array size for radeon_llvm_context::arrays (v2)

2015-05-26 Thread Marek Olšák
From: Marek Olšák v2: - don't use realloc (tgsi_shader_info provides the size) --- src/gallium/drivers/radeon/radeon_llvm.h| 4 +--- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 15 +++ 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/gallium/

[Mesa-dev] [PATCH 2/2] radeon/llvm: reset temps_count on deallocation

2015-05-26 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c index 4983667..c8c980d 100644 --- a/src/gallium/drivers/radeon/

[Mesa-dev] [PATCH] egl: return EGL_BAD_ALLOC if _eglConvertAttribsToInt fails

2015-05-26 Thread Marek Olšák
From: Marek Olšák This is a fix for the EGL 1.5 patch series. --- src/egl/main/eglapi.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 7afc091..3df4968 100644 --- a/src/egl/main/eglapi.c +++ b/src

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] glsl: validate sampler array indexing for 'constant-index-expression'

2015-05-26 Thread Ian Romanick
On 05/26/2015 02:04 PM, Francisco Jerez wrote: > Ian Romanick writes: > >> On 05/26/2015 02:53 AM, Tapani Pälli wrote: >>> Hello; >>> >>> I'd like to ping if this approach would be ok. We've had some >>> discussions with Curro about it and overall it would seem nicer to move >>> this check to hap

Re: [Mesa-dev] [PATCH 2/2] configure.ac: enable building the EGL DRM platform by default

2015-05-26 Thread Marek Olšák
No, it doesn't work. If I just add "drm" to the defaults and not use --with-egl-platforms in the terminal, it fails with the message that radeonsi requires drm. :) Marek On Tue, May 26, 2015 at 10:30 PM, Emil Velikov wrote: > On 26/05/15 10:57, Marek Olšák wrote: >> From: Marek Olšák >> >> This

Re: [Mesa-dev] [PATCH 1/3] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-26 Thread Brian Paul
On 05/26/2015 02:03 PM, Jose Fonseca wrote: On 25/05/15 15:41, Brian Paul wrote: If the glPushAttrib() mask value was zero we didn't actually push anything onto the attribute stack. A subsequent glPopAttrib() call would generate a GL_STACK_UNDERFLOW error. Now push a dummy attribute in that ca

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] glsl: validate sampler array indexing for 'constant-index-expression'

2015-05-26 Thread Francisco Jerez
Ian Romanick writes: > On 05/26/2015 02:53 AM, Tapani Pälli wrote: >> Hello; >> >> I'd like to ping if this approach would be ok. We've had some >> discussions with Curro about it and overall it would seem nicer to move >> this check to happen at compile time. However, this seems quite a >> prob

[Mesa-dev] [PATCH] docs: Fix some typos in the developer notes

2015-05-26 Thread Thomas Helland
26. mai 2015 20.19 skrev "Brian Paul" : > > On 05/26/2015 12:14 PM, Thomas Helland wrote: >> >> Found when double-checking my review on Brian's series. >> >> Signed-off-by: Thomas Helland >> --- >> docs/devinfo.html | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a

Re: [Mesa-dev] [PATCH 2/2] glsl: validate sampler array indexing for 'constant-index-expression'

2015-05-26 Thread Ian Romanick
On 05/26/2015 02:53 AM, Tapani Pälli wrote: > Hello; > > I'd like to ping if this approach would be ok. We've had some > discussions with Curro about it and overall it would seem nicer to move > this check to happen at compile time. However, this seems quite a > problematic move. I'll try explain

Re: [Mesa-dev] [PATCH 1/3] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-26 Thread Jose Fonseca
On 25/05/15 15:41, Brian Paul wrote: If the glPushAttrib() mask value was zero we didn't actually push anything onto the attribute stack. A subsequent glPopAttrib() call would generate a GL_STACK_UNDERFLOW error. Now push a dummy attribute in that case to prevent the error. Mesa now matches nv

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Add CIK SDMA support

2015-05-26 Thread Alex Deucher
On Tue, May 26, 2015 at 3:29 PM, Grigori Goronzy wrote: > On 26.05.2015 09:28, Michel Dänzer wrote: >> From: Michel Dänzer >> >> Based on the corresponding SI support. Same as that, this is currently >> only enabled for one-dimensional buffer copies due to issues with >> multi-dimensional SDMA co

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Add CIK SDMA support

2015-05-26 Thread Marek Olšák
I suggest we implement a thorough SDMA test first before trying to fix it. We definitely want to test all implemented tiling modes, dimensions, subrectangles of those (for the copies), bit depths, number of samples, etc. and some of those parameters can differ between src and dst. The list of teste

Re: [Mesa-dev] [PATCH 1/3] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-26 Thread Emil Velikov
On 26/05/15 19:11, Brian Paul wrote: > On 05/26/2015 02:05 PM, Emil Velikov wrote: >> On 25/05/15 14:41, Brian Paul wrote: >>> If the glPushAttrib() mask value was zero we didn't actually push >>> anything onto the attribute stack. A subsequent glPopAttrib() call >>> would generate a GL_STACK_UNDE

[Mesa-dev] [PATCH 3/5] dri_util: Use _mesa_override_gl_version_contextless

2015-05-26 Thread Ian Romanick
From: Ian Romanick Remove _mesa_get_gl_version_override. We don't need two functions that do basically the same thing. This change seemed easier (esp. with the next patch) than going the other way. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/common/dri_util.c | 18 +++---

[Mesa-dev] [PATCH 4/5] mesa: Add support for a new override string MESA_GLES_VERSION_OVERRIDE

2015-05-26 Thread Ian Romanick
From: Ian Romanick The string is only applied when the context is API_OPENGLES2. The bulk of the change is to prevent overriding the context to API_OPENGL_CORE based on the requested version. If the context is API_OPENGL_ES2, don't change it. Signed-off-by: Ian Romanick --- src/mesa/main/ver

[Mesa-dev] [PATCH 1/5] gles/es3.1: Enable dispatch of almost all new GLES 3.1 functions

2015-05-26 Thread Ian Romanick
From: Ian Romanick A couple functions are missing because there are no implementations of them yet. These are: glFramebufferParameteri (from GL_ARB_framebuffer_no_attachments) glGetFramebufferParameteriv (from GL_ARB_framebuffer_no_attachments) glMemoryBarrierByRegion v2: Reb

[Mesa-dev] [PATCH 2/5] mesa/es3.1: Enable ES 3.1 API and shading language version

2015-05-26 Thread Ian Romanick
From: Ian Romanick This is a bit of a hack for now. Several of the extensions required for OpenGL ES 3.1 have no support, at all, in Mesa. However, with this patch and a patch to allow MESA_GL_VERSION_OVERRIDE to work with ES contexts, people can begin testing the ES "version" of the functional

[Mesa-dev] [PATCH 0/5] Remainder of GLES3.1 foundation work

2015-05-26 Thread Ian Romanick
The first two patches are just re-re-sends of the same patches. Based on feedback from Emil and others, I changed the later patches to use a new environment variable, MESA_GLES_VERSION_OVERRIDE, to override GLES versions. I considered naming this MESA_GLES2_VERSION_OVERRIDE so that we could later

[Mesa-dev] [PATCH 5/5] mesa: Allow overriding the version of ES2+ contexts

2015-05-26 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/common/dri_util.c | 4 src/mesa/main/context.c| 4 +--- src/mesa/state_tracker/st_manager.c| 3 +-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/common/dri_uti

Re: [Mesa-dev] [PATCH 2/2] configure.ac: enable building the EGL DRM platform by default

2015-05-26 Thread Emil Velikov
On 26/05/15 10:57, Marek Olšák wrote: > From: Marek Olšák > > This is required by radeonsi. > > The code was moved because with_egl_platforms was used before > the default was set. > --- > configure.ac | 21 ++--- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --g

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Add CIK SDMA support

2015-05-26 Thread Grigori Goronzy
On 26.05.2015 09:28, Michel Dänzer wrote: > From: Michel Dänzer > > Based on the corresponding SI support. Same as that, this is currently > only enabled for one-dimensional buffer copies due to issues with > multi-dimensional SDMA copies. > What a pity, so CIK has exactly the same issues as SI?

Re: [Mesa-dev] [PATCH 1/2] configure.ac: enable building GLES1 and GLES2 by default

2015-05-26 Thread Emil Velikov
On 26/05/15 10:57, Marek Olšák wrote: > From: Marek Olšák > > No particular reason other than most people should always build this. Yes please. Personally I've not seen any noticable increase in the build time, plus anyone is welcome to disable it as they please. If you need to go for the defaul

Re: [Mesa-dev] [PATCH] radeon/llvm: don't use a static array size for radeon_llvm_context::arrays

2015-05-26 Thread Emil Velikov
On 26/05/15 14:04, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/drivers/radeon/radeon_llvm.h| 5 ++--- > src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 15 +++ > 2 files changed, 13 insertions(+), 7 deletions(-) > > diff --git a/src/gallium/driver

Re: [Mesa-dev] [PATCH 2/3] glsl_to_tgsi: don't use a static array size for st_translate::arrays

2015-05-26 Thread Emil Velikov
On 26/05/15 14:04, Marek Olšák wrote: > From: Marek Olšák > > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp > b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp >

Re: [Mesa-dev] [PATCH 1/3] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-26 Thread Brian Paul
On 05/26/2015 02:05 PM, Emil Velikov wrote: On 25/05/15 14:41, Brian Paul wrote: If the glPushAttrib() mask value was zero we didn't actually push anything onto the attribute stack. A subsequent glPopAttrib() call would generate a GL_STACK_UNDERFLOW error. Now push a dummy attribute in that ca

Re: [Mesa-dev] [PATCH 1/3] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-26 Thread Emil Velikov
On 25/05/15 14:41, Brian Paul wrote: > If the glPushAttrib() mask value was zero we didn't actually push > anything onto the attribute stack. A subsequent glPopAttrib() call > would generate a GL_STACK_UNDERFLOW error. Now push a dummy attribute > in that case to prevent the error. > > Mesa now

Re: [Mesa-dev] [PATCH 01/15] egl: remove unused _egl_global::ClientExtensions

2015-05-26 Thread Emil Velikov
On 23/05/15 12:31, Marek Olšák wrote: > Ping. > > Nobody has given me Reviewed-by for this series yet. > So I went over the spec a couple of times, and the series looks great. Would be nice to hear from someone with more experience in the area but FWIW Patches 1-3, 6-15 (with the ENOMEM check in

Re: [Mesa-dev] [PATCH 3/3] egl: import platform headers from registry (v2)

2015-05-26 Thread Emil Velikov
On 23/05/15 12:09, Marek Olšák wrote: > From: Marek Olšák > > v2: don't remove local Mesa changes I'd say that it's nice to resolve the outstanding diff, to ensure compatibility/portability of the EGL headers. Obviously that can be done as a follow up commit(s) of those interested. For the 3 pat

Re: [Mesa-dev] [PATCH] glapi: Avoid argparse type argument for API XML input files.

2015-05-26 Thread Jose Fonseca
On 26/05/15 19:48, Jose Fonseca wrote: On 26/05/15 19:06, Dylan Baker wrote: On Tue, May 26, 2015 at 11:15:36AM +0100, Jose Fonseca wrote: argparse type is a nice type saver for simple data types, but it doesn't look a good fit for the input XML file: - Certain implementations of argparse (par

Re: [Mesa-dev] [Mesa-stable] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

2015-05-26 Thread Emil Velikov
On 21/05/15 14:31, Boyan Ding wrote: > On 05/16/2015 01:55 AM, Emil Velikov wrote: >> On 09/04/15 16:05, Emil Velikov wrote: >>> Hi Boyan, >>> >>> On 9 April 2015 at 16:08, Boyan Ding wrote: For the same reason as the i965 one, as suggested by Chih-Wei Huang. Cc: "10.4 10.5" S

Re: [Mesa-dev] [PATCH] glapi: Avoid argparse type argument for API XML input files.

2015-05-26 Thread Jose Fonseca
On 26/05/15 19:06, Dylan Baker wrote: On Tue, May 26, 2015 at 11:15:36AM +0100, Jose Fonseca wrote: argparse type is a nice type saver for simple data types, but it doesn't look a good fit for the input XML file: - Certain implementations of argparse (particularly python 2.7.3's) invoke the

Re: [Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-26 Thread Emil Velikov
On 22/05/15 01:15, Brian Paul wrote: > On 05/15/2015 02:28 PM, Emil Velikov wrote: >> On 15/05/15 17:58, Brian Paul wrote: >>> On 05/15/2015 11:14 AM, Emil Velikov wrote: On 15/05/15 15:13, Brian Paul wrote: > Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and > _glapi_set_

Re: [Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-26 Thread Ian Romanick
On 05/26/2015 11:36 AM, Brian Paul wrote: > On 05/26/2015 12:21 PM, Ian Romanick wrote: >> On 05/26/2015 11:17 AM, Brian Paul wrote: >>> On 05/26/2015 12:07 PM, Ian Romanick wrote: On 05/21/2015 06:19 PM, Brian Paul wrote: > Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and >>

Re: [Mesa-dev] [Mesa-stable] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-26 Thread Brian Paul
On 05/26/2015 12:38 PM, Ian Romanick wrote: From: Brian Paul Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and _glapi_set_nop_handler() functions in the glapi dispatcher (which live in libGL.so). The calls to those functions from context.c would be undefined (i.e. an ABI break) if

[Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-26 Thread Ian Romanick
From: Brian Paul Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and _glapi_set_nop_handler() functions in the glapi dispatcher (which live in libGL.so). The calls to those functions from context.c would be undefined (i.e. an ABI break) if the libGL used at runtime was older. For the

Re: [Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-26 Thread Brian Paul
On 05/26/2015 12:21 PM, Ian Romanick wrote: On 05/26/2015 11:17 AM, Brian Paul wrote: On 05/26/2015 12:07 PM, Ian Romanick wrote: On 05/21/2015 06:19 PM, Brian Paul wrote: Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and _glapi_set_nop_handler() functions in the glapi dispatcher

Re: [Mesa-dev] [PATCH] glapi: Avoid argparse type argument for API XML input files.

2015-05-26 Thread Dylan Baker
On Tue, May 26, 2015 at 02:15:37PM -0400, Ilia Mirkin wrote: > On Tue, May 26, 2015 at 2:14 PM, Dylan Baker wrote: > > On Tue, May 26, 2015 at 02:05:41PM -0400, Ilia Mirkin wrote: > >> On Tue, May 26, 2015 at 2:06 PM, Dylan Baker > >> wrote: > >> > On Tue, May 26, 2015 at 11:15:36AM +0100, Jose

Re: [Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-26 Thread Ian Romanick
On 05/26/2015 11:17 AM, Brian Paul wrote: > On 05/26/2015 12:07 PM, Ian Romanick wrote: >> On 05/21/2015 06:19 PM, Brian Paul wrote: >>> Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and >>> _glapi_set_nop_handler() functions in the glapi dispatcher (which >>> live in libGL.so). The c

Re: [Mesa-dev] [PATCH] docs: Fix some typos in the developer notes

2015-05-26 Thread Brian Paul
On 05/26/2015 12:14 PM, Thomas Helland wrote: Found when double-checking my review on Brian's series. Signed-off-by: Thomas Helland --- docs/devinfo.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/devinfo.html b/docs/devinfo.html index f5113b0..3f810e9 10064

Re: [Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-26 Thread Brian Paul
On 05/26/2015 12:07 PM, Ian Romanick wrote: On 05/21/2015 06:19 PM, Brian Paul wrote: Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and _glapi_set_nop_handler() functions in the glapi dispatcher (which live in libGL.so). The calls to those functions from context.c would be undefine

Re: [Mesa-dev] [PATCH] glapi: Avoid argparse type argument for API XML input files.

2015-05-26 Thread Ilia Mirkin
On Tue, May 26, 2015 at 2:14 PM, Dylan Baker wrote: > On Tue, May 26, 2015 at 02:05:41PM -0400, Ilia Mirkin wrote: >> On Tue, May 26, 2015 at 2:06 PM, Dylan Baker wrote: >> > On Tue, May 26, 2015 at 11:15:36AM +0100, Jose Fonseca wrote: >> >> argparse type is a nice type saver for simple data typ

[Mesa-dev] [PATCH] docs: Fix some typos in the developer notes

2015-05-26 Thread Thomas Helland
Found when double-checking my review on Brian's series. Signed-off-by: Thomas Helland --- docs/devinfo.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/devinfo.html b/docs/devinfo.html index f5113b0..3f810e9 100644 --- a/docs/devinfo.html +++ b/docs/devinfo.html

Re: [Mesa-dev] [PATCH] glapi: Avoid argparse type argument for API XML input files.

2015-05-26 Thread Dylan Baker
On Tue, May 26, 2015 at 02:05:41PM -0400, Ilia Mirkin wrote: > On Tue, May 26, 2015 at 2:06 PM, Dylan Baker wrote: > > On Tue, May 26, 2015 at 11:15:36AM +0100, Jose Fonseca wrote: > >> argparse type is a nice type saver for simple data types, but it doesn't > >> look a good fit for the input XML

Re: [Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-26 Thread Ian Romanick
On 05/21/2015 06:19 PM, Brian Paul wrote: > Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and > _glapi_set_nop_handler() functions in the glapi dispatcher (which > live in libGL.so). The calls to those functions from context.c > would be undefined (i.e. an ABI break) if the libGL used

Re: [Mesa-dev] [PATCH] glapi: Avoid argparse type argument for API XML input files.

2015-05-26 Thread Ilia Mirkin
On Tue, May 26, 2015 at 2:06 PM, Dylan Baker wrote: > On Tue, May 26, 2015 at 11:15:36AM +0100, Jose Fonseca wrote: >> argparse type is a nice type saver for simple data types, but it doesn't >> look a good fit for the input XML file: >> >> - Certain implementations of argparse (particularly pytho

Re: [Mesa-dev] [PATCH] glapi: Avoid argparse type argument for API XML input files.

2015-05-26 Thread Dylan Baker
On Tue, May 26, 2015 at 11:15:36AM +0100, Jose Fonseca wrote: > argparse type is a nice type saver for simple data types, but it doesn't > look a good fit for the input XML file: > > - Certain implementations of argparse (particularly python 2.7.3's) > invoke the type constructor for the default

Re: [Mesa-dev] [PATCH] docs: add information about reviewing patches

2015-05-26 Thread Matt Turner
On Tue, May 26, 2015 at 10:41 AM, Brian Paul wrote: > --- Thanks Brian! Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] st/dri: fix postprocessing crash when there's no depth buffer

2015-05-26 Thread Brian Paul
On 05/26/2015 11:33 AM, Marek Olšák wrote: From: Marek Olšák Cc: 10.6 10.5 --- src/gallium/state_trackers/dri/dri_context.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/dri/dri_context.c b/src/gallium/state_trackers/dri/dri_context

Re: [Mesa-dev] [PATCH 1/2] configure.ac: enable building GLES1 and GLES2 by default

2015-05-26 Thread Ian Romanick
On 05/26/2015 05:08 AM, Marek Olšák wrote: > It's mainly for distributions. You can turn it off, but it won't make > the build faster, because all code is shared. If this could be used as a step towards eventually eliminating some configure options altogether, I'm definitely in favor > Marek

[Mesa-dev] [PATCH] docs: add information about reviewing patches

2015-05-26 Thread Brian Paul
--- docs/devinfo.html | 25 + 1 file changed, 25 insertions(+) diff --git a/docs/devinfo.html b/docs/devinfo.html index f5113b0..eb3aba1 100644 --- a/docs/devinfo.html +++ b/docs/devinfo.html @@ -266,6 +266,31 @@ re-sending the whole series). Using --in-reply-to makes it

Re: [Mesa-dev] [PATCH 14.1/15] glapi: Store exec table version info outside the XML

2015-05-26 Thread Ian Romanick
On 05/21/2015 02:04 PM, Fredrik Höglund wrote: > On Tuesday 19 May 2015, Ian Romanick wrote: >> From: Ian Romanick >> >> Currently on the functions that are exclusive to core-profile are >> implemented. The remainder continue to live in the XML. Additional >> functions can be moved later. >> >>

[Mesa-dev] [PATCH] st/dri: fix postprocessing crash when there's no depth buffer

2015-05-26 Thread Marek Olšák
From: Marek Olšák Cc: 10.6 10.5 --- src/gallium/state_trackers/dri/dri_context.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/gallium/state_trackers/dri/dri_context.c b/src/gallium/state_trackers/dri/dri_context.c index 9f11b15..3d8af65 100644 --- a/src/gall

[Mesa-dev] [PATCH 2/2] tgsi/ureg: fix a coverity defect in emit_decls

2015-05-26 Thread Marek Olšák
From: Marek Olšák Reported by Ilia Mirkin. --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_ureg.c b/src/gallium/auxiliary/tgsi/tgsi_ureg.c index 1cea091..0eaf1df 100644 --- a/src/gallium/auxili

Re: [Mesa-dev] [PATCH 2/2] radeonsi: Add CIK SDMA support

2015-05-26 Thread Alex Deucher
On Tue, May 26, 2015 at 3:28 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Based on the corresponding SI support. Same as that, this is currently > only enabled for one-dimensional buffer copies due to issues with > multi-dimensional SDMA copies. > > Signed-off-by: Michel Dänzer For the se

[Mesa-dev] [PATCH 1/2] r600g: fix a coverity defect in streamout code

2015-05-26 Thread Marek Olšák
From: Marek Olšák Reported by Ilia Mirkin. --- src/gallium/drivers/r600/r600_shader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 87b6e6e..2e83143 100644 --- a/src/gallium/drivers/r600/

Re: [Mesa-dev] [PATCH 3/3] docs: update the coding style information

2015-05-26 Thread Matt Turner
On Tue, May 26, 2015 at 6:35 AM, Brian Paul wrote: > On 05/25/2015 01:59 PM, Thomas Helland wrote: >> I'm no expert on how to add extensions, but patch 2 and 3, >> and the html of patch one LGTM. (Apart from what Ilia pointed out) > > > Is that a R-b? I think this might be another good thing to d

Re: [Mesa-dev] [PATCH 1/2] configure.ac: enable building GLES1 and GLES2 by default

2015-05-26 Thread Matt Turner
On Tue, May 26, 2015 at 3:57 AM, Marek Olšák wrote: > From: Marek Olšák > > No particular reason other than most people should always build this. > --- No preference from me, but the patch does what it claims: Reviewed-by: Matt Turner ___ mesa-dev ma

Re: [Mesa-dev] [PATCH 2/2] configure.ac: enable building the EGL DRM platform by default

2015-05-26 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 3/3] docs: update the coding style information

2015-05-26 Thread Thomas Helland
Forgot to send to list. > > 26. mai 2015 15.35 skrev "Brian Paul" : > > > > On 05/25/2015 01:59 PM, Thomas Helland wrote: > >> > >> 2015-05-25 18:20 GMT+02:00 Brian Paul : > >>> > >>> This hasn't been updated in a long time and from recent discussion on > >>> the mailing list, it's not always clea

Re: [Mesa-dev] [PATCH] xlib: fix X_GLXCreateContextAtrribs/Attribs typo

2015-05-26 Thread Jose Fonseca
On 26/05/15 16:00, Brian Paul wrote: In case the glproto.h file isn't up to date, we provide the #define for X_GLXCreateContextAttribsARB. v2: fix other occurances, improve #ifndef test, per Jose. --- src/gallium/state_trackers/glx/xlib/glx_api.c | 27 +-- 1 file chang

[Mesa-dev] [PATCH] xlib: fix X_GLXCreateContextAtrribs/Attribs typo

2015-05-26 Thread Brian Paul
In case the glproto.h file isn't up to date, we provide the #define for X_GLXCreateContextAttribsARB. v2: fix other occurances, improve #ifndef test, per Jose. --- src/gallium/state_trackers/glx/xlib/glx_api.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) di

Re: [Mesa-dev] [PATCH 00/11] TGSI support for input and output array declarations

2015-05-26 Thread Rob Clark
thanks On Mon, May 25, 2015 at 5:38 PM, Marek Olšák wrote: > Hi Rob, > > I've sent a patch that adds the CAP. > > Marek > > On Mon, May 25, 2015 at 3:17 PM, Rob Clark wrote: >> Ignoring the compiler for a moment, I think this would probably break >> my varying linking (where I match up VS out an

[Mesa-dev] [Bug 90600] IOError: [Errno 2] No such file or directory: 'gl_API.xml'

2015-05-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90600 José Fonseca changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 01/11] gallium: define the maximum number of shader arrays

2015-05-26 Thread Marek Olšák
I'm dropping this patch. I've also sent a new version of patch 2 as well as new patches that dynamically allocate some of the arrays. The complete patch series with all feedback comments resolved is also here: http://cgit.freedesktop.org/~mareko/mesa/log/?h=tgsi-arrays (starting from "glsl_to_tgsi

[Mesa-dev] [PATCH 2/3] glsl_to_tgsi: don't use a static array size for st_translate::arrays

2015-05-26 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 792771e..57b80a32 100644 --- a/src/mesa/state_trac

[Mesa-dev] [PATCH 1/3] glsl_to_tgsi: don't use a static array size for "array_sizes"

2015-05-26 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 719d081..792771e 100644 --- a/src/mesa/state_tra

[Mesa-dev] [PATCH] radeon/llvm: don't use a static array size for radeon_llvm_context::arrays

2015-05-26 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/radeon_llvm.h| 5 ++--- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 15 +++ 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_llvm.h b/src/gallium/drivers/radeon/r

[Mesa-dev] [PATCH 3/3] glsl_to_tgsi: remove memset after calloc

2015-05-26 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 57b80a32..f8f198c 100644 --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp +++ b/src

Re: [Mesa-dev] [PATCH 3/3] docs: update the coding style information

2015-05-26 Thread Brian Paul
On 05/25/2015 01:59 PM, Thomas Helland wrote: 2015-05-25 18:20 GMT+02:00 Brian Paul : This hasn't been updated in a long time and from recent discussion on the mailing list, it's not always clear what's expected. Hopefully, this will help a bit. --- docs/devinfo.html | 155 +++

Re: [Mesa-dev] [PATCH] glapi: Avoid argparse type argument for API XML input files.

2015-05-26 Thread Brian Paul
On 05/26/2015 04:15 AM, Jose Fonseca wrote: argparse type is a nice type saver for simple data types, but it doesn't look a good fit for the input XML file: - Certain implementations of argparse (particularly python 2.7.3's) invoke the type constructor for the default argument even when an

[Mesa-dev] [PATCH] mesa: reference built-in uniforms into gl_uniform_storage

2015-05-26 Thread Martin Peres
This change introduces a new field in gl_uniform_storage to explicitely say that a uniform is built-in. In the case where it is, no storage is defined to make it clear that it is read-only from the mesa side. I think I fixed all the places in the code that made use of the structure that I changed.

[Mesa-dev] [PATCH] glsl: fix constructing a vector from a matrix

2015-05-26 Thread Martin Peres
Without this patch, the following constructs (not an extensive list) would crash mesa: - mat2 foo = mat2(1); vec4 bar = vec4(foo); - mat3 foo = mat3(1); vec4 bar = vec4(foo); - mat3 foo = mat3(1); ivec4 bar = ivec4(foo); The first case is explicitely allowed by the GLSL spec, as seen on page 101

Re: [Mesa-dev] [PATCH 1/2] configure.ac: enable building GLES1 and GLES2 by default

2015-05-26 Thread Marek Olšák
It's mainly for distributions. You can turn it off, but it won't make the build faster, because all code is shared. Marek On Tue, May 26, 2015 at 1:26 PM, Tapani Pälli wrote: > > On 05/26/2015 01:57 PM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> No particular reason other than most people

[Mesa-dev] [Bug 90600] IOError: [Errno 2] No such file or directory: 'gl_API.xml'

2015-05-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90600 José Fonseca changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |jfons...@vmware.com |or

  1   2   >