https://bugs.freedesktop.org/show_bug.cgi?id=90600

José Fonseca <jfons...@vmware.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from José Fonseca <jfons...@vmware.com> ---
commit b787f48ed2a7e1855100afd943ae6b407abb401f
Author: Jose Fonseca <jfons...@vmware.com>
Date:   Tue May 26 11:01:57 2015 +0100

    glapi: Avoid argparse type argument for API XML input files.

    argparse type is a nice type saver for simple data types, but it doesn't
    look a good fit for the input XML file:

    - Certain implementations of argparse (particularly python 2.7.3's)
      invoke the type constructor for the default argument even when an
      option is passed in the command line.  Causing `No such file or
      directory: 'gl_API.xml'` when the current dir is not
      src/mapi/glapi/gen.

    - The parser takes multiple arguments.  This is currently worked around
      using lambdas, but that unnecessarily complex and hard to read.
      Furthermore it's odd to have a side-effect as heavy as parsing XML
      happening deep inside the argument parsing.

    https://bugs.freedesktop.org/show_bug.cgi?id=90600

    Reviewed-by: Brian Paul <bri...@vmware.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to