Re: Ignoring text in spell-check

2007-08-19 Thread Mael Hilléreau
Le 17 août 07 à 12:34, Dov Feldstern a écrit : It's not just a matter of convenience --- I'm still not convinced that insets are *conceptually* right in this case. An inset conveys to me the following idea: I have the main text, and then inside it is something which is a *break* from the no

Re: Ignoring text in spell-check

2007-08-17 Thread Helge Hafting
Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: Why InsetCitation? Because external citation is that's the only use case I can think of. Saying to the user use the NoSpellCheck inset for citations looks weird to me. Of course internally it can be called InsetNoSpellChecker. Well, ther

Re: Ignoring text in spell-check

2007-08-17 Thread Helge Hafting
Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: Mael Hilléreau <[EMAIL PROTECTED]> writes: Then many things are already ugly, e.g. charstyles :) Storing a spellchecker setting into a character or font is senseless, whereas an inset is designed for functional purposes. Well, calling "se

Re: Ignoring text in spell-check

2007-08-17 Thread Dov Feldstern
Mael Hilléreau wrote: Le 17 août 07 à 10:36, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: Mael Hilléreau <[EMAIL PROTECTED]> writes: Le 16 août 07 à 23:41, Jean-Marc Lasgouttes a écrit : This is possible already with my inset-based solution, so you can't say t

Re: Ignoring text in spell-check

2007-08-17 Thread Mael Hilléreau
Le 17 août 07 à 10:36, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: Mael Hilléreau <[EMAIL PROTECTED]> writes: Le 16 août 07 à 23:41, Jean-Marc Lasgouttes a écrit : This is possible already with my inset-based solution, so you can't say that a char-based approac

Re: Ignoring text in spell-check

2007-08-17 Thread Jean-Marc Lasgouttes
Mael Hilléreau <[EMAIL PROTECTED]> writes: >> Mael Hilléreau <[EMAIL PROTECTED]> writes: >> >>> Le 16 août 07 à 23:41, Jean-Marc Lasgouttes a écrit : >>> >>> This is possible already with my inset-based solution, so you can't >>> say that a char-based approach is needed for this. The only >>> diff

Re: Ignoring text in spell-check

2007-08-17 Thread Mael Hilléreau
Le 17 août 07 à 00:56, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: Le 16 août 07 à 23:41, Jean-Marc Lasgouttes a écrit : This is possible already with my inset-based solution, so you can't say that a char-based approach is needed for this. The only difference I s

Re: Ignoring text in spell-check

2007-08-16 Thread Jean-Marc Lasgouttes
Mael Hilléreau <[EMAIL PROTECTED]> writes: > Le 16 août 07 à 23:41, Jean-Marc Lasgouttes a écrit : > > This is possible already with my inset-based solution, so you can't > say that a char-based approach is needed for this. The only > difference I see is the possibility of having an underline. Thi

Re: Ignoring text in spell-check

2007-08-16 Thread Mael Hilléreau
Le 16 août 07 à 23:41, Jean-Marc Lasgouttes a écrit : Mael --- the reason that I think a character-based solution might be useful, even though spell-checking is word-based and not character-base, is that at the conceptual level, what I want to do is to mark regions of text and give them some att

Re: Ignoring text in spell-check

2007-08-16 Thread Jean-Marc Lasgouttes
Dov Feldstern <[EMAIL PROTECTED]> writes: > JMarc, I still tend to agree with you on this point. However, I think > my aborted patch from last night clearly demonstrates that hijacking > Font is *not* a very good idea. Do you have any other idea of how this > could be done in a character-based way

Re: Ignoring text in spell-check

2007-08-16 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: Mael Hilléreau <[EMAIL PROTECTED]> writes: Of course, but as it is a presentation issue, it can be fixed later. I would rather advocate to use character properties in current code and switch to insets-as-character-properties later. Any text longer than one of two w

Re: Ignoring text in spell-check

2007-08-16 Thread José Matos
On Thursday 16 August 2007 21:18:39 Jean-Marc Lasgouttes wrote: > None of this is horrible to fix, but I think we miss a lot of polish. OK. :-) > JMarc -- José Abílio

Re: Ignoring text in spell-check

2007-08-16 Thread Jean-Marc Lasgouttes
José Matos <[EMAIL PROTECTED]> writes: >> charstyles have been introduced because of some shortcomings of our font >> system, in particular the fact that fonts did not nest correctly. They >> feel however as an afterthought, and my belief is that we have not >> found yet how to integrate them full

Re: Ignoring text in spell-check

2007-08-16 Thread José Matos
On Thursday 16 August 2007 14:49:57 Jean-Marc Lasgouttes wrote: > > The real problem you mentioned may be that insets do not provide as > > many display schemes as needed. New schemes would be useful for > > other purposes as well, e.g. for charstyles; however that's not a > > reason for putting ch

Re: Ignoring text in spell-check

2007-08-16 Thread christian . ridderstrom
On Thu, 16 Aug 2007, Mael Hilléreau wrote: It is always a bit more complicated that that. For example, a word ending with numbers will be checked without the trailing numbers. Ok, I see. This wouldn't be a "true" word however (I mean in carbon-14, only "carbon" is a word). I don't think I a

Re: Ignoring text in spell-check

2007-08-16 Thread Mael Hilléreau
Le 16 août 07 à 17:48, Abdelrazak Younes a écrit : Jean-Marc Lasgouttes wrote: Why InsetCitation? Because external citation is that's the only use case I can think of. Saying to the user use the NoSpellCheck inset for citations looks weird to me. Of course internally it can be called I

Re: Ignoring text in spell-check

2007-08-16 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Why InsetCitation? Because external citation is that's the only use case I can think of. Saying to the user use the NoSpellCheck inset for citations looks weird to me. Of course internally it can be called InsetNoSpellChecker. Anyway, the first priority would

Re: Ignoring text in spell-check

2007-08-16 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > Are you sure of that? It seems to me that Word and OpenOffice adds > "ignored words" into a list and not to the word font definitions or > character attributes itself. I was actually thinking about setting an area of text as "do not spellcheck". Li

Re: Ignoring text in spell-check

2007-08-16 Thread Mael Hilléreau
Le 16 août 07 à 17:11, Abdelrazak Younes a écrit : Jean-Marc Lasgouttes wrote: Mael Hilléreau <[EMAIL PROTECTED]> writes: Then many things are already ugly, e.g. charstyles :) Storing a spellchecker setting into a character or font is senseless, whereas an inset is designed for functional purp

Re: Ignoring text in spell-check

2007-08-16 Thread Mael Hilléreau
Le 16 août 07 à 16:49, Jean-Marc Lasgouttes a écrit : Why "senseless"? Because semantically speaking, spellcheck deals with words, not characters. It is always a bit more complicated that that. For example, a word ending with numbers will be checked without the trailing numbers. Ok, I see. T

Re: Ignoring text in spell-check

2007-08-16 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Mael Hilléreau <[EMAIL PROTECTED]> writes: Then many things are already ugly, e.g. charstyles :) Storing a spellchecker setting into a character or font is senseless, whereas an inset is designed for functional purposes. Well, calling "senseless" the method used b

Re: Ignoring text in spell-check

2007-08-16 Thread Jean-Marc Lasgouttes
Mael Hilléreau <[EMAIL PROTECTED]> writes: > Perhaps it is used by other word processors... But isn't LyX supposed > to be better?! :) Yes of course. > Why "senseless"? Because semantically speaking, spellcheck deals with > words, not characters. It is always a bit more complicated that that. F

Re: Ignoring text in spell-check

2007-08-16 Thread Mael Hilléreau
Le 16 août 07 à 15:49, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: Then many things are already ugly, e.g. charstyles :) Storing a spellchecker setting into a character or font is senseless, whereas an inset is designed for functional purposes. Well, calling "se

Re: Ignoring text in spell-check

2007-08-16 Thread Jean-Marc Lasgouttes
Mael Hilléreau <[EMAIL PROTECTED]> writes: > Then many things are already ugly, e.g. charstyles :) Storing a > spellchecker setting into a character or font is senseless, whereas > an inset is designed for functional purposes. Well, calling "senseless" the method used by all other word processor

Re: Ignoring text in spell-check

2007-08-16 Thread Mael Hilléreau
Le 16 août 07 à 14:36, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: Of course, but as it is a presentation issue, it can be fixed later. I would rather advocate to use character properties in current code and switch to insets-as-character-properties later. Any te

Re: Ignoring text in spell-check

2007-08-16 Thread Jean-Marc Lasgouttes
Mael Hilléreau <[EMAIL PROTECTED]> writes: > Of course, but as it is a presentation issue, it can be fixed later. I would rather advocate to use character properties in current code and switch to insets-as-character-properties later. Any text longer than one of two words put in such an inset will

Re: Ignoring text in spell-check

2007-08-16 Thread Mael Hilléreau
Le 16 août 07 à 12:03, Helge Hafting a écrit : Mael Hilléreau wrote: Le 15 août 07 à 16:07, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: Yes, by "frame" I meant something that would integrate seamlessly into paragraphs (the 3-box-drawing approach that Andre advo

Re: Ignoring text in spell-check

2007-08-16 Thread Helge Hafting
Mael Hilléreau wrote: Le 15 août 07 à 16:07, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: Yes, by "frame" I meant something that would integrate seamlessly into paragraphs (the 3-box-drawing approach that Andre advocates would be very well suited for that). This

Re: Ignoring text in spell-check

2007-08-15 Thread Mael Hilléreau
Le 15 août 07 à 16:07, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: Yes, by "frame" I meant something that would integrate seamlessly into paragraphs (the 3-box-drawing approach that Andre advocates would be very well suited for that). This is probably outside of

Re: Ignoring text in spell-check

2007-08-15 Thread Dov Feldstern
Andre Poenitz wrote: On Wed, Aug 15, 2007 at 02:33:16AM +0300, Dov Feldstern wrote: Mael Hilléreau wrote: Le 15 août 07 à 00:32, Andre Poenitz a écrit : On Wed, Aug 15, 2007 at 12:16:47AM +0300, Dov Feldstern wrote: [..] The problem is, this is not working --- even now with branches, as I ju

Re: Spell-check: Settings in dialog (WasRe: Ignoring text in spell-check)

2007-08-15 Thread christian . ridderstrom
On Wed, 15 Aug 2007, Abdelrazak Younes wrote: [EMAIL PROTECTED] wrote: On Tue, 14 Aug 2007, Mael Hilléreau wrote: > > > > What about my old document that I created without this option? > > > > Should I "remake" all notes? How do you know that _all_ notes should not be checked? Maybe I w

Re: Spell-check: Settings in dialog (WasRe: Ignoring text in spell-check)

2007-08-15 Thread Mael Hilléreau
Le 15 août 07 à 16:00, Abdelrazak Younes a écrit : But, except for that, I like your proposal a lot. I think it's easier to implement than all the other proposal and it doesn't touch the core (provided you don't store the info in the document of course). At the end, spell-checking is a fro

Re: Ignoring text in spell-check

2007-08-15 Thread Jean-Marc Lasgouttes
Mael Hilléreau <[EMAIL PROTECTED]> writes: > Yes, by "frame" I meant something that would integrate seamlessly > into paragraphs (the 3-box-drawing approach that Andre advocates > would be very well suited for that). This is probably outside of 1.6 program, though. JMarc

Re: Spell-check: Settings in dialog (WasRe: Ignoring text in spell-check)

2007-08-15 Thread Abdelrazak Younes
Mael Hilléreau wrote: Le 15 août 07 à 10:02, Abdelrazak Younes a écrit : Abdelrazak Younes wrote: [EMAIL PROTECTED] wrote: On Tue, 14 Aug 2007, Mael Hilléreau wrote: > > What about my old document that I created without this option? > > Should I "remake" all notes? How do you know that _

Re: Ignoring text in spell-check

2007-08-15 Thread Mael Hilléreau
Le 15 août 07 à 12:05, Helge Hafting a écrit : A type-level approach would be as much simple (at least): just use what is already implemented: insets and layouts. The Inset::allowSpellcheck() method is already there, and what I propose is just to use it. If you have one note inset now, you

Re: Spell-check: Settings in dialog (WasRe: Ignoring text in spell-check)

2007-08-15 Thread Mael Hilléreau
Le 15 août 07 à 10:02, Abdelrazak Younes a écrit : Abdelrazak Younes wrote: [EMAIL PROTECTED] wrote: On Tue, 14 Aug 2007, Mael Hilléreau wrote: > > What about my old document that I created without this option? > > Should I "remake" all notes? How do you know that _all_ notes should not

Re: Ignoring text in spell-check

2007-08-15 Thread Helge Hafting
Mael Hilléreau wrote: Le 14 août 07 à 16:22, Helge Hafting a écrit : Mael Hilléreau wrote: Le 14 août 07 à 14:01, Helge Hafting a écrit : What happens if you add a new note? For that, you will indeed need a document setting saying "don't spellcheck notes". Ah! I think we're dealing with

Re: Ignoring text in spell-check

2007-08-15 Thread Andre Poenitz
On Wed, Aug 15, 2007 at 02:33:16AM +0300, Dov Feldstern wrote: > Mael Hilléreau wrote: > >Le 15 août 07 à 00:32, Andre Poenitz a écrit : > > > >>On Wed, Aug 15, 2007 at 12:16:47AM +0300, Dov Feldstern wrote: > >>>[..] The problem is, this is not working --- even now with > >>>branches, as I just fo

Re: Spell-check: Settings in dialog (WasRe: Ignoring text in spell-check)

2007-08-15 Thread Abdelrazak Younes
Abdelrazak Younes wrote: [EMAIL PROTECTED] wrote: On Tue, 14 Aug 2007, Mael Hilléreau wrote: > > What about my old document that I created without this option? > > Should I "remake" all notes? How do you know that _all_ notes should not be checked? Maybe I wan't a few of them to actually be

Re: Spell-check: Settings in dialog (WasRe: Ignoring text in spell-check)

2007-08-15 Thread Abdelrazak Younes
[EMAIL PROTECTED] wrote: On Tue, 14 Aug 2007, Mael Hilléreau wrote: > > What about my old document that I created without this option? > > Should I "remake" all notes? How do you know that _all_ notes should not be checked? Maybe I wan't a few of them to actually be checked. Or sometimes I w

Spell-check: Settings in dialog (WasRe: Ignoring text in spell-check)

2007-08-15 Thread christian . ridderstrom
On Tue, 14 Aug 2007, Mael Hilléreau wrote: > > What about my old document that I created without this option? > > Should I "remake" all notes? How do you know that _all_ notes should not be checked? Maybe I wan't a few of them to actually be checked. Or sometimes I want them all to be checke

Re: Ignoring text in spell-check

2007-08-14 Thread Martin Vermeer
On Wed, Aug 15, 2007 at 12:16:47AM +0300, Dov Feldstern wrote: > Mael Hilléreau wrote: > > >> So inset-type would be a nice higher level, because it will allow me to > >> easily do what I usually want; but we still need to account for > >> exceptions, which inset-type can't do. (Don't say "we c

Re: Ignoring text in spell-check

2007-08-14 Thread Dov Feldstern
Mael Hilléreau wrote: Le 15 août 07 à 00:32, Andre Poenitz a écrit : On Wed, Aug 15, 2007 at 12:16:47AM +0300, Dov Feldstern wrote: [..] The problem is, this is not working --- even now with branches, as I just found out thanks to your question --- in certain cases which involve Bidi text (and

Re: Ignoring text in spell-check

2007-08-14 Thread Mael Hilléreau
Le 15 août 07 à 00:32, Andre Poenitz a écrit : On Wed, Aug 15, 2007 at 12:16:47AM +0300, Dov Feldstern wrote: [..] The problem is, this is not working --- even now with branches, as I just found out thanks to your question --- in certain cases which involve Bidi text (and maybe other kinds of t

Re: Ignoring text in spell-check

2007-08-14 Thread Mael Hilléreau
Le 14 août 07 à 23:16, Dov Feldstern a écrit : Certainly. All along I've said that I like your patches, and we *will* need some sort of higher level in order to make this *easy* to use. But once the basis is in, I think this should be possible, and not much more complicated than your origin

Re: Ignoring text in spell-check

2007-08-14 Thread Andre Poenitz
On Wed, Aug 15, 2007 at 12:16:47AM +0300, Dov Feldstern wrote: > [..] > The problem is, this is not working --- even now with branches, as I > just found out thanks to your question --- in certain cases which > involve Bidi text (and maybe other kinds of transitions). In other > words, in these

Re: Ignoring text in spell-check

2007-08-14 Thread Dov Feldstern
Mael Hilléreau wrote: So inset-type would be a nice higher level, because it will allow me to easily do what I usually want; but we still need to account for exceptions, which inset-type can't do. (Don't say "we can have a special 'ignore spelling' inset": I think it will be hard to correctly

Re: Ignoring text in spell-check

2007-08-14 Thread Mael Hilléreau
Le 14 août 07 à 19:42, Dov Feldstern a écrit : Ah! I think we're dealing with some kind of type-level here... Nothing wrong with that - but the document structure and screen redrawing should be kept as simple as possible. A type-level approach would be as much simple (at least): just use wha

Re: Ignoring text in spell-check

2007-08-14 Thread Dov Feldstern
Mael Hilléreau wrote: Le 14 août 07 à 16:22, Helge Hafting a écrit : Mael Hilléreau wrote: Le 14 août 07 à 14:01, Helge Hafting a écrit : What happens if you add a new note? For that, you will indeed need a document setting saying "don't spellcheck notes". Ah! I think we're dealing with

Re: Ignoring text in spell-check

2007-08-14 Thread Mael Hilléreau
Le 14 août 07 à 17:08, Mael Hilléreau a écrit : Le 14 août 07 à 16:22, Helge Hafting a écrit : Mael Hilléreau wrote: Le 14 août 07 à 14:01, Helge Hafting a écrit : What happens if you add a new note? For that, you will indeed need a document setting saying "don't spellcheck notes". Ah!

Re: Ignoring text in spell-check

2007-08-14 Thread Mael Hilléreau
Le 14 août 07 à 16:22, Helge Hafting a écrit : Mael Hilléreau wrote: Le 14 août 07 à 14:01, Helge Hafting a écrit : What happens if you add a new note? For that, you will indeed need a document setting saying "don't spellcheck notes". Ah! I think we're dealing with some kind of type-level

Re: Ignoring text in spell-check

2007-08-14 Thread Helge Hafting
Mael Hilléreau wrote: Le 14 août 07 à 14:01, Helge Hafting a écrit : What happens if you add a new note? For that, you will indeed need a document setting saying "don't spellcheck notes". Ah! I think we're dealing with some kind of type-level here... Nothing wrong with that - but the d

Re: Ignoring text in spell-check

2007-08-14 Thread Mael Hilléreau
Le 14 août 07 à 14:01, Helge Hafting a écrit : Now, "don't spellcheck notes" is still doable by having a LFUN or something that simply applies "character level no-spellcheck" over all existing notes. What happens if you add a new note? For that, you will indeed need a document setting sayin

Re: Ignoring text in spell-check

2007-08-14 Thread Helge Hafting
Mael Hilléreau wrote: Le 14 août 07 à 11:05, Helge Hafting a écrit : Mael Hilléreau wrote: Le 13 août 07 à 22:44, Jean-Marc Lasgouttes a écrit : Then you won't fix bug 1509. As a LyX user, ignoring spellchecking into notes or comments is the most needed feature for me. One does not rule

Re: Ignoring text in spell-check

2007-08-14 Thread Mael Hilléreau
Le 14 août 07 à 11:05, Helge Hafting a écrit : Mael Hilléreau wrote: Le 13 août 07 à 22:44, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: Some users use comments, notes to put quick reminders which shouldn't be spellchecked at all. Other users will e.g. use not

Re: Ignoring text in spell-check

2007-08-14 Thread Helge Hafting
Mael Hilléreau wrote: Le 13 août 07 à 22:44, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: Some users use comments, notes to put quick reminders which shouldn't be spellchecked at all. Other users will e.g. use notes as drafts and could like them to be spellchecke

Re: Ignoring text in spell-check

2007-08-14 Thread Helge Hafting
Dov Feldstern wrote: [EMAIL PROTECTED] wrote: On Mon, 13 Aug 2007, Jean-Marc Lasgouttes wrote: other hand, I think that it is bad if the spell checker ignores text which the user thinks that it is checking --- so it should be very clear to the user what is or is not being checked. I agree.

Re: Ignoring text in spell-check [updated patch]

2007-08-13 Thread christian . ridderstrom
On Tue, 14 Aug 2007, Mael Hilléreau wrote: Ah.. this reminds me of something I said here at the meeting, but should of course have posted as well. A noun in e.g. English may contain spaces. Select a compound word, and click the button. Very easy, no? (provided that this is supported at the

Re: Ignoring text in spell-check

2007-08-13 Thread Mael Hilléreau
Le 14 août 07 à 00:42, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: What _we_ need isn't necessarily what _you_ think, right? I can already tell you what I need (and I'm not the only one, see bug ): a way to ignore notes in all my documents. What you propose i

Re: Ignoring text in spell-check

2007-08-13 Thread Jean-Marc Lasgouttes
Mael Hilléreau <[EMAIL PROTECTED]> writes: > What _we_ need isn't necessarily what _you_ think, right? > > I can already tell you what I need (and I'm not the only one, see bug > ): a way to ignore notes in all my documents. What you propose is > just to configure each of them to be ignored! Not

Re: Ignoring text in spell-check [updated patch]

2007-08-13 Thread Mael Hilléreau
Le 13 août 07 à 21:06, [EMAIL PROTECTED] a écrit : On Mon, 13 Aug 2007, Mael Hilléreau wrote: 3) A list of words into document settings (with add/remove control), and a button into spellchecker dialog for adding on-the-fly. Ah.. this reminds me of something I said here at the meeting, b

Re: Ignoring text in spell-check

2007-08-13 Thread Mael Hilléreau
Le 14 août 07 à 00:08, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: Then you won't fix bug 1509. As a LyX user, ignoring spellchecking into notes or comments is the most needed feature for me. It is a good habit to write correct language in notes :) Not good fo

Re: Ignoring text in spell-check

2007-08-13 Thread Mael Hilléreau
Le 14 août 07 à 00:07, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: No. A per-character approach doesn't allow this. With per-character, you'll provide instance level, not type level ignoring. For example, you can use a tool (provided it is implemented) to ignore a

Re: Ignoring text in spell-check

2007-08-13 Thread Jean-Marc Lasgouttes
Mael Hilléreau <[EMAIL PROTECTED]> writes: > Then you won't fix bug 1509. As a LyX user, ignoring spellchecking > into notes or comments is the most needed feature for me. It is a good habit to write correct language in notes :) JMarc

Re: Ignoring text in spell-check

2007-08-13 Thread Jean-Marc Lasgouttes
Mael Hilléreau <[EMAIL PROTECTED]> writes: > No. A per-character approach doesn't allow this. With per-character, > you'll provide instance level, not type level ignoring. For example, > you can use a tool (provided it is implemented) to ignore all notes > instances in your document, but what happ

Re: Ignoring text in spell-check

2007-08-13 Thread Mael Hilléreau
Le 13 août 07 à 22:44, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: Some users use comments, notes to put quick reminders which shouldn't be spellchecked at all. Other users will e.g. use notes as drafts and could like them to be spellchecked. Only a per-inset or

Re: Ignoring text in spell-check

2007-08-13 Thread Mael Hilléreau
Le 13 août 07 à 22:40, Dov Feldstern a écrit : Then we should try to see how important it is to add per-inset or per-layout customisability. I am not 100% convince that everybody expects that LyXCode is not spell-checked. Some users use comments, notes to put quick reminders which shouldn't be

Re: Ignoring text in spell-check

2007-08-13 Thread Jean-Marc Lasgouttes
Dov Feldstern <[EMAIL PROTECTED]> writes: > Me too. BTW, JMarc, if you want a two-digit bug, this is #86 ;) I have a fix for bug 19, it is even better :) > Or per-character (as language or font-attributes), which although > unnecessary for spell-checking purposes, I think would be simpler in > t

Re: Ignoring text in spell-check

2007-08-13 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: Mael Hilléreau <[EMAIL PROTECTED]> writes: Some users use comments, notes to put quick reminders which shouldn't be spellchecked at all. Other users will e.g. use notes as drafts and could like them to be spellchecked. Only a per-inset or per-layout approach can add

Re: Ignoring text in spell-check

2007-08-13 Thread Jean-Marc Lasgouttes
Mael Hilléreau <[EMAIL PROTECTED]> writes: > Some users use comments, notes to put quick reminders which shouldn't > be spellchecked at all. Other users will e.g. use notes as drafts and > could like them to be spellchecked. Only a per-inset or per-layout > approach can address these needs. I do

Re: Ignoring text in spell-check

2007-08-13 Thread Dov Feldstern
Mael Hilléreau wrote: Le 13 août 07 à 01:03, Jean-Marc Lasgouttes a écrit : Dov Feldstern writes: On the other hand, I think that it is bad if the spell checker ignores text which the user thinks that it is checking --- so it should be very clear to the user what is or is not being checked. A

Re: Ignoring text in spell-check

2007-08-13 Thread Dov Feldstern
[EMAIL PROTECTED] wrote: On Mon, 13 Aug 2007, Jean-Marc Lasgouttes wrote: other hand, I think that it is bad if the spell checker ignores text which the user thinks that it is checking --- so it should be very clear to the user what is or is not being checked. I agree. Another solution I ju

Re: Ignoring text in spell-check

2007-08-13 Thread Mael Hilléreau
Le 13 août 07 à 01:03, Jean-Marc Lasgouttes a écrit : Dov Feldstern <[EMAIL PROTECTED]> writes: On the other hand, I think that it is bad if the spell checker ignores text which the user thinks that it is checking --- so it should be very clear to the user what is or is not being checked. And i

Re: Ignoring text in spell-check

2007-08-13 Thread Dov Feldstern
Mael Hilléreau wrote: Selon Dov Feldstern : etc., etc. It becomes too ad-hoc, the code gets more and more complicated in order to deal with ever-more specific cases, and we are still not as flexible as possible. Precisely, that's why what you propose (lower level) won't make things easier; yo

Re: Ignoring text in spell-check [updated patch]

2007-08-13 Thread christian . ridderstrom
On Mon, 13 Aug 2007, Mael Hilléreau wrote: 3) A list of words into document settings (with add/remove control), and a button into spellchecker dialog for adding on-the-fly. Ah.. this reminds me of something I said here at the meeting, but should of course have posted as well. A n

Re: Ignoring text in spell-check [updated patch]

2007-08-13 Thread Mael Hilléreau
Le 13 août 07 à 01:12, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: I uploaded this patch to bugzilla: http://bugzilla.lyx.org/show_bug.cgi?id=3D1509 IMHO it fixes this bug. Please let me know wether it has a chance to be applied. FWIW, I looked at the patch a

Re: Ignoring text in spell-check

2007-08-13 Thread christian . ridderstrom
On Mon, 13 Aug 2007, Mael Hilléreau wrote: Le 13 août 07 à 13:01, [EMAIL PROTECTED] a écrit : On Sun, 12 Aug 2007, Mael Hilléreau wrote: > > I didn't understand him that way. I thought he meant that the specific > > instanc of that word (and perhaps optionally all identical words) would > >

Re: Ignoring text in spell-check

2007-08-13 Thread Mael Hilléreau
Le 13 août 07 à 09:42, Helge Hafting a écrit : Agreed. I have a simple solution: use 2 checkboxes. One for notes, the other for disabled branches. This solves the spellchecking of branches. But note that such checkboxes does not remove the need for marking parts of the document as non-sp

Re: Ignoring text in spell-check

2007-08-13 Thread Mael Hilléreau
Le 13 août 07 à 13:01, [EMAIL PROTECTED] a écrit : On Sun, 12 Aug 2007, Mael Hilléreau wrote: I didn't understand him that way. I thought he meant that the specific instanc of that word (and perhaps optionally all identical words) would be marked as "do not spellcheck me". So there would be

Re: Ignoring text in spell-check

2007-08-13 Thread christian . ridderstrom
On Sun, 12 Aug 2007, Mael Hilléreau wrote: I didn't understand him that way. I thought he meant that the specific instanc of that word (and perhaps optionally all identical words) would be marked as "do not spellcheck me". So there would be no list of words, rather some (more) words that are mar

Re: Ignoring text in spell-check

2007-08-13 Thread christian . ridderstrom
On Mon, 13 Aug 2007, Jean-Marc Lasgouttes wrote: other hand, I think that it is bad if the spell checker ignores text which the user thinks that it is checking --- so it should be very clear to the user what is or is not being checked. I agree. Another solution I just made up would be to be

Re: Ignoring text in spell-check

2007-08-13 Thread Helge Hafting
Mael Hilléreau wrote: Selon Dov Feldstern <[EMAIL PROTECTED]>: Mael Hilléreau wrote: Selon Helge Hafting <[EMAIL PROTECTED]>: I want my disabled branches spellchecked. :-/ I write a test with hidden answers. I want to spellcheck everything, so I can print the answers later wit

Re: Ignoring text in spell-check [updated patch]

2007-08-12 Thread Jean-Marc Lasgouttes
Mael Hilléreau <[EMAIL PROTECTED]> writes: > I uploaded this patch to bugzilla: > > http://bugzilla.lyx.org/show_bug.cgi?id=3D1509 > > IMHO it fixes this bug. Please let me know wether it has a chance to > be applied. FWIW, I looked at the patch and there are a few things I do not like in there.

Re: Ignoring text in spell-check

2007-08-12 Thread Jean-Marc Lasgouttes
Dov Feldstern <[EMAIL PROTECTED]> writes: > On the > other hand, I think that it is bad if the spell checker ignores text > which the user thinks that it is checking --- so it should be very > clear to the user what is or is not being checked. And ignoring text > --- any text, even if it isn't goin

Re: Ignoring text in spell-check

2007-08-12 Thread Mael Hilléreau
Selon Dov Feldstern <[EMAIL PROTECTED]>: > > Agreed. I have a simple solution: use 2 checkboxes. One for notes, the > other for > > disabled branches. > > Sure it's simple enough, but then a third person wants comments (as > opposed to notes) treated a third way, Indeed. I thought that comments w

Re: Ignoring text in spell-check

2007-08-12 Thread Dov Feldstern
Mael Hilléreau wrote: Selon Dov Feldstern : Mael Hilléreau wrote: Selon Helge Hafting <[EMAIL PROTECTED]>: I want my disabled branches spellchecked. :-/ I write a test with hidden answers. I want to spellcheck everything, so I can print the answers later without further checking & editing.

Re: Ignoring text in spell-check

2007-08-11 Thread Mael Hilléreau
Selon Mael Hilléreau <[EMAIL PROTECTED]>: > Selon Mael Hilléreau <[EMAIL PROTECTED]>: > > > If it's just _one_ instance that we want to ignore, then we can use a > > charstyle > > or a special inset having keyword "NoSpellcheck" (this is already possible > > with > > the patch). > > Please, read "

Re: Ignoring text in spell-check [updated patch]

2007-08-11 Thread Bo Peng
> Did you see my patch from last week, which starts solving these problems > in listings? Let's continue this issue in that thread... > (http://permalink.gmane.org/gmane.editors.lyx.devel/91323) I saw that. But I did not comment because I am not familiar with language handling. Bo

Re: Ignoring text in spell-check

2007-08-11 Thread Mael Hilléreau
Selon Mael Hilléreau <[EMAIL PROTECTED]>: > If it's just _one_ instance that we want to ignore, then we can use a > charstyle > or a special inset having keyword "NoSpellcheck" (this is already possible > with > the patch). Please, read "layout", not "special inset". I was mistaken... Mael.

Re: Ignoring text in spell-check

2007-08-11 Thread Mael Hilléreau
Selon [EMAIL PROTECTED]: > >> I like Helge's idea of having an easy way to mark a word/phrase as "do not > >> spellcheck e"... Maybe the word is a real word in some contexts, but not > >> in others, so I might not wan't it to be added to my personal dictionary. > > > > After all, why not... But i

Re: Ignoring text in spell-check

2007-08-11 Thread Mael Hilléreau
Selon Dov Feldstern <[EMAIL PROTECTED]>: > Mael Hilléreau wrote: > > Selon Helge Hafting <[EMAIL PROTECTED]>: > > > >> I want my disabled branches spellchecked. :-/ > >> I write a test with hidden answers. I want to spellcheck everything, > >> so I can print the answers later without further check

Re: Ignoring text in spell-check

2007-08-11 Thread christian . ridderstrom
On Sun, 12 Aug 2007, Mael Hilléreau wrote: I like Helge's idea of having an easy way to mark a word/phrase as "do not spellcheck e"... Maybe the word is a real word in some contexts, but not in others, so I might not wan't it to be added to my personal dictionary. After all, why not... But if

Re: Ignoring text in spell-check [updated patch]

2007-08-11 Thread Dov Feldstern
Mael Hilléreau wrote: Selon Mael Hilléreau <[EMAIL PROTECTED]>: Selon Bo Peng <[EMAIL PROTECTED]>: IMHO it fixes this bug. Please let me know wether it has a chance to be applied. Sorry that I did not follow this thread closely. Does this related to the caption in listings bug? If this sol

Re: Ignoring text in spell-check

2007-08-11 Thread Dov Feldstern
Mael Hilléreau wrote: Selon Helge Hafting <[EMAIL PROTECTED]>: I want my disabled branches spellchecked. :-/ I write a test with hidden answers. I want to spellcheck everything, so I can print the answers later without further checking & editing. That's why there's a checkbox in the preferenc

Re: Ignoring text in spell-check

2007-08-11 Thread Mael Hilléreau
Selon [EMAIL PROTECTED]: > >> The spellcheck dialog could have another button for "don't spellcheck > >> this word again". (Surely with a shorter caption, but you get the > >> idea.) > >> > >> That button would mark the word as not spellchecked, and the next time > >> the spellchecker runs those

Re: Ignoring text in spell-check [updated patch]

2007-08-11 Thread Dov Feldstern
Mael Hilléreau wrote: Selon Mael Hilléreau <[EMAIL PROTECTED]>: Selon Dov Feldstern : Jean-Marc Lasgouttes wrote: Mael Hilléreau <[EMAIL PROTECTED]> writes: No, in fact it wasn't the case with LyX-Code. I updated the patch so that LyX-Code paragraphs are no more spellchecked (see attache

Re: Ignoring text in spell-check

2007-08-11 Thread christian . ridderstrom
On Sun, 12 Aug 2007, Mael Hilléreau wrote: The spellcheck dialog could have another button for "don't spellcheck this word again". (Surely with a shorter caption, but you get the idea.) That button would mark the word as not spellchecked, and the next time the spellchecker runs those words

Re: Ignoring text in spell-check

2007-08-11 Thread Mael Hilléreau
Selon Helge Hafting <[EMAIL PROTECTED]>: > I want my disabled branches spellchecked. :-/ > I write a test with hidden answers. I want to spellcheck everything, > so I can print the answers later without further checking & editing. That's why there's a checkbox in the preference pane :) (see the p

Re: Ignoring text in spell-check

2007-08-11 Thread Helge Hafting
On Thu, Aug 09, 2007 at 01:24:03AM +0200, Mael Hilléreau wrote: > Selon Mael Hilléreau <[EMAIL PROTECTED]>: > > > ... On the other hand, there could be a much more simple solution: > > > > 1. Disable spellcheck for any code-inset (LyX code, listings...) -- perhaps > > it's already the case; > > I

Re: Ignoring text in spell-check [updated patch]

2007-08-11 Thread Mael Hilléreau
Selon Mael Hilléreau <[EMAIL PROTECTED]>: > Selon Bo Peng <[EMAIL PROTECTED]>: > > > > IMHO it fixes this bug. Please let me know wether it has a chance to be > > applied. > > > > > > Sorry that I did not follow this thread closely. Does this related to > > the caption in listings bug? If this sol

  1   2   >