Re: [patch] partial merging of CharStyle and InsetLayout handling

2007-08-16 Thread Martin Vermeer
On Thu, Aug 16, 2007 at 03:58:44PM +0200, Jean-Marc Lasgouttes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > > Sorry... I don't understand this. What do you mean? What > > code does this require? > > Something like that (untested) > > InsetLayout const & TextClass::insetlayout(docstrin

Re: My lyx/trunk can not load any layout file.

2007-08-16 Thread Martin Vermeer
On Thu, Aug 16, 2007 at 11:20:16PM -0500, Bo Peng wrote: > > Do you have the file lib/layouts/stdinsets.inc? I do, and > > it is in svn too. > > I find out the reason: scons does not install the newly added stdinsets.inc. > > However, lyx/trunk does not display any character on my system (See > a

Re: My lyx/trunk can not load any layout file.

2007-08-16 Thread Bo Peng
> Do you have the file lib/layouts/stdinsets.inc? I do, and > it is in svn too. I find out the reason: scons does not install the newly added stdinsets.inc. However, lyx/trunk does not display any character on my system (See attached). Is this a known problem? Bo <>

Re: Compile error: current trunk

2007-08-16 Thread Bennett Helm
On Aug 14, 2007, at 3:11 AM, Jean-Marc Lasgouttes wrote: Anders Ekberg <[EMAIL PROTECTED]> writes: I have the same as Bennett: /* Define to `int' if doesn't define. */ #define uid_t int We found out that this is related to a string of errors in config.log, but still have no idea of why.

Re: Question About New Build System

2007-08-16 Thread Jean-Marc Lasgouttes
Andre Poenitz <[EMAIL PROTECTED]> writes: >> I did not find a place where his variable is instantiated, actually. >> How is this done? > > Thesaurus.cpp:121 I meant the place in the object code. I read a bit about flat namespace (see error message)and if the following page makes sense to you, we

Lyx 1.5.1 failed to start on Windows XP

2007-08-16 Thread Steven Truong
Hi, all. Could you please take a look at this thread? There is a serious bug that prevents user(s) to install this software and run it from the very beginning. http://www.mail-archive.com/[EMAIL PROTECTED]/msg58146.html Thank you.

Re: Question About New Build System

2007-08-16 Thread Andre Poenitz
On Thu, Aug 16, 2007 at 11:53:59PM +0200, Jean-Marc Lasgouttes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > > Ok. Glad to here that. No I need only a positive report from a Mac user. > > OK, almost positive :) I build here with pkg-config installed from > macports, and Qt is 4.3.0. > >

Re: Question About New Build System

2007-08-16 Thread Jean-Marc Lasgouttes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > 2) a shared build. Libraries are not installed at the regular place, > but I think I can fix that. Compilation goes fine. I can install at the proper place (LyX.app/Contents/Frameworks if I believe apple) with the following patch. It does not cha

Re: Ignoring text in spell-check

2007-08-16 Thread Jean-Marc Lasgouttes
Mael Hilléreau <[EMAIL PROTECTED]> writes: > Le 16 août 07 à 23:41, Jean-Marc Lasgouttes a écrit : > > This is possible already with my inset-based solution, so you can't > say that a char-based approach is needed for this. The only > difference I see is the possibility of having an underline. Thi

Re: Ignoring text in spell-check

2007-08-16 Thread Mael Hilléreau
Le 16 août 07 à 23:41, Jean-Marc Lasgouttes a écrit : Mael --- the reason that I think a character-based solution might be useful, even though spell-checking is word-based and not character-base, is that at the conceptual level, what I want to do is to mark regions of text and give them some att

Re: Ignoring spell-check

2007-08-16 Thread Jean-Marc Lasgouttes
Dov Feldstern <[EMAIL PROTECTED]> writes: > I've been working on the ignore-spell-check feature using character > attributes (actually inside Font), but I'm having trouble with this. I > think much of the trouble is that I don't understand the intricacies > of Fonts (realized fonts, inheritance/ig

Re: Question About New Build System

2007-08-16 Thread Jean-Marc Lasgouttes
Andre Poenitz <[EMAIL PROTECTED]> writes: > Ok. Glad to here that. No I need only a positive report from a Mac user. OK, almost positive :) I build here with pkg-config installed from macports, and Qt is 4.3.0. Note that I disable pch. autoconf (GNU Autoconf) 2.61 automake (GNU automake) 1.10

Re: Ignoring text in spell-check

2007-08-16 Thread Jean-Marc Lasgouttes
Dov Feldstern <[EMAIL PROTECTED]> writes: > JMarc, I still tend to agree with you on this point. However, I think > my aborted patch from last night clearly demonstrates that hijacking > Font is *not* a very good idea. Do you have any other idea of how this > could be done in a character-based way

Re: status buildsystem

2007-08-16 Thread Andre Poenitz
On Thu, Aug 16, 2007 at 09:17:01PM +0200, Andre Poenitz wrote: > On Thu, Aug 16, 2007 at 04:33:19PM +0200, [EMAIL PROTECTED] wrote: > > On Thu, 16 Aug 2007, Andre Poenitz wrote: > > > > > > > >I just build release-static and release-dynamic with current svn 'pure > > >autoconf'. debug-static is i

Re: Question About New Build System

2007-08-16 Thread Andre Poenitz
On Thu, Aug 16, 2007 at 03:59:10PM +0200, Enrico Forestieri wrote: > On Thu, Aug 16, 2007 at 01:24:05AM +0200, Andre Poenitz wrote: > > > On Wed, Aug 15, 2007 at 07:12:04PM +0200, Enrico Forestieri wrote: > > > On Wed, Aug 15, 2007 at 09:54:01AM +0200, Andre Poenitz wrote: > > > > > > > The probl

Re: Ignoring text in spell-check

2007-08-16 Thread Dov Feldstern
Jean-Marc Lasgouttes wrote: Mael Hilléreau <[EMAIL PROTECTED]> writes: Of course, but as it is a presentation issue, it can be fixed later. I would rather advocate to use character properties in current code and switch to insets-as-character-properties later. Any text longer than one of two w

Re: Ignoring text in spell-check

2007-08-16 Thread José Matos
On Thursday 16 August 2007 21:18:39 Jean-Marc Lasgouttes wrote: > None of this is horrible to fix, but I think we miss a lot of polish. OK. :-) > JMarc -- José Abílio

Re: Ignoring text in spell-check

2007-08-16 Thread Jean-Marc Lasgouttes
José Matos <[EMAIL PROTECTED]> writes: >> charstyles have been introduced because of some shortcomings of our font >> system, in particular the fact that fonts did not nest correctly. They >> feel however as an afterthought, and my belief is that we have not >> found yet how to integrate them full

Re: r19513 - /lyx-devel/trunk/src/frontends/qt4/QLPainter.cpp

2007-08-16 Thread Enrico Forestieri
On Thu, Aug 16, 2007 at 06:37:49PM +0200, Abdelrazak Younes wrote: > It's fixed now, thanks. Thank you, Abdel. -- Enrico

Re: Ignoring text in spell-check

2007-08-16 Thread José Matos
On Thursday 16 August 2007 14:49:57 Jean-Marc Lasgouttes wrote: > > The real problem you mentioned may be that insets do not provide as > > many display schemes as needed. New schemes would be useful for > > other purposes as well, e.g. for charstyles; however that's not a > > reason for putting ch

Re: My lyx/trunk can not load any layout file.

2007-08-16 Thread Martin Vermeer
On Thu, Aug 16, 2007 at 01:58:53PM -0500, Bo Peng wrote: > > You may want to update your tree in lib/layouts. > > I have the most current svn version Maybe some encoding problem? Do you have the file lib/layouts/stdinsets.inc? I do, and it is in svn too. - Martin

Re: [PATCH] more work on counters

2007-08-16 Thread Andre Poenitz
On Thu, Aug 16, 2007 at 03:57:40PM +0200, Abdelrazak Younes wrote: > Jean-Marc Lasgouttes wrote: > >Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > > > >>The following patch introduces LabelString for counters. This > >>labelstring will be used in several places: > > > >Here is the updated versi

Re: status buildsystem

2007-08-16 Thread Andre Poenitz
On Thu, Aug 16, 2007 at 04:33:19PM +0200, [EMAIL PROTECTED] wrote: > On Thu, 16 Aug 2007, Andre Poenitz wrote: > > > > >I just build release-static and release-dynamic with current svn 'pure > >autoconf'. debug-static is in the pipe. > > > >I'd like to hear of any problems people experience (and,

Re: drag an drop lyx tokens

2007-08-16 Thread pol
Jean-Marc Lasgouttes wrote: > pol <[EMAIL PROTECTED]> writes: >> I am thinking about a sort of improvement of the >> Insert->File->LyxDocument operation, placing dragged file at the cursor >> position, possibly retaining the identity of dropped items, allowing >> author to move them across the doc

Re: My lyx/trunk can not load any layout file.

2007-08-16 Thread Bo Peng
> You may want to update your tree in lib/layouts. I have the most current svn version Maybe some encoding problem? Bo

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Abdelrazak Younes
Bo Peng wrote: Actually I just came to realize that statusChanged() is a signal so it may have multiple slots connected to it. So it is wrong to store the connection inside CacheItem along the signal. Right. Conclusion: Both your patch and mine are correct. Sorry about the confusion. I assu

Re: Ignoring text in spell-check

2007-08-16 Thread christian . ridderstrom
On Thu, 16 Aug 2007, Mael Hilléreau wrote: It is always a bit more complicated that that. For example, a word ending with numbers will be checked without the trailing numbers. Ok, I see. This wouldn't be a "true" word however (I mean in carbon-14, only "carbon" is a word). I don't think I a

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Bo Peng
> Actually I just came to realize that statusChanged() is a signal so it > may have multiple slots connected to it. So it is wrong to store the > connection inside CacheItem along the signal. Right. > Conclusion: Both your patch and mine are correct. Sorry about the confusion. I assume this is a

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Abdelrazak Younes
Bo Peng wrote: The best solution actually is to store the signal connection inside CacheItem actually. So neither your patch nor mine is correct. I have told you that the attached patch does not work (and ~Impl() is not called). Am I missing something? Actually I just came to realize that sta

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Bo Peng wrote: The best solution actually is to store the signal connection inside CacheItem actually. So neither your patch nor mine is correct. I have told you that the attached patch does not work (and ~Impl() is not called). Am I missing something? Ah? Sorry, I m

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Bo Peng wrote: The best solution actually is to store the signal connection inside CacheItem actually. So neither your patch nor mine is correct. I have told you that the attached patch does not work (and ~Impl() is not called). Am I missing something? Ah? Sorry, I m

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Abdelrazak Younes
Bo Peng wrote: The best solution actually is to store the signal connection inside CacheItem actually. So neither your patch nor mine is correct. I have told you that the attached patch does not work (and ~Impl() is not called). Am I missing something? Ah? Sorry, I missed that one. Try this o

Re: Ignoring text in spell-check

2007-08-16 Thread Mael Hilléreau
Le 16 août 07 à 17:48, Abdelrazak Younes a écrit : Jean-Marc Lasgouttes wrote: Why InsetCitation? Because external citation is that's the only use case I can think of. Saying to the user use the NoSpellCheck inset for citations looks weird to me. Of course internally it can be called I

Re: [PATCH] 4108: update figures crash lyx with copied graphics inset.

2007-08-16 Thread Bo Peng
> Try this patch instead. Does not work. Bo

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Bo Peng
> The best solution actually is to store > the signal connection inside CacheItem actually. So neither your patch > nor mine is correct. I have told you that the attached patch does not work (and ~Impl() is not called). Am I missing something? Bo Index: src/graphics/GraphicsCacheItem.cpp

Re: [PATCH] 4108: update figures crash lyx with copied graphics inset.

2007-08-16 Thread Abdelrazak Younes
Bo Peng wrote: On 8/16/07, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: I don't understand why you want to revert it. It will hurt someone sooner or later. Because your fix might not be necessary at all. Maybe some signal sender/receiver will be destroyed at the same time, maybe a signal will

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Abdelrazak Younes
Bo Peng wrote: If I read correctly your patch, it is a problem of non disconnected signal so it is related. When you reset the smart pointer, you will in effect call the destructor. As far as I can tell, the destructor of CacheItem is *not* called when cache_item_.reset() is called. Of course

Re: [PATCH] 4108: update figures crash lyx with copied graphics inset.

2007-08-16 Thread Bo Peng
On 8/16/07, Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > I don't understand why you want to revert it. It will hurt > someone sooner or later. Because your fix might not be necessary at all. Maybe some signal sender/receiver will be destroyed at the same time, maybe a signal will never be sent

Re: [patch] Streamlining collapsable status, inlined, etc. in InsetCollapsable

2007-08-16 Thread Martin Vermeer
On Thu, Aug 16, 2007 at 03:51:02PM +0200, Jean-Marc Lasgouttes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > > This was a great idea... result attached. I will commit this > > presently if I hear no objections. > > Good. It's committed. - Martin

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Bo Peng
> If I read correctly your patch, it is a problem of non disconnected > signal so it is related. When you reset the smart pointer, you will in > effect call the destructor. As far as I can tell, the destructor of CacheItem is *not* called when cache_item_.reset() is called. When I save sc_ and dis

Re: r19513 - /lyx-devel/trunk/src/frontends/qt4/QLPainter.cpp

2007-08-16 Thread Abdelrazak Younes
Enrico Forestieri wrote: On Wed, Aug 15, 2007 at 07:58:28PM +0200, Abdelrazak Younes wrote: Abdelrazak Younes wrote: Enrico Forestieri wrote: On Wed, Aug 15, 2007 at 07:30:47PM +0200, Abdelrazak Younes wrote: Enrico Forestieri wrote: On Wed, Aug 15, 2007 at 06:57:19PM +0200, Abdelrazak You

Re: My lyx/trunk can not load any layout file.

2007-08-16 Thread Martin Vermeer
On Thu, Aug 16, 2007 at 10:36:35AM -0500, Bo Peng wrote: > lyx1.6svn just does not work here. Maybe this is why I can not use > view-source coursor. > > % /usr/local/bin/lyx16 > LyX: Could not find inputfile: stdinsets.inc [around line 42 of file > [layouts/stdclass.inc]] > LyX: Error reading inp

Re: r19607 - in /lyx-devel/trunk/src: TextClass.cpp TextClass.h

2007-08-16 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > [EMAIL PROTECTED] wrote: >> Author: lasgouttes >> Date: Thu Aug 16 17:26:00 2007 >> New Revision: 19607 >> >> URL: http://www.lyx.org/trac/changeset/19607 >> Log: >> rename TextClass::ctrs_ to counters_ > > Thanks but you did a bit more, not sure tha

Re: [PATCH] more work on counters

2007-08-16 Thread Enrico Forestieri
On Thu, Aug 16, 2007 at 06:09:47PM +0200, Edwin Leuven wrote: > >> O tempora, o mores... > > > > Not everybody understand Latin either ;-) > > i think tempora is a japanese dish... > > so it must mean something like > > "oh, how i love deep fried battered veggies" > > or something like that..

Re: [PATCH] 4108: update figures crash lyx with copied graphics inset.

2007-08-16 Thread Abdelrazak Younes
Bo Peng wrote: I will also revert Abdel's patch when I apply it to the trunk. After all, we should not fix a bug that does not exist (yet). I don't really care if you revert it but your patch is doing exactly the same as my patch: you disconnect the signal before the item is destroyed. I don'

Re: [patch] partial merging of CharStyle and InsetLayout handling

2007-08-16 Thread Martin Vermeer
On Thu, Aug 16, 2007 at 03:58:44PM +0200, Jean-Marc Lasgouttes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > > Sorry... I don't understand this. What do you mean? What > > code does this require? > ... > Assuming that you ask for "charstyle:author", which does not exist, > the code w

Re: 1.5.1 crashes when saving to unavailable network drive

2007-08-16 Thread Eran Kaplinsky
http://bugzilla.lyx.org/show_bug.cgi?id=4148 Summary: crash when saving to unavailable network drive Product: LyX Version: 1.5.1 Platform: PC OS/Version: other Status: UNCONFIRMED Severity: normal Priority: P2 Comp

Re: [PATCH] more work on counters

2007-08-16 Thread Edwin Leuven
O tempora, o mores... Not everybody understand Latin either ;-) i think tempora is a japanese dish... so it must mean something like "oh, how i love deep fried battered veggies" or something like that... ;-)

Re: [PATCH] more work on counters

2007-08-16 Thread Abdelrazak Younes
Enrico Forestieri wrote: On Thu, Aug 16, 2007 at 05:18:12PM +0200, Abdelrazak Younes wrote: Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: (Counters::theCounter): return a representation of a given counter using its labelstring I'd write Counters::

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Abdelrazak Younes
Bo Peng wrote: I agree with Abdel. If the bug is already identified, why leave it lurking? I have just posted a patch. The real reason for this bug does not seem to be related to the destructor/signals problem, If I read correctly your patch, it is a problem of non disconnected signal so it

Re: [PATCH] more work on counters

2007-08-16 Thread Enrico Forestieri
On Thu, Aug 16, 2007 at 05:18:12PM +0200, Abdelrazak Younes wrote: > Jean-Marc Lasgouttes wrote: > > Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > > >>(Counters::theCounter): return a representation of a given > >>counter using its labelstring > >> > >> I'd write Counters::get() for t

Re: Ignoring text in spell-check

2007-08-16 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Why InsetCitation? Because external citation is that's the only use case I can think of. Saying to the user use the NoSpellCheck inset for citations looks weird to me. Of course internally it can be called InsetNoSpellChecker. Anyway, the first priority would

Re: r19607 - in /lyx-devel/trunk/src: TextClass.cpp TextClass.h

2007-08-16 Thread Abdelrazak Younes
[EMAIL PROTECTED] wrote: Author: lasgouttes Date: Thu Aug 16 17:26:00 2007 New Revision: 19607 URL: http://www.lyx.org/trac/changeset/19607 Log: rename TextClass::ctrs_ to counters_ Thanks but you did a bit more, not sure that was on purpose: InsetLayout const & TextClass::insetlayout(docstr

Re: Ignoring text in spell-check

2007-08-16 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > Are you sure of that? It seems to me that Word and OpenOffice adds > "ignored words" into a list and not to the word font definitions or > character attributes itself. I was actually thinking about setting an area of text as "do not spellcheck". Li

My lyx/trunk can not load any layout file.

2007-08-16 Thread Bo Peng
lyx1.6svn just does not work here. Maybe this is why I can not use view-source coursor. % /usr/local/bin/lyx16 LyX: Could not find inputfile: stdinsets.inc [around line 42 of file [layouts/stdclass.inc]] LyX: Error reading inputfile: /usr/local/share/lyx16/./layouts/stdclass.inc [around line 9 of

Re: [Cvslog] r19598 - in /lyx-devel/trunk: development/scons/scons_man...

2007-08-16 Thread Richard Heck
Andre Poenitz wrote: On Thu, Aug 16, 2007 at 01:59:21AM -, [EMAIL PROTECTED] wrote: +BibTeXInfo::BibTeXInfo(bool isBibTeX): isBibTeX(isBibTeX) +{} It's also one of the rare cases where a default argument might make sense. Also, really trivial code (i.e. 'fits on the line') can go to

Re: Ignoring text in spell-check

2007-08-16 Thread Mael Hilléreau
Le 16 août 07 à 17:11, Abdelrazak Younes a écrit : Jean-Marc Lasgouttes wrote: Mael Hilléreau <[EMAIL PROTECTED]> writes: Then many things are already ugly, e.g. charstyles :) Storing a spellchecker setting into a character or font is senseless, whereas an inset is designed for functional purp

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Bo Peng
> I agree with Abdel. If the bug is already identified, why leave it lurking? I have just posted a patch. The real reason for this bug does not seem to be related to the destructor/signals problem, and I dislike the idea of fixing a nonexistent bug that I can not test. Cheers, Bo

Re: [PATCH] more work on counters

2007-08-16 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: Isn't new a reserved word? Indeed. What about newItem()? In general I think that members should have explicit naming (I know this is not your doing). Rather than doing that, I think I'd prefer to expose a map-like

[PATCH] 4108: update figures crash lyx with copied graphics inset.

2007-08-16 Thread Bo Peng
Dear all, Using a gcc3 compiled lyx, when we remove the underlying figure of a graphic inset that is copied and pasted, lyx crashes. This is because 'cached_item_.connect()' is not properly disconnected when the cached_item_ is reset. This may not be related to the signals/desctructor problem we

Re: [patch] partial merging of CharStyle and InsetLayout handling

2007-08-16 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: I personally prefer this style: if (i == string::npos) // delimiter was not found break; n = n.substr(0, i); Remember o

Re: [PATCH] more work on counters

2007-08-16 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: (Counters::theCounter): return a representation of a given counter using its labelstring I'd write Counters::get() for the same reason as above. It is now what the method does really. It is an equivalen

Re: Ignoring text in spell-check

2007-08-16 Thread Mael Hilléreau
Le 16 août 07 à 16:49, Jean-Marc Lasgouttes a écrit : Why "senseless"? Because semantically speaking, spellcheck deals with words, not characters. It is always a bit more complicated that that. For example, a word ending with numbers will be checked without the trailing numbers. Ok, I see. T

Re: Ignoring text in spell-check

2007-08-16 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Mael Hilléreau <[EMAIL PROTECTED]> writes: Then many things are already ugly, e.g. charstyles :) Storing a spellchecker setting into a character or font is senseless, whereas an inset is designed for functional purposes. Well, calling "senseless" the method used b

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Bo Peng wrote: Your patch may not be needed at least for this bug. >>> It will be needed for a forthcoming bugs ;-) >>> As I said, if you are serious about supporting gcc 3, you should do this >>> for all boost signal connection. >> >> I still prefer to fix th

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Abdelrazak Younes
Bo Peng wrote: Your patch may not be needed at least for this bug. It will be needed for a forthcoming bugs ;-) As I said, if you are serious about supporting gcc 3, you should do this for all boost signal connection. I still prefer to fix the bug when I see it, rather than blindly doing this

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Jean-Marc Lasgouttes
"Bo Peng" <[EMAIL PROTECTED]> writes: >> Does anybody know what the cause of "the signal problem" actually is? > > I do not know your problem, but the problem with this thread is that > when an object is destroyed, its signals are still connected in qcc3, > but not in gcc4. Then, when the signal i

Re: [patch] partial merging of CharStyle and InsetLayout handling

2007-08-16 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > I personally prefer this style: > > if (i == string::npos) > // delimiter was not found > break; > > n = n.substr(0, i); > > Remember our discussions about iterat

Re: Ignoring text in spell-check

2007-08-16 Thread Jean-Marc Lasgouttes
Mael Hilléreau <[EMAIL PROTECTED]> writes: > Perhaps it is used by other word processors... But isn't LyX supposed > to be better?! :) Yes of course. > Why "senseless"? Because semantically speaking, spellcheck deals with > words, not characters. It is always a bit more complicated that that. F

Re: [PATCH] more work on counters

2007-08-16 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > (Counters::theCounter): return a representation of a given > counter using its labelstring > > I'd write Counters::get() for the same reason as above. It is now what the method does really. It is an equivalent to LaTeX's \thefigure, for

Re: [PATCH] more work on counters

2007-08-16 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > Some cosmetic comments on the code (all IMHO): > > @@ -922,14 +928,31 @@ void TextClass::readCounter(Lexer & lexr > switch (static_cast(le)) { > case CT_NAME: > lexrc.next(); > - n

Re: Ignoring text in spell-check

2007-08-16 Thread Mael Hilléreau
Le 16 août 07 à 15:49, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: Then many things are already ugly, e.g. charstyles :) Storing a spellchecker setting into a character or font is senseless, whereas an inset is designed for functional purposes. Well, calling "se

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Bo Peng
> > Your patch may not be needed at > > least for this bug. > > It will be needed for a forthcoming bugs ;-) > As I said, if you are serious about supporting gcc 3, you should do this > for all boost signal connection. I still prefer to fix the bug when I see it, rather than blindly doing this for

Re: status buildsystem

2007-08-16 Thread christian . ridderstrom
On Thu, 16 Aug 2007, Andre Poenitz wrote: I just build release-static and release-dynamic with current svn 'pure autoconf'. debug-static is in the pipe. I'd like to hear of any problems people experience (and, of course any idea on with the --with-qmake build crahes when constructin a boos

Re: On the fly spellcheck? (fwd)

2007-08-16 Thread Bo Peng
> Why search only the existing text? A new document have very > little of that. If you search the spellchecker wordlist for > the language in effect, then you get more completions, > especially for short documents. If you read further along this thread, this is being considered and is why I would

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Bo Peng
> Does anybody know what the cause of "the signal problem" actually is? I do not know your problem, but the problem with this thread is that when an object is destroyed, its signals are still connected in qcc3, but not in gcc4. Then, when the signal is triggered, lyx crashes with a gcc3 build. Th

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Abdelrazak Younes
Bo Peng wrote: So all signals need to be saved, and disconnected when an object is destroyed? Basically yes. The attached patch fixes the crash. Good. Your patch may not be needed at least for this bug. It will be needed for a forthcoming bugs ;-) As I said, if you are serious about supp

Re: [patch] partial merging of CharStyle and InsetLayout handling

2007-08-16 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Martin Vermeer <[EMAIL PROTECTED]> writes: Sorry... I don't understand this. What do you mean? What code does this require? Something like that (untested) InsetLayout const & TextClass::insetlayout(docstring const & name) const { docstring n = name;

Re: [PATCH] more work on counters

2007-08-16 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: The following patch introduces LabelString for counters. This labelstring will be used in several places: Here is the updated version of the patch, the shortcoming have been resolved and the layout files have been up

Re: [patch] partial merging of CharStyle and InsetLayout handling

2007-08-16 Thread Jean-Marc Lasgouttes
Martin Vermeer <[EMAIL PROTECTED]> writes: > Sorry... I don't understand this. What do you mean? What > code does this require? Something like that (untested) InsetLayout const & TextClass::insetlayout(docstring const & name) const { docstring n = name; while (!n.empty()) {

Re: [PATCH] more work on counters

2007-08-16 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: The following patch introduces LabelString for counters. This labelstring will be used in several places: Here is the updated version of the patch, the shortcoming have been resolved and the layout files have been up

Re: Question About New Build System

2007-08-16 Thread Enrico Forestieri
On Thu, Aug 16, 2007 at 01:24:05AM +0200, Andre Poenitz wrote: > On Wed, Aug 15, 2007 at 07:12:04PM +0200, Enrico Forestieri wrote: > > On Wed, Aug 15, 2007 at 09:54:01AM +0200, Andre Poenitz wrote: > > > > > The problem with automake+libtools is that it takes about twice as much > > > time as ei

Re: status buildsystem

2007-08-16 Thread Jean-Marc Lasgouttes
Andre Poenitz <[EMAIL PROTECTED]> writes: > I just build release-static and release-dynamic with current svn 'pure > autoconf'. debug-static is in the pipe. > > I'd like to hear of any problems people experience (and, of course any > idea on with the --with-qmake build crahes when constructin a >

Re: [patch] Streamlining collapsable status, inlined, etc. in InsetCollapsable

2007-08-16 Thread Jean-Marc Lasgouttes
Martin Vermeer <[EMAIL PROTECTED]> writes: > This was a great idea... result attached. I will commit this > presently if I hear no objections. Good. JMarc

Re: Ignoring text in spell-check

2007-08-16 Thread Jean-Marc Lasgouttes
Mael Hilléreau <[EMAIL PROTECTED]> writes: > Then many things are already ugly, e.g. charstyles :) Storing a > spellchecker setting into a character or font is senseless, whereas > an inset is designed for functional purposes. Well, calling "senseless" the method used by all other word processor

Re: r19513 - /lyx-devel/trunk/src/frontends/qt4/QLPainter.cpp

2007-08-16 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: it is certainly less efficient for me ;-) as all text except smallcaps has become invisible! Setting USE_PIXMAP_CACHE to 0 restores text rendering. Too bad! Somebody else seeing this? I see the same here with Qt 4.1.4

Re: [patch] selection in source panel

2007-08-16 Thread Enrico Forestieri
On Thu, Aug 16, 2007 at 02:04:02PM +0200, Alfredo Braunstein wrote: > Ugh. We could set the font explicitly I guess, don't know if this makes > sense. Here you can change font size on the widget with C-MouseWheel. Cool! Didn't know that trick. It works with all Qt versions, the only difference b

Re: Ignoring text in spell-check

2007-08-16 Thread Mael Hilléreau
Le 16 août 07 à 14:36, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: Of course, but as it is a presentation issue, it can be fixed later. I would rather advocate to use character properties in current code and switch to insets-as-character-properties later. Any te

status buildsystem

2007-08-16 Thread Andre Poenitz
I just build release-static and release-dynamic with current svn 'pure autoconf'. debug-static is in the pipe. I'd like to hear of any problems people experience (and, of course any idea on with the --with-qmake build crahes when constructin a boost::signal) Andre'

Re: [patch] Streamlining collapsable status, inlined, etc. in InsetCollapsable

2007-08-16 Thread Martin Vermeer
On Thu, Aug 16, 2007 at 10:54:40AM +0200, Jean-Marc Lasgouttes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > > On Thu, Aug 16, 2007 at 09:23:40AM +0200, Jean-Marc Lasgouttes wrote: > >> Martin Vermeer <[EMAIL PROTECTED]> writes: > >> > >> > Hmmm, elsewhere in the code I see such constru

Re: Ignoring text in spell-check

2007-08-16 Thread Jean-Marc Lasgouttes
Mael Hilléreau <[EMAIL PROTECTED]> writes: > Of course, but as it is a presentation issue, it can be fixed later. I would rather advocate to use character properties in current code and switch to insets-as-character-properties later. Any text longer than one of two words put in such an inset will

Re: [patch] partial merging of CharStyle and InsetLayout handling

2007-08-16 Thread Martin Vermeer
On Thu, Aug 16, 2007 at 01:20:19PM +0200, Jean-Marc Lasgouttes wrote: > Martin Vermeer <[EMAIL PROTECTED]> writes: > > > Yes, you can do this. The price you pay is the long name > > appearing also on the inset labels. > > We are free to chose how the label appears on scrren What I am > describing

Re: [patch] selection in source panel

2007-08-16 Thread Alfredo Braunstein
Enrico Forestieri wrote: > We can also rule out 4.1.4, as it differs from 4.1.5 by an epsilon. Ok. >> Wrt. to the glitch, the attached should fix it, hopefully without >> introducing other glitches. It turns out it is trickier than it may seem >> to get all corner cases right (1 position -> mul

Re: [Cvslog] r19598 - in /lyx-devel/trunk: development/scons/scons_man...

2007-08-16 Thread Andre Poenitz
On Thu, Aug 16, 2007 at 01:59:21AM -, [EMAIL PROTECTED] wrote: > Modified: lyx-devel/trunk/src/Biblio.cpp > URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/Biblio.cpp?rev=19598 > == > --- lyx-devel/trunk/src/Bibli

Re: Ignoring text in spell-check

2007-08-16 Thread Mael Hilléreau
Le 16 août 07 à 12:03, Helge Hafting a écrit : Mael Hilléreau wrote: Le 15 août 07 à 16:07, Jean-Marc Lasgouttes a écrit : Mael Hilléreau <[EMAIL PROTECTED]> writes: Yes, by "frame" I meant something that would integrate seamlessly into paragraphs (the 3-box-drawing approach that Andre advo

Re: Question About New Build System

2007-08-16 Thread Jean-Marc Lasgouttes
Andre Poenitz <[EMAIL PROTECTED]> writes: > Unfortunately, this won't work on Windows as DLLs needs to be > self-contained and our current spaghetti mess does not lend itself to > modularization. Fortunately enough, --disable-shared --enable-static > is supposed to produce the old static behaviou

Re: [PATCH] more work on counters

2007-08-16 Thread Jean-Marc Lasgouttes
Martin Vermeer <[EMAIL PROTECTED]> writes: > And I seem to remember that in some classes, symbols are used > like dagger, ddagger etc. Can the system (be made to) handle > that? I am not sure how to do that. Currently I have just removed the numbering in the cases where we output \thanks instead

Re: [patch] partial merging of CharStyle and InsetLayout handling

2007-08-16 Thread Jean-Marc Lasgouttes
Martin Vermeer <[EMAIL PROTECTED]> writes: > Yes, you can do this. The price you pay is the long name > appearing also on the inset labels. We are free to chose how the label appears on scrren What I am describing here is internal. > Currently the namespace -- if you add one --is just a "dumb" >

Re: 4108: who knows the graphic cache code?

2007-08-16 Thread Andre Poenitz
On Wed, Aug 15, 2007 at 09:45:11AM -0500, Bo Peng wrote: > > I can't reproduce. I tried what you suggested in the report, but still > > didn't get a crash. Can you post or send a minimal file? > > OK. I have confirmed that this is our old signals + gcc 3 friend. When > I compile the program with g

crash in signals

2007-08-16 Thread Andre Poenitz
Has anybody seen anything like that before? #1 0xb59c6d3f in __gnu_debug::_Safe_iterator_base::_M_attach () from /usr/lib/libstdc++.so.6 #2 0xb59c6ead in __gnu_debug::_Safe_sequence_base::_M_detach_all () from /usr/lib/libstdc++.so.6 #3 0x08066cdd in ~_Safe_sequence_base (this=0x813436c

  1   2   >