Bo Peng wrote:
On 8/16/07, Abdelrazak Younes <[EMAIL PROTECTED]> wrote:
I don't understand why you want to revert it. It will hurt
someone sooner or later.
Because your fix might not be necessary at all. Maybe some signal
sender/receiver will be destroyed at the same time, maybe a signal
will never be sent to a destroyed object in some cases (prevented by
some other tests). I just do not want to *blindly* save all
connections.
Try this patch instead.
Abdel.
Index: GraphicsCacheItem.cpp
===================================================================
--- GraphicsCacheItem.cpp (revision 19589)
+++ GraphicsCacheItem.cpp (working copy)
@@ -131,6 +131,9 @@
/// The connection of the signal ConvProcess::finishedConversion,
boost::signals::connection cc_;
+
+ ///
+ boost::signals::connection statusChanged_connection_;
///
boost::scoped_ptr<Converter> converter_;
@@ -191,7 +194,8 @@
boost::signals::connection CacheItem::connect(slot_type const & slot) const
{
- return pimpl_->statusChanged.connect(slot);
+ pimpl_->statusChanged_connection_ = pimpl_->statusChanged.connect(slot);
+ return pimpl_->statusChanged_connection_;
}
