Re: [PATCH] Re: broken_headers.h

2004-11-29 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> You are sure this is not needed by something else? gettext | Lars> f.ex.? > | gettext is supposed to handle its own tests. Perhaps it is now, but did it use to? But go ahe

Re: CoordBranch merge

2004-11-29 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | But note that there is more code inside that if block, so you cannot remove | the "if". And > | if (d <= best_dist) { | best_dist = min(best_dist, d); | ... > | does look silly (to me). sure. > >> | If I read such code I always me

Re: tex2lyx does not handle latex accents

2004-11-29 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> If possible we should not create new dependencies on those Lars> files. (we should work to get rid of them instead... :-) ) That makes sense... JMarc

Re: [PATCH] Re: broken_headers.h

2004-11-29 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> You are sure this is not needed by something else? gettext Lars> f.ex.? gettext is supposed to handle its own tests. JMarc

Re: [patch] restore TABULAR::UNSET_ALL_LINES

2004-11-29 Thread Alfredo Braunstein
Georg Baum wrote: > A final patch follows after the coord merge, I don't want to create mroe > work for Alfredo. Really appreciated. Just commited the merge, thanks! Alfredo

Re: CoordBranch merge

2004-11-29 Thread Alfredo Braunstein
Lars Gullik BjÃnnes wrote: > Andre Poenitz > <[EMAIL PROTECTED]> > writes: > > | On Mon, Nov 29, 2004 at 02:36:47PM +0100, Lars Gullik BjÃnnes wrote: >>> Alfredo Braunstein <[EMAIL PROTECTED]> writes: >>> | // Find position closest to (x, y) in cell given by iter. >>> | + // Used only in mathed

commands disabled

2004-11-29 Thread Alfredo Braunstein
Somone's been touching getStatus calls somewhere and left "find" and others permanently disabled somehow. I.e. in current cvs, load the UG, Edit->F&R, "a" and push "find next"->command disabled Regards, Alfredo

Re: [PATCH] Re: broken_headers.h

2004-11-29 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Therefore I propose the following cleanup patch. While I was at it, I | removed all traces of strcmp, memset and memmove. > | Comments? > | JMarc > > | Index: configure.ac | === | RCS

Re: [patch] restore TABULAR::UNSET_ALL_LINES

2004-11-29 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Sun, Nov 28, 2004 at 08:03:52PM +0100, Georg Baum wrote: >> I found some inconsistencies that may have been the problem for Jürgen: >> member functions declared with an "int" argument, but defined with an >> "int const" argument > | That's fine. The

Re: [patch] validators for the rest

2004-11-29 Thread Lars Gullik Bjønnes
Juergen Spitzmueller <[EMAIL PROTECTED]> writes: | Angus Leeming wrote: >> QString float2qstr(float value, size_t precision) >> { >>         std::ostringstream ss; >>         ss << setprecision(precision) << value; >>         return toqstr(ss.str()); >> } > | Since this problem is frontend-indepen

Re: [patch] validators for the rest

2004-11-29 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Juergen Spitzmueller wrote: > >> Angus Leeming wrote: >>> QString float2qstr(float value, size_t precision) >>> { >>> std::ostringstream ss; >>> ss << setprecision(precision) << value; >>> return toqstr(ss.str()); >>> } >> >> Since this problem is front

Re: tex2lyx does not handle latex accents

2004-11-29 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: > | Georg> Jean-Marc Lasgouttes wrote: >>> Georg, how difficult would it be to transform all such accents to >>> native characters when supported by the current encoding? Could we >>> use the

Re: CoordBranch merge

2004-11-29 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Nov 29, 2004 at 02:36:47PM +0100, Lars Gullik Bjønnes wrote: >> Alfredo Braunstein <[EMAIL PROTECTED]> writes: >> |// Find position closest to (x, y) in cell given by iter. >> | + // Used only in mathed >> |DocIterator bruteFind2(LCursor

Re: Warnings in src/frontends/gtk/FileDialogPrivate.C

2004-11-29 Thread John Spray
Thanks, I've applied the attached patch to fix these. John On Mon, 2004-11-29 at 20:45 +0100, Georg Baum wrote: > I get the following warnings: > > ../../../../src/frontends/gtk/FileDialogPrivate.h: In constructor ` >FileDialog::Private::Private(const std::string&, kb_action, >std::pair,

Re: Playing a bit with valgrind/massif

2004-11-29 Thread Kuba Ober
> The last interesting thingy is the dark blue 'stack' entry. This > memory grows when I press PageDown continuously and goes down when LyX > has managed to keep up with the number of PageDown request I have > issued. So there seems to be some recusrsivity going on when LyX > cannot execute events

Warnings in src/frontends/gtk/FileDialogPrivate.C

2004-11-29 Thread Georg Baum
John, I get the following warnings: ../../../../src/frontends/gtk/FileDialogPrivate.h: In constructor ` FileDialog::Private::Private(const std::string&, kb_action, std::pair, std::pair)': ../../../../src/frontends/gtk/FileDialogPrivate.h:40: warning: ` FileDialog::Private::action_' will

Re: CoordBranch merge

2004-11-29 Thread Alfredo Braunstein
Lars Gullik BjÃnnes wrote: > Alfredo Braunstein <[EMAIL PROTECTED]> writes: > > Some lame comments from me. > > Seems that you should just update from head, and merge this baby. Cool, I'll try to correct those and commit tonight. Regards, Alfredo

Re: CoordBranch merge

2004-11-29 Thread Andre Poenitz
On Mon, Nov 29, 2004 at 02:36:47PM +0100, Lars Gullik Bjønnes wrote: > Alfredo Braunstein <[EMAIL PROTECTED]> writes: > | // Find position closest to (x, y) in cell given by iter. > | + // Used only in mathed > | DocIterator bruteFind2(LCursor const & c, int x, int y) > | { > |

Re: Renaming README.Win32

2004-11-29 Thread Andre Poenitz
On Mon, Nov 29, 2004 at 04:22:01PM +0100, [EMAIL PROTECTED] wrote: > > Hello everybody, > > for various reasons, I'm bound to the Windows platform (XP) at present. > > I have been struggling with the compilation of LyX on Windows for some > time That's strange as LyX 1.4.0cvs + kdewin's Qt port

Re: [patch] restore TABULAR::UNSET_ALL_LINES

2004-11-29 Thread Andre Poenitz
On Sun, Nov 28, 2004 at 08:03:52PM +0100, Georg Baum wrote: > I found some inconsistencies that may have been the problem for Jürgen: > member functions declared with an "int" argument, but defined with an > "int const" argument That's fine. The toplevel const does not change the function signat

Re: [patch] restore TABULAR::UNSET_ALL_LINES

2004-11-29 Thread Jose' Matos
On Monday 29 November 2004 17:58, Georg Baum wrote: > > I looked it up, it is in update_tabular in lyx_1_2.py. At least the > version is changed there. The equivalent to setHeaderFooterRows() of > tabular.C is missing. Why? Or did I overlook something? I don't think so. :-) Probably no one use

Re: [patch] restore TABULAR::UNSET_ALL_LINES

2004-11-29 Thread Georg Baum
Jose' Matos wrote: > On Saturday 27 November 2004 18:46, Juergen Spitzmueller wrote: >> Furthermore, there is some compatibility code in tabular.C (1294ff). >> Georg/José, shouldn't this be handled by lyx2lyx? > > As Georg and André stated before this is old code that is not used > anymore. lyx

Re: tex2lyx does not handle latex accents

2004-11-29 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Jean-Marc Lasgouttes wrote: >> Georg, how difficult would it be to transform all such accents to >> native characters when supported by the current encoding? Could we >> use the tables in bdb/*.cdef for that? Georg> What is bdb/*.cdef

Re: [PATCH] Re: broken_headers.h

2004-11-29 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Jean-Marc Lasgouttes wrote: >> Comments? Georg> Can't test (have no broken system ;-) ), but it looks good. Since these systems are SCO unix and SunOS4, I think we do not care much :) JMarc

Re: [patch] validators for the rest

2004-11-29 Thread Juergen Spitzmueller
Angus Leeming wrote: > Why not >         float tostr(float value, int precision = -1) >         { >                 std::ostringstream ss; >                 if (precision < 0) >                         ss << value; >                 else >                         ss << setprecision(precision) << va

Re: [patch] validators for the rest

2004-11-29 Thread Angus Leeming
Juergen Spitzmueller wrote: > Angus Leeming wrote: >> QString float2qstr(float value, size_t precision) >> { >> std::ostringstream ss; >> ss << setprecision(precision) << value; >> return toqstr(ss.str()); >> } > > Since this problem is frontend-independent, I will add an > appropriate function t

Re: [patch] validators for the rest

2004-11-29 Thread Juergen Spitzmueller
Angus Leeming wrote: > QString float2qstr(float value, size_t precision) > { >         std::ostringstream ss; >         ss << setprecision(precision) << value; >         return toqstr(ss.str()); > } Since this problem is frontend-independent, I will add an appropriate function to lstrings (correc

Re: [patch] restore TABULAR::UNSET_ALL_LINES

2004-11-29 Thread Georg Baum
Angus Leeming wrote: > You could reasonably define a LyXTabular::npos, no? I did it to be on the safe side. Now the changes are purely mechanical. > -int LyXTabular::TeXTopHLine(ostream & os, int row) const > +int LyXTabular::TeXTopHLine(ostream & os, mynewrowtype row) const > { > - BOOST

Re: tex2lyx does not handle latex accents

2004-11-29 Thread Jose' Matos
On Monday 29 November 2004 16:55, Jean-Marc Lasgouttes wrote: > > "Jose'" == Jose' Matos <[EMAIL PROTECTED]> writes: > > Jose'> Actually I think that this kind of transformation could go > Jose'> inside lyx2lyx, or as a different module, called by lyx2lyx. > > Jose'> I say this since I use

Re: tex2lyx does not handle latex accents

2004-11-29 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Georg, how difficult would it be to transform all such accents to > native characters when supported by the current encoding? Could we use > the tables in bdb/*.cdef for that? What is bdb/*.cdef? I don't think that it is difficult. We need a command line switch to t

Re: tex2lyx does not handle latex accents

2004-11-29 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Latex accents like \'e are translated to InsetLatexAccent by > tex2lyx. This is unfortunate, since some converters produce such > latex accents (from swriter, I believe). Alternatively, go the other way and use tex2lyx to transform a Latin-1 e-acute to the locale-ind

Re: [PATCH] Re: broken_headers.h

2004-11-29 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Comments? Can't test (have no broken system ;-) ), but it looks good. Georg

Re: Playing a bit with valgrind/massif

2004-11-29 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: >> "Angus" == Angus Leeming <[EMAIL PROTECTED]> >> writes: > > Angus> Jean-Marc Lasgouttes wrote: >>> The light blue entry is interesting, since it seems to point to >>> the banner. Following the stack leads to: >>> http://www-rocq.inria.fr/~lasgoutt/lyx/massif

Re: tex2lyx does not handle latex accents

2004-11-29 Thread Jean-Marc Lasgouttes
> "Jose'" == Jose' Matos <[EMAIL PROTECTED]> writes: Jose'> Actually I think that this kind of transformation could go Jose'> inside lyx2lyx, or as a different module, called by lyx2lyx. Jose'> I say this since I use a python script to convert ancient Jose'> documents, that used inset lat

Re: tex2lyx does not handle latex accents

2004-11-29 Thread Jose' Matos
On Monday 29 November 2004 16:32, Jean-Marc Lasgouttes wrote: > > Georg, how difficult would it be to transform all such accents to > native characters when supported by the current encoding? Could we use > the tables in bdb/*.cdef for that? Actually I think that this kind of transformation coul

tex2lyx does not handle latex accents

2004-11-29 Thread Jean-Marc Lasgouttes
Latex accents like \'e are translated to InsetLatexAccent by tex2lyx. This is unfortunate, since some converters produce such latex accents (from swriter, I believe). Actually, tex2lyx has a built-in hack to handle german umlauts (surprise!), but this hacks assumes that the encoding is latin1 or

Re: Playing a bit with valgrind/massif

2004-11-29 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Jean-Marc Lasgouttes wrote: >> The light blue entry is interesting, since it seems to point to the >> banner. Following the stack leads to: >> http://www-rocq.inria.fr/~lasgoutt/lyx/massif.10779.html#bB24C7D08 >> therefore hinting a

[PATCH] Re: broken_headers.h

2004-11-29 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Am Samstag, 27. November 2004 15:01 schrieb Lars Gullik Georg> Bjønnes: >> Do we really need this header file anymore? >> >> And if we do, shouldn't we just handle this in the >> configure/config.h instead? Actually BROKEN_HEADERS i

Re: Playing a bit with valgrind/massif

2004-11-29 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > The light blue entry is interesting, since it seems to point to the > banner. Following the stack leads to: > http://www-rocq.inria.fr/~lasgoutt/lyx/massif.10779.html#bB24C7D08 > therefore hinting at the graphics cache. Since the is no graphics in > Customization.lyx

Re: Renaming README.Win32

2004-11-29 Thread michael.schmitt
Hello everybody, for various reasons, I'm bound to the Windows platform (XP) at present. I have been struggling with the compilation of LyX on Windows for some time and I thought you might be interested in an experience report: Cygwin & Qt X11/free & LyX 1.3.1

Playing a bit with valgrind/massif

2004-11-29 Thread Jean-Marc Lasgouttes
I took a look at what happens when running lyx under the heap profiler massif. The command used is valgrind --tool=massif --format=html --depth=10 ./lyx ~/src/lyx/lyx-devel/lib/doc/Customization.lyx and then I pressed pagedown repetedly until the scrollbar was at the middle of the document. Y

Re: Renaming README.Win32

2004-11-29 Thread Ruurd Reitsma
"Angus Leeming" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > > I have MinSyS installed on a WinXP machine. I guess I could create a > native Windows LyX executable using the gcc toolchain, no? > Yep. The regular mingw distro (gcc etc.) + msys will do. There are instructions for Qt

Re: [patch] validators for the rest

2004-11-29 Thread Angus Leeming
Juergen Spitzmueller wrote: > Angus Leeming wrote: >> What do you mean, "Doesn't work"? The constructor is: >> CheckedLineEdit(QLineEdit * input, QLabel * label = 0); > > Ah, silly me. Yes, that works (without visual clue, that is, but I'm > fine with that). > >> > 10.3019073486 >> > >> > Is

Re: CoordBranch merge

2004-11-29 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: Some lame comments from me. Seems that you should just update from head, and merge this baby. | Index: src/Makefile.am | === | RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/Makefile.am

Re: [patch] validators for the rest

2004-11-29 Thread Juergen Spitzmueller
Angus Leeming wrote: > What do you mean, "Doesn't work"? The constructor is: >         CheckedLineEdit(QLineEdit * input, QLabel * label = 0); Ah, silly me. Yes, that works (without visual clue, that is, but I'm fine with that). > > 10.3019073486 > > > > Isn't this a bit too precise? ;-) > >

Re: CoordBranch merge

2004-11-29 Thread Alfredo Braunstein
Lars Gullik BjÃnnes wrote: > | ping! > > I need more time... Sure, but please be aware that I cannot do anything else until this is commited. Regards, Alfredo

Re: CoordBranch merge

2004-11-29 Thread Lars Gullik Bjønnes
Alfredo Braunstein <[EMAIL PROTECTED]> writes: | Alfredo Braunstein wrote: > >> Lars Gullik Bjønnes wrote: >> >>> | Hrm... here it is ;-) >>> >>> Ok, thanks. >>> >>> Please wait at least until next week with the merge. >> >> Sure, no problem. I'll probably out for the weekend anyways. >> >>>

Re: CoordBranch merge

2004-11-29 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > Lars Gullik BjÃnnes wrote: > >> | Hrm... here it is ;-) >> >> Ok, thanks. >> >> Please wait at least until next week with the merge. > > Sure, no problem. I'll probably out for the weekend anyways. > >> I have some comments (mostly nit-picking), and I also want to

Re: [patch] restore TABULAR::UNSET_ALL_LINES

2004-11-29 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Jose'" == Jose' Matos <[EMAIL PROTECTED]> writes: > | Jose'> If you, or any one else for that matter, find any code like | Jose'> this in lyx please report it so that it can be removed. lyx2lyx | Jose'> is the right layer for this code. >

Re: [patch] validators for the rest

2004-11-29 Thread Angus Leeming
Juergen Spitzmueller wrote: > Attached is a patch that adds validators to all remaining qt > dialogs. > > One problem remains: The vspace input widget in QDocument does not > have a label, so the validator does not work. Angus, what can be > done? Can we have a checkedwidget that uses an other wi

Re: [patch] restore TABULAR::UNSET_ALL_LINES

2004-11-29 Thread Jean-Marc Lasgouttes
> "Jose'" == Jose' Matos <[EMAIL PROTECTED]> writes: Jose'> If you, or any one else for that matter, find any code like Jose'> this in lyx please report it so that it can be removed. lyx2lyx Jose'> is the right layer for this code. Jose'> The only other place where I expect to possibly fi

lyx2lyx patch

2004-11-29 Thread Jose' Matos
This patch fixes convertion from old files. The opt structure changed to file, and so for some reason one instance of it remained unchanged. :-( This is trivial, so I apply it soon. :-) -- José Abílio Index: ChangeLog === RCS file:

Re: [patch] restore TABULAR::UNSET_ALL_LINES

2004-11-29 Thread Jose' Matos
On Saturday 27 November 2004 18:46, Juergen Spitzmueller wrote: > Furthermore, there is some compatibility code in tabular.C (1294ff). > Georg/José, shouldn't this be handled by lyx2lyx? As Georg and André stated before this is old code that is not used anymore. lyx2lyx always return version 3

[patch] validators for the rest

2004-11-29 Thread Juergen Spitzmueller
Attached is a patch that adds validators to all remaining qt dialogs. One problem remains: The vspace input widget in QDocument does not have a label, so the validator does not work. Angus, what can be done? Can we have a checkedwidget that uses an other widget than a label? If so, what is the b

Re: Renaming README.Win32

2004-11-29 Thread Angus Leeming
Ruurd Reitsma wrote: > "Angus Leeming" <[EMAIL PROTECTED]> wrote in > message news:[EMAIL PROTECTED] >> Edwin Leuven wrote: >> >> Here, 'formal support' means merging changes made by Ruurd to get >> LyX to compile with the half-baked compiler (Borland) that was used >> to compile the qt/win32 libr

Re: Final NVI (for insets) patch.

2004-11-29 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: > >> This is the final NVI patch for the inset hierarchy. >> >> Please have a look if interested. >> >> I'll try to break out some of the non-mechanical changes into >> separate >> patches before applying this: Some function

Re: Final NVI (for insets) patch.

2004-11-29 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > This is the final NVI patch for the inset hierarchy. > > Please have a look if interested. > > I'll try to break out some of the non-mechanical changes into > separate > patches before applying this: Some functions do not need to be > virtual, some are unused. (or o

Re: [patch] par->pit

2004-11-29 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Sat, Nov 27, 2004 at 05:14:31PM +0100, Lars Gullik Bjønnes wrote: >> Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> | On Wed, Nov 24, 2004 at 10:45:19PM +0100, Lars Gullik Bjønnes wrote: >> >> I do not like the pit_type name at all. From what I can

Re: [patch] restore TABULAR::UNSET_ALL_LINES

2004-11-29 Thread Andre Poenitz
On Sat, Nov 27, 2004 at 07:46:46PM +0100, Juergen Spitzmueller wrote: > Finally, please have a look at the attached patch. I cannot see why we > couldn't simplify the code like this. Because 'everything between start cell and end cell' is different from 'everything betwween start col and and col

Re: [patch] par->pit

2004-11-29 Thread Andre Poenitz
On Sat, Nov 27, 2004 at 05:14:31PM +0100, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Wed, Nov 24, 2004 at 10:45:19PM +0100, Lars Gullik Bjønnes wrote: > >> I do not like the pit_type name at all. From what I can see this is > >> really some kind of offset. So p

Re: [Patch] Move getStatus out of cursor.

2004-11-29 Thread Andre Poenitz
On Sat, Nov 27, 2004 at 09:22:18PM +0100, Georg Baum wrote: > Am Samstag, 27. November 2004 17:22 schrieb Lars Gullik Bjønnes: > > > + // The inset's getStatus() will return 'true' if it made > > + // a definitive decision on whether it want to handle the > > + // request or not. The result of

Re: [patch] restore TABULAR::UNSET_ALL_LINES

2004-11-29 Thread Andre Poenitz
On Sat, Nov 27, 2004 at 07:46:46PM +0100, Juergen Spitzmueller wrote: > Jean-Marc Lasgouttes wrote: > > Well, the real type is idx_type, so I think it is better than size_t. > > I think that the places that use size_t do that to avoid pulling a big > > header. > > This has turned out as a can of w

Re: Renaming README.Win32

2004-11-29 Thread Ruurd Reitsma
"Angus Leeming" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Edwin Leuven wrote: > > Here, 'formal support' means merging changes made by Ruurd to get LyX to > compile with the half-baked compiler (Borland) that was used to compile > the qt/win32 library provided by Trolltech. Hypo

Re: [patch] restore TABULAR::UNSET_ALL_LINES

2004-11-29 Thread Angus Leeming
Georg Baum wrote: > The code depends now a bit more on the fact that we have at least one > row, one column and one cell, because we use "row - 1", "column - 1" and > "cell -1" at several places, and the result must be positive, but I think > this is no problem. You could reasonably define a LyXTa